Re: [dm-devel] [PATCH 11/29] btrfs: use bdev_nr_sectors instead of open coding it

2021-10-14 Thread Chaitanya Kulkarni
On 10/12/2021 10:10 PM, Christoph Hellwig wrote: > Use the proper helper to read the block device size. > > Signed-off-by: Christoph Hellwig Looks good. Reviewed-by: Chaitanya Kulkarni -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 11/29] btrfs: use bdev_nr_sectors instead of open coding it

2021-10-14 Thread Keith Busch
On Wed, Oct 13, 2021 at 07:10:24AM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size. Just IMO, this patch looks like it wants a new bdev_nr_bytes() helper instead of using the double shifting sectors back to bytes. -- dm-devel mailing list dm-devel@redhat.com

Re: [dm-devel] [PATCH 11/29] btrfs: use bdev_nr_sectors instead of open coding it

2021-10-13 Thread Anand Jain
On 13/10/2021 13:10, Christoph Hellwig wrote: Use the proper helper to read the block device size. Signed-off-by: Christoph Hellwig Looks good. Reviewed-by: Anand Jain -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH 11/29] btrfs: use bdev_nr_sectors instead of open coding it

2021-10-12 Thread Christoph Hellwig
Use the proper helper to read the block device size. Signed-off-by: Christoph Hellwig --- fs/btrfs/dev-replace.c | 2 +- fs/btrfs/disk-io.c | 3 ++- fs/btrfs/ioctl.c | 4 ++-- fs/btrfs/volumes.c | 7 --- 4 files changed, 9 insertions(+), 7 deletions(-) diff --git