Re: [dm-devel] [PATCH 14/31] rnbd-srv: don't pass a holder for non-exclusive blkdev_get_by_path

2023-06-07 Thread Christian Brauner
On Tue, Jun 06, 2023 at 09:39:33AM +0200, Christoph Hellwig wrote: > Passing a holder to blkdev_get_by_path when FMODE_EXCL isn't set doesn't > make sense, so pass NULL instead. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Acked-by: Christian Brauner -- dm-devel mailing list dm

Re: [dm-devel] [PATCH 14/31] rnbd-srv: don't pass a holder for non-exclusive blkdev_get_by_path

2023-06-07 Thread Jinpu Wang
On Tue, Jun 6, 2023 at 9:40 AM Christoph Hellwig wrote: > > Passing a holder to blkdev_get_by_path when FMODE_EXCL isn't set doesn't > make sense, so pass NULL instead. > > Signed-off-by: Christoph Hellwig Acked-by: Jack Wang > --- > drivers/block/rnbd/rnbd-srv.c | 2 +- > 1 file changed, 1 ins

Re: [dm-devel] [PATCH 14/31] rnbd-srv: don't pass a holder for non-exclusive blkdev_get_by_path

2023-06-07 Thread Hannes Reinecke
On 6/6/23 09:39, Christoph Hellwig wrote: Passing a holder to blkdev_get_by_path when FMODE_EXCL isn't set doesn't make sense, so pass NULL instead. Signed-off-by: Christoph Hellwig --- drivers/block/rnbd/rnbd-srv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Hannes

[dm-devel] [PATCH 14/31] rnbd-srv: don't pass a holder for non-exclusive blkdev_get_by_path

2023-06-06 Thread Christoph Hellwig
Passing a holder to blkdev_get_by_path when FMODE_EXCL isn't set doesn't make sense, so pass NULL instead. Signed-off-by: Christoph Hellwig --- drivers/block/rnbd/rnbd-srv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/rnbd/rnbd-srv.c b/drivers/block/rnbd/rnb