Re: [dm-devel] [PATCH 15/20] block: merge struct block_device and struct hd_struct

2020-11-20 Thread Jan Kara
On Fri 20-11-20 10:15:46, Christoph Hellwig wrote: > On Thu, Nov 19, 2020 at 03:39:21PM +0100, Jan Kara wrote: > > This patch is kind of difficult to review due to the size of mostly > > mechanical changes mixed with not completely mechanical changes. Can we > > perhaps split out the mechanical bit

Re: [dm-devel] [PATCH 15/20] block: merge struct block_device and struct hd_struct

2020-11-20 Thread Christoph Hellwig
On Thu, Nov 19, 2020 at 03:39:21PM +0100, Jan Kara wrote: > This patch is kind of difficult to review due to the size of mostly > mechanical changes mixed with not completely mechanical changes. Can we > perhaps split out the mechanical bits? E.g. the rq->part => rq->bdev > renaming is mechanical a

Re: [dm-devel] [PATCH 15/20] block: merge struct block_device and struct hd_struct

2020-11-19 Thread Jan Kara
On Wed 18-11-20 09:47:55, Christoph Hellwig wrote: > Instead of having two structures that represent each block device with > different lift time rules merged them into a single one. This also ^^^ :) life merge > greatly simplifies the reference counting rules, as we can use

[dm-devel] [PATCH 15/20] block: merge struct block_device and struct hd_struct

2020-11-18 Thread Christoph Hellwig
Instead of having two structures that represent each block device with different lift time rules merged them into a single one. This also greatly simplifies the reference counting rules, as we can use the inode reference count as the main reference count for the new struct block_device, with the d