Re: [dm-devel] [PATCH 17/19] libmultipath: add udev and logsink symbols

2020-09-23 Thread Benjamin Marzinski
On Wed, Sep 23, 2020 at 10:16:48AM +0200, Martin Wilck wrote: > On Mon, 2020-09-21 at 15:10 -0500, Benjamin Marzinski wrote: > > > > After calling libmultipath_exit(), you can never reinitialized the > > udev > > device. That seems fine, but it should probably set udev to null, so > > that future

Re: [dm-devel] [PATCH 17/19] libmultipath: add udev and logsink symbols

2020-09-23 Thread Martin Wilck
On Mon, 2020-09-21 at 15:10 -0500, Benjamin Marzinski wrote: > > After calling libmultipath_exit(), you can never reinitialized the > udev > device. That seems fine, but it should probably set udev to null, so > that future calls to libmultipath_init() don't return success. Either > that or multi

Re: [dm-devel] [PATCH 17/19] libmultipath: add udev and logsink symbols

2020-09-21 Thread Benjamin Marzinski
On Wed, Sep 16, 2020 at 05:37:16PM +0200, mwi...@suse.com wrote: > From: Martin Wilck > > With these symbols added, applications using libmultipath don't > need to define global variables "udev" and "logsink" any more. > This comes at the cost of having to call an init function. > Currently, libm

[dm-devel] [PATCH 17/19] libmultipath: add udev and logsink symbols

2020-09-16 Thread mwilck
From: Martin Wilck With these symbols added, applications using libmultipath don't need to define global variables "udev" and "logsink" any more. This comes at the cost of having to call an init function. Currently, libmultipath_init() does nothing but initialize "udev". The linker's symbol look