Re: [dm-devel] [PATCH 2/2] dm thin: Flush data device before committing metadata

2019-12-04 Thread Nikos Tsironis
On 12/4/19 6:39 PM, Mike Snitzer wrote:> On Wed, Dec 04 2019 at 11:17am -0500, Nikos Tsironis wrote: On 12/4/19 5:27 PM, Joe Thornber wrote: On Wed, Dec 04, 2019 at 04:07:42PM +0200, Nikos Tsironis wrote: The thin provisioning target maintains per thin device mappings that map virtual blocks

Re: [dm-devel] [PATCH 2/2] dm thin: Flush data device before committing metadata

2019-12-04 Thread Mike Snitzer
On Wed, Dec 04 2019 at 11:17am -0500, Nikos Tsironis wrote: > On 12/4/19 5:27 PM, Joe Thornber wrote: > >On Wed, Dec 04, 2019 at 04:07:42PM +0200, Nikos Tsironis wrote: > >>The thin provisioning target maintains per thin device mappings that map > >>virtual blocks to data blocks in the data devic

Re: [dm-devel] [PATCH 2/2] dm thin: Flush data device before committing metadata

2019-12-04 Thread Nikos Tsironis
On 12/4/19 5:27 PM, Joe Thornber wrote: On Wed, Dec 04, 2019 at 04:07:42PM +0200, Nikos Tsironis wrote: The thin provisioning target maintains per thin device mappings that map virtual blocks to data blocks in the data device. Ack. But I think we're issuing the FLUSH twice with your patch.

Re: [dm-devel] [PATCH 2/2] dm thin: Flush data device before committing metadata

2019-12-04 Thread Joe Thornber
On Wed, Dec 04, 2019 at 04:07:42PM +0200, Nikos Tsironis wrote: > The thin provisioning target maintains per thin device mappings that map > virtual blocks to data blocks in the data device. Ack. But I think we're issuing the FLUSH twice with your patch. Since the original bio is still remapped

[dm-devel] [PATCH 2/2] dm thin: Flush data device before committing metadata

2019-12-04 Thread Nikos Tsironis
The thin provisioning target maintains per thin device mappings that map virtual blocks to data blocks in the data device. When we write to a shared block, in case of internal snapshots, or provision a new block, in case of external snapshots, we copy the shared block to a new data block (COW), up