Re: [dm-devel] [PATCH 2/2] multipathd: add recheck_wwid_time option to verify the path wwid

2021-02-26 Thread Benjamin Marzinski
On Tue, Feb 09, 2021 at 10:19:45PM +, Martin Wilck wrote: > On Mon, 2021-02-08 at 23:19 -0600, Benjamin Marzinski wrote: > > If > > multipathd notices that a path's wwid has changed it will remove and > > re-add the path, just like the existing wwid checking code for change > > events does.  I

Re: [dm-devel] [PATCH 2/2] multipathd: add recheck_wwid_time option to verify the path wwid

2021-02-19 Thread Martin Wilck
On Thu, 2021-02-18 at 11:22 +0800, Chongyun Wu wrote: > > > > I wasn't aware of multiple affected users. I saw Chongyun's post > > and it > > looked to me as if this had happend once, likely in his > > organization. > > It wasn't even clear to me whether production data were affected. > > > Had c

Re: [dm-devel] [PATCH 2/2] multipathd: add recheck_wwid_time option to verify the path wwid

2021-02-17 Thread Chongyun Wu
On 2021/2/11 20:14, Martin Wilck wrote: But foremost, do we really have to try to deal with configuration mistakes as blatant as this? What if a user sets the same WWID for different devices, or re-uses the same WWID on different storage servers? I already hesitated about the code I added mys

Re: [dm-devel] [PATCH 2/2] multipathd: add recheck_wwid_time option to verify the path wwid

2021-02-17 Thread Benjamin Block
On Tue, Feb 09, 2021 at 10:19:45PM +, Martin Wilck wrote: > On Mon, 2021-02-08 at 23:19 -0600, Benjamin Marzinski wrote: > > There are cases where the wwid of a path changes due to LUN remapping > > without triggering uevent for the changed path. Multipathd has no > > method > > for trying to c

Re: [dm-devel] [PATCH 2/2] multipathd: add recheck_wwid_time option to verify the path wwid

2021-02-11 Thread Martin Wilck
On Wed, 2021-02-10 at 22:48 -0600, Benjamin Marzinski wrote: > On Tue, Feb 09, 2021 at 10:19:45PM +, Martin Wilck wrote: > > On Mon, 2021-02-08 at 23:19 -0600, Benjamin Marzinski wrote: > > > There are cases where the wwid of a path changes due to LUN > > > remapping > > > without triggering ue

Re: [dm-devel] [PATCH 2/2] multipathd: add recheck_wwid_time option to verify the path wwid

2021-02-11 Thread Benjamin Block
On Wed, Feb 10, 2021 at 07:09:31PM +0100, Benjamin Block wrote: > On Tue, Feb 09, 2021 at 10:19:45PM +, Martin Wilck wrote: > > On Mon, 2021-02-08 at 23:19 -0600, Benjamin Marzinski wrote: > > > There are cases where the wwid of a path changes due to LUN remapping > > > without triggering ueven

Re: [dm-devel] [PATCH 2/2] multipathd: add recheck_wwid_time option to verify the path wwid

2021-02-10 Thread Benjamin Marzinski
On Tue, Feb 09, 2021 at 10:19:45PM +, Martin Wilck wrote: > On Mon, 2021-02-08 at 23:19 -0600, Benjamin Marzinski wrote: > > There are cases where the wwid of a path changes due to LUN remapping > > without triggering uevent for the changed path. Multipathd has no > > method > > for trying to c

Re: [dm-devel] [PATCH 2/2] multipathd: add recheck_wwid_time option to verify the path wwid

2021-02-10 Thread Martin Wilck
On Wed, 2021-02-10 at 19:09 +0100, Benjamin Block wrote: > > Yeah, just for reference, I saw this happening in practice when > something with the LU mapping changed on IBM storage - IIRC I saw it > with capacity changes. You end up in this code in the kernel: >     > https://git.kernel.org/pub/sc

Re: [dm-devel] [PATCH 2/2] multipathd: add recheck_wwid_time option to verify the path wwid

2021-02-09 Thread Martin Wilck
On Mon, 2021-02-08 at 23:19 -0600, Benjamin Marzinski wrote: > There are cases where the wwid of a path changes due to LUN remapping > without triggering uevent for the changed path. Multipathd has no > method > for trying to catch these cases, and corruption has resulted because > of > it. > > In

[dm-devel] [PATCH 2/2] multipathd: add recheck_wwid_time option to verify the path wwid

2021-02-08 Thread Benjamin Marzinski
There are cases where the wwid of a path changes due to LUN remapping without triggering uevent for the changed path. Multipathd has no method for trying to catch these cases, and corruption has resulted because of it. In order to have a better chance at catching these cases, multipath now has a r