Re: [dm-devel] [PATCH 2/3] libmutipath: don't close fd on dm_lib_release

2020-07-03 Thread Martin Wilck
On Thu, 2020-07-02 at 15:06 -0500, Benjamin Marzinski wrote: > On Thu, Jul 02, 2020 at 11:52:21AM +, Martin Wilck wrote: > > On Wed, 2020-03-25 at 17:00 -0500, Benjamin Marzinski wrote: > > > On Wed, Mar 25, 2020 at 03:52:55PM -0500, Benjamin Marzinski > > > wrote: > > > > On Wed, Mar 25, 2020

Re: [dm-devel] [PATCH 2/3] libmutipath: don't close fd on dm_lib_release

2020-07-02 Thread Benjamin Marzinski
On Thu, Jul 02, 2020 at 11:52:21AM +, Martin Wilck wrote: > On Wed, 2020-03-25 at 17:00 -0500, Benjamin Marzinski wrote: > > On Wed, Mar 25, 2020 at 03:52:55PM -0500, Benjamin Marzinski wrote: > > > On Wed, Mar 25, 2020 at 03:16:50PM +, Martin Wilck wrote: > > > > On Tue, 2020-03-24 at

Re: [dm-devel] [PATCH 2/3] libmutipath: don't close fd on dm_lib_release

2020-07-02 Thread Martin Wilck
On Wed, 2020-03-25 at 17:00 -0500, Benjamin Marzinski wrote: > On Wed, Mar 25, 2020 at 03:52:55PM -0500, Benjamin Marzinski wrote: > > On Wed, Mar 25, 2020 at 03:16:50PM +, Martin Wilck wrote: > > > On Tue, 2020-03-24 at 16:03 -0500, Benjamin Marzinski wrote: > > > > > > AFAICS, this function

Re: [dm-devel] [PATCH 2/3] libmutipath: don't close fd on dm_lib_release

2020-03-25 Thread Martin Wilck
On Wed, 2020-03-25 at 17:00 -0500, Benjamin Marzinski wrote: > On Wed, Mar 25, 2020 at 03:52:55PM -0500, Benjamin Marzinski wrote: > > On Wed, Mar 25, 2020 at 03:16:50PM +, Martin Wilck wrote: > > > On Tue, 2020-03-24 at 16:03 -0500, Benjamin Marzinski wrote: > > > > > > AFAICS, this function

Re: [dm-devel] [PATCH 2/3] libmutipath: don't close fd on dm_lib_release

2020-03-25 Thread Benjamin Marzinski
On Wed, Mar 25, 2020 at 03:52:55PM -0500, Benjamin Marzinski wrote: > On Wed, Mar 25, 2020 at 03:16:50PM +, Martin Wilck wrote: > > On Tue, 2020-03-24 at 16:03 -0500, Benjamin Marzinski wrote: > > > > AFAICS, this function has been in libdm since 1.02.111. We support > > 1.02.89 (if all

Re: [dm-devel] [PATCH 2/3] libmutipath: don't close fd on dm_lib_release

2020-03-25 Thread Benjamin Marzinski
On Wed, Mar 25, 2020 at 03:16:50PM +, Martin Wilck wrote: > On Tue, 2020-03-24 at 16:03 -0500, Benjamin Marzinski wrote: > > If dm_hold_control_open() isn't set, when dm_lib_release() is called, > > it > > will close the control fd. The control fd will get re-opened on the > > next > >

Re: [dm-devel] [PATCH 2/3] libmutipath: don't close fd on dm_lib_release

2020-03-25 Thread Martin Wilck
On Tue, 2020-03-24 at 16:03 -0500, Benjamin Marzinski wrote: > If dm_hold_control_open() isn't set, when dm_lib_release() is called, > it > will close the control fd. The control fd will get re-opened on the > next > dm_task_run() call, but if there is a dm_task_run() call already > in progress in

[dm-devel] [PATCH 2/3] libmutipath: don't close fd on dm_lib_release

2020-03-24 Thread Benjamin Marzinski
If dm_hold_control_open() isn't set, when dm_lib_release() is called, it will close the control fd. The control fd will get re-opened on the next dm_task_run() call, but if there is a dm_task_run() call already in progress in another thread, it can fail. Since many of the device-mapper callouts