Re: [dm-devel] [PATCH 2/4] multipath-tools: add checker callout to repair path

2016-08-15 Thread Bart Van Assche
On 08/14/2016 01:41 AM, Mike Christie wrote: Attached patch should fix these issues. Hello Mike, With that patch applied multipathd works again reliable on my test setup. Thanks! Bart. -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 2/4] multipath-tools: add checker callout to repair path

2016-08-14 Thread Mike Christie
On 08/11/2016 04:41 PM, Bart Van Assche wrote: > On 08/11/2016 01:33 PM, Mike Christie wrote: >> Could you try the attached patch. I found two segfaults. If check_path >> returns less than 0 then we free the path and so we cannot call repair >> on it. If libcheck_init fails it memsets the checker,

Re: [dm-devel] [PATCH 2/4] multipath-tools: add checker callout to repair path

2016-08-12 Thread Bart Van Assche
On 08/12/2016 09:54 AM, Mike Christie wrote: > On 08/11/2016 04:41 PM, Bart Van Assche wrote: >> On 08/11/2016 01:33 PM, Mike Christie wrote: >>> Could you try the attached patch. I found two segfaults. If check_path >>> returns less than 0 then we free the path and so we cannot call repair >>> on

Re: [dm-devel] [PATCH 2/4] multipath-tools: add checker callout to repair path

2016-08-12 Thread Mike Christie
On 08/11/2016 04:41 PM, Bart Van Assche wrote: > On 08/11/2016 01:33 PM, Mike Christie wrote: >> Could you try the attached patch. I found two segfaults. If check_path >> returns less than 0 then we free the path and so we cannot call repair >> on it. If libcheck_init fails it memsets the checker,

Re: [dm-devel] [PATCH 2/4] multipath-tools: add checker callout to repair path

2016-08-11 Thread Bart Van Assche
On 08/11/2016 01:33 PM, Mike Christie wrote: Could you try the attached patch. I found two segfaults. If check_path returns less than 0 then we free the path and so we cannot call repair on it. If libcheck_init fails it memsets the checker, so we cannot call repair on it too. I moved the repair

Re: [dm-devel] [PATCH 2/4] multipath-tools: add checker callout to repair path

2016-08-11 Thread Mike Christie
On 08/11/2016 10:50 AM, Bart Van Assche wrote: > On 08/08/2016 05:01 AM, Mike Christie wrote: >> This patch adds a callback which can be used to repair a path >> if check() has determined it is in the PATH_DOWN state. >> >> The next patch that adds rbd checker support which will use this to >> hand

Re: [dm-devel] [PATCH 2/4] multipath-tools: add checker callout to repair path

2016-08-11 Thread Bart Van Assche
On 08/08/2016 05:01 AM, Mike Christie wrote: > This patch adds a callback which can be used to repair a path > if check() has determined it is in the PATH_DOWN state. > > The next patch that adds rbd checker support which will use this to > handle the case where a rbd device is blacklisted. Hello

[dm-devel] [PATCH 2/4] multipath-tools: add checker callout to repair path

2016-08-08 Thread Mike Christie
This patch adds a callback which can be used to repair a path if check() has determined it is in the PATH_DOWN state. The next patch that adds rbd checker support which will use this to handle the case where a rbd device is blacklisted. Signed-off-by: Mike Christie --- libmultipath/checkers.c

[dm-devel] [PATCH 2/4] multipath-tools: add checker callout to repair path

2016-07-05 Thread Mike Christie
This patch adds a callback which can be used to repair a path if check() has determined it is in the PATH_DOWN state. The next patch that adds rbd checker support which will use this to handle the case where a rbd device is blacklisted. Signed-off-by: Mike Christie --- libmultipath/checkers.c