Re: [dm-devel] [PATCH 2/7] multipathd: fix check_path errors with removed map

2020-06-24 Thread Martin Wilck
On Fri, 2020-06-19 at 11:30 -0500, Benjamin Marzinski wrote: > On Fri, Jun 19, 2020 at 08:32:34AM +0200, Hannes Reinecke wrote: > > > > fac68d7 is related to the famous "dm-multipath: Accept failed > > > > paths for > > > > multipath maps" patch (e.g. > > > >

Re: [dm-devel] [PATCH 2/7] multipathd: fix check_path errors with removed map

2020-06-19 Thread Martin Wilck
On Fri, 2020-06-19 at 11:52 -0500, Benjamin Marzinski wrote: > On Fri, Jun 19, 2020 at 01:42:47PM +, Martin Wilck wrote: > > On Thu, 2020-06-18 at 18:17 -0500, Benjamin Marzinski wrote: > > > On Thu, Jun 18, 2020 at 07:34:38PM +, Martin Wilck wrote: > > > > > > > > It would be more

Re: [dm-devel] [PATCH 2/7] multipathd: fix check_path errors with removed map

2020-06-19 Thread Benjamin Marzinski
On Fri, Jun 19, 2020 at 01:42:47PM +, Martin Wilck wrote: > On Thu, 2020-06-18 at 18:17 -0500, Benjamin Marzinski wrote: > > On Thu, Jun 18, 2020 at 07:34:38PM +, Martin Wilck wrote: > > > On Wed, 2020-06-17 at 19:24 -0500, Benjamin Marzinski wrote: > > > > > > > > static void > > > > @@

Re: [dm-devel] [PATCH 2/7] multipathd: fix check_path errors with removed map

2020-06-19 Thread Benjamin Marzinski
On Fri, Jun 19, 2020 at 08:32:34AM +0200, Hannes Reinecke wrote: > >> > >>fac68d7 is related to the famous "dm-multipath: Accept failed paths for > >>multipath maps" patch (e.g. > >>https://patchwork.kernel.org/patch/3368381/#7193001), which never made > >>it upstream. SUSE kernels have shipped

Re: [dm-devel] [PATCH 2/7] multipathd: fix check_path errors with removed map

2020-06-19 Thread Martin Wilck
On Thu, 2020-06-18 at 18:17 -0500, Benjamin Marzinski wrote: > On Thu, Jun 18, 2020 at 07:34:38PM +, Martin Wilck wrote: > > On Wed, 2020-06-17 at 19:24 -0500, Benjamin Marzinski wrote: > > > > > > static void > > > @@ -2088,8 +2084,13 @@ check_path (struct vectors * vecs, struct > > > path

Re: [dm-devel] [PATCH 2/7] multipathd: fix check_path errors with removed map

2020-06-19 Thread Hannes Reinecke
On 6/19/20 1:17 AM, Benjamin Marzinski wrote: On Thu, Jun 18, 2020 at 07:34:38PM +, Martin Wilck wrote: On Wed, 2020-06-17 at 19:24 -0500, Benjamin Marzinski wrote: If a multipath device is removed during, or immediately before the call to check_path(), multipathd can behave incorrectly. A

Re: [dm-devel] [PATCH 2/7] multipathd: fix check_path errors with removed map

2020-06-18 Thread Benjamin Marzinski
On Thu, Jun 18, 2020 at 07:34:38PM +, Martin Wilck wrote: > On Wed, 2020-06-17 at 19:24 -0500, Benjamin Marzinski wrote: > > If a multipath device is removed during, or immediately before the > > call > > to check_path(), multipathd can behave incorrectly. A missing > > multpath > > device

Re: [dm-devel] [PATCH 2/7] multipathd: fix check_path errors with removed map

2020-06-18 Thread Martin Wilck
On Wed, 2020-06-17 at 19:24 -0500, Benjamin Marzinski wrote: > If a multipath device is removed during, or immediately before the > call > to check_path(), multipathd can behave incorrectly. A missing > multpath > device will cause update_multipath_strings() to fail, setting > pp->dmstate to