Re: [dm-devel] [PATCH 29/45] block: initialize struct block_device in bdev_alloc

2020-11-29 Thread Hannes Reinecke
On 11/28/20 5:14 PM, Christoph Hellwig wrote: Don't play tricks with slab constructors as bdev structures tends to not get reused very much, and this makes the code a lot less error prone. Signed-off-by: Christoph Hellwig Reviewed-by: Jan Kara Acked-by: Tejun Heo --- fs/block_dev.c | 22

[dm-devel] [PATCH 29/45] block: initialize struct block_device in bdev_alloc

2020-11-28 Thread Christoph Hellwig
Don't play tricks with slab constructors as bdev structures tends to not get reused very much, and this makes the code a lot less error prone. Signed-off-by: Christoph Hellwig Reviewed-by: Jan Kara Acked-by: Tejun Heo --- fs/block_dev.c | 22 +- 1 file changed, 9

Re: [dm-devel] [PATCH 29/45] block: initialize struct block_device in bdev_alloc

2020-11-24 Thread Tejun Heo
On Tue, Nov 24, 2020 at 02:27:35PM +0100, Christoph Hellwig wrote: > Don't play tricks with slab constructors as bdev structures tends to not > get reused very much, and this makes the code a lot less error prone. > > Signed-off-by: Christoph Hellwig Acked-by: Tejun Heo -- tejun -- dm-devel

[dm-devel] [PATCH 29/45] block: initialize struct block_device in bdev_alloc

2020-11-24 Thread Christoph Hellwig
Don't play tricks with slab constructors as bdev structures tends to not get reused very much, and this makes the code a lot less error prone. Signed-off-by: Christoph Hellwig --- fs/block_dev.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git