Re: [dm-devel] [PATCH 3/3] dm: mark dm queue as blocking if any underlying is blocking

2022-01-11 Thread Jeff Moyer
Ming Lei writes: > dm request based driver doesn't set BLK_MQ_F_BLOCKING, so dm_queue_rq() > is supposed to not sleep. > > However, blk_insert_cloned_request() is used by dm_queue_rq() for > queuing underlying request, but the underlying queue may be marked as > BLK_MQ_F_BLOCKING, so blk_insert_c

Re: [dm-devel] [PATCH 3/3] dm: mark dm queue as blocking if any underlying is blocking

2022-01-10 Thread Mike Snitzer
On Thu, Jan 06 2022 at 10:51P -0500, Ming Lei wrote: > On Thu, Jan 06, 2022 at 10:40:51AM -0500, Mike Snitzer wrote: > > On Tue, Dec 21 2021 at 9:14P -0500, > > Ming Lei wrote: > > > > > dm request based driver doesn't set BLK_MQ_F_BLOCKING, so dm_queue_rq() > > > is supposed to not sleep. > >

Re: [dm-devel] [PATCH 3/3] dm: mark dm queue as blocking if any underlying is blocking

2022-01-06 Thread Ming Lei
On Thu, Jan 06, 2022 at 10:40:51AM -0500, Mike Snitzer wrote: > On Tue, Dec 21 2021 at 9:14P -0500, > Ming Lei wrote: > > > dm request based driver doesn't set BLK_MQ_F_BLOCKING, so dm_queue_rq() > > is supposed to not sleep. > > > > However, blk_insert_cloned_request() is used by dm_queue_rq()

Re: [dm-devel] [PATCH 3/3] dm: mark dm queue as blocking if any underlying is blocking

2022-01-06 Thread Mike Snitzer
On Tue, Dec 21 2021 at 9:14P -0500, Ming Lei wrote: > dm request based driver doesn't set BLK_MQ_F_BLOCKING, so dm_queue_rq() > is supposed to not sleep. > > However, blk_insert_cloned_request() is used by dm_queue_rq() for > queuing underlying request, but the underlying queue may be marked as

[dm-devel] [PATCH 3/3] dm: mark dm queue as blocking if any underlying is blocking

2021-12-21 Thread Ming Lei
dm request based driver doesn't set BLK_MQ_F_BLOCKING, so dm_queue_rq() is supposed to not sleep. However, blk_insert_cloned_request() is used by dm_queue_rq() for queuing underlying request, but the underlying queue may be marked as BLK_MQ_F_BLOCKING, so blk_insert_cloned_request() may become to