Re: [dm-devel] [PATCH 3/5] block: Provide blk_status_t decoding for retryable errors

2018-01-08 Thread Christoph Hellwig
> +static inline bool blk_retryable(blk_status_t error) The naming isn't really useful - it is about the fact that it's worth retrying on another path. So please chose a better name, and add a kerneldoc comment describing it. -- dm-devel mailing list dm-devel@redhat.com

Re: [dm-devel] [PATCH 3/5] block: Provide blk_status_t decoding for retryable errors

2018-01-08 Thread Hannes Reinecke
On 01/04/2018 11:46 PM, Keith Busch wrote: > This patch provides a common decoder for block status that may be retried > so various entities wishing to consult this do not have to duplicate > this decision. > > Signed-off-by: Keith Busch > --- > include/linux/blk_types.h

Re: [dm-devel] [PATCH 3/5] block: Provide blk_status_t decoding for retryable errors

2018-01-04 Thread Mike Snitzer
On Thu, Jan 04 2018 at 5:46pm -0500, Keith Busch wrote: > This patch provides a common decoder for block status that may be retried > so various entities wishing to consult this do not have to duplicate > this decision. > > Signed-off-by: Keith Busch

[dm-devel] [PATCH 3/5] block: Provide blk_status_t decoding for retryable errors

2018-01-04 Thread Keith Busch
This patch provides a common decoder for block status that may be retried so various entities wishing to consult this do not have to duplicate this decision. Signed-off-by: Keith Busch --- include/linux/blk_types.h | 16 1 file changed, 16 insertions(+)