Re: [dm-devel] [PATCH 4/8] block: support delayed holder registration

2021-08-20 Thread Guenter Roeck
On 8/20/21 8:08 AM, Christoph Hellwig wrote: Please try the patch below: --- From 7609266da56160d211662cd2fbe26570aad11b15 Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Fri, 20 Aug 2021 17:00:11 +0200 Subject: mtd_blkdevs: don't hold del_mtd_blktrans_dev in blktrans_{open,release}

Re: [dm-devel] [PATCH 4/8] block: support delayed holder registration

2021-08-20 Thread Christoph Hellwig
Please try the patch below: --- >From 7609266da56160d211662cd2fbe26570aad11b15 Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Fri, 20 Aug 2021 17:00:11 +0200 Subject: mtd_blkdevs: don't hold del_mtd_blktrans_dev in blktrans_{open,release} There is nothing that this protects against exce

Re: [dm-devel] [PATCH 4/8] block: support delayed holder registration

2021-08-17 Thread Guenter Roeck
On Mon, Aug 16, 2021 at 09:21:58AM +0200, Christoph Hellwig wrote: > On Sun, Aug 15, 2021 at 07:27:37AM -0700, Guenter Roeck wrote: > > [ 14.467748][T1] Possible unsafe locking scenario: > > [ 14.467748][T1] > > [ 14.467928][T1]CPU0CPU1 > > [ 14.4680

Re: [dm-devel] [PATCH 4/8] block: support delayed holder registration

2021-08-16 Thread Guenter Roeck
On Mon, Aug 16, 2021 at 09:21:58AM +0200, Christoph Hellwig wrote: > On Sun, Aug 15, 2021 at 07:27:37AM -0700, Guenter Roeck wrote: > > [ 14.467748][T1] Possible unsafe locking scenario: > > [ 14.467748][T1] > > [ 14.467928][T1]CPU0CPU1 > > [ 14.4680

Re: [dm-devel] [PATCH 4/8] block: support delayed holder registration

2021-08-16 Thread Christoph Hellwig
On Sun, Aug 15, 2021 at 07:27:37AM -0700, Guenter Roeck wrote: > [ 14.467748][T1] Possible unsafe locking scenario: > [ 14.467748][T1] > [ 14.467928][T1]CPU0CPU1 > [ 14.468058][T1] > [ 14.468187][T1] lo

Re: [dm-devel] [PATCH 4/8] block: support delayed holder registration

2021-08-15 Thread Guenter Roeck
On 8/15/21 12:07 AM, Christoph Hellwig wrote: On Sat, Aug 14, 2021 at 02:13:09PM -0700, Guenter Roeck wrote: On Wed, Aug 04, 2021 at 11:41:43AM +0200, Christoph Hellwig wrote: device mapper needs to register holders before it is ready to do I/O. Currently it does so by registering the disk earl

Re: [dm-devel] [PATCH 4/8] block: support delayed holder registration

2021-08-15 Thread Christoph Hellwig
On Sat, Aug 14, 2021 at 02:13:09PM -0700, Guenter Roeck wrote: > On Wed, Aug 04, 2021 at 11:41:43AM +0200, Christoph Hellwig wrote: > > device mapper needs to register holders before it is ready to do I/O. > > Currently it does so by registering the disk early, which can leave > > the disk and queu

Re: [dm-devel] [PATCH 4/8] block: support delayed holder registration

2021-08-14 Thread Guenter Roeck
On Wed, Aug 04, 2021 at 11:41:43AM +0200, Christoph Hellwig wrote: > device mapper needs to register holders before it is ready to do I/O. > Currently it does so by registering the disk early, which can leave > the disk and queue in a weird half state where the queue is registered > with the disk,

Re: [dm-devel] [PATCH 4/8] block: support delayed holder registration

2021-08-11 Thread Marek Szyprowski
Hi, On 04.08.2021 11:41, Christoph Hellwig wrote: > device mapper needs to register holders before it is ready to do I/O. > Currently it does so by registering the disk early, which can leave > the disk and queue in a weird half state where the queue is registered > with the disk, except for sysfs

[dm-devel] [PATCH 4/8] block: support delayed holder registration

2021-08-04 Thread Christoph Hellwig
device mapper needs to register holders before it is ready to do I/O. Currently it does so by registering the disk early, which can leave the disk and queue in a weird half state where the queue is registered with the disk, except for sysfs and the elevator. And this state has been a bit promlemat

Re: [dm-devel] [PATCH 4/8] block: support delayed holder registration

2021-07-29 Thread Mike Snitzer
On Sun, Jul 25 2021 at 1:54P -0400, Christoph Hellwig wrote: > device mapper needs to register holders before it is ready to do I/O. > Currently it does so by registering the disk early, which has all kinds > of bad side effects. Support registering holders on an initialized but > not registere

Re: [dm-devel] [PATCH 4/8] block: support delayed holder registration

2021-07-27 Thread Christoph Hellwig
On Tue, Jul 27, 2021 at 12:06:04PM -0400, Mike Snitzer wrote: > This header starts to shine some light on what is motivating this > series by touching on "all kinds of bad side effects" being fixed. > Any chance you could elaborate what you've noticed/found/hit? The proble mis that it leaves the q

Re: [dm-devel] [PATCH 4/8] block: support delayed holder registration

2021-07-27 Thread Mike Snitzer
On Sun, Jul 25 2021 at 1:54P -0400, Christoph Hellwig wrote: > device mapper needs to register holders before it is ready to do I/O. > Currently it does so by registering the disk early, which has all kinds > of bad side effects. Support registering holders on an initialized but > not registere

[dm-devel] [PATCH 4/8] block: support delayed holder registration

2021-07-24 Thread Christoph Hellwig
device mapper needs to register holders before it is ready to do I/O. Currently it does so by registering the disk early, which has all kinds of bad side effects. Support registering holders on an initialized but not registered disk instead by delaying the sysfs registration until the disk is regi