Re: [dm-devel] [PATCH 41/44] block: switch disk_part_iter_* to use a struct block_device

2020-11-27 Thread Jan Kara
On Fri 27-11-20 16:24:07, Christoph Hellwig wrote: > On Fri, Nov 27, 2020 at 01:53:41PM +0100, Jan Kara wrote: > > On Thu 26-11-20 14:04:19, Christoph Hellwig wrote: > > > > There's: > > > > /* put the last partition */ > > disk_put_part(piter->part); > > piter->part =

Re: [dm-devel] [PATCH 41/44] block: switch disk_part_iter_* to use a struct block_device

2020-11-27 Thread Christoph Hellwig
On Fri, Nov 27, 2020 at 01:53:41PM +0100, Jan Kara wrote: > On Thu 26-11-20 14:04:19, Christoph Hellwig wrote: > > Switch the partition iter infrastructure to iterate over block_device > > references instead of hd_struct ones mostly used to get at the > > block_device. > > > > Signed-off-by:

Re: [dm-devel] [PATCH 41/44] block: switch disk_part_iter_* to use a struct block_device

2020-11-27 Thread Jan Kara
On Thu 26-11-20 14:04:19, Christoph Hellwig wrote: > Switch the partition iter infrastructure to iterate over block_device > references instead of hd_struct ones mostly used to get at the > block_device. > > Signed-off-by: Christoph Hellwig The patch mostly looks good. Two comments below. >

[dm-devel] [PATCH 41/44] block: switch disk_part_iter_* to use a struct block_device

2020-11-26 Thread Christoph Hellwig
Switch the partition iter infrastructure to iterate over block_device references instead of hd_struct ones mostly used to get at the block_device. Signed-off-by: Christoph Hellwig --- block/genhd.c | 57 +++ block/partitions/core.c | 13