Re: [dm-devel] [PATCH v13 5/9] nvme: add copy offload support

2023-07-20 Thread Christoph Hellwig
> + if (blk_rq_nr_phys_segments(req) != 2) > + return BLK_STS_IOERR; The magic number of segments adding up source and dest really need constants and helpers to make the code understandable. > + /* +1 shift as dst+src length is added in request merging, we send copy > + *

[dm-devel] [PATCH v13 5/9] nvme: add copy offload support

2023-06-28 Thread Nitesh Shetty
Current design only supports single source range. We receive a request with REQ_OP_COPY_DST. Parse this request which consists of dst(1st) and src(2nd) bios. Form a copy command (TP 4065) trace event support for nvme_copy_cmd. Set the device copy limits to queue limits. Signed-off-by: Kanchan Jos