Re: [dm-devel] [PATCH v2] dm-crypt: make printing of the key constant-time

2022-05-09 Thread Demi Marie Obenour
Nit: did you mean CC: sta...@vger.kernel.org (colon instead of semicolon)? Also, would it be better to avoid using the formatting built-in to DMEMIT()? Finally, are there any architectures for which gcc or clang make this non-constant-time? -- Sincerely, Demi Marie Obenour (she/her/hers) Invisib

Re: [dm-devel] [PATCH v2] dm-crypt: make printing of the key constant-time

2022-05-04 Thread Milan Broz
On 25/04/2022 14:53, Mikulas Patocka wrote: This is the second version of this patch. It casts the value to unsigned before doing the shift, because right shift of a negative number is not defined. Mikulas From: Mikulas Patocka The device mapper dm-crypt target is using scnprintf("%02x", cc

[dm-devel] [PATCH v2] dm-crypt: make printing of the key constant-time

2022-04-25 Thread Mikulas Patocka
This is the second version of this patch. It casts the value to unsigned before doing the shift, because right shift of a negative number is not defined. Mikulas From: Mikulas Patocka The device mapper dm-crypt target is using scnprintf("%02x", cc->key[i]) to report the current key to users