Re: [dm-devel] [PATCH v2] dm thin: Fix bug wrt FUA request completion

2019-02-15 Thread Nikos Tsironis
On 2/15/19 5:16 PM, Mike Snitzer wrote: > On Fri, Feb 15 2019 at 9:33am -0500, > Nikos Tsironis wrote: > >> On 2/15/19 3:54 PM, Joe Thornber wrote: >>> Ack. >>> >>> Thanks for this I was under the mistaken impression that FUA requests got >>> split >>> by core dm into separate payload and PREF

Re: [dm-devel] [PATCH v2] dm thin: Fix bug wrt FUA request completion

2019-02-15 Thread Mike Snitzer
On Fri, Feb 15 2019 at 9:33am -0500, Nikos Tsironis wrote: > On 2/15/19 3:54 PM, Joe Thornber wrote: > > Ack. > > > > Thanks for this I was under the mistaken impression that FUA requests got > > split > > by core dm into separate payload and PREFLUSH requests. > > > > I've audited dm-cache

Re: [dm-devel] [PATCH v2] dm thin: Fix bug wrt FUA request completion

2019-02-15 Thread Nikos Tsironis
On 2/15/19 3:54 PM, Joe Thornber wrote: > Ack. > > Thanks for this I was under the mistaken impression that FUA requests got > split > by core dm into separate payload and PREFLUSH requests. > > I've audited dm-cache and that looks ok. > > How did you test this patch? That missing bio_list_in

Re: [dm-devel] [PATCH v2] dm thin: Fix bug wrt FUA request completion

2019-02-15 Thread Joe Thornber
Ack. Thanks for this I was under the mistaken impression that FUA requests got split by core dm into separate payload and PREFLUSH requests. I've audited dm-cache and that looks ok. How did you test this patch? That missing bio_list_init() in V1 must have caused memory corruption? - Joe On

Re: [dm-devel] [PATCH v2] dm thin: Fix bug wrt FUA request completion

2019-02-14 Thread Mike Snitzer
On Thu, Feb 14 2019 at 6:21pm -0500, Nikos Tsironis wrote: > When provisioning a new data block for a virtual block, either because > the block was previously unallocated or because we are breaking sharing, > if the whole block of data is being overwritten the bio that triggered > the provisioni

[dm-devel] [PATCH v2] dm thin: Fix bug wrt FUA request completion

2019-02-14 Thread Nikos Tsironis
When provisioning a new data block for a virtual block, either because the block was previously unallocated or because we are breaking sharing, if the whole block of data is being overwritten the bio that triggered the provisioning is issued immediately, skipping copying or zeroing of the data bloc