Re: [dm-devel] [PATCH v3 22/22] libmultipath: make checker_message thread safe

2018-11-02 Thread Martin Wilck
On Thu, 2018-11-01 at 14:53 -0500, Benjamin Marzinski wrote: > On Tue, Oct 30, 2018 at 10:06:53PM +0100, Martin Wilck wrote: > > Get rid of the static char buffer in checker_message() > > introduced in the previous "replace message by msgid" patch. > > What you have is fine, but why not somethin

Re: [dm-devel] [PATCH v3 22/22] libmultipath: make checker_message thread safe

2018-11-01 Thread Benjamin Marzinski
On Tue, Oct 30, 2018 at 10:06:53PM +0100, Martin Wilck wrote: > Get rid of the static char buffer in checker_message() > introduced in the previous "replace message by msgid" patch. What you have is fine, but why not something like this, which doesn't need to do any allocating? diff --git a/libm

[dm-devel] [PATCH v3 22/22] libmultipath: make checker_message thread safe

2018-10-30 Thread Martin Wilck
Get rid of the static char buffer in checker_message() introduced in the previous "replace message by msgid" patch. Signed-off-by: Martin Wilck --- libmultipath/checkers.c | 23 ++- libmultipath/checkers.h | 4 +++- libmultipath/discovery.c | 9 ++--- multipathd/main.