Re: [dm-devel] [PATCH v7 0/6] block: Introduce REQ_ALLOCATE flag for REQ_OP_WRITE_ZEROES

2020-03-29 Thread Chaitanya Kulkarni
On 03/26/2020 07:46 AM, Christoph Hellwig wrote: > On Thu, Mar 26, 2020 at 10:34:42AM -0400, Martin K. Petersen wrote: >>> I just worry about the proliferation of identical merging and >>> splitting code throughout the block stack as we add additional >>> single-range, no payload operations

Re: [dm-devel] [PATCH v7 0/6] block: Introduce REQ_ALLOCATE flag for REQ_OP_WRITE_ZEROES

2020-03-26 Thread Christoph Hellwig
On Thu, Mar 26, 2020 at 10:34:42AM -0400, Martin K. Petersen wrote: > I just worry about the proliferation of identical merging and splitting > code throughout the block stack as we add additional single-range, no > payload operations (Verify, etc.). I prefer to enforce the semantics in > the LLD

Re: [dm-devel] [PATCH v7 0/6] block: Introduce REQ_ALLOCATE flag for REQ_OP_WRITE_ZEROES

2020-03-26 Thread Martin K. Petersen
Christoph, > That's why I don't like the whole flags game very much. I'd rather > have REQ_OP_WRITE_ZEROES as the integrity operation that gurantees > zeroing, and a REQ_ALLOCATE that doesn't guarantee zeroing, just some > deterministic state of the blocks. I just worry about the

Re: [dm-devel] [PATCH v7 0/6] block: Introduce REQ_ALLOCATE flag for REQ_OP_WRITE_ZEROES

2020-03-26 Thread Christoph Hellwig
On Wed, Mar 25, 2020 at 01:23:33PM -0400, Martin K. Petersen wrote: > > Christoph, > > > I am very much against that for the following reason: > > > > - the current REQ_OP_DISCARD is purely a hint, and implementations can > >(and do) choose to ignore it > > > > - REQ_OP_WRITE_ZEROES is an

Re: [dm-devel] [PATCH v7 0/6] block: Introduce REQ_ALLOCATE flag for REQ_OP_WRITE_ZEROES

2020-03-25 Thread Martin K. Petersen
Christoph, > I am very much against that for the following reason: > > - the current REQ_OP_DISCARD is purely a hint, and implementations can >(and do) choose to ignore it > > - REQ_OP_WRITE_ZEROES is an actual data integrity operation with >everything that entails If you want to

Re: [dm-devel] [PATCH v7 0/6] block: Introduce REQ_ALLOCATE flag for REQ_OP_WRITE_ZEROES

2020-03-25 Thread Darrick J. Wong
On Thu, Mar 19, 2020 at 09:03:40AM -0400, Martin K. Petersen wrote: > > Christoph, > > >> Some comments? Some requests for reworking? Some personal reasons to > >> ignore my patches? > > > > I'm still completely opposed to the magic overloading using a flag. > > That is just a bad design waiting

Re: [dm-devel] [PATCH v7 0/6] block: Introduce REQ_ALLOCATE flag for REQ_OP_WRITE_ZEROES

2020-03-20 Thread Kirill Tkhai
On 19.03.2020 13:28, Christoph Hellwig wrote: > On Fri, Mar 13, 2020 at 04:08:58PM +0300, Kirill Tkhai wrote: >> I just don't understand the reason nothing happens :( >> I see newly-sent patches comes fast into block tree. >> But there is only silence... I grepped over Documentation, >> and there

Re: [dm-devel] [PATCH v7 0/6] block: Introduce REQ_ALLOCATE flag for REQ_OP_WRITE_ZEROES

2020-03-19 Thread Martin K. Petersen
Christoph, >> Some comments? Some requests for reworking? Some personal reasons to >> ignore my patches? > > I'm still completely opposed to the magic overloading using a flag. > That is just a bad design waiting for trouble to happen. The observation was that Kirill's original patch set was a

Re: [dm-devel] [PATCH v7 0/6] block: Introduce REQ_ALLOCATE flag for REQ_OP_WRITE_ZEROES

2020-03-19 Thread Christoph Hellwig
On Fri, Mar 13, 2020 at 04:08:58PM +0300, Kirill Tkhai wrote: > I just don't understand the reason nothing happens :( > I see newly-sent patches comes fast into block tree. > But there is only silence... I grepped over Documentation, > and there is no special rules about block tree. So, > it looks

Re: [dm-devel] [PATCH v7 0/6] block: Introduce REQ_ALLOCATE flag for REQ_OP_WRITE_ZEROES

2020-03-15 Thread Kirill Tkhai
I just don't understand the reason nothing happens :( I see newly-sent patches comes fast into block tree. But there is only silence... I grepped over Documentation, and there is no special rules about block tree. So, it looks like standard rules should be applyable. Some comments? Some requests

Re: [dm-devel] [PATCH v7 0/6] block: Introduce REQ_ALLOCATE flag for REQ_OP_WRITE_ZEROES

2020-03-06 Thread Kirill Tkhai
ping On 13.02.2020 10:55, Kirill Tkhai wrote: > Hi, Jens, > > could you please provide some comments on this? I sent v1 two months ago, > and it would be great to know your vision of the functionality and > the approach and whether it is going to go to block tree. > > Thanks, > Kirill > > On

Re: [dm-devel] [PATCH v7 0/6] block: Introduce REQ_ALLOCATE flag for REQ_OP_WRITE_ZEROES

2020-02-20 Thread Kirill Tkhai
Hi, Jens, could you please provide some comments on this? I sent v1 two months ago, and it would be great to know your vision of the functionality and the approach and whether it is going to go to block tree. Thanks, Kirill On 13.02.2020 10:39, Kirill Tkhai wrote: > (was "[PATCH block v2 0/3]