Mike,
I don't see your patch at:
https://patchwork.kernel.org/project/linux-block/list/?submitter=1643
Can you please upload this patch there?
Thanks,
/John
On 8/13/20, 10:48 AM, "Mike Snitzer" wrote:
Commit 764e9332098c0 ("nvme-multipath: do not reset on unknown
status"), among
+ switch (nvme_req_disposition(req)) {
+ case COMPLETE:
+ nvme_complete_req(req);
nvme_complete_rq calling nvme_complete_req... Maybe call it
__nvme_complete_rq instead?
That's what I had first, but it felt so strangely out of place next
to the other nvme_*_req
That works Mike.
Unfortunately, I have to work with the corporate MS office email handler (which
sucks) and downloading the .patch file works much better for me.
Thanks,
/John
On 8/13/20, 11:43 AM, "Mike Snitzer" wrote:
Maybe because I didn't cc linux-block?
Only way that I know
On 8/13/20, 2:44 PM, "Christoph Hellwig" wrote:
On Thu, Aug 13, 2020 at 01:47:04PM -0400, Mike Snitzer wrote:
> This is just a tweak to improve the high-level fault tree of core NVMe
> error handling. No functional change, but for such basic errors,
> avoiding entering
+static inline enum nvme_disposition nvme_req_disposition(struct request *req)
+{
+ if (likely(nvme_req(req)->status == 0))
+ return COMPLETE;
+
+ if (blk_noretry_request(req) ||
+ (nvme_req(req)->status & NVME_SC_DNR) ||
+ nvme_req(req)->retries
On Thu, Aug 13 2020 at 2:43pm -0400,
Christoph Hellwig wrote:
> On Thu, Aug 13, 2020 at 01:47:04PM -0400, Mike Snitzer wrote:
> > This is just a tweak to improve the high-level fault tree of core NVMe
> > error handling. No functional change, but for such basic errors,
> > avoiding entering
On Thu, Aug 13 2020 at 11:36am -0400,
Christoph Hellwig wrote:
> On Thu, Aug 13, 2020 at 10:48:11AM -0400, Mike Snitzer wrote:
> > Commit 764e9332098c0 ("nvme-multipath: do not reset on unknown
> > status"), among other things, fixed NVME_SC_CMD_INTERRUPTED error
> > handling by changing
On Thu, Aug 13, 2020 at 10:48:11AM -0400, Mike Snitzer wrote:
> Commit 764e9332098c0 ("nvme-multipath: do not reset on unknown
> status"), among other things, fixed NVME_SC_CMD_INTERRUPTED error
> handling by changing multipathing's nvme_failover_req() to short-circuit
> path failover and then
Maybe because I didn't cc linux-block?
Only way that I know to "upload this patch there" is to have cc'd
linux-block.
But the patch is in dm-devel's patchwork here:
https://patchwork.kernel.org/patch/11712563/
Is that sufficient for your needs?
Thanks,
Mike
On Thu, Aug 13 2020 at 11:29am
Commit 764e9332098c0 ("nvme-multipath: do not reset on unknown
status"), among other things, fixed NVME_SC_CMD_INTERRUPTED error
handling by changing multipathing's nvme_failover_req() to short-circuit
path failover and then fallback to NVMe's normal error handling (which
takes care of
10 matches
Mail list logo
