Re: [dm-devel] [RFC PATCH] libmultipath: prevent DSO unloading with astray checker threads

2020-11-24 Thread Martin Wilck
On Tue, 2020-11-24 at 14:33 -0600, Benjamin Marzinski wrote: > On Fri, Nov 06, 2020 at 06:32:16PM +0100, Martin Wilck wrote: > > On Thu, 2020-11-05 at 18:41 -0600, Benjamin Marzinski wrote: > > > I can't make this segfault. So that looks good, but it does need > > > libmultipath.version updated to

Re: [dm-devel] [RFC PATCH] libmultipath: prevent DSO unloading with astray checker threads

2020-11-24 Thread Benjamin Marzinski
On Fri, Nov 06, 2020 at 06:32:16PM +0100, Martin Wilck wrote: > On Thu, 2020-11-05 at 18:41 -0600, Benjamin Marzinski wrote: > > > > I can't make this segfault. So that looks good, but it does need > > libmultipath.version updated to include checker_thread_entry() > > Great news, thanks. Well

Re: [dm-devel] [RFC PATCH] libmultipath: prevent DSO unloading with astray checker threads

2020-11-07 Thread Xose Vazquez Perez
On 11/6/20 6:32 PM, Martin Wilck wrote: @Christophe, any chance to move forward with the merge? (then we can go ahead with this patch later, too...) These two are trivial enough, and they are missing at upstream-queue: https://marc.info/?t=16040098131 https://marc.info/?t=16040117081

Re: [dm-devel] [RFC PATCH] libmultipath: prevent DSO unloading with astray checker threads

2020-11-06 Thread Martin Wilck
On Thu, 2020-11-05 at 18:41 -0600, Benjamin Marzinski wrote: > > I can't make this segfault. So that looks good, but it does need > libmultipath.version updated to include checker_thread_entry() Great news, thanks. Well the library version stuff hasn't been committed yet anyway, this was against

Re: [dm-devel] [RFC PATCH] libmultipath: prevent DSO unloading with astray checker threads

2020-11-05 Thread Benjamin Marzinski
On Thu, Nov 05, 2020 at 12:49:52PM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > The multipathd tur checker thread is designed to be able to finish at > any time, even after the tur checker itself has been freed. The > multipathd shutdown code makes sure all the checkers have been freed

[dm-devel] [RFC PATCH] libmultipath: prevent DSO unloading with astray checker threads

2020-11-05 Thread mwilck
From: Martin Wilck The multipathd tur checker thread is designed to be able to finish at any time, even after the tur checker itself has been freed. The multipathd shutdown code makes sure all the checkers have been freed before freeing the checker_class and calling dlclose() to unload the DSO,