Re: [dm-devel] [lvm-devel] master - multipathd: fix fd leak when iscsi device logs in

2020-07-14 Thread Benjamin Marzinski
On Mon, Jul 13, 2020 at 09:59:43PM +0200, Martin Wilck wrote: > On Mon, 2020-07-13 at 11:56 +0200, Zdenek Kabelac wrote: > > > > > @Zdenek, do we have to protect every libdm call, or is it > > > sufficient > > > to protect only dm_task_run(), as lixiaokeng suggested? > > > > > > > Hi > > > >

Re: [dm-devel] [lvm-devel] master - multipathd: fix fd leak when iscsi device logs in

2020-07-13 Thread Martin Wilck
On Mon, 2020-07-13 at 11:56 +0200, Zdenek Kabelac wrote: > > > @Zdenek, do we have to protect every libdm call, or is it > > sufficient > > to protect only dm_task_run(), as lixiaokeng suggested? > > > > Hi > > It's actually hard to answer it in a simple way. > Several properties are held in

Re: [dm-devel] [lvm-devel] master - multipathd: fix fd leak when iscsi device logs in

2020-07-13 Thread Martin Wilck
On Mon, 2020-07-13 at 12:13 +0200, Zdenek Kabelac wrote: > Dne 13. 07. 20 v 12:08 Martin Wilck napsal(a): > > > > Ben has already added support for dm_hold_control_dev() in > > libmultipath > > (e24d8b1 ("libmutipath: don't close fd on dm_lib_release")). But > > this > > doesn't protect us from

Re: [dm-devel] [lvm-devel] master - multipathd: fix fd leak when iscsi device logs in

2020-07-13 Thread Zdenek Kabelac
Dne 13. 07. 20 v 12:08 Martin Wilck napsal(a): Hi Zdenek, On Mon, 2020-07-13 at 11:56 +0200, Zdenek Kabelac wrote: Dne 13. 07. 20 v 11:21 Martin Wilck napsal(a): Hi Lixiaokeng, @Zdenek, do we have to protect every libdm call, or is it sufficient to protect only dm_task_run(), as lixiaokeng

Re: [dm-devel] [lvm-devel] master - multipathd: fix fd leak when iscsi device logs in

2020-07-13 Thread Martin Wilck
Hi Zdenek, On Mon, 2020-07-13 at 11:56 +0200, Zdenek Kabelac wrote: > Dne 13. 07. 20 v 11:21 Martin Wilck napsal(a): > > Hi Lixiaokeng, > > > > > > @Zdenek, do we have to protect every libdm call, or is it > > sufficient > > to protect only dm_task_run(), as lixiaokeng suggested? > > > > Hi >

Re: [dm-devel] [lvm-devel] master - multipathd: fix fd leak when iscsi device logs in

2020-07-13 Thread Zdenek Kabelac
Dne 13. 07. 20 v 11:21 Martin Wilck napsal(a): Hi Lixiaokeng, @Zdenek, do we have to protect every libdm call, or is it sufficient to protect only dm_task_run(), as lixiaokeng suggested? Hi It's actually hard to answer it in a simple way. Several properties are held in library static

Re: [dm-devel] [lvm-devel] master - multipathd: fix fd leak when iscsi device logs in

2020-07-13 Thread Martin Wilck
Hi Lixiaokeng, On Mon, 2020-07-13 at 10:15 +0800, lixiaokeng wrote: > Hi > > Now the number of fd pointing /dev/mapper/control in multipathd > process > increases when iscsi device logs in. The reason is that wait_dmevents > thread and uevqloop thread call _open_and_assign_control_fd >

Re: [dm-devel] [lvm-devel] master - multipathd: fix fd leak when iscsi device logs in

2020-07-12 Thread lixiaokeng
Hi Now the number of fd pointing /dev/mapper/control in multipathd process increases when iscsi device logs in. The reason is that wait_dmevents thread and uevqloop thread call _open_and_assign_control_fd concurrently. If lock add to _open_and_assign_control_fd fun in lvm2/libdm/libdm-iface.c,