[dm-devel] Regression: wrong DIO alignment check with dm-crypt

2022-11-01 Thread Eric Biggers
Hi, I happened to notice the following QEMU bug report: https://gitlab.com/qemu-project/qemu/-/issues/1290 I believe it's a regression from the following kernel commit: commit b1a000d3b8ec582da64bb644be633e5a0beffcbf Author: Keith Busch Date: Fri Jun 10 12:58:29 2022 -0700

Re: [dm-devel] Regression: wrong DIO alignment check with dm-crypt

2022-11-02 Thread Mikulas Patocka
Hi On Tue, 1 Nov 2022, Eric Biggers wrote: > Hi, > > I happened to notice the following QEMU bug report: > > https://gitlab.com/qemu-project/qemu/-/issues/1290 > > I believe it's a regression from the following kernel commit: > > commit b1a000d3b8ec582da64bb644be633e5a0beffcbf > Auth

Re: [dm-devel] Regression: wrong DIO alignment check with dm-crypt

2022-11-03 Thread Keith Busch
[Cc'ing Dmitrii, who also reported the same issue] On Tue, Nov 01, 2022 at 08:11:15PM -0700, Eric Biggers wrote: > Hi, > > I happened to notice the following QEMU bug report: > > https://gitlab.com/qemu-project/qemu/-/issues/1290 > > I believe it's a regression from the following kernel commit:

Re: [dm-devel] Regression: wrong DIO alignment check with dm-crypt

2022-11-03 Thread Keith Busch
On Wed, Nov 02, 2022 at 08:03:45PM +0300, Dmitrii Tcvetkov wrote: > > Applied on top 6.1-rc3, the issue still reproduces. Yeah, I see that now. I needed to run a dm-crypt setup to figure out how they're actually doing this, so now I have that up and running. I think this type of usage will requi

Re: [dm-devel] Regression: wrong DIO alignment check with dm-crypt

2022-11-03 Thread Keith Busch
On Wed, Nov 02, 2022 at 08:52:15AM -0600, Keith Busch wrote: > [Cc'ing Dmitrii, who also reported the same issue] > > On Tue, Nov 01, 2022 at 08:11:15PM -0700, Eric Biggers wrote: > > Hi, > > > > I happened to notice the following QEMU bug report: > > > > https://gitlab.com/qemu-project/qemu/-/i

Re: [dm-devel] Regression: wrong DIO alignment check with dm-crypt

2022-11-03 Thread Dmitrii Tcvetkov
On Wed, 2 Nov 2022 10:14:52 -0600 Keith Busch wrote: > This is what I'm coming up with. Only compile tested (still setting up > an enviroment to actually run it). > > --- > diff --git a/drivers/md/dm-crypt.c b/drivers/md/dm-crypt.c > index 159c6806c19b..9334e58a4c9f 100644 > --- a/drivers/md/dm-c

Re: [dm-devel] Regression: wrong DIO alignment check with dm-crypt

2022-11-03 Thread Keith Busch
On Wed, Nov 02, 2022 at 02:45:10PM -0400, Mikulas Patocka wrote: > On Tue, 1 Nov 2022, Eric Biggers wrote: > > Hi, > > > > I happened to notice the following QEMU bug report: > > > > https://gitlab.com/qemu-project/qemu/-/issues/1290 > > > > I believe it's a regression from the following kernel

Re: [dm-devel] Regression: wrong DIO alignment check with dm-crypt

2022-11-03 Thread Dmitrii Tcvetkov
On Wed, 2 Nov 2022 14:09:54 -0600 Keith Busch wrote: > On Wed, Nov 02, 2022 at 08:03:45PM +0300, Dmitrii Tcvetkov wrote: > > > > Applied on top 6.1-rc3, the issue still reproduces. > > Yeah, I see that now. I needed to run a dm-crypt setup to figure out > how they're actually doing this, so now