Re: [dm-devel] dm-thin: Several Questions on dm-thin performance.

2019-12-18 Thread Eric Wheeler
On Wed, 18 Dec 2019, Joe Thornber wrote: > On Sun, Dec 15, 2019 at 09:44:49PM +, Eric Wheeler wrote: > > I was looking through the dm-bio-prison-v2 commit for dm-cache (b29d4986d) > > and it is huge, ~5k lines. Do you still have a git branch with these > > commits in smaller pieces (not

Re: [dm-devel] dm-thin: Several Questions on dm-thin performance.

2019-12-18 Thread Joe Thornber
On Sun, Dec 15, 2019 at 09:44:49PM +, Eric Wheeler wrote: > I was looking through the dm-bio-prison-v2 commit for dm-cache (b29d4986d) > and it is huge, ~5k lines. Do you still have a git branch with these > commits in smaller pieces (not squashed) so we can find the bits that > might be

Re: [dm-devel] dm-thin: Several Questions on dm-thin performance.

2019-12-15 Thread Eric Wheeler
On Fri, 13 Dec 2019, Eric Wheeler wrote: > On Fri, 6 Dec 2019, Nikos Tsironis wrote: > > On 11/22/19 8:55 PM, Joe Thornber wrote: > > > On Fri, Nov 22, 2019 at 11:14:15AM +0800, JeffleXu wrote: > > > > > > > The first question is what's the purpose of data cell? In > > > > thin_bio_map(), > > >

Re: [dm-devel] dm-thin: Several Questions on dm-thin performance.

2019-12-12 Thread Eric Wheeler
On Fri, 6 Dec 2019, Nikos Tsironis wrote: > On 11/22/19 8:55 PM, Joe Thornber wrote: > > On Fri, Nov 22, 2019 at 11:14:15AM +0800, JeffleXu wrote: > > > > > The first question is what's the purpose of data cell? In thin_bio_map(), > > > normal bio will be packed as a virtual cell and data cell. I

Re: [dm-devel] dm-thin: Several Questions on dm-thin performance.

2019-12-06 Thread Nikos Tsironis
On 11/22/19 8:55 PM, Joe Thornber wrote: On Fri, Nov 22, 2019 at 11:14:15AM +0800, JeffleXu wrote: The first question is what's the purpose of data cell? In thin_bio_map(), normal bio will be packed as a virtual cell and data cell. I can understand that virtual cell is used to prevent discard

Re: [dm-devel] dm-thin: Several Questions on dm-thin performance.

2019-12-05 Thread Eric Wheeler
Thanks Joe, great writeup. Maybe this should go in thin-provisioning.txt. More below: On Wed, 4 Dec 2019, Joe Thornber wrote: > (These notes are for my own benefit as much as anything, I haven't > worked on this for a couple of years and will forget it all completely > if I don't write it down

Re: [dm-devel] dm-thin: Several Questions on dm-thin performance.

2019-12-04 Thread Joe Thornber
(These notes are for my own benefit as much as anything, I haven't worked on this for a couple of years and will forget it all completely if I don't write it down somewhere). Let's start by writing some pseudocode for what the remap function for thin provisioning actually does.

Re: [dm-devel] dm-thin: Several Questions on dm-thin performance.

2019-12-03 Thread Joe Thornber
On Mon, Dec 02, 2019 at 10:26:00PM +, Eric Wheeler wrote: > Hi Joe, > > I'm not sure if I will have the time but thought I would start the > research and ask a few questions. I looked at the v1/v2 .h files and some > of the functions just change suffix to _v2 and maybe calling >

Re: [dm-devel] dm-thin: Several Questions on dm-thin performance.

2019-12-02 Thread Eric Wheeler
On Mon, 2 Dec 2019, JeffleXu wrote: > 在 2019/11/23 上午2:55, Joe Thornber 写道: > > > On Fri, Nov 22, 2019 at 11:14:15AM +0800, JeffleXu wrote: > > > > > The first question is what's the purpose of data cell? In thin_bio_map(), > > > normal bio will be packed as a virtual cell and data cell. I can >

Re: [dm-devel] dm-thin: Several Questions on dm-thin performance.

2019-12-02 Thread JeffleXu
Thanks for replying and explanation. Anyway, it seems a significant workload to transform to bio-prison-cell-v2. Regards Jeffle 在 2019/11/23 上午2:55, Joe Thornber 写道: On Fri, Nov 22, 2019 at 11:14:15AM +0800, JeffleXu wrote: The first question is what's the purpose of data cell? In

Re: [dm-devel] dm-thin: Several Questions on dm-thin performance.

2019-11-22 Thread Joe Thornber
On Fri, Nov 22, 2019 at 11:14:15AM +0800, JeffleXu wrote: > The first question is what's the purpose of data cell? In thin_bio_map(), > normal bio will be packed as a virtual cell and data cell. I can understand > that virtual cell is used to prevent discard bio and non-discard bio > targeting

[dm-devel] dm-thin: Several Questions on dm-thin performance.

2019-11-22 Thread JeffleXu
Hi guys, I have several questions on dm-thin when I'm testing and evaluating IO performance of dm-thin. I would be grateful if someone could spend a little time on it. The first question is what's the purpose of data cell? In thin_bio_map(), normal bio will be packed as a virtual cell and

[dm-devel] dm-thin: Several Questions on dm-thin performance.

2019-11-22 Thread JeffleXu
Hi guys, I have several questions on dm-thin when I'm testing and evaluating IO performance of dm-thin. I would be grateful if someone could spend a little time on it. The first question is what's the purpose of data cell? In thin_bio_map(), normal bio will be packed as a virtual cell and