Re: [dm-devel] drive-by blk-cgroup cleanups

2020-06-29 Thread Johannes Thumshirn
On 27/06/2020 09:33, Christoph Hellwig wrote: > Hi all, > > while looking into another "project" I ended up wading through the > blkcq code for research and found a bunch of lose ends. So here is > a bunch of drive-by cleanups for the code. > > Diffstat: > block/bio.c| 143 +---

Re: [dm-devel] drive-by blk-cgroup cleanups

2020-06-29 Thread Johannes Thumshirn
On 29/06/2020 10:08, Christoph Hellwig wrote: > You'll have to ask Jens :) Note that your patch 2 overlaps with this > series. Should have removed you from the To: field, sorry. > I thik my version is a little nicer, given that > blkcg_bio_issue_check is a very strange function doing multiple

Re: [dm-devel] drive-by blk-cgroup cleanups

2020-06-29 Thread Jens Axboe
On 6/27/20 1:31 AM, Christoph Hellwig wrote: > Hi all, > > while looking into another "project" I ended up wading through the > blkcq code for research and found a bunch of lose ends. So here is > a bunch of drive-by cleanups for the code. Applied, thanks. -- Jens Axboe -- dm-devel mailing li

Re: [dm-devel] drive-by blk-cgroup cleanups

2020-06-29 Thread Tejun Heo
On Sat, Jun 27, 2020 at 09:31:45AM +0200, Christoph Hellwig wrote: > Hi all, > > while looking into another "project" I ended up wading through the > blkcq code for research and found a bunch of lose ends. So here is > a bunch of drive-by cleanups for the code. The whole series looks great to me

Re: [dm-devel] drive-by blk-cgroup cleanups

2020-06-29 Thread Christoph Hellwig
On Mon, Jun 29, 2020 at 08:05:07AM +, Johannes Thumshirn wrote: > Btw what ever happened to > https://lore.kernel.org/r/20200430150356.35691-1-johannes.thumsh...@wdc.com? You'll have to ask Jens :) Note that your patch 2 overlaps with this series. I thik my version is a little nicer, given

[dm-devel] drive-by blk-cgroup cleanups

2020-06-27 Thread Christoph Hellwig
Hi all, while looking into another "project" I ended up wading through the blkcq code for research and found a bunch of lose ends. So here is a bunch of drive-by cleanups for the code. Diffstat: block/bio.c| 143 +-- block/blk-cgroup.c |