Re: [dm-devel] xfstests generic/347 was never correct [was: Re: dm: fix inflight IO check]

2018-12-12 Thread Mike Snitzer
On Tue, Dec 11 2018 at 9:58pm -0500, Eric Sandeen wrote: > On 12/11/18 8:34 PM, Mike Snitzer wrote: > > On Mon, Dec 10 2018 at 7:32pm -0500, > > Mike Snitzer wrote: > > > > SO generic/347 needs to account for 2 things: > > 1) issue $XFS_IO_PROG IO in the background with other process(es) > >

Re: [dm-devel] xfstests generic/347 was never correct [was: Re: dm: fix inflight IO check]

2018-12-11 Thread Eric Sandeen
On 12/11/18 8:34 PM, Mike Snitzer wrote: > On Mon, Dec 10 2018 at 7:32pm -0500, > Mike Snitzer wrote: > >> On Mon, Dec 10 2018 at 5:45pm -0500, >> Jens Axboe wrote: >> >>> After switching to percpu inflight counters, the inflight check >>> is totally buggy. It's perfectly valid for some counte

[dm-devel] xfstests generic/347 was never correct [was: Re: dm: fix inflight IO check]

2018-12-11 Thread Mike Snitzer
On Mon, Dec 10 2018 at 7:32pm -0500, Mike Snitzer wrote: > On Mon, Dec 10 2018 at 5:45pm -0500, > Jens Axboe wrote: > > > After switching to percpu inflight counters, the inflight check > > is totally buggy. It's perfectly valid for some counters to be > > non-zero while having a total inflig