Re: [dm-devel] 答复: Re: [PATCH] multipath-tools: improve processing efficiency for addition and deletion of multipath devices

2017-02-20 Thread tang.junhui
multipath-tools: improve processing efficiency for addition and deletion of multipath devices Hello Tang, > In the second case, we know all events in the sequence have the > same > > WWID in this case I think it would be safe to filter away "remove" > > events by subsequent "add"

Re: [dm-devel] 答复: Re: [PATCH] multipath-tools: improve processing efficiency for addition and deletion of multipath devices

2017-02-20 Thread Martin Wilck
Hello Tang, > In the second case, we know all events in the sequence have the > same > > WWID; in this case I think it would be safe to filter away "remove" > > events by subsequent "add" events, ending up with "add path1| add > > path2| remove path3". But I may be overlooking something here. > >

Re: [dm-devel] 答复: Re: [PATCH] multipath-tools: improve processing efficiency for addition and deletion of multipath devices

2017-02-17 Thread Martin Wilck
On Fri, 2017-02-17 at 11:24 +0800, tang.jun...@zte.com.cn wrote: > Hello Martin, > > Thanks for your responsible, > > > I'd like the following better for this check. It uses much less cyc > les. > > >  static bool > > can_discard_by_devpath(const char *devpath) > > > This would be better readab

Re: [dm-devel] 答复: Re: [PATCH] multipath-tools: improve processing efficiency for addition and deletion of multipath devices

2017-02-16 Thread Benjamin Marzinski
On Fri, Feb 17, 2017 at 11:24:10AM +0800, tang.jun...@zte.com.cn wrote: >Hello Martin, > >Thanks for your responsible, > >> I'd like the following better for this check. It uses much less cycles. > >>  static bool >> can_discard_by_devpath(const char *devpath) > >> This