Am Sat, 17 Feb 2024 22:36:04 +
schrieb Simon Kelley :
> On 16/02/2024 13:24, Matthias Lay via Dnsmasq-discuss wrote:
> >
> > Hi List,
> >
> > I am trying to set the *dhcp-ignore* option for a single dhcp-range
> > only. after reading the manpage my setup is like this:
> >
> > dhcp-range=set
Hello,
I might have stumbled upon a minor bug in dnsmasq which causes NET_ADMIN
capability being required even if it's actually not needed (according to
provided command line arguments).
diff --git a/src/dnsmasq.c b/src/dnsmasq.c
index 30fb419..cef42f6 100644
--- a/src/dnsmasq.c
+++ b/src/dnsmasq
On Mon, Feb 19, 2024 at 04:32:50PM +0100, Martin Ivičič wrote:
> Hello,
>
> I might have stumbled upon a minor bug in dnsmasq which causes NET_ADMIN
> capability being required even if it's actually not needed (according to
> provided command line arguments).
>
> diff --git a/src/dnsmasq.c b/src/
It seems like sometimes the rrlist given to rr_on_list can be a circular linked
list:
0xbbf57044 in rr_on_list (list=0xbbfe1990 , rr=5) at
util.c:120
120 while (list)
(gdb) p list
$1 = (struct rrlist *) 0xbbfe1990
(gdb) p list.next
$3 = (struct rrlis
On Mon, 19 Feb 2024 13:29:44 -0800 Clayton Craft wrote:
> The conditions to trigger this aren't well understood by me... it seems to
> happen when we use dnsmasq's dbus interface to toggle filtering ("set_filter A
> bool"). But I've had trouble reproducing it manually. We hit it a lot when
> usi
https://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commit;h=89aad014685161318318737dc0e350ee4dae982d
should fix this.
Simon.
On 19/02/2024 23:16, Simon Kelley wrote:
Wow, excellent bug report, thank you.
Took me straight to the stupid error.
src/dbus.c around line 834. The code block control
Wow, excellent bug report, thank you.
Took me straight to the stupid error.
src/dbus.c around line 834. The code block controlled by "if (!done)"
should include the line "done = 1;" Same thing below for filter .
I'll push the patch directly.
Cheers,
Simon.
On 19/02/2024 21:29, Clayton
If you're doing DHCP, even if you're not sending ICMP ping packets, you
still need CAP_NET_ADMIN, because the DHCP server has to be able to
manipulate the ARP table.
I guess you're starting dnsmasq without CAP_NET_ADMIN, dnsmasq is
determining that it needs CPA_NET_ADMIN to run the DHCP server
> https://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commit;h=89aad014685161318318737dc0e350ee4dae982d
>
> should fix this.
Nice, ya seems to fix it for me. Thanks a lot for the quick fix!
-Clayton
signature.asc
Description: PGP signature
___
Dnsmasq-
I'm currently running dnsmasq (with my patch applied) using the
following script and everything seems to work fine actually - no
errors reported.
(I have only added CAP_NET_BIND_SERVICE in order to be able to bind to port 67.)
#!/bin/bash
set -euo pipefail
SCRIPT_DIR="$( cd "$( dirname "${BASH_SOU
10 matches
Mail list logo
