Re: [Dnsmasq-discuss] [BUG] dnsmasq rewriting NXDOMAIN to NOERROR

2021-07-06 Thread Simon Kelley
On 06/07/2021 13:39, Dominik DL6ER wrote: > On Mon, 2021-07-05 at 21:06 +0100, Simon Kelley wrote: >> Nice catch, thanks. I believe that >> df25f204ba822c9c00bc9372c85da58e9aff6e86 >> should fix this. > > Looks good. We've started a Pi-hole beta testing round which uses the > tip of dnsmasq's

Re: [Dnsmasq-discuss] [BUG] dnsmasq rewriting NXDOMAIN to NOERROR

2021-07-06 Thread Dominik DL6ER
On Mon, 2021-07-05 at 21:06 +0100, Simon Kelley wrote: > Nice catch, thanks. I believe that > df25f204ba822c9c00bc9372c85da58e9aff6e86 > should fix this. Looks good. We've started a Pi-hole beta testing round which uses the tip of dnsmasq's master branch. Hereby we will have many more users

Re: [Dnsmasq-discuss] [BUG] dnsmasq rewriting NXDOMAIN to NOERROR

2021-07-05 Thread Kevin Darbyshire-Bryant
> On 5 Jul 2021, at 21:12, Simon Kelley wrote: > > On 05/07/2021 19:31, Kevin Darbyshire-Bryant wrote: >> >> >>> On 5 Jul 2021, at 16:53, Dominik DL6ER wrote: >>> >>> Hey Simon, >>> >>> the current dnsmasq master version contains a bug rewriting all >>> NXDOMAIN replies from upstream with

Re: [Dnsmasq-discuss] [BUG] dnsmasq rewriting NXDOMAIN to NOERROR

2021-07-05 Thread Simon Kelley
On 05/07/2021 16:53, Dominik DL6ER wrote: > Hey Simon, > > the current dnsmasq master version contains a bug rewriting all > NXDOMAIN replies from upstream with NOERROR. > > The error has been introduced in commit > d0ae3f5a4dc094e8fe2a3c607028c1c59f42f473 (see attached diff) and is > ultimately

Re: [Dnsmasq-discuss] [BUG] dnsmasq rewriting NXDOMAIN to NOERROR

2021-07-05 Thread Simon Kelley
On 05/07/2021 19:31, Kevin Darbyshire-Bryant wrote: > > >> On 5 Jul 2021, at 16:53, Dominik DL6ER wrote: >> >> Hey Simon, >> >> the current dnsmasq master version contains a bug rewriting all >> NXDOMAIN replies from upstream with NOERROR. >> >> The error has been introduced in commit >>

Re: [Dnsmasq-discuss] [BUG] dnsmasq rewriting NXDOMAIN to NOERROR

2021-07-05 Thread Kevin Darbyshire-Bryant
> On 5 Jul 2021, at 16:53, Dominik DL6ER wrote: > > Hey Simon, > > the current dnsmasq master version contains a bug rewriting all > NXDOMAIN replies from upstream with NOERROR. > > The error has been introduced in commit > d0ae3f5a4dc094e8fe2a3c607028c1c59f42f473 (see attached diff) and is

[Dnsmasq-discuss] [BUG] dnsmasq rewriting NXDOMAIN to NOERROR

2021-07-05 Thread Dominik DL6ER
Hey Simon, the current dnsmasq master version contains a bug rewriting all NXDOMAIN replies from upstream with NOERROR. The error has been introduced in commit d0ae3f5a4dc094e8fe2a3c607028c1c59f42f473 (see attached diff) and is ultimately caused by > lookup_domain(daemon->namebuff, F_CONFIG,