Re: [Dnsmasq-discuss] [PATCH] DHCPv6 - List or Range reservation for single host

2020-03-17 Thread Simon Kelley
On 10/03/2020 14:25, Petr Menšík wrote: > That is a pity. Is there anything I can help to include it in 2.81? If > you have any objections to part of it or whole concept, please say so. I > would rebase the change again. > > I was added to Fedora as downstream in late summer [1], have not yet

Re: [Dnsmasq-discuss] [PATCH] DHCPv6 - List or Range reservation for single host

2020-03-10 Thread Petr Menšík
On 3/8/20 5:02 PM, Simon Kelley wrote: > On 06/03/2020 22:10, Petr Menšík wrote: >> Hi Simon, >> >> I have been adapting this feature to earlier releases and discovered one >> error with prefixed address assignment. When it is calculating number of >> addresses from prefixlen, it rotates only

Re: [Dnsmasq-discuss] [PATCH] DHCPv6 - List or Range reservation for single host

2020-03-08 Thread Simon Kelley
On 06/03/2020 22:10, Petr Menšík wrote: > Hi Simon, > > I have been adapting this feature to earlier releases and discovered one > error with prefixed address assignment. When it is calculating number of > addresses from prefixlen, it rotates only 32bit int instead of 64b uint. > Only result is

Re: [Dnsmasq-discuss] [PATCH] DHCPv6 - List or Range reservation for single host

2020-03-06 Thread Petr Menšík
Hi Simon, I have been adapting this feature to earlier releases and discovered one error with prefixed address assignment. When it is calculating number of addresses from prefixlen, it rotates only 32bit int instead of 64b uint. Only result is assigned to 64b variable. Two examples:

Re: [Dnsmasq-discuss] [PATCH] DHCPv6 - List or Range reservation for single host

2020-02-12 Thread Simon Kelley
On 10/02/2020 22:18, Harald Jensås wrote: > On Mon, 2020-02-10 at 21:37 +, Simon Kelley wrote: >> On 10/02/2020 17:56, Harald Jensås wrote: >>> On Fri, 2020-02-07 at 21:27 +, Simon Kelley wrote: Two commits in the repo, one adds arbitrary list of IPv6 addresses to dhcp-host,

Re: [Dnsmasq-discuss] [PATCH] DHCPv6 - List or Range reservation for single host

2020-02-10 Thread Harald Jensås
On Mon, 2020-02-10 at 21:37 +, Simon Kelley wrote: > On 10/02/2020 17:56, Harald Jensås wrote: > > On Fri, 2020-02-07 at 21:27 +, Simon Kelley wrote: > > > Two commits in the repo, one adds arbitrary list of IPv6 > > > addresses to > > > dhcp-host, second adds tags. > > > > > > Please

Re: [Dnsmasq-discuss] [PATCH] DHCPv6 - List or Range reservation for single host

2020-02-10 Thread Simon Kelley
On 10/02/2020 17:56, Harald Jensås wrote: > On Fri, 2020-02-07 at 21:27 +, Simon Kelley wrote: >> Two commits in the repo, one adds arbitrary list of IPv6 addresses to >> dhcp-host, second adds tags. >> >> Please give them a whirl >> > > Thank you for working on this Simon. I have tested

Re: [Dnsmasq-discuss] [PATCH] DHCPv6 - List or Range reservation for single host

2020-02-10 Thread Harald Jensås
On Fri, 2020-02-07 at 21:27 +, Simon Kelley wrote: > Two commits in the repo, one adds arbitrary list of IPv6 addresses to > dhcp-host, second adds tags. > > Please give them a whirl > Thank you for working on this Simon. I have tested the following configuration variations and there

Re: [Dnsmasq-discuss] [PATCH] DHCPv6 - List or Range reservation for single host

2020-02-07 Thread Simon Kelley
Two commits in the repo, one adds arbitrary list of IPv6 addresses to dhcp-host, second adds tags. Please give them a whirl Cheers, Simon. On 04/02/2020 14:24, Harald Jensås wrote: > On Tue, 2020-02-04 at 00:06 +, Simon Kelley wrote: >> I went though this carefully, and decided

Re: [Dnsmasq-discuss] [PATCH] DHCPv6 - List or Range reservation for single host

2020-02-05 Thread Simon Kelley
On 04/02/2020 14:24, Harald Jensås wrote: > On Tue, 2020-02-04 at 00:06 +, Simon Kelley wrote: >> I went though this carefully, and decided that replacing the address >> in >> the dhcp-host with the next free one, but otherwise treating things >> the >> same might not work well. For instance,

Re: [Dnsmasq-discuss] [PATCH] DHCPv6 - List or Range reservation for single host

2020-02-04 Thread Harald Jensås
On Tue, 2020-02-04 at 00:06 +, Simon Kelley wrote: > I went though this carefully, and decided that replacing the address > in > the dhcp-host with the next free one, but otherwise treating things > the > same might not work well. For instance, there are places where the > question is asked

Re: [Dnsmasq-discuss] [PATCH] DHCPv6 - List or Range reservation for single host

2020-02-03 Thread Simon Kelley
I went though this carefully, and decided that replacing the address in the dhcp-host with the next free one, but otherwise treating things the same might not work well. For instance, there are places where the question is asked "is this address reserved in any dhcp-host?" and clearly that needs

Re: [Dnsmasq-discuss] [PATCH] DHCPv6 - List or Range reservation for single host

2020-01-27 Thread Harald Jensås
On Sun, 2020-01-26 at 18:34 +, Simon Kelley wrote: > /62 is crazy, I don't know why I even said that. Harald, if you could > tweak your patch work with 128-based prefixes, I think we have > reached a > successful conclusion. Sure, since 128-bit int's might not be available on many platforms

Re: [Dnsmasq-discuss] [PATCH] DHCPv6 - List or Range reservation for single host

2020-01-26 Thread Simon Kelley
On 21/01/2020 23:31, Harald Jensås wrote: > On Tue, 2020-01-21 at 23:38 +0100, Tore Anderson wrote: >> * Simon Kelley >> >>> I have an alternative suggestion for the syntax of dhcp-host. >>> It's less flexible, but simpler and easier to understand and to >>> explain, >>> and uses existing

Re: [Dnsmasq-discuss] [PATCH] DHCPv6 - List or Range reservation for single host

2020-01-26 Thread Simon Kelley
On 21/01/2020 22:38, Tore Anderson wrote: > * Simon Kelley > >> I have an alternative suggestion for the syntax of dhcp-host. >> It's less flexible, but simpler and easier to understand and to explain, >> and uses existing semantics rather than adding new keywords. >> >> The idea is just to add a

Re: [Dnsmasq-discuss] [PATCH] DHCPv6 - List or Range reservation for single host

2020-01-21 Thread Geert Stappers
On Wed, Jan 22, 2020 at 12:31:16AM +0100, Harald Jensås wrote: > On Tue, 2020-01-21 at 23:38 +0100, Tore Anderson wrote: > > * Simon Kelley > > > > > I have an alternative suggestion for the syntax of dhcp-host. > > > It's less flexible, but simpler and easier to understand and to > > > explain,

Re: [Dnsmasq-discuss] [PATCH] DHCPv6 - List or Range reservation for single host

2020-01-21 Thread Harald Jensås
On Tue, 2020-01-21 at 23:38 +0100, Tore Anderson wrote: > * Simon Kelley > > > I have an alternative suggestion for the syntax of dhcp-host. > > It's less flexible, but simpler and easier to understand and to > > explain, > > and uses existing semantics rather than adding new keywords. > > > >

Re: [Dnsmasq-discuss] [PATCH] DHCPv6 - List or Range reservation for single host

2020-01-21 Thread Tore Anderson
* Simon Kelley > I have an alternative suggestion for the syntax of dhcp-host. > It's less flexible, but simpler and easier to understand and to explain, > and uses existing semantics rather than adding new keywords. > > The idea is just to add a prefix-length to the address. That allows you >

Re: [Dnsmasq-discuss] [PATCH] DHCPv6 - List or Range reservation for single host

2020-01-20 Thread Simon Kelley
On 16/01/2020 18:09, Harald Jensås wrote: > Hi, > > Changing the topic and dropping the history as this is a full re-write > of the patch based on the previous feedback and discussion. Instead of > multiple dhcp-host entries, a single dhcp-host entry can be defined > with either a list: or

Re: [Dnsmasq-discuss] [PATCH] DHCPv6 - List or Range reservation for single host

2020-01-16 Thread Harald Jensås
Hi, Changing the topic and dropping the history as this is a full re-write of the patch based on the previous feedback and discussion. Instead of multiple dhcp-host entries, a single dhcp-host entry can be defined with either a list: or range: of addresses, this should eliminate the issue with