Re: [Dnsmasq-discuss] [PATCH] Re: dhcp-boot & dhcp-reply-delay optional tag fixes

2018-12-16 Thread Simon Kelley
Thanks both for this. Petr's more comprehensive patch is now in my tree. Cheers, Simon. On 15/12/2018 09:43, Kevin Darbyshire-Bryant wrote: > > >> On 14 Dec 2018, at 16:10, Petr Mensik wrote: >> >> Hi Kevin et al, >> >> sure, your fix is correct one. I just found one more place where

Re: [Dnsmasq-discuss] [PATCH] Re: dhcp-boot & dhcp-reply-delay optional tag fixes

2018-12-15 Thread Kevin Darbyshire-Bryant
> On 14 Dec 2018, at 16:10, Petr Mensik wrote: > > Hi Kevin et al, > > sure, your fix is correct one. I just found one more place where tags > were required. Your pointer handling is not as hopeless as you are > saying. :) He he - It’s always good to get a second opinion though :-) And you

[Dnsmasq-discuss] [PATCH] Re: dhcp-boot & dhcp-reply-delay optional tag fixes

2018-12-14 Thread Petr Mensik
Hi Kevin et al, sure, your fix is correct one. I just found one more place where tags were required. Your pointer handling is not as hopeless as you are saying. :) Sorry for inconvenience caused by my change. I miss some tests that would discover it, have to write them someday soon. Petr On