Re: Segfault when using doveadm batch -A : kick

2018-12-07 Thread Apollon Oikonomopoulos
On 21:33 Fri 07 Dec , Apollon Oikonomopoulos wrote: > Hi, > > Apparently the "kick" doveadm_cmd_ver2 struct lacks a .mail_cmd member > pointing to an appropriate allocation function, causing a NULL pointer > dereference when used via `doveadm batch`. > > (g

Segfault when using doveadm batch -A : kick

2018-12-07 Thread Apollon Oikonomopoulos
Hi, Apparently the "kick" doveadm_cmd_ver2 struct lacks a .mail_cmd member pointing to an appropriate allocation function, causing a NULL pointer dereference when used via `doveadm batch`. (gdb) bt #0 0x in ?? () #1 0x55585882 in doveadm_mail_cmd_init

Re: murmurhash3 test failures on big-endian systems

2018-03-29 Thread Apollon Oikonomopoulos
On 15:55 Wed 28 Mar , Josef 'Jeff' Sipek wrote: > Ok, there are two commits: > > 35497604d80090a02619024aeec069b32568e4b4 and > 5522b8b3d3ed1a99c3b63bb120216af0bd427403 > > Together, they should be identical to the patch I sent the other day plus > your fixup. Let me know if you have any

Re: murmurhash3 test failures on big-endian systems

2018-03-27 Thread Apollon Oikonomopoulos
On 13:05 Tue 27 Mar , Apollon Oikonomopoulos wrote: > On 11:31 Tue 27 Mar , Apollon Oikonomopoulos wrote: > It turns out there's a missing byte-inversion when loading the blocks > which should be addressed in getblock{32,64}. Murmurhash treats each > block as an integer expe

Re: murmurhash3 test failures on big-endian systems

2018-03-27 Thread Apollon Oikonomopoulos
On 11:31 Tue 27 Mar , Apollon Oikonomopoulos wrote: > Hi, > > On 12:55 Mon 26 Mar , Josef 'Jeff' Sipek wrote: > > On Mon, Mar 26, 2018 at 15:57:01 +0300, Apollon Oikonomopoulos wrote: > > ... > > > I'd be happy to test the patch, thanks! >

Re: murmurhash3 test failures on big-endian systems

2018-03-27 Thread Apollon Oikonomopoulos
Hi, On 12:55 Mon 26 Mar , Josef 'Jeff' Sipek wrote: > On Mon, Mar 26, 2018 at 15:57:01 +0300, Apollon Oikonomopoulos wrote: > ... > > I'd be happy to test the patch, thanks! > > Ok, try the attached patch. (It is a first pass at the issue, so it may not > be the fina

Re: murmurhash3 test failures on big-endian systems

2018-03-26 Thread Apollon Oikonomopoulos
Hi Aki, On 15:55 Mon 26 Mar , Aki Tuomi wrote: > On 26.03.2018 15:49, Apollon Oikonomopoulos wrote: > > Hi, > > > > The dovecot 2.3.0.1 Debian package currently fails to build on all > > big-endian architectures[1], due to murmurhash3 tests failing. The > >

murmurhash3 test failures on big-endian systems

2018-03-26 Thread Apollon Oikonomopoulos
Hi, The dovecot 2.3.0.1 Debian package currently fails to build on all big-endian architectures[1], due to murmurhash3 tests failing. The relevant output from e.g. s390x is: test-murmurhash3.c:22: Assert(#8) failed: memcmp(result, vectors[i].result, sizeof(result)) == 0

Re: Bug#876364: dovecot-sieve: Just discovered imap_sieve/sieve_imapsieve is not set up to work with virtual mailboxes.

2017-09-21 Thread Apollon Oikonomopoulos
Control: tags -1 + moreinfo upstream [Forwarding this to the Dovecot mailing list, just in case someone can help] Hi, Thanks for the report! See my comments inline. On 11:56 Thu 21 Sep , Thurgood Angelou wrote: > Package: dovecot-core > Version: 1:2.2.32-2 > > I've just discovered a bug

[RFC master-2.2 1/1] Support setting min/max SSL protocol version

2017-09-13 Thread Apollon Oikonomopoulos
ssl_options config file option is encountered while running on OpenSSL 1.1 (although it will not ignore the option at this point). Signed-off-by: Apollon Oikonomopoulos <apoi...@debian.org> --- doc/example-config/conf.d/10-ssl.conf | 4 src/config/config-parser.c

[RFC master-2.2 0/1] Support OpenSSL 1.1 API for setting allowed TLS versions

2017-09-13 Thread Apollon Oikonomopoulos
penSSL 1.0 it doesn't seem to break anything. Other than that, this is a first version; I'm sure there are still things to improve, so comments are welcome :) Regards, Apollon [1] https://bugs.debian.org/871987 [2] https://www.openssl.org/docs/man1.1.0/ssl/SSL_CTX_set_min_proto_version.htm

Re: [PATCH] Manually cleanup OpenSSL from dovecot_openssl_common_global_unref()

2016-11-21 Thread Apollon Oikonomopoulos
Hi, On 22:59 Sun 20 Nov , Reuben Farrelly wrote: > Hi, > > This patch: > > > ... which was committed as c164f8afe58c8d83ef2a48aae629c72408dfea01 in > master-2.2, terminally breaks the build with LibreSSL. Obviously this > wasn't tested or considered ;) Yes, unfortunately LibreSSL fakes

[PATCH] ssl: fix reference to SSLv2 and disable SSLv3

2016-11-15 Thread Apollon Oikonomopoulos
good idea to disable SSLv3 by default as well. [1] https://bugs.debian.org/844347 Signed-off-by: Apollon Oikonomopoulos <apoi...@debian.org> --- doc/example-config/conf.d/10-ssl.conf| 2 +- src/lib-master/master-service-ssl-settings.c | 6 +- 2 files changed, 6 insertions(+), 2 de

[PATCH] Manually cleanup OpenSSL from dovecot_openssl_common_global_unref()

2016-11-13 Thread Apollon Oikonomopoulos
/commit/4af9f7fe79ff82b90c16969b7e5871435056377b [2] https://buildd.debian.org/status/fetch.php?pkg=dovecot=amd64=1:2.2.26.0-2=1478873022 Signed-off-by: Apollon Oikonomopoulos <apoi...@debian.org> --- src/lib-ssl-iostream/dovecot-openssl-common.c | 3 +++ 1 file changed, 3 insertions(+) diff

Sieve script replication glitches

2015-12-09 Thread Apollon Oikonomopoulos
Hi, I'm running a replicated setup on Debian with Dovecot 2.2.18 and Pigeonhole 0.4.8 and run into some glitches with sieve script syncing. Replication is implemented via DSync/doveadm over SSL. While e-mail replication works as expected, sieve script replication is not always successful. In