Re: [Dovecot] quota vs. antispam issue

2008-07-25 Thread Juan Asensio Sánchez
Yes I didn't realise that error, so the plugin did not work correctly. After fixing it (remove the ;), recompile, the plugin looks to work fine. Thank you very much again. 2008/7/25 Anders <[EMAIL PROTECTED]>: > Johannes Berg wrote: > >> Ok, I've committed that, so it should work now. Somebody p

Re: [Dovecot] quota vs. antispam issue

2008-07-25 Thread Anders
Johannes Berg wrote: > Ok, I've committed that, so it should work now. Somebody please test. I guess the extra semicolon (after save_init) is a typo? - return asbox->module_ctx.super.save_init(t, flags, keywords, received_date, + ret = asbox->module_ctx.super.save_init;(t, flags, k

Re: [Dovecot] quota vs. antispam issue

2008-07-24 Thread Juan Asensio Sánchez
I will test it tomorrow. Thanks for your work. 2008/7/24 Johannes Berg <[EMAIL PROTECTED]>: > On Mon, 2008-07-21 at 15:26 +0300, Timo Sirainen wrote: >> On Mon, 2008-07-21 at 06:48 +0200, Johannes Berg wrote: >> > On Sun, 2008-07-20 at 23:53 +0300, Timo Sirainen wrote: >> > >> > > > Ok, that seem

Re: [Dovecot] quota vs. antispam issue

2008-07-24 Thread Johannes Berg
On Mon, 2008-07-21 at 15:26 +0300, Timo Sirainen wrote: > On Mon, 2008-07-21 at 06:48 +0200, Johannes Berg wrote: > > On Sun, 2008-07-20 at 23:53 +0300, Timo Sirainen wrote: > > > > > > Ok, that seems to work, but I think a better alternative would probably > > > > be to make dest_mail a struct ma

Re: [Dovecot] quota vs. antispam issue

2008-07-21 Thread Timo Sirainen
On Mon, 2008-07-21 at 06:48 +0200, Johannes Berg wrote: > On Sun, 2008-07-20 at 23:53 +0300, Timo Sirainen wrote: > > > > Ok, that seems to work, but I think a better alternative would probably > > > be to make dest_mail a struct mail ** like the context. > > > > That'd be an API change and I'd r

Re: [Dovecot] quota vs. antispam issue

2008-07-21 Thread Johannes Berg
On Sun, 2008-07-20 at 23:53 +0300, Timo Sirainen wrote: > > Ok, that seems to work, but I think a better alternative would probably > > be to make dest_mail a struct mail ** like the context. > > That'd be an API change and I'd rather not do that for v1.1. But I > suppose it would be the best per

Re: [Dovecot] quota vs. antispam issue

2008-07-20 Thread Timo Sirainen
On Fri, 2008-07-18 at 20:12 +0200, Johannes Berg wrote: > On Fri, 2008-07-18 at 20:58 +0300, Timo Sirainen wrote: > > > So the quota code eventually sees both ctx->dest_mail = NULL and qt- > > >tmp_mail = NULL. I'm not really sure what the right fix for this > > is.. ctx->dest_mail should be s

Re: [Dovecot] quota vs. antispam issue

2008-07-18 Thread Johannes Berg
On Fri, 2008-07-18 at 20:58 +0300, Timo Sirainen wrote: > So the quota code eventually sees both ctx->dest_mail = NULL and qt- > >tmp_mail = NULL. I'm not really sure what the right fix for this > is.. ctx->dest_mail should be set by something. Perhaps if quota/ > antispam overrides it it sho

Re: [Dovecot] quota vs. antispam issue

2008-07-18 Thread Johannes Berg
> I recently wondered about that code. The problem is: > > 1. save_init() is called with dest_mail=NULL > 2. antispam sees that dest_mail=NULL and sets it, and calls > super.save_init() > 3. quota sees that dest_mail != NULL so it doesn't set qt->tmp_mail > 4. mailbox_save_init() stores ctx->de

Re: [Dovecot] quota vs. antispam issue

2008-07-18 Thread Johannes Berg
On Fri, 2008-07-18 at 19:40 +0200, Johannes Berg wrote: > Can you help me maybe? I don't see the bug. > I'll keep digging but I don't see why > > return quota_check(ctx->transaction, ctx->dest_mail != NULL ? >ctx->dest_mail : qt->tmp_mail); > > should pass NU

Re: [Dovecot] quota vs. antispam issue

2008-07-18 Thread Timo Sirainen
On Jul 18, 2008, at 8:40 PM, Johannes Berg wrote: Can you help me maybe? I don't see the bug. .. 0x100929f4 in mail_get_physical_size (mail=0x0, size_r=0xbfeaf030) at mail.c:100 100 return p->v.get_physical_size(mail, size_r); (gdb) bt #0 0x100929f4 in mail_get_physical_size (ma

[Dovecot] quota vs. antispam issue

2008-07-18 Thread Johannes Berg
Can you help me maybe? I don't see the bug. QUOTA=maildir QUOTA_RULE='*:storage=100M' MAIL_PLUGINS="antispam quota" MAIL_PLUGIN_DIR=/home/johannes/Projects/dovecot/antispam gdb --args /home/johannes/Projects/dovecot/dovecot-1.1/src/imap/imap GNU gdb 6.8-debian Copyright (C) 2008 Free Software Fo