Hi,

we have found that assert test fails on some architectures:

test-net.c:59: Assert failed: net_addr2ip("127.0.0.1", &ip) == 0 && ip.family == AF_INET && ip.u.ip4.s_addr == (127 | (1 << 24))

It seems as bug in test suit as test is expecting IPv4 address in LE format (0x0100007f), but it gets address in BE format(0x7f000001). Patch in attachment should fix this issue.

Regards
Michal Hlavinka
--- dovecot-2.2.18/src/lib/test-net.c	2015-05-03 05:12:11.000000000 -0400
+++ dovecot-2.2.18/src/lib/test-net.c	2015-06-17 03:18:02.571420401 -0400
@@ -56,7 +56,7 @@ static void test_net_ip2addr(void)
 	test_begin("net_ip2addr()");
 	test_assert(net_addr2ip("127.0.0.1", &ip) == 0 &&
 		    ip.family == AF_INET &&
-		    ip.u.ip4.s_addr == (127 | (1 << 24)));
+		    ntohl(ip.u.ip4.s_addr) == (0x7f000001));
 #ifdef HAVE_IPV6
 	test_assert(net_addr2ip("::5", &ip) == 0 &&
 		    ip.family == AF_INET6 &&

Reply via email to