Re: murmurhash3 test failures on big-endian systems

2018-03-29 Thread Apollon Oikonomopoulos
On 15:55 Wed 28 Mar , Josef 'Jeff' Sipek wrote: > Ok, there are two commits: > > 35497604d80090a02619024aeec069b32568e4b4 and > 5522b8b3d3ed1a99c3b63bb120216af0bd427403 > > Together, they should be identical to the patch I sent the other day plus > your fixup. Let me know if you have any

Re: murmurhash3 test failures on big-endian systems

2018-03-28 Thread Josef 'Jeff' Sipek
On Tue, Mar 27, 2018 at 08:46:20 -0400, Josef 'Jeff' Sipek wrote: > On Tue, Mar 27, 2018 at 13:15:31 +0300, Apollon Oikonomopoulos wrote: > > On 13:05 Tue 27 Mar , Apollon Oikonomopoulos wrote: > > > On 11:31 Tue 27 Mar , Apollon Oikonomopoulos wrote: > > > It turns out there's a missing

Re: murmurhash3 test failures on big-endian systems

2018-03-27 Thread Josef 'Jeff' Sipek
On Tue, Mar 27, 2018 at 13:15:31 +0300, Apollon Oikonomopoulos wrote: > On 13:05 Tue 27 Mar , Apollon Oikonomopoulos wrote: > > On 11:31 Tue 27 Mar , Apollon Oikonomopoulos wrote: > > It turns out there's a missing byte-inversion when loading the blocks > > which should be addressed in

Re: murmurhash3 test failures on big-endian systems

2018-03-27 Thread Apollon Oikonomopoulos
On 13:05 Tue 27 Mar , Apollon Oikonomopoulos wrote: > On 11:31 Tue 27 Mar , Apollon Oikonomopoulos wrote: > It turns out there's a missing byte-inversion when loading the blocks > which should be addressed in getblock{32,64}. Murmurhash treats each > block as an integer expecting

Re: murmurhash3 test failures on big-endian systems

2018-03-27 Thread Apollon Oikonomopoulos
On 11:31 Tue 27 Mar , Apollon Oikonomopoulos wrote: > Hi, > > On 12:55 Mon 26 Mar , Josef 'Jeff' Sipek wrote: > > On Mon, Mar 26, 2018 at 15:57:01 +0300, Apollon Oikonomopoulos wrote: > > ... > > > I'd be happy to test the patch, thanks! > > > > Ok, try the attached patch. (It is a

Re: murmurhash3 test failures on big-endian systems

2018-03-27 Thread Apollon Oikonomopoulos
Hi, On 12:55 Mon 26 Mar , Josef 'Jeff' Sipek wrote: > On Mon, Mar 26, 2018 at 15:57:01 +0300, Apollon Oikonomopoulos wrote: > ... > > I'd be happy to test the patch, thanks! > > Ok, try the attached patch. (It is a first pass at the issue, so it may not > be the final diff that'll end up

Re: murmurhash3 test failures on big-endian systems

2018-03-26 Thread Josef 'Jeff' Sipek
On Mon, Mar 26, 2018 at 15:57:01 +0300, Apollon Oikonomopoulos wrote: ... > I'd be happy to test the patch, thanks! Ok, try the attached patch. (It is a first pass at the issue, so it may not be the final diff that'll end up getting committed. It'd be good to know if it actually fixes the issue

Re: murmurhash3 test failures on big-endian systems

2018-03-26 Thread Apollon Oikonomopoulos
Hi Aki, On 15:55 Mon 26 Mar , Aki Tuomi wrote: > On 26.03.2018 15:49, Apollon Oikonomopoulos wrote: > > Hi, > > > > The dovecot 2.3.0.1 Debian package currently fails to build on all > > big-endian architectures[1], due to murmurhash3 tests failing. The > > relevant output from e.g. s390x

Re: murmurhash3 test failures on big-endian systems

2018-03-26 Thread Aki Tuomi
On 26.03.2018 15:49, Apollon Oikonomopoulos wrote: > Hi, > > The dovecot 2.3.0.1 Debian package currently fails to build on all > big-endian architectures[1], due to murmurhash3 tests failing. The > relevant output from e.g. s390x is: > > test-murmurhash3.c:22: Assert(#8) failed:

murmurhash3 test failures on big-endian systems

2018-03-26 Thread Apollon Oikonomopoulos
Hi, The dovecot 2.3.0.1 Debian package currently fails to build on all big-endian architectures[1], due to murmurhash3 tests failing. The relevant output from e.g. s390x is: test-murmurhash3.c:22: Assert(#8) failed: memcmp(result, vectors[i].result, sizeof(result)) == 0