NUM_TV_MODES is the same as ARRAY_SIZE(tv_modes). In the end, I
decided it was cleaner to remove NUM_TV_MODES and just use
ARRAY_SIZE(tv_modes) through out.
Signed-off-by: Dan Carpenter
diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/intel_tv.c
index 6d553c2..ee4de98 100644
We don't need to check the list cursor in a list_for_each_entry(). It's
always non-null.
Signed-off-by: Dan Carpenter
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index cc8131f..8a2bdfc 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/
copy_to_user() returns the number of bytes remaining to be copied and
I'm pretty sure we want to return a negative error code here.
Signed-off-by: Dan Carpenter
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 9ded3da..22691b4 100644
--- a/drivers/gpu/drm/i915
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/radeon/evergreen_cs.c |4 ++--
drivers/gpu/drm/radeon/reg_srcs/evergreen | 10 +-
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/radeon/evergreen_cs.c
b/drivers/gpu/drm/radeon/evergreen_cs.c
index 6
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/radeon/evergreen_cs.c |4 ++--
drivers/gpu/drm/radeon/reg_srcs/evergreen | 10 +-
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/radeon/evergreen_cs.c
b/drivers/gpu/drm/radeon/evergreen_cs.c
index 6
intel_cleanup_ring_buffer() calls drm_gem_object_unreference() (as
opposed to drm_gem_object_unreference_unlocked()) so it needs to be
called with "struct_mutex" held. If we don't hold the lock, it triggers
a BUG_ON(!mutex_is_locked(&dev->struct_mutex));
I also audited the other places that call
https://bugs.freedesktop.org/show_bug.cgi?id=28671
--- Comment #12 from Brett Witherspoon
2010-06-23 13:19:06 PDT ---
Ok I will pull from the git tree and give those a try.
Changing the AGP mode did not improve any of the symptoms. Also disabling one
or all of the EXA options did not seem to he
https://bugs.freedesktop.org/show_bug.cgi?id=28671
--- Comment #12 from Brett Witherspoon
2010-06-23 13:19:06 PDT ---
Ok I will pull from the git tree and give those a try.
Changing the AGP mode did not improve any of the symptoms. Also disabling one
or all of the EXA options did not seem to he
On Wed, 23 Jun 2010 13:19:55 +0200
Dan Carpenter wrote:
> intel_cleanup_ring_buffer() calls drm_gem_object_unreference() (as
> opposed to drm_gem_object_unreference_unlocked()) so it needs to be
> called with "struct_mutex" held. If we don't hold the lock, it triggers
> a BUG_ON(!mutex_is_locked
--=20
controlled by gamma light
intel_cleanup_ring_buffer() calls drm_gem_object_unreference() (as
opposed to drm_gem_object_unreference_unlocked()) so it needs to be
called with "struct_mutex" held. If we don't hold the lock, it triggers
a BUG_ON(!mutex_is_locked(&dev->struct_mutex));
I also audited the other places that call
11 matches
Mail list logo
