[Bug 32402] Oops associated with radeon_unpin_work_func

2011-04-04 Thread bugzilla-dae...@bugzilla.kernel.org
https://bugzilla.kernel.org/show_bug.cgi?id=32402 Mike Mestnik changed: What|Removed |Added CC||cheako911 at gmail.com --- Comment #3

[Bug 35194] [r600g] Evergreen - failed to map bo

2011-04-04 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=35194 --- Comment #4 from Rub?n Fern?ndez 2011-04-04 22:50:00 PDT --- Created an attachment (id=45262) View: https://bugs.freedesktop.org/attachment.cgi?id=45262 Review: https://bugs.freedesktop.org/review?bug=35194=45262 Patch for wine that

[Bug 35194] [r600g] Evergreen - failed to map bo

2011-04-04 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=35194 --- Comment #3 from Rub?n Fern?ndez 2011-04-04 22:48:23 PDT --- The problem seems to be related to the way wine manages memory; wine reserves the top 2GB of the addressing space to itself on startup, leaving only 2GB for everything else

[Bug 32829] [RADEON:KMS:R300G] vertex shaders render incorrectly in some wine programs

2011-04-04 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=32829 Rub?n Fern?ndez changed: What|Removed |Added Resolution|FIXED |WONTFIX -- Configure bugmail:

[Bug 33792] [r600g] Evergreen vertex shaders transform vertices incorrectly in wine programs

2011-04-04 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=33792 Rub?n Fern?ndez changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Bug 32829] [RADEON:KMS:R300G] vertex shaders render incorrectly in some wine programs

2011-04-04 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=32829 Rub?n Fern?ndez changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[RFC] drm platform multi-device support

2011-04-04 Thread Rob Clark
On Mon, Apr 4, 2011 at 7:30 PM, Dave Airlie wrote: > On Wed, Mar 30, 2011 at 2:44 AM, Rob Clark wrote: >> From: Rob Clark >> >> Include the minor device id in the bus-id to give userspace a way to open >> the correct "cardN" when there are multiple device instances. >> --- >> It may seem a bit

[PATCH] fix warning: unused variable ‘dev_priv’ drivers/gpu/drm/nouveau/nv50_vm.c

2011-04-04 Thread helight.xu
fix warning: unused variable ?dev_priv? drivers/gpu/drm/nouveau/nv50_vm.c Signed-off-by: helight --- drivers/gpu/drm/nouveau/nv50_vm.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nv50_vm.c b/drivers/gpu/drm/nouveau/nv50_vm.c index

[git pull] drm fixes

2011-04-04 Thread Keith Packard
hives/dri-devel/attachments/20110404/8f9c7bc7/attachment.pgp>

[git pull] drm fixes

2011-04-04 Thread Linus Torvalds
On Mon, Apr 4, 2011 at 6:02 PM, Keith Packard wrote: > On Tue, 5 Apr 2011 01:38:31 +0100 (IST), Dave Airlie > wrote: > >> ? ? ? drm/i915: Reset GMBUS controller after NAK > > We've got a report of a regression from this patch and have a fix in > review right now. Please don't merge this to

[git pull] drm fixes

2011-04-04 Thread Keith Packard
nce. -- keith.packard at intel.com -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20110404/5a3a0fc0/attachment.pgp>

[Bug 35942] Crash in World of Warcraft

2011-04-04 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=35942 --- Comment #5 from Chris Rankin 2011-04-04 16:36:33 PDT --- I have finally captured the actual error when WoW crashes: wine: Unhandled page fault on write access to 0x0809 at address 0x7d9610bb (thread 000b), starting debugger...

[Bug 34709] [bisected] with r300 (rv530) kms loaded cannot suspend kernel 2.6.37+ with uswsusp

2011-04-04 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=34709 Michal Suchanek changed: What|Removed |Added Blocks||35969 -- Configure bugmail:

[Bug 35969] New: with linux 2.6.38 and later resume from suspend (uswsusp) lockups on rv530 kms

2011-04-04 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=35969 Summary: with linux 2.6.38 and later resume from suspend (uswsusp) lockups on rv530 kms Product: DRI Version: unspecified Platform: x86-64 (AMD64) OS/Version: Linux (All)

[Bug 34709] [bisected] with r300 (rv530) kms loaded cannot suspend kernel 2.6.37+ with uswsusp

2011-04-04 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=34709 --- Comment #14 from Michal Suchanek 2011-04-04 15:11:57 PDT --- ok, with the patch 2.6.37 works, 2.6.38 and head suspends but lockups on resume. I guess time for another bisect. -- Configure bugmail:

i915 freeze on boot

2011-04-04 Thread Yermandu Patapitafious
URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20110404/db326aef/attachment-0001.bin>

[Bug 35942] Crash in World of Warcraft

2011-04-04 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=35942 --- Comment #4 from Chris Rankin 2011-04-04 14:00:28 PDT --- (In reply to comment #1) > If you just revert 437c748bf5072d2bded77a00c74c51cdb8b510e5, does it fix the > bug? No, the first bad commit seems to be

[Bug 34709] [bisected] with r300 (rv530) kms loaded cannot suspend kernel 2.6.37+ with uswsusp

2011-04-04 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=34709 --- Comment #13 from Alex Deucher 2011-04-04 12:55:21 PDT --- (In reply to comment #12) > With the patch 2.6.37 suspends and resumes, 2.6.38 suspends (which was not > possible without it ) and locks up on resume. Can you bisect (and apply the

[Bug 35942] Crash in World of Warcraft

2011-04-04 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=35942 --- Comment #3 from Chris Rankin 2011-04-04 11:40:29 PDT --- I've just experienced the exact same crash with this commit as HEAD: commit c35572352e3e92683988ee8d151b47f4190d62f9 Author: Marek Ol??k Date: Sun Apr 3 17:32:47 2011 +0200

[Bug 34709] [bisected] with r300 (rv530) kms loaded cannot suspend kernel 2.6.37+ with uswsusp

2011-04-04 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=34709 --- Comment #12 from Michal Suchanek 2011-04-04 11:14:12 PDT --- With the patch 2.6.37 suspends and resumes, 2.6.38 suspends (which was not possible without it ) and locks up on resume. On rv515gl 2.6.38 suspends and resumes fine without

[Bug 35942] Crash in World of Warcraft

2011-04-04 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=35942 --- Comment #2 from Chris Rankin 2011-04-04 11:12:29 PDT --- Created an attachment (id=45236) --> (https://bugs.freedesktop.org/attachment.cgi?id=45236) Wine stacktrace from WoW crash -- Configure bugmail:

[PATCH] drm/radeon/kms: add some new ontario pci ids

2011-04-04 Thread Alex Deucher
Signed-off-by: Alex Deucher Cc:stable at kernel.org --- include/drm/drm_pciids.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/drm/drm_pciids.h b/include/drm/drm_pciids.h index 820ee90..816e30c 100644 --- a/include/drm/drm_pciids.h +++

Future desktop on dumb frame buffers?

2011-04-04 Thread Alan Cox
> It's nothing fantastic, but I've had a number of people tell me that > it was useful for them. It does document some stuff nicely - not alas the bits I need to figure out at the moment but its definitely a nice reference to the basic setup. (ponders Voodoo2 DRI)

gears doesnt play with softpipe driver.

2011-04-04 Thread Michel Dänzer
[ I think dri-devel should be dropped ] On Son, 2011-04-03 at 01:27 -0700, kumar vemuri wrote: > > Am trying to get the progs/demos work with the gallium softpipe > driver and the DRI swrast driver. > > When i try gears demo with the libGL.so in the mesa/lib and > swrast_dri.so in mesa/lib

[Bug 35942] Crash in World of Warcraft

2011-04-04 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=35942 --- Comment #1 from Marek Ol??k 2011-04-04 08:04:33 PDT --- If you just revert 437c748bf5072d2bded77a00c74c51cdb8b510e5, does it fix the bug? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving

[Bug 35935] since 2.6.38.1, screen become garbled after some times (RV770)

2011-04-04 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=35935 --- Comment #4 from Mjules 2011-04-04 03:23:59 PDT --- thanks for your quick answer. With the same userspace and configuration, 2.6.38 works fine. I will try to bisect. thx -- Configure bugmail:

[patch] drm: fix "persistant" typo

2011-04-04 Thread Jan Engelhardt
parent 9e7e37e88264e35f3ba6d0dc1da8dd95e70f2b3f (v2.6.39-rc1-185-g9e7e37e) commit b0ef5d4e28cd127eef94b300f27ba0104deb5ad6 Author: Jan Engelhardt Date: Mon Apr 4 01:24:58 2011 +0200 drm: fix "persistant" typo Signed-off-by: Jan Engelhardt --- drivers/gpu/drm/nouveau/nouveau_gem.c |2 +-

[Bug 35942] New: Crash in World of Warcraft

2011-04-04 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=35942 Summary: Crash in World of Warcraft Product: Mesa Version: git Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: major Priority: medium

[Intel-gfx] [PATCH] drm, drm/i915/lvds: Honour video= parameter to override LVDS fixed mode

2011-04-04 Thread Steven Newbury
> > > > > > On Tue, Mar 29, 2011 at 5:49 PM, Dave Airlie > > > > > > wrote: > > > > > > > can you guys ask someone internally about it also, there is a > > > > > > > driver somewhere in Google also for driving the LVDS->HDMI > > > > > > > adapter but I'm not sure what i2c bus its hanging off. > >

mesa: remove-driver-date GIT branch

2011-04-04 Thread Sedat Dilek
WOW! Just remembered my approach (witch patches and rants) to remove core-date and driver-date from kernel (drm-2.6) and libdrm as the version are simply unmaintained. Looks like I am not alone :-). - Sedat - [1] http://cgit.freedesktop.org/mesa/mesa/log/?h=remove-driver-date

2.6.39-rc1 noveau trouble and regression (bad commit: 38f1cff0863809587b5fd10ecd0c24c8b543a48c )

2011-04-04 Thread Dominik Brodowski
Hey, After bisecting for a day, I'm pretty confident that the commit 38f1cff0863809587b5fd10ecd0c24c8b543a48c introduced an error which causes one of my computers to hang during boot -- only a blank screen appears. The initramfs never gets run. The system consists of an Atom D525 with Intel NM10

[Bug 35942] New: Crash in World of Warcraft

2011-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35942 Summary: Crash in World of Warcraft Product: Mesa Version: git Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: major Priority: medium

Re: gears doesnt play with softpipe driver.

2011-04-04 Thread Michel Dänzer
[ I think dri-devel should be dropped ] On Son, 2011-04-03 at 01:27 -0700, kumar vemuri wrote: Am trying to get the progs/demos work with the gallium softpipe driver and the DRI swrast driver. When i try gears demo with the libGL.so in the mesa/lib and swrast_dri.so in mesa/lib or

Re: Future desktop on dumb frame buffers?

2011-04-04 Thread Alan Cox
It's nothing fantastic, but I've had a number of people tell me that it was useful for them. It does document some stuff nicely - not alas the bits I need to figure out at the moment but its definitely a nice reference to the basic setup. (ponders Voodoo2 DRI)

[Bug 35935] since 2.6.38.1, screen become garbled after some times (RV770)

2011-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35935 --- Comment #4 from Mjules mjulie...@gmail.com 2011-04-04 03:23:59 PDT --- thanks for your quick answer. With the same userspace and configuration, 2.6.38 works fine. I will try to bisect. thx -- Configure bugmail:

[PATCH] fix warning: unused variable ‘dev_priv’ drivers/gpu/drm/nouveau/nv50_vm.c

2011-04-04 Thread helight.xu
fix warning: unused variable ‘dev_priv’ drivers/gpu/drm/nouveau/nv50_vm.c Signed-off-by: helight heli...@zhwen.org --- drivers/gpu/drm/nouveau/nv50_vm.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nv50_vm.c b/drivers/gpu/drm/nouveau/nv50_vm.c

[PATCH] drm/radeon/kms: add some new ontario pci ids

2011-04-04 Thread Alex Deucher
Signed-off-by: Alex Deucher alexdeuc...@gmail.com Cc:sta...@kernel.org --- include/drm/drm_pciids.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/drm/drm_pciids.h b/include/drm/drm_pciids.h index 820ee90..816e30c 100644 --- a/include/drm/drm_pciids.h +++

[Bug 35942] Crash in World of Warcraft

2011-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35942 --- Comment #1 from Marek Olšák mar...@gmail.com 2011-04-04 08:04:33 PDT --- If you just revert 437c748bf5072d2bded77a00c74c51cdb8b510e5, does it fix the bug? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ---

[Bug 35942] Crash in World of Warcraft

2011-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35942 --- Comment #2 from Chris Rankin ranki...@googlemail.com 2011-04-04 11:12:29 PDT --- Created an attachment (id=45236) -- (https://bugs.freedesktop.org/attachment.cgi?id=45236) Wine stacktrace from WoW crash -- Configure bugmail:

[Bug 34709] [bisected] with r300 (rv530) kms loaded cannot suspend kernel 2.6.37+ with uswsusp

2011-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=34709 --- Comment #12 from Michal Suchanek hramr...@gmail.com 2011-04-04 11:14:12 PDT --- With the patch 2.6.37 suspends and resumes, 2.6.38 suspends (which was not possible without it ) and locks up on resume. On rv515gl 2.6.38 suspends and resumes

[Bug 34709] [bisected] with r300 (rv530) kms loaded cannot suspend kernel 2.6.37+ with uswsusp

2011-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=34709 --- Comment #13 from Alex Deucher ag...@yahoo.com 2011-04-04 12:55:21 PDT --- (In reply to comment #12) With the patch 2.6.37 suspends and resumes, 2.6.38 suspends (which was not possible without it ) and locks up on resume. Can you bisect

[Bug 35942] Crash in World of Warcraft

2011-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35942 --- Comment #4 from Chris Rankin ranki...@googlemail.com 2011-04-04 14:00:28 PDT --- (In reply to comment #1) If you just revert 437c748bf5072d2bded77a00c74c51cdb8b510e5, does it fix the bug? No, the first bad commit seems to be

[Bug 34709] [bisected] with r300 (rv530) kms loaded cannot suspend kernel 2.6.37+ with uswsusp

2011-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=34709 --- Comment #14 from Michal Suchanek hramr...@gmail.com 2011-04-04 15:11:57 PDT --- ok, with the patch 2.6.37 works, 2.6.38 and head suspends but lockups on resume. I guess time for another bisect. -- Configure bugmail:

[Bug 35969] New: with linux 2.6.38 and later resume from suspend (uswsusp) lockups on rv530 kms

2011-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35969 Summary: with linux 2.6.38 and later resume from suspend (uswsusp) lockups on rv530 kms Product: DRI Version: unspecified Platform: x86-64 (AMD64) OS/Version: Linux (All)

[Bug 34709] [bisected] with r300 (rv530) kms loaded cannot suspend kernel 2.6.37+ with uswsusp

2011-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=34709 Michal Suchanek hramr...@gmail.com changed: What|Removed |Added Blocks||35969 -- Configure

[Bug 32402] Oops associated with radeon_unpin_work_func

2011-04-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=32402 Mike Mestnik cheako...@gmail.com changed: What|Removed |Added CC||cheako...@gmail.com

[Bug 32402] Oops associated with radeon_unpin_work_func

2011-04-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=32402 --- Comment #4 from Mike Mestnik cheako...@gmail.com 2011-04-04 23:11:44 --- Created an attachment (id=53492) -- (https://bugzilla.kernel.org/attachment.cgi?id=53492) KMS-BSOD ttm_bo_ref - do_invalid_op -- Configure bugmail:

[Bug 32402] Oops associated with radeon_unpin_work_func

2011-04-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=32402 --- Comment #5 from Mike Mestnik cheako...@gmail.com 2011-04-04 23:14:18 --- Created an attachment (id=53502) -- (https://bugzilla.kernel.org/attachment.cgi?id=53502) SystemInformation.txt -- Configure bugmail:

[Bug 32402] Oops associated with radeon_unpin_work_func

2011-04-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=32402 --- Comment #6 from Mike Mestnik cheako...@gmail.com 2011-04-04 23:17:14 --- Created an attachment (id=53512) -- (https://bugzilla.kernel.org/attachment.cgi?id=53512) SoftwareInformation.txt -- Configure bugmail:

[Bug 35942] Crash in World of Warcraft

2011-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35942 --- Comment #5 from Chris Rankin ranki...@googlemail.com 2011-04-04 16:36:33 PDT --- I have finally captured the actual error when WoW crashes: wine: Unhandled page fault on write access to 0x0809 at address 0x7d9610bb (thread 000b),

[git pull] drm fixes

2011-04-04 Thread Dave Airlie
Hi Linus, Nothing too major, the radeon sanity checks and i915 fixes probably the most important. Dave. The following changes since commit 0ce790e7d736cedc563e1fb4e998babf5a4dbc3d: Linux 2.6.39-rc1 (2011-03-29 12:09:47 -0700) are available in the git repository at:

Re: [git pull] drm fixes

2011-04-04 Thread Keith Packard
On Tue, 5 Apr 2011 01:38:31 +0100 (IST), Dave Airlie airl...@linux.ie wrote: drm/i915: Reset GMBUS controller after NAK We've got a report of a regression from this patch and have a fix in review right now. Please don't merge this to master until that fix has been verified and added to

Re: [git pull] drm fixes

2011-04-04 Thread Dave Airlie
Hi Linus, Nothing too major, the radeon sanity checks and i915 fixes probably the most important. Oh in a shock to me the i915 fixes break VGA detect which is doing something really stdupid. so please hold off on this until Chris/Keith can get the correct patch, and I'll send a new

Re: [git pull] drm fixes

2011-04-04 Thread Linus Torvalds
On Mon, Apr 4, 2011 at 6:02 PM, Keith Packard kei...@keithp.com wrote: On Tue, 5 Apr 2011 01:38:31 +0100 (IST), Dave Airlie airl...@linux.ie wrote:       drm/i915: Reset GMBUS controller after NAK We've got a report of a regression from this patch and have a fix in review right now. Please

Re: [git pull] drm fixes

2011-04-04 Thread Keith Packard
On Mon, 4 Apr 2011 18:09:55 -0700, Linus Torvalds torva...@linux-foundation.org wrote: I'm not doing an -rc2 until tomorrow, though, so hopefully the issue will be resolved and a fix pushed to me by then. Should be resolved this evening; someone is trying to use an i2c address of 0xa0, which

Re: [RFC] drm platform multi-device support

2011-04-04 Thread Rob Clark
On Mon, Apr 4, 2011 at 7:30 PM, Dave Airlie airl...@gmail.com wrote: On Wed, Mar 30, 2011 at 2:44 AM, Rob Clark r...@ti.com wrote: From: Rob Clark robdcl...@gmail.com Include the minor device id in the bus-id to give userspace a way to open the correct cardN when there are multiple device

[Bug 32829] [RADEON:KMS:R300G] vertex shaders render incorrectly in some wine programs

2011-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=32829 Rubén Fernández rubenf3...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 33792] [r600g] Evergreen vertex shaders transform vertices incorrectly in wine programs

2011-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=33792 Rubén Fernández rubenf3...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 32829] [RADEON:KMS:R300G] vertex shaders render incorrectly in some wine programs

2011-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=32829 Rubén Fernández rubenf3...@gmail.com changed: What|Removed |Added Resolution|FIXED |WONTFIX --

[Bug 35194] [r600g] Evergreen - failed to map bo

2011-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35194 --- Comment #3 from Rubén Fernández rubenf3...@gmail.com 2011-04-04 22:48:23 PDT --- The problem seems to be related to the way wine manages memory; wine reserves the top 2GB of the addressing space to itself on startup, leaving only 2GB for

[Bug 35194] [r600g] Evergreen - failed to map bo

2011-04-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35194 --- Comment #4 from Rubén Fernández rubenf3...@gmail.com 2011-04-04 22:50:00 PDT --- Created an attachment (id=45262) View: https://bugs.freedesktop.org/attachment.cgi?id=45262 Review: