Re: [PATCH 04/10] drm/exynos: Use devm_clk_get in exynos_drm_fimc.c

2012-12-27 Thread Sachin Kamat
On Wednesday, 26 December 2012, Inki Dae wrote: > > > 2012/12/24 Sachin Kamat >> >> This eliminates the need for explicit clk_put and makes the >> cleanup and exit path code simpler. >> >> Cc: Eunchul Kim >> Signed-off-by: Sachin Kamat >> --- >> drivers/gpu/drm/exynos/exynos_drm_fimc.c | 46

[PATCH 04/10] drm/exynos: Use devm_clk_get in exynos_drm_fimc.c

2012-12-27 Thread Sachin Kamat
On Wednesday, 26 December 2012, Inki Dae wrote: > > > 2012/12/24 Sachin Kamat >> >> This eliminates the need for explicit clk_put and makes the >> cleanup and exit path code simpler. >> >> Cc: Eunchul Kim >> Signed-off-by: Sachin Kamat >> --- >> drivers/gpu/drm/exynos/exynos_drm_fimc.c | 46

Re: [PATCH 04/10] drm/exynos: Use devm_clk_get in exynos_drm_fimc.c

2012-12-27 Thread Inki Dae
2012/12/26 Sachin Kamat > > > On Wednesday, 26 December 2012, Inki Dae wrote: > > > > > > 2012/12/24 Sachin Kamat > >> > >> This eliminates the need for explicit clk_put and makes the > >> cleanup and exit path code simpler. > >> > >> Cc: Eunchul Kim > >> Signed-off-by: Sachin Kamat > >> ---

[Bug 57875] Second Life viewer bad rendering with git-ec83535

2012-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=57875 --- Comment #18 from Piero Finizio --- If i try to revert the commit e866bd1adea2c3b4971ad68e69c644752f2ab7b6 (above mentioned workaround) with git "HEAD at 7c35521 mesa: add missing texel fetch code for sRGB DXT formats" the compilation ends wi

[PATCH] drm/exynos: fix gem buffer allocation type checking

2012-12-27 Thread Inki Dae
This patch fixes gem buffer allocation type checking. EXYNOS_BO_CONTIG has 0 so the checking should be fixed to 'if (!(flags & EXYNOS_BO_NONCONTIG))' Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_buf.c |2 +- 1 files changed, 1 insertions(+), 1 d

[PATCH] drm/exynos: fimd: modify condition in fimd resume

2012-12-27 Thread Prathyush K
If fimd is runtime suspended (by DPMS OFF), fimd_suspend does not call fimd_activate(false) and just returns. Similarily the check in fimd_resume should not resume if previously runtime_suspended. Instead the existing check does the opposite. So if fimd was not runtime suspended, suspend will turn

Re: [PATCH] drm/exynos: fix gem buffer allocation type checking

2012-12-27 Thread Prathyush K
On Thu, Dec 27, 2012 at 4:27 PM, Inki Dae wrote: > This patch fixes gem buffer allocation type checking. > EXYNOS_BO_CONTIG has 0 so the checking should be fixed > to 'if (!(flags & EXYNOS_BO_NONCONTIG))' > > Signed-off-by: Inki Dae > Signed-off-by: Kyungmin Park > --- > drivers/gpu/drm/exynos

Re: [PATCH] drm/exynos: fix gem buffer allocation type checking

2012-12-27 Thread Inki Dae
2012/12/27 Prathyush K > > > > On Thu, Dec 27, 2012 at 4:27 PM, Inki Dae wrote: > >> This patch fixes gem buffer allocation type checking. >> EXYNOS_BO_CONTIG has 0 so the checking should be fixed >> to 'if (!(flags & EXYNOS_BO_NONCONTIG))' >> >> Signed-off-by: Inki Dae >> Signed-off-by: Kyungm

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Tomasz Figa
Hi Laurent, On Monday 24 of December 2012 15:12:28 Laurent Pinchart wrote: > Hi Tomasz, > > On Friday 21 December 2012 11:00:52 Tomasz Figa wrote: > > On Tuesday 18 of December 2012 08:31:30 Vikas Sajjan wrote: > > > On 17 December 2012 20:55, Laurent Pinchart wrote: > > > > Hi Vikas, > > > > >

Re: Display resolutions missing on external VGA display [regressing]

2012-12-27 Thread Jani Nikula
On Mon, 24 Dec 2012, John wrote: > On launchpad they requested to report this bug upstream. Please let me know > if any information is missing. Please file a bug on DRM/Intel at [1]. Please reference your mail and the launchpad bug, no need to attach all the info there again. What's the latest k

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Rob Clark
On Mon, Dec 24, 2012 at 7:37 AM, Laurent Pinchart wrote: > Hi Rob, > > On Tuesday 18 December 2012 00:21:32 Rob Clark wrote: >> On Mon, Dec 17, 2012 at 11:04 PM, Dave Airlie wrote: >> >> Many developers showed interest in the first RFC, and I've had the >> >> opportunity to discuss it with most o

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Rob Clark
On Mon, Dec 24, 2012 at 11:09 AM, Laurent Pinchart wrote: > On the topic of discussions, would anyone be interested in a > BoF/brainstorming/whatever session during the FOSDEM ? I will be at FOSDEM.. and from http://wiki.x.org/wiki/fosdem2013 it looks like at least Daniel will be there. If enoug

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Rob Clark
On Mon, Dec 24, 2012 at 11:27 AM, Laurent Pinchart wrote: > On Wednesday 19 December 2012 16:57:56 Jani Nikula wrote: >> It just seems to me that, at least from a DRM/KMS perspective, adding >> another layer (=CDF) for HDMI or DP (or legacy outputs) would be >> overengineering it. They are pretty

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Rob Clark
On Mon, Dec 24, 2012 at 11:35 AM, Laurent Pinchart wrote: > On Wednesday 19 December 2012 09:26:40 Rob Clark wrote: >> And, there are also external HDMI encoders (for example connected over >> i2c) that can also be shared between boards. So I think there will be >> a number of cases where CDF is

[Bug 43167] X intel driver causes wrong wraparound of console command line

2012-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43167 Jani Nikula changed: What|Removed |Added CC||jani.nik...@intel.com --- Comment #41 from

[Bug 43167] X intel driver causes wrong wraparound of console command line

2012-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43167 Jani Nikula changed: What|Removed |Added Status|REOPENED|NEEDINFO --- Comment #42 from Jani Nikula

[Bug 49981] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -12!

2012-12-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=49981 --- Comment #4 from Apostolos B. 2012-12-27 18:16:42 --- I chasnged my DE from gnome 3 to E17 and i don't get that error anymore? Could it be related? -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email --- You are

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Sascha Hauer
On Thu, Dec 27, 2012 at 09:54:55AM -0600, Rob Clark wrote: > On Mon, Dec 24, 2012 at 7:37 AM, Laurent Pinchart > wrote: > > Hi Rob, > > > > On Tuesday 18 December 2012 00:21:32 Rob Clark wrote: > >> On Mon, Dec 17, 2012 at 11:04 PM, Dave Airlie wrote: > >> >> Many developers showed interest in th

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Sascha Hauer
On Thu, Dec 27, 2012 at 10:04:22AM -0600, Rob Clark wrote: > On Mon, Dec 24, 2012 at 11:27 AM, Laurent Pinchart > wrote: > > On Wednesday 19 December 2012 16:57:56 Jani Nikula wrote: > >> It just seems to me that, at least from a DRM/KMS perspective, adding > >> another layer (=CDF) for HDMI or DP

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Rob Clark
On Thu, Dec 27, 2012 at 1:18 PM, Sascha Hauer wrote: > On Thu, Dec 27, 2012 at 09:54:55AM -0600, Rob Clark wrote: >> On Mon, Dec 24, 2012 at 7:37 AM, Laurent Pinchart >> wrote: >> > Hi Rob, >> > >> > On Tuesday 18 December 2012 00:21:32 Rob Clark wrote: >> >> On Mon, Dec 17, 2012 at 11:04 PM, Dav

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Sascha Hauer
On Thu, Dec 27, 2012 at 01:57:56PM -0600, Rob Clark wrote: > On Thu, Dec 27, 2012 at 1:18 PM, Sascha Hauer wrote: > > On Thu, Dec 27, 2012 at 09:54:55AM -0600, Rob Clark wrote: > >> On Mon, Dec 24, 2012 at 7:37 AM, Laurent Pinchart > > > > This implies that the master driver knows all potential su

[Bug 41265] Radeon KMS does not work on thunderbolt media dock

2012-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41265 --- Comment #53 from Gerald Nunn --- Does AMD need to make a change to the proprietary fglrx drivers in order for the kernel patch to work with their drivers and if so has a bug been opened with them? I'm using Ubuntu 12.10 with kernel 3.6.9 and

[PATCH] drm/exynos: Add device tree based discovery support for Exynos G2D

2012-12-27 Thread Ajay Kumar
This patch adds device tree match table for Exynos G2D controller. Signed-off-by: Ajay Kumar --- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c index 6ffa07

Re: [PATCH] video: drm: exynos: mie bypass enable for fimd

2012-12-27 Thread Leela Krishna Amudala
Hello Inki Dae, On Thu, Dec 27, 2012 at 11:47 AM, Inki Dae wrote: > > Hi, > > DISP1BLK_CFG register is related to GScaler, HDCP and MIXER as well. So > it's not good that this register is controlled in fimd module. And I think > the function to control the register should be placed in SoC common

Re: [PATCH] video: drm: exynos: mie bypass enable for fimd

2012-12-27 Thread Inki Dae
2012/12/28 Leela Krishna Amudala : > Hello Inki Dae, > > On Thu, Dec 27, 2012 at 11:47 AM, Inki Dae wrote: >> >> Hi, >> >> DISP1BLK_CFG register is related to GScaler, HDCP and MIXER as well. So >> it's not good that this register is controlled in fimd module. And I think >> the function to contro

Re: [RFC,libdrm 1/3] tegra: Add stream library

2012-12-27 Thread Mark Zhang
I just skimmed the code of libdrm while I'm trying to understand the host1x driver. So below is what I found. Mark On 12/13/2012 10:01 PM, Arto Meriläinen wrote: > From: Arto Merilainen > > This patch introduces tegra stream library. The library is used for > buffer management, command stream co

Re: [RFC,libdrm 2/3] tegra: Add 2d library

2012-12-27 Thread Mark Zhang
I just skimmed the code of libdrm while I'm trying to understand the host1x driver. So below is what I found. Mark On 12/13/2012 10:01 PM, Arto Meriläinen wrote: > From: Francis Hart > > This patch introduces a simple 2d library on top of stream library. > > Signed-off-by: Francis Hart [...] >

Re: [RFC,libdrm 1/3] tegra: Add stream library

2012-12-27 Thread Arto Merilainen
On 12/28/2012 08:47 AM, Mark Zhang wrote: +int tegra_fence_is_valid(const struct tegra_fence *fence) +{ +int valid = fence ? 1 : 0; +valid = valid && fence->id != (uint32_t) -1; +valid = valid && fence->id < 32; Hardcode here. Assume always has 32 syncpts. Change to a micro wrapped

Re: [RFC,libdrm 1/3] tegra: Add stream library

2012-12-27 Thread Mark Zhang
On 12/28/2012 03:45 PM, Arto Merilainen wrote: > On 12/28/2012 08:47 AM, Mark Zhang wrote: >>> +int tegra_fence_is_valid(const struct tegra_fence *fence) >>> +{ >>> +int valid = fence ? 1 : 0; >>> +valid = valid && fence->id != (uint32_t) -1; >>> +valid = valid && fence->id < 32; >> >>

Re: [PATCH 04/10] drm/exynos: Use devm_clk_get in exynos_drm_fimc.c

2012-12-27 Thread Sachin Kamat
On Wednesday, 26 December 2012, Inki Dae wrote: > > > 2012/12/24 Sachin Kamat >> >> This eliminates the need for explicit clk_put and makes the >> cleanup and exit path code simpler. >> >> Cc: Eunchul Kim >> Signed-off-by: Sachin Kamat >> --- >> drivers/gpu/drm/exynos/exynos_drm_fimc.c | 46

[PATCH 04/10] drm/exynos: Use devm_clk_get in exynos_drm_fimc.c

2012-12-27 Thread Sachin Kamat
On Wednesday, 26 December 2012, Inki Dae wrote: > > > 2012/12/24 Sachin Kamat >> >> This eliminates the need for explicit clk_put and makes the >> cleanup and exit path code simpler. >> >> Cc: Eunchul Kim >> Signed-off-by: Sachin Kamat >> --- >> drivers/gpu/drm/exynos/exynos_drm_fimc.c | 46

Re: [PATCH 04/10] drm/exynos: Use devm_clk_get in exynos_drm_fimc.c

2012-12-27 Thread Inki Dae
2012/12/26 Sachin Kamat > > > On Wednesday, 26 December 2012, Inki Dae wrote: > > > > > > 2012/12/24 Sachin Kamat > >> > >> This eliminates the need for explicit clk_put and makes the > >> cleanup and exit path code simpler. > >> > >> Cc: Eunchul Kim > >> Signed-off-by: Sachin Kamat > >> ---

[Bug 57875] Second Life viewer bad rendering with git-ec83535

2012-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=57875 --- Comment #18 from Piero Finizio --- If i try to revert the commit e866bd1adea2c3b4971ad68e69c644752f2ab7b6 (above mentioned workaround) with git "HEAD at 7c35521 mesa: add missing texel fetch code for sRGB DXT formats" the compilation ends wi

[PATCH] drm/exynos: fix gem buffer allocation type checking

2012-12-27 Thread Inki Dae
This patch fixes gem buffer allocation type checking. EXYNOS_BO_CONTIG has 0 so the checking should be fixed to 'if (!(flags & EXYNOS_BO_NONCONTIG))' Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_buf.c |2 +- 1 files changed, 1 insertions(+), 1 d

[PATCH] drm/exynos: fimd: modify condition in fimd resume

2012-12-27 Thread Prathyush K
If fimd is runtime suspended (by DPMS OFF), fimd_suspend does not call fimd_activate(false) and just returns. Similarily the check in fimd_resume should not resume if previously runtime_suspended. Instead the existing check does the opposite. So if fimd was not runtime suspended, suspend will turn

Re: [PATCH] drm/exynos: fix gem buffer allocation type checking

2012-12-27 Thread Prathyush K
On Thu, Dec 27, 2012 at 4:27 PM, Inki Dae wrote: > This patch fixes gem buffer allocation type checking. > EXYNOS_BO_CONTIG has 0 so the checking should be fixed > to 'if (!(flags & EXYNOS_BO_NONCONTIG))' > > Signed-off-by: Inki Dae > Signed-off-by: Kyungmin Park > --- > drivers/gpu/drm/exynos

Re: [PATCH] drm/exynos: fix gem buffer allocation type checking

2012-12-27 Thread Inki Dae
2012/12/27 Prathyush K > > > > On Thu, Dec 27, 2012 at 4:27 PM, Inki Dae wrote: > >> This patch fixes gem buffer allocation type checking. >> EXYNOS_BO_CONTIG has 0 so the checking should be fixed >> to 'if (!(flags & EXYNOS_BO_NONCONTIG))' >> >> Signed-off-by: Inki Dae >> Signed-off-by: Kyungm

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Tomasz Figa
Hi Laurent, On Monday 24 of December 2012 15:12:28 Laurent Pinchart wrote: > Hi Tomasz, > > On Friday 21 December 2012 11:00:52 Tomasz Figa wrote: > > On Tuesday 18 of December 2012 08:31:30 Vikas Sajjan wrote: > > > On 17 December 2012 20:55, Laurent Pinchart wrote: > > > > Hi Vikas, > > > > >

Re: Display resolutions missing on external VGA display [regressing]

2012-12-27 Thread Jani Nikula
On Mon, 24 Dec 2012, John wrote: > On launchpad they requested to report this bug upstream. Please let me know > if any information is missing. Please file a bug on DRM/Intel at [1]. Please reference your mail and the launchpad bug, no need to attach all the info there again. What's the latest k

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Rob Clark
On Mon, Dec 24, 2012 at 7:37 AM, Laurent Pinchart wrote: > Hi Rob, > > On Tuesday 18 December 2012 00:21:32 Rob Clark wrote: >> On Mon, Dec 17, 2012 at 11:04 PM, Dave Airlie wrote: >> >> Many developers showed interest in the first RFC, and I've had the >> >> opportunity to discuss it with most o

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Rob Clark
On Mon, Dec 24, 2012 at 11:09 AM, Laurent Pinchart wrote: > On the topic of discussions, would anyone be interested in a > BoF/brainstorming/whatever session during the FOSDEM ? I will be at FOSDEM.. and from http://wiki.x.org/wiki/fosdem2013 it looks like at least Daniel will be there. If enoug

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Rob Clark
On Mon, Dec 24, 2012 at 11:27 AM, Laurent Pinchart wrote: > On Wednesday 19 December 2012 16:57:56 Jani Nikula wrote: >> It just seems to me that, at least from a DRM/KMS perspective, adding >> another layer (=CDF) for HDMI or DP (or legacy outputs) would be >> overengineering it. They are pretty

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Rob Clark
On Mon, Dec 24, 2012 at 11:35 AM, Laurent Pinchart wrote: > On Wednesday 19 December 2012 09:26:40 Rob Clark wrote: >> And, there are also external HDMI encoders (for example connected over >> i2c) that can also be shared between boards. So I think there will be >> a number of cases where CDF is

[Bug 43167] X intel driver causes wrong wraparound of console command line

2012-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43167 Jani Nikula changed: What|Removed |Added CC||jani.nik...@intel.com --- Comment #41 from

[Bug 43167] X intel driver causes wrong wraparound of console command line

2012-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43167 Jani Nikula changed: What|Removed |Added Status|REOPENED|NEEDINFO --- Comment #42 from Jani Nikula

[Bug 49981] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -12!

2012-12-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=49981 --- Comment #4 from Apostolos B. 2012-12-27 18:16:42 --- I chasnged my DE from gnome 3 to E17 and i don't get that error anymore? Could it be related? -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email --- You are

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Sascha Hauer
On Thu, Dec 27, 2012 at 09:54:55AM -0600, Rob Clark wrote: > On Mon, Dec 24, 2012 at 7:37 AM, Laurent Pinchart > wrote: > > Hi Rob, > > > > On Tuesday 18 December 2012 00:21:32 Rob Clark wrote: > >> On Mon, Dec 17, 2012 at 11:04 PM, Dave Airlie wrote: > >> >> Many developers showed interest in th

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Sascha Hauer
On Thu, Dec 27, 2012 at 10:04:22AM -0600, Rob Clark wrote: > On Mon, Dec 24, 2012 at 11:27 AM, Laurent Pinchart > wrote: > > On Wednesday 19 December 2012 16:57:56 Jani Nikula wrote: > >> It just seems to me that, at least from a DRM/KMS perspective, adding > >> another layer (=CDF) for HDMI or DP

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Rob Clark
On Thu, Dec 27, 2012 at 1:18 PM, Sascha Hauer wrote: > On Thu, Dec 27, 2012 at 09:54:55AM -0600, Rob Clark wrote: >> On Mon, Dec 24, 2012 at 7:37 AM, Laurent Pinchart >> wrote: >> > Hi Rob, >> > >> > On Tuesday 18 December 2012 00:21:32 Rob Clark wrote: >> >> On Mon, Dec 17, 2012 at 11:04 PM, Dav

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Sascha Hauer
On Thu, Dec 27, 2012 at 01:57:56PM -0600, Rob Clark wrote: > On Thu, Dec 27, 2012 at 1:18 PM, Sascha Hauer wrote: > > On Thu, Dec 27, 2012 at 09:54:55AM -0600, Rob Clark wrote: > >> On Mon, Dec 24, 2012 at 7:37 AM, Laurent Pinchart > > > > This implies that the master driver knows all potential su

[Bug 41265] Radeon KMS does not work on thunderbolt media dock

2012-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41265 --- Comment #53 from Gerald Nunn --- Does AMD need to make a change to the proprietary fglrx drivers in order for the kernel patch to work with their drivers and if so has a bug been opened with them? I'm using Ubuntu 12.10 with kernel 3.6.9 and

[PATCH] drm/exynos: Add device tree based discovery support for Exynos G2D

2012-12-27 Thread Ajay Kumar
This patch adds device tree match table for Exynos G2D controller. Signed-off-by: Ajay Kumar --- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c index 6ffa07

Re: [PATCH] video: drm: exynos: mie bypass enable for fimd

2012-12-27 Thread Leela Krishna Amudala
Hello Inki Dae, On Thu, Dec 27, 2012 at 11:47 AM, Inki Dae wrote: > > Hi, > > DISP1BLK_CFG register is related to GScaler, HDCP and MIXER as well. So > it's not good that this register is controlled in fimd module. And I think > the function to control the register should be placed in SoC common

Re: [PATCH] video: drm: exynos: mie bypass enable for fimd

2012-12-27 Thread Inki Dae
2012/12/28 Leela Krishna Amudala : > Hello Inki Dae, > > On Thu, Dec 27, 2012 at 11:47 AM, Inki Dae wrote: >> >> Hi, >> >> DISP1BLK_CFG register is related to GScaler, HDCP and MIXER as well. So >> it's not good that this register is controlled in fimd module. And I think >> the function to contro

Re: [RFC,libdrm 1/3] tegra: Add stream library

2012-12-27 Thread Mark Zhang
I just skimmed the code of libdrm while I'm trying to understand the host1x driver. So below is what I found. Mark On 12/13/2012 10:01 PM, Arto Meriläinen wrote: > From: Arto Merilainen > > This patch introduces tegra stream library. The library is used for > buffer management, command stream co

Re: [RFC,libdrm 2/3] tegra: Add 2d library

2012-12-27 Thread Mark Zhang
I just skimmed the code of libdrm while I'm trying to understand the host1x driver. So below is what I found. Mark On 12/13/2012 10:01 PM, Arto Meriläinen wrote: > From: Francis Hart > > This patch introduces a simple 2d library on top of stream library. > > Signed-off-by: Francis Hart [...] >

Re: [RFC,libdrm 1/3] tegra: Add stream library

2012-12-27 Thread Arto Merilainen
On 12/28/2012 08:47 AM, Mark Zhang wrote: +int tegra_fence_is_valid(const struct tegra_fence *fence) +{ +int valid = fence ? 1 : 0; +valid = valid && fence->id != (uint32_t) -1; +valid = valid && fence->id < 32; Hardcode here. Assume always has 32 syncpts. Change to a micro wrapped

Re: [RFC,libdrm 1/3] tegra: Add stream library

2012-12-27 Thread Mark Zhang
On 12/28/2012 03:45 PM, Arto Merilainen wrote: > On 12/28/2012 08:47 AM, Mark Zhang wrote: >>> +int tegra_fence_is_valid(const struct tegra_fence *fence) >>> +{ >>> +int valid = fence ? 1 : 0; >>> +valid = valid && fence->id != (uint32_t) -1; >>> +valid = valid && fence->id < 32; >> >>

Re: [PATCH 04/10] drm/exynos: Use devm_clk_get in exynos_drm_fimc.c

2012-12-27 Thread Sachin Kamat
On Wednesday, 26 December 2012, Inki Dae wrote: > > > 2012/12/24 Sachin Kamat >> >> This eliminates the need for explicit clk_put and makes the >> cleanup and exit path code simpler. >> >> Cc: Eunchul Kim >> Signed-off-by: Sachin Kamat >> --- >> drivers/gpu/drm/exynos/exynos_drm_fimc.c | 46

[PATCH 04/10] drm/exynos: Use devm_clk_get in exynos_drm_fimc.c

2012-12-27 Thread Sachin Kamat
On Wednesday, 26 December 2012, Inki Dae wrote: > > > 2012/12/24 Sachin Kamat >> >> This eliminates the need for explicit clk_put and makes the >> cleanup and exit path code simpler. >> >> Cc: Eunchul Kim >> Signed-off-by: Sachin Kamat >> --- >> drivers/gpu/drm/exynos/exynos_drm_fimc.c | 46

Re: [PATCH 04/10] drm/exynos: Use devm_clk_get in exynos_drm_fimc.c

2012-12-27 Thread Inki Dae
2012/12/26 Sachin Kamat > > > On Wednesday, 26 December 2012, Inki Dae wrote: > > > > > > 2012/12/24 Sachin Kamat > >> > >> This eliminates the need for explicit clk_put and makes the > >> cleanup and exit path code simpler. > >> > >> Cc: Eunchul Kim > >> Signed-off-by: Sachin Kamat > >> ---

[Bug 57875] Second Life viewer bad rendering with git-ec83535

2012-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=57875 --- Comment #18 from Piero Finizio --- If i try to revert the commit e866bd1adea2c3b4971ad68e69c644752f2ab7b6 (above mentioned workaround) with git "HEAD at 7c35521 mesa: add missing texel fetch code for sRGB DXT formats" the compilation ends wi

[PATCH] drm/exynos: fix gem buffer allocation type checking

2012-12-27 Thread Inki Dae
This patch fixes gem buffer allocation type checking. EXYNOS_BO_CONTIG has 0 so the checking should be fixed to 'if (!(flags & EXYNOS_BO_NONCONTIG))' Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_buf.c |2 +- 1 files changed, 1 insertions(+), 1 d

[PATCH] drm/exynos: fimd: modify condition in fimd resume

2012-12-27 Thread Prathyush K
If fimd is runtime suspended (by DPMS OFF), fimd_suspend does not call fimd_activate(false) and just returns. Similarily the check in fimd_resume should not resume if previously runtime_suspended. Instead the existing check does the opposite. So if fimd was not runtime suspended, suspend will turn

Re: [PATCH] drm/exynos: fix gem buffer allocation type checking

2012-12-27 Thread Prathyush K
On Thu, Dec 27, 2012 at 4:27 PM, Inki Dae wrote: > This patch fixes gem buffer allocation type checking. > EXYNOS_BO_CONTIG has 0 so the checking should be fixed > to 'if (!(flags & EXYNOS_BO_NONCONTIG))' > > Signed-off-by: Inki Dae > Signed-off-by: Kyungmin Park > --- > drivers/gpu/drm/exynos

Re: [PATCH] drm/exynos: fix gem buffer allocation type checking

2012-12-27 Thread Inki Dae
2012/12/27 Prathyush K > > > > On Thu, Dec 27, 2012 at 4:27 PM, Inki Dae wrote: > >> This patch fixes gem buffer allocation type checking. >> EXYNOS_BO_CONTIG has 0 so the checking should be fixed >> to 'if (!(flags & EXYNOS_BO_NONCONTIG))' >> >> Signed-off-by: Inki Dae >> Signed-off-by: Kyungm

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Tomasz Figa
Hi Laurent, On Monday 24 of December 2012 15:12:28 Laurent Pinchart wrote: > Hi Tomasz, > > On Friday 21 December 2012 11:00:52 Tomasz Figa wrote: > > On Tuesday 18 of December 2012 08:31:30 Vikas Sajjan wrote: > > > On 17 December 2012 20:55, Laurent Pinchart wrote: > > > > Hi Vikas, > > > > >

Re: Display resolutions missing on external VGA display [regressing]

2012-12-27 Thread Jani Nikula
On Mon, 24 Dec 2012, John wrote: > On launchpad they requested to report this bug upstream. Please let me know > if any information is missing. Please file a bug on DRM/Intel at [1]. Please reference your mail and the launchpad bug, no need to attach all the info there again. What's the latest k

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Rob Clark
On Mon, Dec 24, 2012 at 7:37 AM, Laurent Pinchart wrote: > Hi Rob, > > On Tuesday 18 December 2012 00:21:32 Rob Clark wrote: >> On Mon, Dec 17, 2012 at 11:04 PM, Dave Airlie wrote: >> >> Many developers showed interest in the first RFC, and I've had the >> >> opportunity to discuss it with most o

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Rob Clark
On Mon, Dec 24, 2012 at 11:09 AM, Laurent Pinchart wrote: > On the topic of discussions, would anyone be interested in a > BoF/brainstorming/whatever session during the FOSDEM ? I will be at FOSDEM.. and from http://wiki.x.org/wiki/fosdem2013 it looks like at least Daniel will be there. If enoug

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Rob Clark
On Mon, Dec 24, 2012 at 11:27 AM, Laurent Pinchart wrote: > On Wednesday 19 December 2012 16:57:56 Jani Nikula wrote: >> It just seems to me that, at least from a DRM/KMS perspective, adding >> another layer (=CDF) for HDMI or DP (or legacy outputs) would be >> overengineering it. They are pretty

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Rob Clark
On Mon, Dec 24, 2012 at 11:35 AM, Laurent Pinchart wrote: > On Wednesday 19 December 2012 09:26:40 Rob Clark wrote: >> And, there are also external HDMI encoders (for example connected over >> i2c) that can also be shared between boards. So I think there will be >> a number of cases where CDF is

[Bug 43167] X intel driver causes wrong wraparound of console command line

2012-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43167 Jani Nikula changed: What|Removed |Added CC||jani.nik...@intel.com --- Comment #41 from

[Bug 43167] X intel driver causes wrong wraparound of console command line

2012-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=43167 Jani Nikula changed: What|Removed |Added Status|REOPENED|NEEDINFO --- Comment #42 from Jani Nikula

[Bug 49981] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -12!

2012-12-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=49981 --- Comment #4 from Apostolos B. 2012-12-27 18:16:42 --- I chasnged my DE from gnome 3 to E17 and i don't get that error anymore? Could it be related? -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email --- You are

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Sascha Hauer
On Thu, Dec 27, 2012 at 09:54:55AM -0600, Rob Clark wrote: > On Mon, Dec 24, 2012 at 7:37 AM, Laurent Pinchart > wrote: > > Hi Rob, > > > > On Tuesday 18 December 2012 00:21:32 Rob Clark wrote: > >> On Mon, Dec 17, 2012 at 11:04 PM, Dave Airlie wrote: > >> >> Many developers showed interest in th

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Sascha Hauer
On Thu, Dec 27, 2012 at 10:04:22AM -0600, Rob Clark wrote: > On Mon, Dec 24, 2012 at 11:27 AM, Laurent Pinchart > wrote: > > On Wednesday 19 December 2012 16:57:56 Jani Nikula wrote: > >> It just seems to me that, at least from a DRM/KMS perspective, adding > >> another layer (=CDF) for HDMI or DP

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Rob Clark
On Thu, Dec 27, 2012 at 1:18 PM, Sascha Hauer wrote: > On Thu, Dec 27, 2012 at 09:54:55AM -0600, Rob Clark wrote: >> On Mon, Dec 24, 2012 at 7:37 AM, Laurent Pinchart >> wrote: >> > Hi Rob, >> > >> > On Tuesday 18 December 2012 00:21:32 Rob Clark wrote: >> >> On Mon, Dec 17, 2012 at 11:04 PM, Dav

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Sascha Hauer
On Thu, Dec 27, 2012 at 01:57:56PM -0600, Rob Clark wrote: > On Thu, Dec 27, 2012 at 1:18 PM, Sascha Hauer wrote: > > On Thu, Dec 27, 2012 at 09:54:55AM -0600, Rob Clark wrote: > >> On Mon, Dec 24, 2012 at 7:37 AM, Laurent Pinchart > > > > This implies that the master driver knows all potential su

[Bug 41265] Radeon KMS does not work on thunderbolt media dock

2012-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41265 --- Comment #53 from Gerald Nunn --- Does AMD need to make a change to the proprietary fglrx drivers in order for the kernel patch to work with their drivers and if so has a bug been opened with them? I'm using Ubuntu 12.10 with kernel 3.6.9 and

[PATCH] drm/exynos: Add device tree based discovery support for Exynos G2D

2012-12-27 Thread Ajay Kumar
This patch adds device tree match table for Exynos G2D controller. Signed-off-by: Ajay Kumar --- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c index 6ffa07

Re: [PATCH] video: drm: exynos: mie bypass enable for fimd

2012-12-27 Thread Leela Krishna Amudala
Hello Inki Dae, On Thu, Dec 27, 2012 at 11:47 AM, Inki Dae wrote: > > Hi, > > DISP1BLK_CFG register is related to GScaler, HDCP and MIXER as well. So > it's not good that this register is controlled in fimd module. And I think > the function to control the register should be placed in SoC common

Re: [PATCH] video: drm: exynos: mie bypass enable for fimd

2012-12-27 Thread Inki Dae
2012/12/28 Leela Krishna Amudala : > Hello Inki Dae, > > On Thu, Dec 27, 2012 at 11:47 AM, Inki Dae wrote: >> >> Hi, >> >> DISP1BLK_CFG register is related to GScaler, HDCP and MIXER as well. So >> it's not good that this register is controlled in fimd module. And I think >> the function to contro

Re: [RFC,libdrm 1/3] tegra: Add stream library

2012-12-27 Thread Mark Zhang
I just skimmed the code of libdrm while I'm trying to understand the host1x driver. So below is what I found. Mark On 12/13/2012 10:01 PM, Arto Meriläinen wrote: > From: Arto Merilainen > > This patch introduces tegra stream library. The library is used for > buffer management, command stream co

Re: [RFC,libdrm 2/3] tegra: Add 2d library

2012-12-27 Thread Mark Zhang
I just skimmed the code of libdrm while I'm trying to understand the host1x driver. So below is what I found. Mark On 12/13/2012 10:01 PM, Arto Meriläinen wrote: > From: Francis Hart > > This patch introduces a simple 2d library on top of stream library. > > Signed-off-by: Francis Hart [...] >

Re: [RFC,libdrm 1/3] tegra: Add stream library

2012-12-27 Thread Arto Merilainen
On 12/28/2012 08:47 AM, Mark Zhang wrote: +int tegra_fence_is_valid(const struct tegra_fence *fence) +{ +int valid = fence ? 1 : 0; +valid = valid && fence->id != (uint32_t) -1; +valid = valid && fence->id < 32; Hardcode here. Assume always has 32 syncpts. Change to a micro wrapped

Re: [RFC,libdrm 1/3] tegra: Add stream library

2012-12-27 Thread Mark Zhang
On 12/28/2012 03:45 PM, Arto Merilainen wrote: > On 12/28/2012 08:47 AM, Mark Zhang wrote: >>> +int tegra_fence_is_valid(const struct tegra_fence *fence) >>> +{ >>> +int valid = fence ? 1 : 0; >>> +valid = valid && fence->id != (uint32_t) -1; >>> +valid = valid && fence->id < 32; >> >>

Re: [PATCH 04/10] drm/exynos: Use devm_clk_get in exynos_drm_fimc.c

2012-12-27 Thread Sachin Kamat
On Wednesday, 26 December 2012, Inki Dae wrote: > > > 2012/12/24 Sachin Kamat >> >> This eliminates the need for explicit clk_put and makes the >> cleanup and exit path code simpler. >> >> Cc: Eunchul Kim >> Signed-off-by: Sachin Kamat >> --- >> drivers/gpu/drm/exynos/exynos_drm_fimc.c | 46

[PATCH 04/10] drm/exynos: Use devm_clk_get in exynos_drm_fimc.c

2012-12-27 Thread Sachin Kamat
On Wednesday, 26 December 2012, Inki Dae wrote: > > > 2012/12/24 Sachin Kamat >> >> This eliminates the need for explicit clk_put and makes the >> cleanup and exit path code simpler. >> >> Cc: Eunchul Kim >> Signed-off-by: Sachin Kamat >> --- >> drivers/gpu/drm/exynos/exynos_drm_fimc.c | 46

Re: [PATCH 04/10] drm/exynos: Use devm_clk_get in exynos_drm_fimc.c

2012-12-27 Thread Inki Dae
2012/12/26 Sachin Kamat > > > On Wednesday, 26 December 2012, Inki Dae wrote: > > > > > > 2012/12/24 Sachin Kamat > >> > >> This eliminates the need for explicit clk_put and makes the > >> cleanup and exit path code simpler. > >> > >> Cc: Eunchul Kim > >> Signed-off-by: Sachin Kamat > >> ---

[Bug 57875] Second Life viewer bad rendering with git-ec83535

2012-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=57875 --- Comment #18 from Piero Finizio --- If i try to revert the commit e866bd1adea2c3b4971ad68e69c644752f2ab7b6 (above mentioned workaround) with git "HEAD at 7c35521 mesa: add missing texel fetch code for sRGB DXT formats" the compilation ends wi

[PATCH] drm/exynos: fix gem buffer allocation type checking

2012-12-27 Thread Inki Dae
This patch fixes gem buffer allocation type checking. EXYNOS_BO_CONTIG has 0 so the checking should be fixed to 'if (!(flags & EXYNOS_BO_NONCONTIG))' Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_buf.c |2 +- 1 files changed, 1 insertions(+), 1 d

[PATCH] drm/exynos: fimd: modify condition in fimd resume

2012-12-27 Thread Prathyush K
If fimd is runtime suspended (by DPMS OFF), fimd_suspend does not call fimd_activate(false) and just returns. Similarily the check in fimd_resume should not resume if previously runtime_suspended. Instead the existing check does the opposite. So if fimd was not runtime suspended, suspend will turn

Re: [PATCH] drm/exynos: fix gem buffer allocation type checking

2012-12-27 Thread Prathyush K
On Thu, Dec 27, 2012 at 4:27 PM, Inki Dae wrote: > This patch fixes gem buffer allocation type checking. > EXYNOS_BO_CONTIG has 0 so the checking should be fixed > to 'if (!(flags & EXYNOS_BO_NONCONTIG))' > > Signed-off-by: Inki Dae > Signed-off-by: Kyungmin Park > --- > drivers/gpu/drm/exynos

Re: [PATCH] drm/exynos: fix gem buffer allocation type checking

2012-12-27 Thread Inki Dae
2012/12/27 Prathyush K > > > > On Thu, Dec 27, 2012 at 4:27 PM, Inki Dae wrote: > >> This patch fixes gem buffer allocation type checking. >> EXYNOS_BO_CONTIG has 0 so the checking should be fixed >> to 'if (!(flags & EXYNOS_BO_NONCONTIG))' >> >> Signed-off-by: Inki Dae >> Signed-off-by: Kyungm

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Tomasz Figa
Hi Laurent, On Monday 24 of December 2012 15:12:28 Laurent Pinchart wrote: > Hi Tomasz, > > On Friday 21 December 2012 11:00:52 Tomasz Figa wrote: > > On Tuesday 18 of December 2012 08:31:30 Vikas Sajjan wrote: > > > On 17 December 2012 20:55, Laurent Pinchart wrote: > > > > Hi Vikas, > > > > >

Re: Display resolutions missing on external VGA display [regressing]

2012-12-27 Thread Jani Nikula
On Mon, 24 Dec 2012, John wrote: > On launchpad they requested to report this bug upstream. Please let me know > if any information is missing. Please file a bug on DRM/Intel at [1]. Please reference your mail and the launchpad bug, no need to attach all the info there again. What's the latest k

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Rob Clark
On Mon, Dec 24, 2012 at 7:37 AM, Laurent Pinchart wrote: > Hi Rob, > > On Tuesday 18 December 2012 00:21:32 Rob Clark wrote: >> On Mon, Dec 17, 2012 at 11:04 PM, Dave Airlie wrote: >> >> Many developers showed interest in the first RFC, and I've had the >> >> opportunity to discuss it with most o

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Rob Clark
On Mon, Dec 24, 2012 at 11:09 AM, Laurent Pinchart wrote: > On the topic of discussions, would anyone be interested in a > BoF/brainstorming/whatever session during the FOSDEM ? I will be at FOSDEM.. and from http://wiki.x.org/wiki/fosdem2013 it looks like at least Daniel will be there. If enoug

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Rob Clark
On Mon, Dec 24, 2012 at 11:27 AM, Laurent Pinchart wrote: > On Wednesday 19 December 2012 16:57:56 Jani Nikula wrote: >> It just seems to me that, at least from a DRM/KMS perspective, adding >> another layer (=CDF) for HDMI or DP (or legacy outputs) would be >> overengineering it. They are pretty

  1   2   >