Re: [RFC 1/21] Add VIA DRM driver

2013-06-12 Thread Dave Airlie
> commit 1fcf23d361375645d586756d126b436796ba4fba > Author: James Simmons > Date: Sat Jun 8 09:31:57 2013 -0400 > > via: New KMS ioctls and hardware to support. > > Add new VIA pci ids to support newer hardware. Cleanup userspace > api structs to remove kernel types and add the new K

[git pull] drm fixes

2013-06-12 Thread Dave Airlie
Hi Linus, just some GMA500 memory leaks and i915 regression fix due to regression fix. Dave. The following changes since commit ab0296319a8cb970f4e42659472bb40fbfae3e56: Merge tag 'spi-v3.10-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi (2013-06-10 13:28:39 -0700) are

Re: [PATCH v4 0/4] add mutex wait/wound/style style locks

2013-06-12 Thread Maarten Lankhorst
Op 28-05-13 16:48, Maarten Lankhorst schreef: > Version 4 already? > > Small api changes since v3: > - Remove ww_mutex_unlock_single and ww_mutex_lock_single. > - Rename ww_mutex_trylock_single to ww_mutex_trylock. > - Remove separate implementations of ww_mutex_lock_slow*, normal > functions can

[PATCH] drm: Don't pass negative delta to ktime_sub_ns()

2013-06-12 Thread Michel Dänzer
From: Michel Dänzer It takes an unsigned value. This happens not to blow up on 64-bit architectures, but it does on 32-bit, causing drm_calc_vbltimestamp_from_scanoutpos() to calculate totally bogus timestamps for vblank events. Which in turn causes e.g. gnome-shell to hang after a DPMS off cycle

Re: [PATCH] radeon: Fix a false positive lockup after 10s of inactivity

2013-06-12 Thread Michel Dänzer
On Die, 2013-06-11 at 16:23 -0700, Andy Lutomirski wrote: > If the device is idle for over ten seconds, then the next attempt to do > anything can race with the lockup detector and cause a bogus lockup > to be detected. > > Oddly, the situation is well-described in the lockup detector's comments >

Re: [PATCH 2/6] gpu: host1x: Fix syncpoint wait return value

2013-06-12 Thread Terje Bergström
On 11.06.2013 15:09, Daniel Vetter wrote: > Maybe it wasn't clear, but -EAGAIN does _not_ resubmit work. -EAGAIN > is used to restart the ioctl if we had to kick a thread (to make sure > it doesn't hold any locks), e.g. for a blocking wait on oustanding > rendering. The codepaths taken work exactly

Re: [PATCH] drm: Don't pass negative delta to ktime_sub_ns()

2013-06-12 Thread Chris Wilson
On Wed, Jun 12, 2013 at 11:58:44AM +0200, Michel Dänzer wrote: > From: Michel Dänzer > > It takes an unsigned value. This happens not to blow up on 64-bit > architectures, but it does on 32-bit, causing > drm_calc_vbltimestamp_from_scanoutpos() to calculate totally bogus > timestamps for vblank e

Re: [PATCH] drm: Don't pass negative delta to ktime_sub_ns()

2013-06-12 Thread Imre Deak
On Wed, 2013-06-12 at 11:58 +0200, Michel Dänzer wrote: > From: Michel Dänzer > > It takes an unsigned value. This happens not to blow up on 64-bit > architectures, but it does on 32-bit, causing > drm_calc_vbltimestamp_from_scanoutpos() to calculate totally bogus > timestamps for vblank events.

Re: [PATCH 2/6] gpu: host1x: Fix syncpoint wait return value

2013-06-12 Thread Daniel Vetter
On Wed, Jun 12, 2013 at 12:28 PM, Terje Bergström wrote: > On 11.06.2013 15:09, Daniel Vetter wrote: >> Maybe it wasn't clear, but -EAGAIN does _not_ resubmit work. -EAGAIN >> is used to restart the ioctl if we had to kick a thread (to make sure >> it doesn't hold any locks), e.g. for a blocking w

Re: [PATCH] drm: Don't pass negative delta to ktime_sub_ns()

2013-06-12 Thread Chris Wilson
On Wed, Jun 12, 2013 at 11:48:13AM +0100, Chris Wilson wrote: > On Wed, Jun 12, 2013 at 11:58:44AM +0200, Michel Dänzer wrote: > > From: Michel Dänzer > > > > It takes an unsigned value. This happens not to blow up on 64-bit > > architectures, but it does on 32-bit, causing > > drm_calc_vbltimest

Re: [PATCH] radeon: Fix a false positive lockup after 10s of inactivity

2013-06-12 Thread Christian König
Am 12.06.2013 12:26, schrieb Michel Dänzer: On Die, 2013-06-11 at 16:23 -0700, Andy Lutomirski wrote: If the device is idle for over ten seconds, then the next attempt to do anything can race with the lockup detector and cause a bogus lockup to be detected. Oddly, the situation is well-describe

[PATCH 0/3] drm/cma: use prim helpers instead GEM CMA specific dma_buf functionality

2013-06-12 Thread Joonyoung Shim
Hi, GEM CMA supports dma_buf but it needs GEM CMA specific functionality for dma_buf. We can use prime helpers for dma_buf by commit 89177644a7b6306e6084a89eab7e290f4bfef397 "drm: add prime helpers", so this patchset is to replace from using GEM CMA specific functions to using prime helpers. Tha

[PATCH 1/3] drm: add mmap function to prime helpers

2013-06-12 Thread Joonyoung Shim
This adds to call low-level mmap() from prime helpers. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/drm_prime.c | 5 - include/drm/drmP.h | 2 ++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c index d92853

[PATCH 2/3] drm/cma: add low-level hook functions to use prime helpers

2013-06-12 Thread Joonyoung Shim
Instead of using the dma_buf functionality for GEM CMA, we can use prime helpers if we can provide low-level hook functions for GEM CMA. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/drm_gem_cma_helper.c | 76 include/drm/drm_gem_cma_helper.h | 9 +++

[PATCH 3/3] drm/cma: remove GEM CMA specific dma_buf functionality

2013-06-12 Thread Joonyoung Shim
We can use prime helpers instead. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/drm_gem_cma_helper.c | 283 --- include/drm/drm_gem_cma_helper.h | 6 - 2 files changed, 289 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/dr

Re: [PATCH 0/3] drm/cma: use prim helpers instead GEM CMA specific dma_buf functionality

2013-06-12 Thread Laurent Pinchart
Hi Joonyoung, Thank you for the patches. I'll try to review and test them next week. On Wednesday 12 June 2013 22:16:14 Joonyoung Shim wrote: > Hi, > > GEM CMA supports dma_buf but it needs GEM CMA specific functionality for > dma_buf. We can use prime helpers for dma_buf by commit > 89177644a7b

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-12 Thread Rob Clark
On Wed, Jun 12, 2013 at 9:48 AM, Russell King - ARM Linux wrote: > On Tue, Jun 11, 2013 at 09:48:57AM +1000, Dave Airlie wrote: >> On Tue, Jun 11, 2013 at 9:36 AM, Russell King - ARM Linux >> wrote: >> > On Tue, Jun 11, 2013 at 09:24:16AM +1000, Dave Airlie wrote: >> >> I'd like to see all the AR

Re: [PATCH] radeon: Fix a false positive lockup after 10s of inactivity

2013-06-12 Thread Jerome Glisse
On Wed, Jun 12, 2013 at 6:26 AM, Michel Dänzer wrote: > On Die, 2013-06-11 at 16:23 -0700, Andy Lutomirski wrote: >> If the device is idle for over ten seconds, then the next attempt to do >> anything can race with the lockup detector and cause a bogus lockup >> to be detected. >> >> Oddly, the si

Re: [PATCH] drm/mgag200: Don't do full cleanup if mgag200_device_init fails

2013-06-12 Thread Christopher Harvey
On Wed, Jun 05 2013, Christopher Harvey wrote: > Running mgag200_driver_unload when the driver init fails early on > causes functions like drm_mode_config_cleanup to be called. The > problem is, drm_mode_config_cleanup crashes because the corresponding > init hasn't happend yet. There really isn't

Re: [PATCH] drm/mgag200: Hardware cursor support

2013-06-12 Thread Christopher Harvey
On Wed, Jun 05 2013, Christopher Harvey wrote: > G200 cards support, at best, 16 colour palleted images for the cursor > so we do a conversion in the cursor_set function, and reject cursors > with more than 16 colours, or cursors with partial transparency. Xorg > falls back gracefully to software

[PATCH 1/1] drm/mgag200: Added resolution and bandwidth limits for various G200e products.

2013-06-12 Thread Julia Lemire
This code was ported from the old xorg mga driver. These limits were implemented as a solution to a number of problems that were seen. These problems were linked to the bandwidth limitations of the g200e series. Signed-off-by: Julia Lemire --- drivers/gpu/drm/mgag200/mgag200_drv.h | 41

[PATCH 0/1] drm/mgag200: Added resolution and bandwidth limits for various G200e products.

2013-06-12 Thread Julia Lemire
At the larger resolutions, the g200e series sometimes struggles with maintaining a proper output. Problems like flickering or black bands appearing on screen can occur. In order to avoid this, limitations regarding resolutions and bandwidth have been added for the different variations of the g20

[Bug 64257] RS880 issues with r600-llvm-compiler

2013-06-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64257 --- Comment #49 from vincent --- Created attachment 80739 --> https://bugs.freedesktop.org/attachment.cgi?id=80739&action=edit Force max tex size of 8 Does this patch help ? I assumed a max tex clause size of 16 for anything from HD4000 using

[Bug 64257] RS880 issues with r600-llvm-compiler

2013-06-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64257 --- Comment #50 from Alex Deucher --- 6xx has a max tex/vtx clause size of 8. 7xx+ has a max tex/vtx clause size of 16. In CF_WORD1, make sure you are setting the MSB of the count field. Bits 12:10 and bit 19 make up the total count field. I s

[Bug 65416] r300g does not eliminate unread varyings

2013-06-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65416 --- Comment #5 from Marek Olšák --- I have implemented it, but there is a problem. If I enable the optimization, EXT_separate_shader_objects must be disabled. Is it okay with you? This is a valid sequence with EXT_sso: glUseProgram(prog_with_vs_

[Bug 64257] RS880 issues with r600-llvm-compiler

2013-06-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64257 vincent changed: What|Removed |Added Attachment #80739|0 |1 is obsolete|

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-12 Thread Rob Clark
On Wed, Jun 12, 2013 at 1:05 PM, Russell King - ARM Linux wrote: > On Wed, Jun 12, 2013 at 05:49:14PM +0100, Russell King - ARM Linux wrote: >> On Wed, Jun 12, 2013 at 09:56:22AM -0400, Rob Clark wrote: >> > On Wed, Jun 12, 2013 at 9:48 AM, Russell King - ARM Linux >> > wrote: >> > > And having t

[Bug 64257] RS880 issues with r600-llvm-compiler

2013-06-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64257 --- Comment #52 from Andy Furniss --- (In reply to comment #51) > Created attachment 80740 [details] [review] > Properly set COUNT_3 > > Indeed, I was always setting COUNT_3 to 0. > > This new patch should solve the issue (at least if it's rela

Re: [PATCH] drm/mgag200: Don't do full cleanup if mgag200_device_init fails

2013-06-12 Thread Paul Menzel
Dear Christopher, Am Mittwoch, den 05.06.2013, 11:29 -0400 schrieb Christopher Harvey: > Running mgag200_driver_unload when the driver init fails early on > causes functions like drm_mode_config_cleanup to be called. The > problem is, drm_mode_config_cleanup crashes because the corresponding > in

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-12 Thread Rob Clark
On Wed, Jun 12, 2013 at 7:00 PM, Russell King - ARM Linux wrote: > And here's another one - look carefully at this path: > > buf = dev->driver->gem_prime_export(dev, obj, flags); > if (IS_ERR(buf)) { > /* normally the created dma-buf takes ow

[Bug 64257] RS880 issues with r600-llvm-compiler

2013-06-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=64257 vincent changed: What|Removed |Added Attachment #80740|0 |1 is obsolete|

Re: [RFC 0/2] exynos5250/hdmi: replace dummy hdmiphy clock with pmu reg control

2013-06-12 Thread Rahul Sharma
Mr. Dae, Thanks for your valuable inputs. I posted it as RFC because, I also have received comments to register hdmiphy as a clock controller. As we always configure it for specific frequency, hdmi-phy looks similar to a PLL. But it really doesn't belong to that class. Secondly prior to exynos542

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-12 Thread Russell King - ARM Linux
On Tue, Jun 11, 2013 at 09:48:57AM +1000, Dave Airlie wrote: > On Tue, Jun 11, 2013 at 9:36 AM, Russell King - ARM Linux > wrote: > > On Tue, Jun 11, 2013 at 09:24:16AM +1000, Dave Airlie wrote: > >> I'd like to see all the ARM based drivers based on CMA if it can meet > >> their requirements > >>

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-12 Thread Russell King - ARM Linux
On Wed, Jun 12, 2013 at 09:56:22AM -0400, Rob Clark wrote: > On Wed, Jun 12, 2013 at 9:48 AM, Russell King - ARM Linux > wrote: > > And having thought about this driver, DRM some more, I'm now of the > > opinion that DRM is not suitable for driving hardware where the GPU is > > an entirely separat

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-12 Thread Russell King - ARM Linux
On Wed, Jun 12, 2013 at 05:49:14PM +0100, Russell King - ARM Linux wrote: > On Wed, Jun 12, 2013 at 09:56:22AM -0400, Rob Clark wrote: > > On Wed, Jun 12, 2013 at 9:48 AM, Russell King - ARM Linux > > wrote: > > > And having thought about this driver, DRM some more, I'm now of the > > > opinion th

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-12 Thread Russell King - ARM Linux
On Wed, Jun 12, 2013 at 06:05:12PM +0100, Russell King - ARM Linux wrote: > On Wed, Jun 12, 2013 at 05:49:14PM +0100, Russell King - ARM Linux wrote: > > On Wed, Jun 12, 2013 at 09:56:22AM -0400, Rob Clark wrote: > > > On Wed, Jun 12, 2013 at 9:48 AM, Russell King - ARM Linux > > > wrote: > > > >

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-12 Thread Russell King - ARM Linux
And here's another one - look carefully at this path: buf = dev->driver->gem_prime_export(dev, obj, flags); if (IS_ERR(buf)) { /* normally the created dma-buf takes ownership of the ref, * but if that fails then drop