Re: [PATCH] drm/omap: change "!CONFIG_FB_OMAP2" to "!FB_OMAP2"

2013-06-15 Thread Thierry Reding
On Wed, Mar 13, 2013 at 08:48:22PM +0100, Paul Bolle wrote: > Signed-off-by: Paul Bolle > --- > Untested. Perhaps the first test that people with access to the relevant > hardware might do, is to test _before applying this patch_ with FB_OMAP2 > set. Perhaps this negative dependency isn't needed a

Re: [PATCH] drm/omap: change "!CONFIG_FB_OMAP2" to "!FB_OMAP2"

2013-06-15 Thread Rob Clark
On Thu, Jun 13, 2013 at 6:31 AM, Paul Bolle wrote: > On Wed, 2013-03-13 at 20:48 +0100, Paul Bolle wrote: >> Signed-off-by: Paul Bolle >> --- >> Untested. Perhaps the first test that people with access to the relevant >> hardware might do, is to test _before applying this patch_ with FB_OMAP2 >>

[Bug 65787] New: r600g: corruption in menu in "stunt rally"

2013-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65787 Priority: medium Bug ID: 65787 Assignee: dri-devel@lists.freedesktop.org Summary: r600g: corruption in menu in "stunt rally" Severity: normal Classification: Unclassified OS:

[Bug 65787] r600g: corruption in menu in "stunt rally"

2013-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65787 --- Comment #1 from Harald Judt --- Problem with similar elements in game. But other texts are readable. -- You are receiving this mail because: You are the assignee for the bug. ___ dri-devel mailing

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Aaron Lu
On 06/10/2013 07:01 AM, Matthew Garrett wrote: > Windows 8 leaves backlight control up to individual graphics drivers rather > than making ACPI calls itself. There's plenty of evidence to suggest that > the Intel driver for Windows doesn't use the ACPI interface, including the > fact that it's brok

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-15 Thread Russell King - ARM Linux
On Fri, Jun 14, 2013 at 03:53:41PM +0200, Daniel Vetter wrote: > On Thu, Jun 13, 2013 at 12:50:16PM +0100, Russell King - ARM Linux wrote: > > On Thu, Jun 13, 2013 at 12:19:03PM +0100, Russell King - ARM Linux wrote: > > > The deeper I look, the more bugs there seem to be in this DRM stuff, > > > a

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-15 Thread Russell King - ARM Linux
On Fri, Jun 14, 2013 at 04:23:22PM +0200, Daniel Vetter wrote: > On Thu, Jun 13, 2013 at 3:03 PM, Russell King - ARM Linux > wrote: > > There's a bigger issue here - if it's possible for > > drm_crtc_helper_set_config() > > to be called with set->fb set but set->mode NULL, then we overwrite > > s

Re: [PATCH v2 2/4] gpu: host1x: add runtime pm support for gr2d

2013-06-15 Thread Mayuresh Kulkarni
On Thursday 13 June 2013 08:44 PM, Stephen Warren wrote: On 06/13/2013 03:53 AM, Mayuresh Kulkarni wrote: Patch description? I thought the patch subject is sufficient to tell what it is it doing. Description here would be repetition in my opinion. Also, the cover letter for the patch-set se

Re: [PATCH v2 3/4] gpu: host1x: add runtime pm support for dc

2013-06-15 Thread Mayuresh Kulkarni
On Friday 14 June 2013 12:39 AM, Stephen Warren wrote: On 06/13/2013 12:49 PM, Thierry Reding wrote: On Thu, Jun 13, 2013 at 03:23:37PM +0530, Mayuresh Kulkarni wrote: [...] diff --git a/drivers/gpu/host1x/drm/dc.c b/drivers/gpu/host1x/drm/dc.c [...] @@ -1128,9 +1129,7 @@ static int tegra_dc_

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Matthew Garrett
On Fri, 2013-06-14 at 14:47 +0800, Aaron Lu wrote: > What about a priority based solution? We can introduce a new field named > priority to backlight_device and instead of calling another module's > function like the unregister one here(which cause unnecessary module > dependency), we only need to

[PATCH] drm: Initialize list in event->base.link

2013-06-15 Thread Stéphane Marchesin
The structure was kzalloced, so prev == next == NULL by default which is invalid. Signed-off-by: Stéphane Marchesin --- drivers/gpu/drm/drm_irq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c index 8bcce78..143a311 100644 --- a/drivers/

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-15 Thread Russell King - ARM Linux
On Fri, Jun 14, 2013 at 09:50:22PM +0200, Daniel Vetter wrote: > On Fri, Jun 14, 2013 at 4:42 PM, Russell King - ARM Linux > wrote: > > If you're happy with the patch I supplied, that's probably the minimal fix > > which should go to stable kernels (I'm using 3.9 here) - this also counts > > as a

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Aaron Lu
On 06/15/2013 01:29 AM, Matthew Garrett wrote: > On Fri, 2013-06-14 at 14:47 +0800, Aaron Lu wrote: > >> What about a priority based solution? We can introduce a new field named >> priority to backlight_device and instead of calling another module's >> function like the unregister one here(which c

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Matthew Garrett
On Sat, 2013-06-15 at 09:26 +0800, Aaron Lu wrote: > On 06/15/2013 01:29 AM, Matthew Garrett wrote: > > How would that work with existing userspace? > > User space tool will need to be updated to use this as stated in the > gist page, I've patches for gsd-backlight-helper and xorg-x11-drv-intel,

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Aaron Lu
On 06/15/2013 09:38 AM, Matthew Garrett wrote: > On Sat, 2013-06-15 at 09:26 +0800, Aaron Lu wrote: >> It's not easy to decide if they work or not sometimes, e.g. I came >> across a system that claims win8 in ACPI table and has an Intel GPU, >> while its ACPI video interface also works. With this p

[PATCH] drm/nouveau: fix a memory leak.

2013-06-15 Thread majianpeng
When cleanup extra stat if this object was a notifier,it should free the notifier. Signed-off-by: Jianpeng Ma --- drivers/gpu/drm/nouveau/nouveau_abi16.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_abi16.c b/drivers/gpu/drm/nouveau/nouv

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Aaron Lu
On 06/15/2013 12:19 PM, Matthew Garrett wrote: > On Sat, Jun 15, 2013 at 12:14:42PM +0800, Aaron Lu wrote: >> On 06/15/2013 09:38 AM, Matthew Garrett wrote: >>> Well, Windows 8 will only use the ACPI backlight interface if the GPU >>> driver decides to, right? So the logic for deciding whether to r

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Matthew Garrett
On Sat, Jun 15, 2013 at 08:29:15PM +0800, Aaron Lu wrote: > On 06/15/2013 12:19 PM, Matthew Garrett wrote: > > The vendor will presumably have tested that backlight control works - if > > the GPU driver uses the ACPI interface and backlight control is broken, > > then the vendor would fix it. >

[Bug 59761] New: Kernel fails to reset AMD HD5770 GPU properly and encounters OOPS. GPU reset fails - system remains in unusable state.

2013-06-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=59761 Summary: Kernel fails to reset AMD HD5770 GPU properly and encounters OOPS. GPU reset fails - system remains in unusable state. Product: Drivers Version: 2.5 Kernel Versio

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Daniel Vetter
Hi all, So to me it looks like the discussion is going in circles a bit, hence let me drop my maintainer-opinion here: 1. Matthew's patch series here looks reasonable, and if it fixes a bunch of systems (which it seems to) it has my Ack and imo should go in. If acpi maintainers can smash their Ac

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Matthew Garrett
On Sat, Jun 15, 2013 at 08:29:42PM +0200, Daniel Vetter wrote: > Aside at the end: If the gnome tool indeed has its own backlight code and > doesn't just use that as a fallback if the xrandr backligh property isn't > available, then that's just a serious bug in gnome and should be fixed > asap. Bu

Re: [PATCH] drm: Initialize list in event->base.link

2013-06-15 Thread Daniel Vetter
On Fri, Jun 14, 2013 at 01:39:05PM -0700, Stéphane Marchesin wrote: > The structure was kzalloced, so prev == next == NULL by default which > is invalid. > > Signed-off-by: Stéphane Marchesin We do a list_add_tail which doesn't seem to care about unitizalized list items, and when removing it we

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Rafael J. Wysocki
On Saturday, June 15, 2013 08:29:42 PM Daniel Vetter wrote: > Hi all, > > So to me it looks like the discussion is going in circles a bit, hence let > me drop my maintainer-opinion here: > > 1. Matthew's patch series here looks reasonable, and if it fixes a bunch > of systems (which it seems to)

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Daniel Vetter
On Sat, Jun 15, 2013 at 10:27:06PM +0200, Rafael J. Wysocki wrote: > On Saturday, June 15, 2013 08:29:42 PM Daniel Vetter wrote: > > Hi all, > > > > So to me it looks like the discussion is going in circles a bit, hence let > > me drop my maintainer-opinion here: > > > > 1. Matthew's patch series

[PATCH] drm/crtc-helper: explicit DPMS on after modeset

2013-06-15 Thread Daniel Vetter
Atm the crtc helper implementation of set_config has really inconsisten semantics: If just an fb update is good enough, dpms state will be left as-is, but if we do a full modeset we force everything to dpms on. This change has already been applied to the i915 modeset code in commit e3de42b68478a8

[PATCH] drm/crtc-helper: don't disable disconnected outputs

2013-06-15 Thread Daniel Vetter
This has originally been added in commit a3a0544b2c84e1d7a2022b558ecf66d8c6a8dd93 Author: Dave Airlie Date: Mon Aug 31 15:16:30 2009 +1000 drm/kms: add explicit encoder disable function and detach harder. I think it's the wrong thing to do for a few reasons: - It's policy in the kernel. U

[Bug 65803] New: r600g: segfault with Kerbal Space Program

2013-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65803 Priority: medium Bug ID: 65803 Assignee: dri-devel@lists.freedesktop.org Summary: r600g: segfault with Kerbal Space Program Severity: normal Classification: Unclassified OS:

[Bug 63520] r300g regression (RV380): Strange rendering of light sources in Penumbra (bisected)

2013-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=63520 Tom Stellard changed: What|Removed |Added Attachment #79572|0 |1 is obsolete|

Re: [PATCH] drm/omap: change "!CONFIG_FB_OMAP2" to "!FB_OMAP2"

2013-06-15 Thread Thierry Reding
On Wed, Mar 13, 2013 at 08:48:22PM +0100, Paul Bolle wrote: > Signed-off-by: Paul Bolle > --- > Untested. Perhaps the first test that people with access to the relevant > hardware might do, is to test _before applying this patch_ with FB_OMAP2 > set. Perhaps this negative dependency isn't needed a

Re: [PATCH] drm/omap: change "!CONFIG_FB_OMAP2" to "!FB_OMAP2"

2013-06-15 Thread Rob Clark
On Thu, Jun 13, 2013 at 6:31 AM, Paul Bolle wrote: > On Wed, 2013-03-13 at 20:48 +0100, Paul Bolle wrote: >> Signed-off-by: Paul Bolle >> --- >> Untested. Perhaps the first test that people with access to the relevant >> hardware might do, is to test _before applying this patch_ with FB_OMAP2 >>

[Bug 65787] New: r600g: corruption in menu in "stunt rally"

2013-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65787 Priority: medium Bug ID: 65787 Assignee: dri-devel@lists.freedesktop.org Summary: r600g: corruption in menu in "stunt rally" Severity: normal Classification: Unclassified OS:

[Bug 65787] r600g: corruption in menu in "stunt rally"

2013-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65787 --- Comment #1 from Harald Judt --- Problem with similar elements in game. But other texts are readable. -- You are receiving this mail because: You are the assignee for the bug. ___ dri-devel mailing

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Aaron Lu
On 06/10/2013 07:01 AM, Matthew Garrett wrote: > Windows 8 leaves backlight control up to individual graphics drivers rather > than making ACPI calls itself. There's plenty of evidence to suggest that > the Intel driver for Windows doesn't use the ACPI interface, including the > fact that it's brok

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-15 Thread Russell King - ARM Linux
On Fri, Jun 14, 2013 at 03:53:41PM +0200, Daniel Vetter wrote: > On Thu, Jun 13, 2013 at 12:50:16PM +0100, Russell King - ARM Linux wrote: > > On Thu, Jun 13, 2013 at 12:19:03PM +0100, Russell King - ARM Linux wrote: > > > The deeper I look, the more bugs there seem to be in this DRM stuff, > > > a

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-15 Thread Russell King - ARM Linux
On Fri, Jun 14, 2013 at 04:23:22PM +0200, Daniel Vetter wrote: > On Thu, Jun 13, 2013 at 3:03 PM, Russell King - ARM Linux > wrote: > > There's a bigger issue here - if it's possible for > > drm_crtc_helper_set_config() > > to be called with set->fb set but set->mode NULL, then we overwrite > > s

Re: [PATCH v2 2/4] gpu: host1x: add runtime pm support for gr2d

2013-06-15 Thread Mayuresh Kulkarni
On Thursday 13 June 2013 08:44 PM, Stephen Warren wrote: On 06/13/2013 03:53 AM, Mayuresh Kulkarni wrote: Patch description? I thought the patch subject is sufficient to tell what it is it doing. Description here would be repetition in my opinion. Also, the cover letter for the patch-set se

Re: [PATCH v2 3/4] gpu: host1x: add runtime pm support for dc

2013-06-15 Thread Mayuresh Kulkarni
On Friday 14 June 2013 12:39 AM, Stephen Warren wrote: On 06/13/2013 12:49 PM, Thierry Reding wrote: On Thu, Jun 13, 2013 at 03:23:37PM +0530, Mayuresh Kulkarni wrote: [...] diff --git a/drivers/gpu/host1x/drm/dc.c b/drivers/gpu/host1x/drm/dc.c [...] @@ -1128,9 +1129,7 @@ static int tegra_dc_

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Matthew Garrett
On Fri, 2013-06-14 at 14:47 +0800, Aaron Lu wrote: > What about a priority based solution? We can introduce a new field named > priority to backlight_device and instead of calling another module's > function like the unregister one here(which cause unnecessary module > dependency), we only need to

[PATCH] drm: Initialize list in event->base.link

2013-06-15 Thread Stéphane Marchesin
The structure was kzalloced, so prev == next == NULL by default which is invalid. Signed-off-by: Stéphane Marchesin --- drivers/gpu/drm/drm_irq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c index 8bcce78..143a311 100644 --- a/drivers/

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-15 Thread Russell King - ARM Linux
On Fri, Jun 14, 2013 at 09:50:22PM +0200, Daniel Vetter wrote: > On Fri, Jun 14, 2013 at 4:42 PM, Russell King - ARM Linux > wrote: > > If you're happy with the patch I supplied, that's probably the minimal fix > > which should go to stable kernels (I'm using 3.9 here) - this also counts > > as a

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Aaron Lu
On 06/15/2013 01:29 AM, Matthew Garrett wrote: > On Fri, 2013-06-14 at 14:47 +0800, Aaron Lu wrote: > >> What about a priority based solution? We can introduce a new field named >> priority to backlight_device and instead of calling another module's >> function like the unregister one here(which c

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Matthew Garrett
On Sat, 2013-06-15 at 09:26 +0800, Aaron Lu wrote: > On 06/15/2013 01:29 AM, Matthew Garrett wrote: > > How would that work with existing userspace? > > User space tool will need to be updated to use this as stated in the > gist page, I've patches for gsd-backlight-helper and xorg-x11-drv-intel,

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Aaron Lu
On 06/15/2013 09:38 AM, Matthew Garrett wrote: > On Sat, 2013-06-15 at 09:26 +0800, Aaron Lu wrote: >> It's not easy to decide if they work or not sometimes, e.g. I came >> across a system that claims win8 in ACPI table and has an Intel GPU, >> while its ACPI video interface also works. With this p

[PATCH] drm/nouveau: fix a memory leak.

2013-06-15 Thread majianpeng
When cleanup extra stat if this object was a notifier,it should free the notifier. Signed-off-by: Jianpeng Ma --- drivers/gpu/drm/nouveau/nouveau_abi16.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_abi16.c b/drivers/gpu/drm/nouveau/nouv

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Aaron Lu
On 06/15/2013 12:19 PM, Matthew Garrett wrote: > On Sat, Jun 15, 2013 at 12:14:42PM +0800, Aaron Lu wrote: >> On 06/15/2013 09:38 AM, Matthew Garrett wrote: >>> Well, Windows 8 will only use the ACPI backlight interface if the GPU >>> driver decides to, right? So the logic for deciding whether to r

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Matthew Garrett
On Sat, Jun 15, 2013 at 08:29:15PM +0800, Aaron Lu wrote: > On 06/15/2013 12:19 PM, Matthew Garrett wrote: > > The vendor will presumably have tested that backlight control works - if > > the GPU driver uses the ACPI interface and backlight control is broken, > > then the vendor would fix it. >

[Bug 59761] New: Kernel fails to reset AMD HD5770 GPU properly and encounters OOPS. GPU reset fails - system remains in unusable state.

2013-06-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=59761 Summary: Kernel fails to reset AMD HD5770 GPU properly and encounters OOPS. GPU reset fails - system remains in unusable state. Product: Drivers Version: 2.5 Kernel Versio

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Daniel Vetter
Hi all, So to me it looks like the discussion is going in circles a bit, hence let me drop my maintainer-opinion here: 1. Matthew's patch series here looks reasonable, and if it fixes a bunch of systems (which it seems to) it has my Ack and imo should go in. If acpi maintainers can smash their Ac

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Matthew Garrett
On Sat, Jun 15, 2013 at 08:29:42PM +0200, Daniel Vetter wrote: > Aside at the end: If the gnome tool indeed has its own backlight code and > doesn't just use that as a fallback if the xrandr backligh property isn't > available, then that's just a serious bug in gnome and should be fixed > asap. Bu

Re: [PATCH] drm: Initialize list in event->base.link

2013-06-15 Thread Daniel Vetter
On Fri, Jun 14, 2013 at 01:39:05PM -0700, Stéphane Marchesin wrote: > The structure was kzalloced, so prev == next == NULL by default which > is invalid. > > Signed-off-by: Stéphane Marchesin We do a list_add_tail which doesn't seem to care about unitizalized list items, and when removing it we

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Rafael J. Wysocki
On Saturday, June 15, 2013 08:29:42 PM Daniel Vetter wrote: > Hi all, > > So to me it looks like the discussion is going in circles a bit, hence let > me drop my maintainer-opinion here: > > 1. Matthew's patch series here looks reasonable, and if it fixes a bunch > of systems (which it seems to)

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Daniel Vetter
On Sat, Jun 15, 2013 at 10:27:06PM +0200, Rafael J. Wysocki wrote: > On Saturday, June 15, 2013 08:29:42 PM Daniel Vetter wrote: > > Hi all, > > > > So to me it looks like the discussion is going in circles a bit, hence let > > me drop my maintainer-opinion here: > > > > 1. Matthew's patch series

[PATCH] drm/crtc-helper: explicit DPMS on after modeset

2013-06-15 Thread Daniel Vetter
Atm the crtc helper implementation of set_config has really inconsisten semantics: If just an fb update is good enough, dpms state will be left as-is, but if we do a full modeset we force everything to dpms on. This change has already been applied to the i915 modeset code in commit e3de42b68478a8

[PATCH] drm/crtc-helper: don't disable disconnected outputs

2013-06-15 Thread Daniel Vetter
This has originally been added in commit a3a0544b2c84e1d7a2022b558ecf66d8c6a8dd93 Author: Dave Airlie Date: Mon Aug 31 15:16:30 2009 +1000 drm/kms: add explicit encoder disable function and detach harder. I think it's the wrong thing to do for a few reasons: - It's policy in the kernel. U

[Bug 65803] New: r600g: segfault with Kerbal Space Program

2013-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65803 Priority: medium Bug ID: 65803 Assignee: dri-devel@lists.freedesktop.org Summary: r600g: segfault with Kerbal Space Program Severity: normal Classification: Unclassified OS:

[Bug 63520] r300g regression (RV380): Strange rendering of light sources in Penumbra (bisected)

2013-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=63520 Tom Stellard changed: What|Removed |Added Attachment #79572|0 |1 is obsolete|

Re: [PATCH] drm/omap: change "!CONFIG_FB_OMAP2" to "!FB_OMAP2"

2013-06-15 Thread Thierry Reding
On Wed, Mar 13, 2013 at 08:48:22PM +0100, Paul Bolle wrote: > Signed-off-by: Paul Bolle > --- > Untested. Perhaps the first test that people with access to the relevant > hardware might do, is to test _before applying this patch_ with FB_OMAP2 > set. Perhaps this negative dependency isn't needed a

Re: [PATCH] drm/omap: change "!CONFIG_FB_OMAP2" to "!FB_OMAP2"

2013-06-15 Thread Rob Clark
On Thu, Jun 13, 2013 at 6:31 AM, Paul Bolle wrote: > On Wed, 2013-03-13 at 20:48 +0100, Paul Bolle wrote: >> Signed-off-by: Paul Bolle >> --- >> Untested. Perhaps the first test that people with access to the relevant >> hardware might do, is to test _before applying this patch_ with FB_OMAP2 >>

[Bug 65787] New: r600g: corruption in menu in "stunt rally"

2013-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65787 Priority: medium Bug ID: 65787 Assignee: dri-devel@lists.freedesktop.org Summary: r600g: corruption in menu in "stunt rally" Severity: normal Classification: Unclassified OS:

[Bug 65787] r600g: corruption in menu in "stunt rally"

2013-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65787 --- Comment #1 from Harald Judt --- Problem with similar elements in game. But other texts are readable. -- You are receiving this mail because: You are the assignee for the bug. ___ dri-devel mailing

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Aaron Lu
On 06/10/2013 07:01 AM, Matthew Garrett wrote: > Windows 8 leaves backlight control up to individual graphics drivers rather > than making ACPI calls itself. There's plenty of evidence to suggest that > the Intel driver for Windows doesn't use the ACPI interface, including the > fact that it's brok

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-15 Thread Russell King - ARM Linux
On Fri, Jun 14, 2013 at 03:53:41PM +0200, Daniel Vetter wrote: > On Thu, Jun 13, 2013 at 12:50:16PM +0100, Russell King - ARM Linux wrote: > > On Thu, Jun 13, 2013 at 12:19:03PM +0100, Russell King - ARM Linux wrote: > > > The deeper I look, the more bugs there seem to be in this DRM stuff, > > > a

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-15 Thread Russell King - ARM Linux
On Fri, Jun 14, 2013 at 04:23:22PM +0200, Daniel Vetter wrote: > On Thu, Jun 13, 2013 at 3:03 PM, Russell King - ARM Linux > wrote: > > There's a bigger issue here - if it's possible for > > drm_crtc_helper_set_config() > > to be called with set->fb set but set->mode NULL, then we overwrite > > s

Re: [PATCH v2 2/4] gpu: host1x: add runtime pm support for gr2d

2013-06-15 Thread Mayuresh Kulkarni
On Thursday 13 June 2013 08:44 PM, Stephen Warren wrote: On 06/13/2013 03:53 AM, Mayuresh Kulkarni wrote: Patch description? I thought the patch subject is sufficient to tell what it is it doing. Description here would be repetition in my opinion. Also, the cover letter for the patch-set se

Re: [PATCH v2 3/4] gpu: host1x: add runtime pm support for dc

2013-06-15 Thread Mayuresh Kulkarni
On Friday 14 June 2013 12:39 AM, Stephen Warren wrote: On 06/13/2013 12:49 PM, Thierry Reding wrote: On Thu, Jun 13, 2013 at 03:23:37PM +0530, Mayuresh Kulkarni wrote: [...] diff --git a/drivers/gpu/host1x/drm/dc.c b/drivers/gpu/host1x/drm/dc.c [...] @@ -1128,9 +1129,7 @@ static int tegra_dc_

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Matthew Garrett
On Fri, 2013-06-14 at 14:47 +0800, Aaron Lu wrote: > What about a priority based solution? We can introduce a new field named > priority to backlight_device and instead of calling another module's > function like the unregister one here(which cause unnecessary module > dependency), we only need to

[PATCH] drm: Initialize list in event->base.link

2013-06-15 Thread Stéphane Marchesin
The structure was kzalloced, so prev == next == NULL by default which is invalid. Signed-off-by: Stéphane Marchesin --- drivers/gpu/drm/drm_irq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c index 8bcce78..143a311 100644 --- a/drivers/

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-15 Thread Russell King - ARM Linux
On Fri, Jun 14, 2013 at 09:50:22PM +0200, Daniel Vetter wrote: > On Fri, Jun 14, 2013 at 4:42 PM, Russell King - ARM Linux > wrote: > > If you're happy with the patch I supplied, that's probably the minimal fix > > which should go to stable kernels (I'm using 3.9 here) - this also counts > > as a

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Aaron Lu
On 06/15/2013 01:29 AM, Matthew Garrett wrote: > On Fri, 2013-06-14 at 14:47 +0800, Aaron Lu wrote: > >> What about a priority based solution? We can introduce a new field named >> priority to backlight_device and instead of calling another module's >> function like the unregister one here(which c

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Matthew Garrett
On Sat, 2013-06-15 at 09:26 +0800, Aaron Lu wrote: > On 06/15/2013 01:29 AM, Matthew Garrett wrote: > > How would that work with existing userspace? > > User space tool will need to be updated to use this as stated in the > gist page, I've patches for gsd-backlight-helper and xorg-x11-drv-intel,

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Aaron Lu
On 06/15/2013 09:38 AM, Matthew Garrett wrote: > On Sat, 2013-06-15 at 09:26 +0800, Aaron Lu wrote: >> It's not easy to decide if they work or not sometimes, e.g. I came >> across a system that claims win8 in ACPI table and has an Intel GPU, >> while its ACPI video interface also works. With this p

[PATCH] drm/nouveau: fix a memory leak.

2013-06-15 Thread majianpeng
When cleanup extra stat if this object was a notifier,it should free the notifier. Signed-off-by: Jianpeng Ma --- drivers/gpu/drm/nouveau/nouveau_abi16.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_abi16.c b/drivers/gpu/drm/nouveau/nouv

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Aaron Lu
On 06/15/2013 12:19 PM, Matthew Garrett wrote: > On Sat, Jun 15, 2013 at 12:14:42PM +0800, Aaron Lu wrote: >> On 06/15/2013 09:38 AM, Matthew Garrett wrote: >>> Well, Windows 8 will only use the ACPI backlight interface if the GPU >>> driver decides to, right? So the logic for deciding whether to r

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Matthew Garrett
On Sat, Jun 15, 2013 at 08:29:15PM +0800, Aaron Lu wrote: > On 06/15/2013 12:19 PM, Matthew Garrett wrote: > > The vendor will presumably have tested that backlight control works - if > > the GPU driver uses the ACPI interface and backlight control is broken, > > then the vendor would fix it. >

[Bug 59761] New: Kernel fails to reset AMD HD5770 GPU properly and encounters OOPS. GPU reset fails - system remains in unusable state.

2013-06-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=59761 Summary: Kernel fails to reset AMD HD5770 GPU properly and encounters OOPS. GPU reset fails - system remains in unusable state. Product: Drivers Version: 2.5 Kernel Versio

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Daniel Vetter
Hi all, So to me it looks like the discussion is going in circles a bit, hence let me drop my maintainer-opinion here: 1. Matthew's patch series here looks reasonable, and if it fixes a bunch of systems (which it seems to) it has my Ack and imo should go in. If acpi maintainers can smash their Ac

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Matthew Garrett
On Sat, Jun 15, 2013 at 08:29:42PM +0200, Daniel Vetter wrote: > Aside at the end: If the gnome tool indeed has its own backlight code and > doesn't just use that as a fallback if the xrandr backligh property isn't > available, then that's just a serious bug in gnome and should be fixed > asap. Bu

Re: [PATCH] drm: Initialize list in event->base.link

2013-06-15 Thread Daniel Vetter
On Fri, Jun 14, 2013 at 01:39:05PM -0700, Stéphane Marchesin wrote: > The structure was kzalloced, so prev == next == NULL by default which > is invalid. > > Signed-off-by: Stéphane Marchesin We do a list_add_tail which doesn't seem to care about unitizalized list items, and when removing it we

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Rafael J. Wysocki
On Saturday, June 15, 2013 08:29:42 PM Daniel Vetter wrote: > Hi all, > > So to me it looks like the discussion is going in circles a bit, hence let > me drop my maintainer-opinion here: > > 1. Matthew's patch series here looks reasonable, and if it fixes a bunch > of systems (which it seems to)

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Daniel Vetter
On Sat, Jun 15, 2013 at 10:27:06PM +0200, Rafael J. Wysocki wrote: > On Saturday, June 15, 2013 08:29:42 PM Daniel Vetter wrote: > > Hi all, > > > > So to me it looks like the discussion is going in circles a bit, hence let > > me drop my maintainer-opinion here: > > > > 1. Matthew's patch series

[PATCH] drm/crtc-helper: explicit DPMS on after modeset

2013-06-15 Thread Daniel Vetter
Atm the crtc helper implementation of set_config has really inconsisten semantics: If just an fb update is good enough, dpms state will be left as-is, but if we do a full modeset we force everything to dpms on. This change has already been applied to the i915 modeset code in commit e3de42b68478a8

[PATCH] drm/crtc-helper: don't disable disconnected outputs

2013-06-15 Thread Daniel Vetter
This has originally been added in commit a3a0544b2c84e1d7a2022b558ecf66d8c6a8dd93 Author: Dave Airlie Date: Mon Aug 31 15:16:30 2009 +1000 drm/kms: add explicit encoder disable function and detach harder. I think it's the wrong thing to do for a few reasons: - It's policy in the kernel. U

[Bug 65803] New: r600g: segfault with Kerbal Space Program

2013-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65803 Priority: medium Bug ID: 65803 Assignee: dri-devel@lists.freedesktop.org Summary: r600g: segfault with Kerbal Space Program Severity: normal Classification: Unclassified OS:

[Bug 63520] r300g regression (RV380): Strange rendering of light sources in Penumbra (bisected)

2013-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=63520 Tom Stellard changed: What|Removed |Added Attachment #79572|0 |1 is obsolete|

Re: [PATCH] drm/omap: change "!CONFIG_FB_OMAP2" to "!FB_OMAP2"

2013-06-15 Thread Thierry Reding
On Wed, Mar 13, 2013 at 08:48:22PM +0100, Paul Bolle wrote: > Signed-off-by: Paul Bolle > --- > Untested. Perhaps the first test that people with access to the relevant > hardware might do, is to test _before applying this patch_ with FB_OMAP2 > set. Perhaps this negative dependency isn't needed a

Re: [PATCH] drm/omap: change "!CONFIG_FB_OMAP2" to "!FB_OMAP2"

2013-06-15 Thread Rob Clark
On Thu, Jun 13, 2013 at 6:31 AM, Paul Bolle wrote: > On Wed, 2013-03-13 at 20:48 +0100, Paul Bolle wrote: >> Signed-off-by: Paul Bolle >> --- >> Untested. Perhaps the first test that people with access to the relevant >> hardware might do, is to test _before applying this patch_ with FB_OMAP2 >>

[Bug 65787] New: r600g: corruption in menu in "stunt rally"

2013-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65787 Priority: medium Bug ID: 65787 Assignee: dri-devel@lists.freedesktop.org Summary: r600g: corruption in menu in "stunt rally" Severity: normal Classification: Unclassified OS:

[Bug 65787] r600g: corruption in menu in "stunt rally"

2013-06-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=65787 --- Comment #1 from Harald Judt --- Problem with similar elements in game. But other texts are readable. -- You are receiving this mail because: You are the assignee for the bug. ___ dri-devel mailing

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Aaron Lu
On 06/10/2013 07:01 AM, Matthew Garrett wrote: > Windows 8 leaves backlight control up to individual graphics drivers rather > than making ACPI calls itself. There's plenty of evidence to suggest that > the Intel driver for Windows doesn't use the ACPI interface, including the > fact that it's brok

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-15 Thread Russell King - ARM Linux
On Fri, Jun 14, 2013 at 03:53:41PM +0200, Daniel Vetter wrote: > On Thu, Jun 13, 2013 at 12:50:16PM +0100, Russell King - ARM Linux wrote: > > On Thu, Jun 13, 2013 at 12:19:03PM +0100, Russell King - ARM Linux wrote: > > > The deeper I look, the more bugs there seem to be in this DRM stuff, > > > a

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-15 Thread Russell King - ARM Linux
On Fri, Jun 14, 2013 at 04:23:22PM +0200, Daniel Vetter wrote: > On Thu, Jun 13, 2013 at 3:03 PM, Russell King - ARM Linux > wrote: > > There's a bigger issue here - if it's possible for > > drm_crtc_helper_set_config() > > to be called with set->fb set but set->mode NULL, then we overwrite > > s

Re: [PATCH v2 2/4] gpu: host1x: add runtime pm support for gr2d

2013-06-15 Thread Mayuresh Kulkarni
On Thursday 13 June 2013 08:44 PM, Stephen Warren wrote: On 06/13/2013 03:53 AM, Mayuresh Kulkarni wrote: Patch description? I thought the patch subject is sufficient to tell what it is it doing. Description here would be repetition in my opinion. Also, the cover letter for the patch-set se

Re: [PATCH v2 3/4] gpu: host1x: add runtime pm support for dc

2013-06-15 Thread Mayuresh Kulkarni
On Friday 14 June 2013 12:39 AM, Stephen Warren wrote: On 06/13/2013 12:49 PM, Thierry Reding wrote: On Thu, Jun 13, 2013 at 03:23:37PM +0530, Mayuresh Kulkarni wrote: [...] diff --git a/drivers/gpu/host1x/drm/dc.c b/drivers/gpu/host1x/drm/dc.c [...] @@ -1128,9 +1129,7 @@ static int tegra_dc_

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Matthew Garrett
On Fri, 2013-06-14 at 14:47 +0800, Aaron Lu wrote: > What about a priority based solution? We can introduce a new field named > priority to backlight_device and instead of calling another module's > function like the unregister one here(which cause unnecessary module > dependency), we only need to

[PATCH] drm: Initialize list in event->base.link

2013-06-15 Thread Stéphane Marchesin
The structure was kzalloced, so prev == next == NULL by default which is invalid. Signed-off-by: Stéphane Marchesin --- drivers/gpu/drm/drm_irq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c index 8bcce78..143a311 100644 --- a/drivers/

Re: [PATCH RFC 2/8] DRM: Armada: Add Armada DRM driver

2013-06-15 Thread Russell King - ARM Linux
On Fri, Jun 14, 2013 at 09:50:22PM +0200, Daniel Vetter wrote: > On Fri, Jun 14, 2013 at 4:42 PM, Russell King - ARM Linux > wrote: > > If you're happy with the patch I supplied, that's probably the minimal fix > > which should go to stable kernels (I'm using 3.9 here) - this also counts > > as a

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Aaron Lu
On 06/15/2013 01:29 AM, Matthew Garrett wrote: > On Fri, 2013-06-14 at 14:47 +0800, Aaron Lu wrote: > >> What about a priority based solution? We can introduce a new field named >> priority to backlight_device and instead of calling another module's >> function like the unregister one here(which c

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Matthew Garrett
On Sat, 2013-06-15 at 09:26 +0800, Aaron Lu wrote: > On 06/15/2013 01:29 AM, Matthew Garrett wrote: > > How would that work with existing userspace? > > User space tool will need to be updated to use this as stated in the > gist page, I've patches for gsd-backlight-helper and xorg-x11-drv-intel,

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

2013-06-15 Thread Aaron Lu
On 06/15/2013 09:38 AM, Matthew Garrett wrote: > On Sat, 2013-06-15 at 09:26 +0800, Aaron Lu wrote: >> It's not easy to decide if they work or not sometimes, e.g. I came >> across a system that claims win8 in ACPI table and has an Intel GPU, >> while its ACPI video interface also works. With this p

[PATCH] drm/nouveau: fix a memory leak.

2013-06-15 Thread majianpeng
When cleanup extra stat if this object was a notifier,it should free the notifier. Signed-off-by: Jianpeng Ma --- drivers/gpu/drm/nouveau/nouveau_abi16.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_abi16.c b/drivers/gpu/drm/nouveau/nouv

  1   2   >