[Mesa-dev] [PATCH] glx/dri3: Provide error diagnostics when DRI3 allocation fails

2014-09-30 Thread Keith Packard
available Type: application/pgp-signature Size: 810 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140930/3203225b/attachment.sig>

[PATCH v9 3/3] dt-bindings: video: Add documentation for rockchip vop

2014-09-30 Thread Mark Yao
From: Mark yao This adds binding documentation for Rockchip SoC VOP driver. Signed-off-by: Mark Yao --- Changes in v2: - rename "lcdc" to "vop" - add vop reset - add iommu node - add port for display-subsystem Changes in v3: None Changes in v4: None Changes in v5: None Changes in v6: None

[PATCH v9 2/3] dt-bindings: video: Add for rockchip display subsytem

2014-09-30 Thread Mark Yao
From: Mark yao This add a display subsystem comprise the all display interface nodes. Signed-off-by: Mark Yao --- Changes in v2: - add DRM master device node to list all display nodes that comprise the graphics subsystem. Changes in v3: None Changes in v4: None Changes in v5: None Changes

[PATCH v9 1/3] drm: rockchip: Add basic drm driver

2014-09-30 Thread Mark Yao
From: Mark yao This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-off-by: Mark Yao Signed-off-by: Daniel Kurtz Acked-by: Daniel Vetter Reviewed-by: Rob Clark --- Changes in v2: - use the component framework to defer main drm driver probe until all VOP devices hav

[PATCH v9 0/3] Add drm driver for Rockchip Socs

2014-09-30 Thread Mark Yao
This a series of patches is a DRM Driver for Rockchip Socs, add support for vop devices. Future patches will add additional encoders/connectors, such as eDP, HDMI. The basic "crtc" for rockchip is a "VOP" - Video Output Processor. the vop devices found on Rockchip rk3288 Soc, rk3288 soc have two s

[Mesa-dev] [PATCH] glx/dri3: Provide error diagnostics when DRI3 allocation fails

2014-09-30 Thread Matt Turner
On Tue, Sep 30, 2014 at 8:09 PM, Keith Packard wrote: > Instead of just segfaulting in the driver when a buffer allocation fails, > report error messages indicating what went wrong so that we can debug things. > > As a simple example, chromium wraps Mesa in a sandbox which doesn't allow > access t

[PATCH v6 2/2] drm/i2c:tda998x: Use the HDMI audio CODEC

2014-09-30 Thread Mark Brown
was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: Digital signature URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140930/25764887/attachment.sig>

[PATCH v6 0/2] ASoC: tda998x: add a codec to the HDMI transmitter

2014-09-30 Thread Mark Brown
n-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: Digital signature URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140930/403af0a9/attachment-0001.sig>

[PATCH] glx/dri3: Provide error diagnostics when DRI3 allocation fails

2014-09-30 Thread Keith Packard
Instead of just segfaulting in the driver when a buffer allocation fails, report error messages indicating what went wrong so that we can debug things. As a simple example, chromium wraps Mesa in a sandbox which doesn't allow access to most syscalls, including the ability to create shared memory s

[PATCH] drm/core: use helper to check driver features

2014-09-30 Thread Andrzej Hajda
The patch replaces direct access to driver_features field by calls to helper function. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/drm_drv.c | 4 ++-- drivers/gpu/drm/drm_fops.c | 8 drivers/gpu/drm/drm_gem.c | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --gi

[Bug 84519] New: GPU hang xbmc tvheadend uvd

2014-09-30 Thread bugzilla-dae...@freedesktop.org
ng this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140930/02f1f067/attachment.html>

[PATCH v8 2/3] dt-bindings: video: Add for rockchip display subsytem

2014-09-30 Thread Mark yao
On 2014?09?30? 16:10, Daniel Vetter wrote: > On Tue, Sep 30, 2014 at 02:14:19PM +0800, Mark Yao wrote: >> From: Mark yao >> >> This add a display subsystem comprise the all display interface nodes. >> >> Signed-off-by: Mark Yao >> Signed-off-by: Daniel Kurtz >> Acked-by: Daniel Vetter >> Review

[PATCH v9 1/3] drm: rockchip: Add basic drm driver

2014-09-30 Thread Andrzej Hajda
Hi Mark, On 09/30/2014 03:03 PM, Mark Yao wrote: > From: Mark yao > > This patch adds the basic structure of a DRM Driver for Rockchip Socs. > > Signed-off-by: Mark Yao > Signed-off-by: Daniel Kurtz > Acked-by: Daniel Vetter > Reviewed-by: Rob Clark > --- > Changes in v2: > - use the compon

[PATCH] drm/omap: move rotation property to drm core mode_config

2014-09-30 Thread Tomi Valkeinen
On 30/09/14 14:52, Daniel Vetter wrote: > On Tue, Sep 30, 2014 at 01:49:20PM +0200, Daniel Vetter wrote: >> On Tue, Sep 30, 2014 at 02:42:01PM +0300, Tomi Valkeinen wrote: >>> On 06/08/14 11:40, Daniel Vetter wrote: This allows us to ditch the driver-private lastclose logic. Cc: Tomi

[PATCH] drm/omap: move rotation property to drm core mode_config

2014-09-30 Thread Daniel Vetter
On Tue, Sep 30, 2014 at 03:15:07PM +0300, Tomi Valkeinen wrote: > On 30/09/14 14:52, Daniel Vetter wrote: > > On Tue, Sep 30, 2014 at 01:49:20PM +0200, Daniel Vetter wrote: > >> On Tue, Sep 30, 2014 at 02:42:01PM +0300, Tomi Valkeinen wrote: > >>> On 06/08/14 11:40, Daniel Vetter wrote: > This

[PATCH] drm/i915: don't crash if unable to setup stolen

2014-09-30 Thread Rob Clark
On this baytrail NUC I would see: *ERROR* conflict detected with stolen region: [0xbb00 - 0xbf00] Since stolen region is not setup, dev_priv->mm.stolen would not be initialized, which results that vlv_pctx is not allocated in valleyview_setup_pctx() which results in things going BOOM in

[PATCH] drm/omap: move rotation property to drm core mode_config

2014-09-30 Thread Tomi Valkeinen
ry if you point me to a git tree with the patch. Tomi -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: OpenPGP digital signature URL: <http://lists.freedesktop.org/archives/dri-devel

[PATCH 1/2] video/fbdev: Always built-in video= cmdline parsing

2014-09-30 Thread Tomi Valkeinen
/fb_cmdline.c Sorry for late response. Looks fine for me, and I'm fine merging it via drm-next. Acked-by: Tomi Valkeinen Tomi -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: OpenPGP digital signature URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140930/8c79ea67/attachment.sig>

[Bug 85311] radeon 0000:01:00.0: Max Payload Size 16384, but upstream 0000:00:01.0 set to 128; if necessary, use "pci=pcie_bus_safe" and report a bug

2014-09-30 Thread bugzilla-dae...@bugzilla.kernel.org
https://bugzilla.kernel.org/show_bug.cgi?id=85311 Bjorn Helgaas changed: What|Removed |Added CC||bhelgaas at google.com Regression

[PATCH v8 3/3] dt-bindings: video: Add documentation for rockchip vop

2014-09-30 Thread Mark Yao
From: Mark yao This adds binding documentation for Rockchip SoC VOP driver. Signed-off-by: Mark Yao Acked-by: Daniel Vetter Reviewed-by: Rob Clark --- Changes in v2: - rename "lcdc" to "vop" - add vop reset - add iommu node - add port for display-subsystem Changes in v3: None Changes in v4:

[PATCH v8 2/3] dt-bindings: video: Add for rockchip display subsytem

2014-09-30 Thread Mark Yao
From: Mark yao This add a display subsystem comprise the all display interface nodes. Signed-off-by: Mark Yao Signed-off-by: Daniel Kurtz Acked-by: Daniel Vetter Reviewed-by: Rob Clark --- Changes in v2: - add DRM master device node to list all display nodes that comprise the graphics subs

[PATCH v8 1/3] drm: rockchip: Add basic drm driver

2014-09-30 Thread Mark Yao
From: Mark yao This patch adds the basic structure of a DRM Driver for Rockchip Socs. Signed-off-by: Mark Yao Signed-off-by: Daniel Kurtz Acked-by: Daniel Vetter Reviewed-by: Rob Clark --- Changes in v2: - use the component framework to defer main drm driver probe until all VOP devices hav

[PATCH v8 0/3] Add drm driver for Rockchip Socs

2014-09-30 Thread Mark Yao
This a series of patches is a DRM Driver for Rockchip Socs, add support for vop devices. Future patches will add additional encoders/connectors, such as eDP, HDMI. The basic "crtc" for rockchip is a "VOP" - Video Output Processor. the vop devices found on Rockchip rk3288 Soc, rk3288 soc have two s

[PATCH 1/2] video/fbdev: Always built-in video= cmdline parsing

2014-09-30 Thread Daniel Vetter
On Tue, Sep 30, 2014 at 1:40 PM, Tomi Valkeinen wrote: > On 06/08/14 15:52, Daniel Vetter wrote: >> In drm/i915 we want to get at the video= cmdline modes even when we >> don't have fbdev support enabled, so that users can always override >> the kernel's initial mode selection. >> >> But that giv

[PATCH] drm/omap: move rotation property to drm core mode_config

2014-09-30 Thread Daniel Vetter
On Tue, Sep 30, 2014 at 01:49:20PM +0200, Daniel Vetter wrote: > On Tue, Sep 30, 2014 at 02:42:01PM +0300, Tomi Valkeinen wrote: > > On 06/08/14 11:40, Daniel Vetter wrote: > > > This allows us to ditch the driver-private lastclose logic. > > > > > > Cc: Tomi Valkeinen > > > Cc: Rob Clark > > >

[PATCH] drm/omap: move rotation property to drm core mode_config

2014-09-30 Thread Daniel Vetter
On Tue, Sep 30, 2014 at 02:42:01PM +0300, Tomi Valkeinen wrote: > On 06/08/14 11:40, Daniel Vetter wrote: > > This allows us to ditch the driver-private lastclose logic. > > > > Cc: Tomi Valkeinen > > Cc: Rob Clark > > Signed-off-by: Daniel Vetter > > > > -- > > > > Untested and atm only appl

[Bug 85311] radeon 0000:01:00.0: Max Payload Size 16384, but upstream 0000:00:01.0 set to 128; if necessary, use "pci=pcie_bus_safe" and report a bug

2014-09-30 Thread bugzilla-dae...@bugzilla.kernel.org
https://bugzilla.kernel.org/show_bug.cgi?id=85311 Alex Deucher changed: What|Removed |Added CC||alexdeucher at gmail.com --- Comment #1 fr

[Bug 82050] R9270X pyrit benchmark perf regressions with latest kernel/llvm

2014-09-30 Thread bugzilla-dae...@freedesktop.org
gnee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140930/80e95795/attachment.html>

[PATCH] drm/exynos: remove ifdeferry from initialization code

2014-09-30 Thread Andrzej Hajda
Hi Inki, Gently ping. Andrzej On 09/10/2014 01:53 PM, Andrzej Hajda wrote: > The patch replaces separate calls to driver (de)registration by > loops over the array of drivers. As a result it significantly > decreases number of ifdefs. Additionally it moves device registration > related ifdefs to

[Bug 84500] [radeonsi] radeon 0000:01:00.0: Packet0 not allowed!

2014-09-30 Thread bugzilla-dae...@freedesktop.org
hit the error, please attach the full output of the CS. -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140930/572c340a/attachment.html>

[Bug 84500] [radeonsi] radeon 0000:01:00.0: Packet0 not allowed!

2014-09-30 Thread bugzilla-dae...@freedesktop.org
v var later today. -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140930/c9eb27be/attachment.html>

[Bug 81644] Random crashes on RadeonSI with Chromium.

2014-09-30 Thread bugzilla-dae...@freedesktop.org
tered what issue(s) under what circumstances. I opened Bug 84500 just for Packet0. -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140930/0d5ce1df/attachment.html>

[Bug 83792] Kernel hangs on boot without nomodeset option

2014-09-30 Thread bugzilla-dae...@freedesktop.org
netconsole works, can you get remote access to the box (e.g., ssh) as well or does it hang completely? -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archive

[PATCH libdrm 1/3] intel/skl: Add SKL PCI ids

2014-09-30 Thread Damien Lespiau
On Tue, Sep 30, 2014 at 11:19:37AM +0100, Thomas Wood wrote: > On 26 September 2014 14:19, Damien Lespiau > wrote: > > v2: Add more PCI IDs (Michael H. Nguyen) > > v3: Synchronize one more with the kernel PCI IDs (Damien) > > > > Signed-off-by: Damien Lespiau > > Signed-off-by: Ben Widawsky > >

[PATCH v2 1/5] video: move mediabus format definition to a more standard place

2014-09-30 Thread Boris Brezillon
On Tue, 30 Sep 2014 10:39:53 +0200 Thierry Reding wrote: > On Tue, Sep 30, 2014 at 09:37:57AM +0200, Boris Brezillon wrote: > > On Mon, 29 Sep 2014 23:41:09 +0300 > > Laurent Pinchart wrote: > [...] > > > Incidentally, patch 2/5 in this series is missing a documentation update > > > ;-) > > >

[PATCH libdrm 1/3] intel/skl: Add SKL PCI ids

2014-09-30 Thread Thomas Wood
On 26 September 2014 14:19, Damien Lespiau wrote: > v2: Add more PCI IDs (Michael H. Nguyen) > v3: Synchronize one more with the kernel PCI IDs (Damien) > > Signed-off-by: Damien Lespiau > Signed-off-by: Ben Widawsky > Signed-off-by: Michael H. Nguyen Reviewed-by: Thomas Wood > --- > intel/

[Bug 83792] Kernel hangs on boot without nomodeset option

2014-09-30 Thread bugzilla-dae...@freedesktop.org
archives/dri-devel/attachments/20140930/19ca796d/attachment-0001.html>

[Bug 82050] R9270X pyrit benchmark perf regressions with latest kernel/llvm

2014-09-30 Thread bugzilla-dae...@freedesktop.org
n have a look if I can manually see how to do it. -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140930/705a3b1a/attachment.html>

[Bug 83792] Kernel hangs on boot without nomodeset option

2014-09-30 Thread bugzilla-dae...@freedesktop.org
-- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140930/e10d26e6/attachment.html>

[PATCH v2 1/5] video: move mediabus format definition to a more standard place

2014-09-30 Thread Thierry Reding
t part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140930/f9b553a2/attachment.sig>

[Bug 85311] New: radeon 0000:01:00.0: Max Payload Size 16384, but upstream 0000:00:01.0 set to 128; if necessary, use "pci=pcie_bus_safe" and report a bug

2014-09-30 Thread bugzilla-dae...@bugzilla.kernel.org
https://bugzilla.kernel.org/show_bug.cgi?id=85311 Bug ID: 85311 Summary: radeon :01:00.0: Max Payload Size 16384, but upstream :00:01.0 set to 128; if necessary, use "pci=pcie_bus_safe" and report a bug Product: Driv

[PATCH v8 2/3] dt-bindings: video: Add for rockchip display subsytem

2014-09-30 Thread Daniel Vetter
On Tue, Sep 30, 2014 at 10:10:20AM +0200, Daniel Vetter wrote: > On Tue, Sep 30, 2014 at 02:14:19PM +0800, Mark Yao wrote: > > From: Mark yao > > > > This add a display subsystem comprise the all display interface nodes. > > > > Signed-off-by: Mark Yao > > Signed-off-by: Daniel Kurtz > > Acked

[RFC] Explicit synchronization for Nouveau

2014-09-30 Thread Daniel Vetter
On Mon, Sep 29, 2014 at 10:20:44AM -0700, James Jones wrote: > Additionally, I think the goal is to move to a model where some higher-level > object such as a working set, rather than individual buffers, are assigned > counters or sync primitives on a per-submission basis. Versioning off tags > fo

[PATCH] drm/radeon: remove unecessary includes

2014-09-30 Thread Christian König
Am 30.09.2014 um 04:46 schrieb Alex Deucher: > The requirement for these was removed in: > 0a168933976eb483da91161316cb74d00486 > > Signed-off-by: Alex Deucher Reviewed-by: Christian K?nig > --- > drivers/gpu/drm/radeon/evergreen.c | 1 - > drivers/gpu/drm/radeon/rv770.c | 1 - > 2

[PATCH v8 2/3] dt-bindings: video: Add for rockchip display subsytem

2014-09-30 Thread Heiko Stübner
Am Dienstag, 30. September 2014, 10:10:20 schrieb Daniel Vetter: > On Tue, Sep 30, 2014 at 02:14:19PM +0800, Mark Yao wrote: > > From: Mark yao > > > > This add a display subsystem comprise the all display interface nodes. > > > > Signed-off-by: Mark Yao > > Signed-off-by: Daniel Kurtz > > Ack

[PATCH v8 2/3] dt-bindings: video: Add for rockchip display subsytem

2014-09-30 Thread Daniel Vetter
On Tue, Sep 30, 2014 at 02:14:19PM +0800, Mark Yao wrote: > From: Mark yao > > This add a display subsystem comprise the all display interface nodes. > > Signed-off-by: Mark Yao > Signed-off-by: Daniel Kurtz > Acked-by: Daniel Vetter > Reviewed-by: Rob Clark Just a quick clarification: My a

[PATCH] drm/radeon/cik: write gfx ucode version to ucode addr reg

2014-09-30 Thread Alex Deucher
Helpful for debugging as the version shows up in a register dump. Cc: Jay Cornwall Signed-off-by: Alex Deucher --- drivers/gpu/drm/radeon/cik.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c inde

[PATCH v2 1/5] video: move mediabus format definition to a more standard place

2014-09-30 Thread Boris Brezillon
On Mon, 29 Sep 2014 23:41:09 +0300 Laurent Pinchart wrote: > Hi Boris, > > Thank you for the patch. > > On Monday 29 September 2014 16:02:39 Boris Brezillon wrote: > > Rename mediabus formats and move the enum into a separate header file so > > that it can be used by DRM/KMS subsystem without a

[Bug 82050] R9270X pyrit benchmark perf regressions with latest kernel/llvm

2014-09-30 Thread bugzilla-dae...@freedesktop.org
--- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140930/b7bf1bf1/attachment-0001.html>

[RESENT PATCH v7 1/3] drm: rockchip: Add basic drm driver

2014-09-30 Thread Mark yao
On 2014?09?29? 12:01, Daniel Kurtz wrote: > Hi Mark, > > More review comments inline... (sorry for the delay) Thanks for your review. > > On Fri, Sep 26, 2014 at 6:55 PM, Mark Yao wrote: >> From: Mark yao >> >> This patch adds the basic structure of a DRM Driver for Rockchip Socs. >> >> Signed-of

[Bug 82050] R9270X pyrit benchmark perf regressions with latest kernel/llvm

2014-09-30 Thread bugzilla-dae...@freedesktop.org
lp by the way. Has there been any progress? -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140930/9f64f886/attachment.html>

[Bug 84500] [radeonsi] radeon 0000:01:00.0: Packet0 not allowed!

2014-09-30 Thread bugzilla-dae...@freedesktop.org
bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140930/b41990f9/attachment.html>

[Bug 81644] Random crashes on RadeonSI with Chromium.

2014-09-30 Thread bugzilla-dae...@freedesktop.org
ng this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140930/8bb889df/attachment.html>

[Bug 83500] si_dma_copy_tile causes GPU hangs

2014-09-30 Thread bugzilla-dae...@freedesktop.org
-- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140930/e0cbc02a/attachment-0001.html>

[Bug 84500] [radeonsi] radeon 0000:01:00.0: Packet0 not allowed!

2014-09-30 Thread bugzilla-dae...@freedesktop.org
was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140930/a0d0e097/attachment.html>

[Bug 84500] New: [radeonsi] radeon 0000:01:00.0: Packet0 not allowed!

2014-09-30 Thread bugzilla-dae...@freedesktop.org
nt was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140930/4b753c18/attachment.html>

[Bug 81644] Random crashes on RadeonSI with Chromium.

2014-09-30 Thread bugzilla-dae...@freedesktop.org
u are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140930/5263ec7a/attachment.html>

[Bug 81644] Random crashes on RadeonSI with Chromium.

2014-09-30 Thread bugzilla-dae...@freedesktop.org
the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140930/2816a417/attachment.html>

[Bug 81644] Random crashes on RadeonSI with Chromium.

2014-09-30 Thread bugzilla-dae...@freedesktop.org
-- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140930/00de3091/attachment.html>

[Bug 81644] Random crashes on RadeonSI with Chromium.

2014-09-30 Thread bugzilla-dae...@freedesktop.org
... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140930/13835f05/attachment.html>

[Bug 78221] 3.16 RC1: AMD R9 270 GPU locks up on some heavy 2D activity - GPU VM fault occurs. (possibly DMA copying issue strikes back?)

2014-09-30 Thread bugzilla-dae...@bugzilla.kernel.org
https://bugzilla.kernel.org/show_bug.cgi?id=78221 Jean-Michel Smith changed: What|Removed |Added CC||jean.michel.sm at gmail.com --- Comme