Hi again,
one bigger thing I noticed only now.
Am Freitag, 22. Juli 2016, 17:07:14 schrieben Sie:
> diff --git a/drivers/firmware/rockchip_sip.c
> b/drivers/firmware/rockchip_sip.c new file mode 100644
> index 000..7756af9
> --- /dev/null
> +++ b/drivers/firmware/rockchip_sip.c
> @@ -0,0
;https://lists.freedesktop.org/archives/dri-devel/attachments/20160722/65eacd59/attachment.html>
Yakir,
On Wed, Jul 13, 2016 at 9:15 PM, Yakir Yang wrote:
> +static void psr_set_state(struct psr_drv *psr, enum psr_state state)
> +{
> + mutex_lock(>state_mutex);
> +
> + if (psr->state == state) {
> + mutex_unlock(>state_mutex);
> + return;
> + }
are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/dri-devel/attachments/20160722/f044fea2/attachment.html>
he bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/dri-devel/attachments/20160722/4866d746/attachment.html>
part --
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/dri-devel/attachments/20160722/1ef25214/attachment.html>
tps://lists.freedesktop.org/archives/dri-devel/attachments/20160722/55fdd126/attachment.html>
--
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/dri-devel/attachments/20160722/9fa4c3e8/attachment.html>
bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/dri-devel/attachments/20160722/8a54e196/attachment.html>
On Fri, Jul 22, 2016 at 06:53:41PM +0200, Daniel Vetter wrote:
> On Fri, Jul 22, 2016 at 02:09:12PM +0200, Philipp Zabel wrote:
> > Some encoders need more information from crtc and connector state
> > than just the mode. Add an atomic encoder mode setting variant
> > that passes the crtc state
On Fri, Jul 22, 2016 at 04:30:24PM +0200, Takashi Iwai wrote:
> Hi,
>
> is there any reason drm-mipi-dsi can't be a module? It's fixed as a
> built-in since its Kconfig is bool.
Probably none except embedded folks eshew modules ;-) Submit patch, I'll
apply.
-Daniel
--
Daniel Vetter
Software
On Fri, Jul 22, 2016 at 02:09:12PM +0200, Philipp Zabel wrote:
> Some encoders need more information from crtc and connector state
> than just the mode. Add an atomic encoder mode setting variant
> that passes the crtc state (which contains the modes) and the
> connector state.
>
> Signed-off-by:
On Fri, Jul 22, 2016 at 12:57:15PM +0200, Philipp Zabel wrote:
> Am Freitag, den 22.07.2016, 11:35 +0200 schrieb Daniel Vetter:
> [...]
> > Proper fix would be to roll out atomic_ versions of all teh encoder
> > callbacks where we additionally pass both the crtc state and the connector
> > state.
From: Ville Syrjälä
The global mode_config.rotation_property is going away, switch over to
per-plane rotation_property.
v2: Propagate error upwards (Boris)
Cc: Boris Brezillon
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
Am 22.07.2016 17:48, schrieb SF Markus Elfring:
> From: Markus Elfring
> Date: Fri, 22 Jul 2016 16:45:22 +0200
>
> Move a return statement into a block for successful function execution.
> Omit a duplicate check for the local variable "ret" then at the end.
>
> Signed-off-by: Markus Elfring
From: Markus Elfring
Date: Fri, 22 Jul 2016 17:17:48 +0200
Refactor this function implementation so that the
drm_gem_object_unreference_unlocked() function will only be called once
in case of a failure according to the Linux coding style recommendation
for
From: Markus Elfring
Date: Fri, 22 Jul 2016 16:51:00 +0200
Adjust jump targets according to the Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 14 +++---
1 file changed, 7 insertions(+), 7
From: Markus Elfring
Date: Fri, 22 Jul 2016 16:45:22 +0200
Move a return statement into a block for successful function execution.
Omit a duplicate check for the local variable "ret" then at the end.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Fri, 22 Jul 2016 15:56:15 +0200
The functions drm_gem_object_unreference_unlocked() and vunmap() perform
also input parameter validation.
Thus the tests around their calls are not needed.
This issue was detected by using the Coccinelle
From: Markus Elfring
Date: Fri, 22 Jul 2016 17:34:32 +0200
Further update suggestions were taken into account
after a patch was applied from static source code analysis.
Markus Elfring (4):
Delete unnecessary checks before two function calls
Delete unnecessary
Hi Philipp,
On Fri, Jul 22, 2016 at 4:59 PM, Philipp Zabel
wrote:
> Hi Liu,
>
> thank you for your comments.
>
> Am Freitag, den 22.07.2016, 12:01 +0800 schrieb Ying Liu:
>> Hi Philipp,
>>
>> This patch's headline doesn't exactly reflect what the patch actually
>> does - retrieve lvds bus
On Fri, 22 Jul 2016, Sean Paul wrote:
> On Fri, Jul 22, 2016 at 3:22 AM, Lee Jones wrote:
> > Since 0b52297f228 ("reset: Add support for shared reset controls") the
> > new Reset API now demands consumers choose either an *_exclusive or
> > a *_shared line when requesting reset lines.
> >
> >
when in ddr frequency scaling process, vop can not do
enable or disable operate, since dcf will base on vop vblank
time to do frequency scaling and need to get vop irq if there
have vop enabled. So need register to dmc notifier, and we can
get the dmc status.
Signed-off-by: Lin Huang
---
Changes
base on dfi result, we do ddr frequency scaling, register
dmc driver to devfreq framework, and use simple-ondemand
policy.
Signed-off-by: Lin Huang
---
Changes in v3:
- operate dram setting through sip call
- imporve set rate flow
Changes in v2:
- None
Changes in v1:
- move dfi controller to
on rk3399 platform, there is dfi conroller can monitor
ddr load, base on this result, we can do ddr freqency
scaling.
Signed-off-by: Lin Huang
Acked-by: Chanwoo Choi
---
Changes in v3:
- None
Changes in v2:
- use clk_disable_unprepare and clk_enable_prepare
- remove clk_enable_prepare in probe
add ddrc clock setting, so we can do ddr frequency
scaling on rk3399 platform in future.
Signed-off-by: Lin Huang
---
Changes in v3:
- None
Changes in v2:
- remove clk_ddrc_dpll_src from critical clock list
Changes in v1:
- remove ddrc source CLK_IGNORE_UNUSED flag
- move clk_ddrc and
Signed-off-by: Lin Huang
---
Changes in v3:
-None
Changes in v2:
- None
Changes in v1:
- None
include/dt-bindings/clock/rk3399-cru.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/dt-bindings/clock/rk3399-cru.h
b/include/dt-bindings/clock/rk3399-cru.h
index 50a44cf..8a0f0442
On new rockchip platform(rk3399 etc), there have dcf controller to
do ddr frequency scaling, and this controller will implement in
arm-trust-firmware. We add a special clock-type to handle that.
Signed-off-by: Lin Huang
---
Changes in v3:
- use sip call to set/read ddr rate
Changes in v2:
- use
From: Shengfei xu
This patch adds support for the SiP interface, we can pass dram
paramtert to bl31, and control ddr frequency scaling in bl31.
Signed-off-by: Shengfei xu
Signed-off-by: Lin Huang
---
Changes in v3:
- None
Changes in v2:
- None
Changes in v1:
- None
rk3399 platform have dfi controller can monitor ddr load,
and dcf controller to handle ddr register so we can get the
right ddr frequency and make ddr controller happy work(which
will implement in bl31). So we do ddr frequency scaling with
following flow:
kernel
From: Ville Syrjälä
The primary and sprite planes on CHV pipe B support horizontal
mirroring. Expose it to the world.
Sadly the hardware ignores the mirror bit when the rotate bit is
set, so we'll have to reject the 180+X case.
Signed-off-by: Ville Syrjälä
From: Ville Syrjälä
Move the plane control register rotation setup away from the
coordinate munging code. This will result in neater looking
code once we add reflection support for CHV.
Signed-off-by: Ville Syrjälä
Reviewed-by: Chris Wilson
Reviewed-by:
From: Ville Syrjälä
Using == to check for 180 degree rotation only works as long as the
reflection bits aren't set. That will change soon enough for CHV, so
let's stop doing things the wrong way.
Signed-off-by: Ville Syrjälä
Reviewed-by: Chris Wilson
From: Ville Syrjälä
Now that all drivers have been converted over to the per-plane rotation
property, we can just nuke the global rotation property.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/drm_atomic.c| 6 ++
drivers/gpu/drm/drm_crtc.c
From: Ville Syrjälä
On certain platforms not all planes support the same set of
rotations/reflections, so let's use the per-plane property
for this.
This is already a problem on SKL when we use the legay cursor plane
as it only supports 0|180 whereas the
From: Ville Syrjälä
Since the hardware can apparently do both X and Y reflection, we
can advertize also 180 degree rotation as thats just X+Y reflection.
Cc: Rob Clark
Cc: Jilai Wang
Signed-off-by: Ville Syrjälä
---
From: Ville Syrjälä
The global mode_config.rotation_property is going away, switch over to
per-plane rotation_property.
Cc: Rob Clark
Cc: Jilai Wang
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 15 +--
1 file
From: Ville Syrjälä
0 isn't a valid rotation property value, so let's set the initial value
of the property to BIT(DRM_ROTATE_0) instead.
In the same vein, we must always have at leat one angle as part of
set of supported rotation bits, so let's include
From: Ville Syrjälä
The global mode_config.rotation_property is going away, switch over to
per-plane rotation_property.
Not sure I got the annoying crtc rotation_property handling right.
Might work, or migth not.
Cc: Tomi Valkeinen
Cc: Rob Clark
From: Ville Syrjälä
0 isn't a valid rotation property value, so let's set the initial value
of the property to BIT(DRM_ROTATE_0) instead.
Cc: Tomi Valkeinen
Cc: Rob Clark
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/omapdrm/omap_drv.c | 6 --
From: Ville Syrjälä
The global mode_config.rotation_property is going away, switch over to
per-plane rotation_property.
Cc: Boris Brezillon
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 18 ++
1 file
From: Ville Syrjälä
The global mode_config.rotation_property is going away, switch over to
per-plane rotation_property.
Cc: Liviu Dudau
Cc: Brian Starkey
Cc: Mali DP Maintainers
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/arm/malidp_planes.c | 13
From: Ville Syrjälä
Not all planes on the ssytem may support the same rotations/reflections,
so make it possible to create a separate property for each plane.
This way userspace gets told exactly which rotations/reflections are
possible for each plane.
v2: Add
From: Ville Syrjälä
The rotation property should only accept exactly one rotation angle
at once. Let's reject attempts to set none or multiple angles.
Testcase: igt/kms_rotation_crc/bad-rotation
Signed-off-by: Ville Syrjälä
Reviewed-by: Joonas Lahtinen
From: Ville Syrjälä
We have intel_rotation_90_or_270() in i915 to check if the rotation is
90 or 270 degrees. Similar checks are elsewhere in drm, so let's move
the helper into a central place and use it everwhere.
Signed-off-by: Ville Syrjälä
Reviewed-by:
From: Ville Syrjälä
Here's an expaned version of my earlier series [1]. This time I went as
far as nuking the mode_config.rotation_property in favor of the per-plane
property. Also tried to fix a few buglets in omap/msm rotation property
setup.
Entire series is
Call strcpytoupper() rather than copying the string explicitly and then
walking it to convert it to uppercase.
Signed-off-by: Markus Mayer
---
drivers/gpu/drm/nouveau/nvkm/engine/fifo/gk104.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git
Call strlcpytolower() rather than copying the string explicitly and
then walking it to convert it to lowercase.
Signed-off-by: Markus Mayer
---
The semantics of the new function has changed, so this patch has been
updated since v2 to match the new strlcpy() semantics (no explicit NULL
Add a collection of generic functions to convert strings to lowercase
or uppercase.
Changing the case of a string (with or without copying it first) seems
to be a recurring requirement in the kernel that is currently being
solved by several duplicated implementations doing the same thing. This
This series introduces a family of generic string case conversion
functions. This kind of functionality is needed in several places in
the kernel. Right now, everybody seems to be implementing their own
copy of this functionality.
Based on the discussion of the previous version of this series[1]
Hi,
is there any reason drm-mipi-dsi can't be a module? It's fixed as a
built-in since its Kconfig is bool.
thanks,
Takashi
On Fri, Jul 22, 2016 at 5:07 AM, Lin Huang wrote:
> on rk3399 platform, there is dfi conroller can monitor
> ddr load, base on this result, we can do ddr freqency
> scaling.
>
> Signed-off-by: Lin Huang
> Acked-by: Chanwoo Choi
> ---
> Changes in v3:
> - None
>
> Changes in v2:
> - use
On Fri, Jul 22, 2016 at 5:07 AM, Lin Huang wrote:
> base on dfi result, we do ddr frequency scaling, register
> dmc driver to devfreq framework, and use simple-ondemand
> policy.
>
> Signed-off-by: Lin Huang
> ---
> Changes in v3:
> - operate dram setting through sip call
> - imporve set rate
On Fri, Jul 22, 2016 at 01:52:32PM +0100, Matthew Auld wrote:
> I believe you're thinking of:
> https://patchwork.freedesktop.org/patch/77191/
> https://patchwork.freedesktop.org/patch/77192/
>
> Although they don't test for multiple rotation values...
I guess you could just
for (rotation = 0;
.
-- next part --
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/dri-devel/attachments/20160722/0d149776/attachment.html>
The core provides now an ABI to userspace for generation of frame CRCs,
so implement the ->set_crc_source() callback and reuse as much code as
possible with the previous ABI implementation.
v2:
- Leave the legacy implementation in place as the ABI implementation
in the core is
Adds files and directories to debugfs for controlling and reading frame
CRCs, per CRTC:
dri/0/crtc-0/crc
dri/0/crtc-0/crc/control
dri/0/crtc-0/crc/data
Drivers can implement the set_crc_source callback() in drm_crtc_funcs to
start and stop generating frame CRCs and can add entries to the output
In preparation to using a generic API in the DRM core for continuous CRC
generation, move the related code out of i915_debugfs.c into a new file.
Eventually, only the Intel-specific code will remain in this new file.
v2: Rebased.
Signed-off-by: Tomeu Vizoso
---
drivers/gpu/drm/i915/Makefile
Hi,
this series basically takes the facility for continuously capturing CRCs
of frames from the i915 driver and into the DRM core.
The idea is that test suites such as IGT use this information to check
that frames that are exected to be identical, also have identical CRC
values.
Other drivers
Hi Ville,
On Fri, 22 Jul 2016 16:43:06 +0300
ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä
>
> The global mode_config.rotation_property is going away, switch over to
> per-plane rotation_property.
>
> Cc: Boris Brezillon
> Signed-off-by: Ville Syrjälä
> ---
>
bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/dri-devel/attachments/20160722/e5f2aa41/attachment.html>
bug.
-- next part --
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/dri-devel/attachments/20160722/5f789669/attachment.html>
--
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/dri-devel/attachments/20160722/23378732/attachment-0001.html>
On Fri, Jul 22, 2016 at 04:43:05PM +0300, Ville Syrjälä wrote:
>From: Ville Syrjälä
>
>The global mode_config.rotation_property is going away, switch over to
>per-plane rotation_property.
>
>Cc: Liviu Dudau
>Cc: Brian Starkey
>Cc: Mali DP Maintainers
>Signed-off-by: Ville Syrjälä
From: Christian König
We still need to unbind explicitely during a move.
This partial reverts commit ff20caa0bcbfef9f7686f8d1868a3b990921afd6.
v2: remove unnecessary check and unused variable
Signed-off-by: Christian König
---
drivers/gpu/drm/ttm/ttm_bo_util.c |
From: Markus Elfring
Date: Fri, 22 Jul 2016 14:45:51 +0200
The backlight_device_unregister() function tests whether its argument
is NULL and then returns immediately.
Thus the test around the call is not needed.
This issue was detected by using the Coccinelle
version 6:
rebased patch on top rcar-du changes for zpos
version 4:
fix null pointer issue while setting zpos in plane reset function
This patch replaces zpos property handling custom code in rcar DRM
driver with calls to generic DRM code.
Signed-off-by: Benjamin Gaignard
Reviewed-by: Laurent
From: Markus Elfring
Date: Fri, 22 Jul 2016 14:14:54 +0200
The drm_gem_object_unreference_unlocked() function tests whether
its argument is NULL and then returns immediately.
Thus the test around the call is not needed.
This issue was detected by using the
Using atomic_mode_set instead of mode_set allows to access crtc
and connector states in addition to the modes. This allows to
remove the connector list walk.
Signed-off-by: Philipp Zabel
---
drivers/gpu/drm/imx/imx-ldb.c | 24 ++--
1 file changed, 10 insertions(+), 14
Some encoders need more information from crtc and connector state
than just the mode. Add an atomic encoder mode setting variant
that passes the crtc state (which contains the modes) and the
connector state.
Signed-off-by: Philipp Zabel
---
drivers/gpu/drm/drm_atomic_helper.c | 6 +-
The code in imx_ldb_encoder_mode_set crashes with a NULL pointer
dereference trying to access crtc->state->state, which was previously
cleared by drm_atomic_helper_swap_state:
Unable to handle kernel NULL pointer dereference at virtual address 0010
pgd = ae08c000
[0010]
On Fri, Jul 22, 2016 at 11:51 AM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Fri, 22 Jul 2016 17:17:48 +0200
>
> Refactor this function implementation so that the
> drm_gem_object_unreference_unlocked() function will only be called once
> in case of a failure according to the Linux
On Fri, Jul 22, 2016 at 11:47 AM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Fri, 22 Jul 2016 15:56:15 +0200
>
> The functions drm_gem_object_unreference_unlocked() and vunmap() perform
> also input parameter validation.
> Thus the tests around their calls are not needed.
>
> This
I believe you're thinking of:
https://patchwork.freedesktop.org/patch/77191/
https://patchwork.freedesktop.org/patch/77192/
Although they don't test for multiple rotation values...
On Fri, Jul 22, 2016 at 11:50 AM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Fri, 22 Jul 2016 16:51:00 +0200
>
> Adjust jump targets according to the Linux coding style convention.
>
I'm not convinced the old labels are really that bad, tbh.
Sean
> Signed-off-by: Markus Elfring
From: Markus Elfring
Date: Fri, 22 Jul 2016 13:31:00 +0200
The vfree() function performs also input parameter validation.
Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
Move things around a little in __etnaviv_gem_new() to make it
more readable.
Reported-by: Markus Elfring
Reported-by: walter harms
Signed-off-by: Sean Paul
---
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 25 +++--
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git
2016-07-21 18:10 GMT+02:00 Emil Velikov :
> On 21 July 2016 at 14:12, Andreas Boll wrote:
>> A similar change was made to mesa's copy of virtgpu_drm.h by the
>> following commit:
>>
> Please sync this using the approach shown in commit
> c745e541a9d8dfd3fb5e1ac57297e58d34d9328f.
>
> Namely:
> -
2016-07-21 18:14 GMT+02:00 Emil Velikov :
> On 21 July 2016 at 14:12, Andreas Boll wrote:
>> Currently only some Android Makefiles are included in the release tarball.
>> Add all remaining files to be more consistent.
>>
> Since Android folk never fully bought the idea of using actual
>
Generated using make headers_install.
This brings the C++ guard, proper include path for drm.h and the
switching to kernel types for fixed-with integers.
Generated from drm-next commit c11dea5b0290984fa48111957ba3fdc5b3bdae5a
Suggested-by: Emil Velikov
Signed-off-by: Andreas Boll
---
Currently only some Android Makefiles are included in the release tarball.
To be more consistent one could either add the remaining files or don't
ship Android Makefiles altogether.
According to Emil the Android folk doesn't use our release tarballs.
Thus it makes sense to remove those files from
On Tue, Jul 12, 2016 at 03:11:45PM +0200, Daniel Vetter wrote:
> On Fri, Jul 08, 2016 at 07:49:32AM +0200, Lukas Wunner wrote:
> > On Wed, Jul 06, 2016 at 01:40:25PM -0700, Darren Hart wrote:
> > > On Mon, Jul 04, 2016 at 12:40:35PM +0200, Lukas Wunner wrote:
> > > > Convert asciidoc-formatted
Am Freitag, den 22.07.2016, 11:35 +0200 schrieb Daniel Vetter:
[...]
> Proper fix would be to roll out atomic_ versions of all teh encoder
> callbacks where we additionally pass both the crtc state and the connector
> state. Then there's no need for walking connector lists like that. And in
> the
From: Markus Elfring
Date: Fri, 22 Jul 2016 12:48:12 +0200
The drm_property_unreference_blob() function tests whether its argument
is NULL and then returns immediately.
Thus the test around the call is not needed.
This issue was detected by using the Coccinelle
Am Freitag, 22. Juli 2016, 17:07:16 schrieb Lin Huang:
> Signed-off-by: Lin Huang
> ---
> Changes in v3:
> -None
>
> Changes in v2:
> - None
> Changes in v1:
> - None
>
> include/dt-bindings/clock/rk3399-cru.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
Em Wed, 20 Jul 2016 20:35:09 +0200
Markus Heiser escreveu:
> Am 20.07.2016 um 14:20 schrieb Mauro Carvalho Chehab s-opensource.com>:
>
> > Em Tue, 19 Jul 2016 14:36:50 +0200
> > Daniel Vetter escreveu:
> >
> >> On Tue, Jul 19, 2016 at 01:42:55PM +0200, Daniel Vetter wrote:
> >>> These
Hi Philipp,
This patch's headline doesn't exactly reflect what the patch actually
does - retrieve lvds bus format from imx_crtc_state during encoder
mode_set.
On Thu, Jul 21, 2016 at 9:25 PM, Philipp Zabel
wrote:
> The code in imx_ldb_encoder_mode_set crashes trying to access the
>
Hi,
Am Freitag, 22. Juli 2016, 17:07:14 schrieb Lin Huang:
> From: Shengfei xu
>
> This patch adds support for the SiP interface, we can pass dram
> paramtert to bl31, and control ddr frequency scaling in bl31.
>
> Signed-off-by: Shengfei xu
> Signed-off-by: Lin Huang
[...]
> +++
On Fri, Jul 22, 2016 at 10:59:51AM +0200, Philipp Zabel wrote:
> The code in imx_ldb_encoder_mode_set crashes with a NULL pointer
> dereference trying to access crtc->state->state, which was previously
> cleared by drm_atomic_helper_swap_state:
>
> Unable to handle kernel NULL pointer
On Fri, Jul 22, 2016 at 10:45:30AM +0200, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Fri, 22 Jul 2016 10:30:30 +0200
>
> The functions pci_dev_put() and psb_intel_i2c_destroy() test whether
> their argument is NULL and then return immediately.
> Thus the tests around their calls are
From: Markus Elfring
Date: Fri, 22 Jul 2016 11:20:27 +0200
The drm_gem_object_unreference_unlocked() function tests whether
its argument is NULL and then returns immediately.
Thus the test around the call is not needed.
This issue was detected by using the
On Fri, Jul 22, 2016 at 8:54 AM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Fri, 22 Jul 2016 14:45:51 +0200
>
> The backlight_device_unregister() function tests whether its argument
> is NULL and then returns immediately.
> Thus the test around the call is not needed.
>
> This issue
On Fri, Jul 22, 2016 at 8:22 AM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Fri, 22 Jul 2016 14:14:54 +0200
>
> The drm_gem_object_unreference_unlocked() function tests whether
> its argument is NULL and then returns immediately.
> Thus the test around the call is not needed.
>
>
On Fri, Jul 22, 2016 at 7:45 AM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Fri, 22 Jul 2016 13:31:00 +0200
>
> The vfree() function performs also input parameter validation.
> Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
On Fri, Jul 22, 2016 at 5:32 AM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Fri, 22 Jul 2016 11:20:27 +0200
>
> The drm_gem_object_unreference_unlocked() function tests whether
> its argument is NULL and then returns immediately.
> Thus the test around the call is not needed.
>
>
On Fri, Jul 22, 2016 at 3:22 AM, Lee Jones wrote:
> Since 0b52297f228 ("reset: Add support for shared reset controls") the
> new Reset API now demands consumers choose either an *_exclusive or
> a *_shared line when requesting reset lines.
>
> Signed-off-by: Lee Jones
> ---
>
Am Freitag, den 22.07.2016, 10:59 +0200 schrieb Philipp Zabel:
> + struct drm_crtc_state *crtc_state = encoder->crtc->state;
Sorry, this is superfluous. I'll drop it.
On Fri, Jul 22, 2016 at 9:10 AM, Christian König
wrote:
> From: Christian König
>
> We still need to unbind explicitely during a move.
Sorry for the drive-by nit, but:
s/explicitely/explicitly/
>
> This partial reverts commit ff20caa0bcbfef9f7686f8d1868a3b990921afd6.
>
> v2: remove
On Thu, Jul 21, 2016 at 9:00 PM, Yakir Yang wrote:
> Sean,
>
> Thanks for your fast respond :-)
>
> But this patch is not the latest one, I have upgraded this to "v1.1" version
> to fix the eDP can't be disabled problem:
> [PATCH v1.1 2/2] drm/bridge: analogix_dp: turn off the panel when eDP
The code in imx_ldb_encoder_mode_set crashes with a NULL pointer
dereference trying to access crtc->state->state, which was previously
cleared by drm_atomic_helper_swap_state:
Unable to handle kernel NULL pointer dereference at virtual address 0010
pgd = ae08c000
[0010]
1 - 100 of 130 matches
Mail list logo