Re: [PATCH 00/14] clean up drm_bridge_add

2017-08-21 Thread Inki Dae
Hi Archit, 2017년 07월 06일 17:58에 Archit Taneja 이(가) 쓴 글: > > > On 07/03/2017 02:12 PM, Inki Dae wrote: >> This patch series changes return type of drm_bridge_add >> function to void one and also removes unnecessary checking >> of the return type from relevant drivers. >> >> Ps. I had just build

Re: [PATCH 00/14] clean up drm_bridge_add

2017-08-21 Thread Archit Taneja
On 08/08/2017 08:51 AM, Archit Taneja wrote: Hi, On 08/08/2017 04:25 AM, Inki Dae wrote: Daniel, please ping~ 2017년 07월 03일 17:42에 Inki Dae 이(가) 쓴 글: This patch series changes return type of drm_bridge_add function to void one and also removes unnecessary checking of the return type from

Re: [PATCH v6 1/3] dt-bindings: display: Add Document for Rockchip Soc LVDS

2017-08-21 Thread Rob Herring
On Fri, Aug 18, 2017 at 04:09:49PM +0800, Sandy Huang wrote: > This patch add Document for Rockchip Soc RK3288 LVDS, > This based on the patches from Mark yao and Heiko Stuebner. > > Signed-off-by: Sandy Huang > Signed-off-by: Mark yao >

Re: [PATCH 4/6] dt-bindings: host1x: Fix and add Tegra186 information

2017-08-21 Thread Rob Herring
On Thu, Aug 17, 2017 at 09:54:11PM +0300, Mikko Perttunen wrote: > Add note that address/size-cells should be 2 on 64-bit systems, > and add Tegra186-specific register range properties. Generally the cell sizes have nothing to do with the addressing size of the cpu. They should be as small as

Re: [PATCH 1/4] gpu: host1x: Enable Tegra186 syncpoint protection

2017-08-21 Thread Mikko Perttunen
On 08/19/2017 01:36 AM, Dmitry Osipenko wrote: On 18.08.2017 19:15, Mikko Perttunen wrote: Since Tegra186 the Host1x hardware allows syncpoints to be assigned to specific channels, preventing any other channels from incrementing them. Enable this feature where available and assign syncpoints

Re: [PATCH v4 6/8] Documentation: Add device tree binding for Goldfish FB driver

2017-08-21 Thread Sergei Shtylyov
On 08/18/2017 04:08 PM, Aleksandar Markovic wrote: From: Aleksandar Markovic Add documentation for DT binding of Goldfish FB driver. The compatible string used by OS for binding the driver is "google,goldfish-fb". Signed-off-by: Miodrag Dinic

Re: [PATCH 2/4] gpu: host1x: Enable gather filter

2017-08-21 Thread Dmitry Osipenko
On 19.08.2017 13:46, Mikko Perttunen wrote: > On 08/19/2017 01:42 PM, Dmitry Osipenko wrote: >> On 18.08.2017 19:15, Mikko Perttunen wrote: >>> The gather filter is a feature present on Tegra124 and newer where the >>> hardware prevents GATHERed command buffers from executing commands >>> normally

[PATCH] drm: virtio: constify drm_fb_helper_funcs

2017-08-21 Thread Arvind Yadav
drm_fb_helper_funcs are not supposed to change at runtime. All functions working with drm_fb_helper_funcs provided by work with const drm_fb_helper_funcs. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/gpu/drm/virtio/virtgpu_fb.c | 2

[PATCH 1/3] drm: i2c: ch7006: constify i2c_device_id

2017-08-21 Thread Arvind Yadav
i2c_device_id are not supposed to change at runtime. All functions working with i2c_device_id provided by work with const i2c_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/gpu/drm/i2c/ch7006_drv.c | 2 +- 1 file changed, 1

Re: [PATCH 1/4] gpu: host1x: Enable Tegra186 syncpoint protection

2017-08-21 Thread Dmitry Osipenko
On 19.08.2017 13:35, Mikko Perttunen wrote: > On 08/19/2017 01:09 PM, Dmitry Osipenko wrote: >> On 19.08.2017 11:10, Mikko Perttunen wrote: >> [snip] > +host1x_hw_syncpt_set_protection(host, true); Is it really okay to force the protection? Maybe protection should be

Re: [PATCH 1/4] gpu: host1x: Enable Tegra186 syncpoint protection

2017-08-21 Thread Dmitry Osipenko
On 18.08.2017 19:15, Mikko Perttunen wrote: > Since Tegra186 the Host1x hardware allows syncpoints to be assigned to > specific channels, preventing any other channels from incrementing > them. > > Enable this feature where available and assign syncpoints to channels > when submitting a job.

Re: [PATCH v2 1/1] Split VGA default device handler out of VGA arbiter

2017-08-21 Thread Bjorn Helgaas
On Sun, Aug 20, 2017 at 12:08:20PM -0700, Benjamin Herrenschmidt wrote: > On Sat, 2017-08-19 at 10:47 -0500, Bjorn Helgaas wrote: > > So if ARM64 doesn't have these PCI legacy resources, does that mean an > > ARM64 host bridge cannot generate these legacy addresses on PCI? That > > is, there's no

[PATCH v4 2/4] drm/i915: Re-register PMIC bus access notifier on runtime resume

2017-08-21 Thread Hans de Goede
intel_uncore_suspend() unregisters the uncore code's PMIC bus access notifier and gets called on both normal and runtime suspend. intel_uncore_resume_early() re-registers the notifier, but only on normal resume. Add a new intel_uncore_runtime_resume() function which only re-registers the notifier

Re: [PATCH 1/4] gpu: host1x: Enable Tegra186 syncpoint protection

2017-08-21 Thread Dmitry Osipenko
On 18.08.2017 19:15, Mikko Perttunen wrote: > Since Tegra186 the Host1x hardware allows syncpoints to be assigned to > specific channels, preventing any other channels from incrementing > them. > > Enable this feature where available and assign syncpoints to channels > when submitting a job.

[PATCH] drm: mxsfb: constify drm_simple_display_pipe_funcs

2017-08-21 Thread Arvind Yadav
drm_simple_display_pipe_funcs are not supposed to change at runtime. All functions working with drm_simple_display_pipe_funcs provided by work with const drm_simple_display_pipe_funcs. So mark the non-const structs as const. Signed-off-by: Arvind Yadav ---

Re: [PATCH 3/4] gpu: host1x: Improve debug disassembly formatting

2017-08-21 Thread Dmitry Osipenko
On 18.08.2017 19:15, Mikko Perttunen wrote: > The host1x driver prints out "disassembly" dumps of the command FIFO > and gather contents on submission timeouts. However, the output has > been quite difficult to read with unnecessary newlines and occasional > missing parentheses. > > Fix these

[PATCH 3/3] drm: i2c: tda998x: constify i2c_device_id

2017-08-21 Thread Arvind Yadav
i2c_device_id are not supposed to change at runtime. All functions working with i2c_device_id provided by work with const i2c_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/gpu/drm/i2c/tda998x_drv.c | 2 +- 1 file changed,

Re: [PATCH] drm: hdlcd: allow HDLCD to be used without interrupt

2017-08-21 Thread Vladimir Murzin
On 10/08/17 13:15, Vladimir Murzin wrote: > On 26/07/17 11:27, Russell King - ARM Linux wrote: >> I suspect the above failure is down to either (a) not having enough >> memory available to allocate a 1920x1080 frame buffer, or (b) not >> (yet) being able to program the hdlcd pixel clock for this

Re: [PATCH 1/4] gpu: host1x: Enable Tegra186 syncpoint protection

2017-08-21 Thread Dmitry Osipenko
On 19.08.2017 14:32, Mikko Perttunen wrote: > > > On 08/19/2017 02:11 PM, Dmitry Osipenko wrote: >> On 19.08.2017 13:35, Mikko Perttunen wrote: >>> On 08/19/2017 01:09 PM, Dmitry Osipenko wrote: On 19.08.2017 11:10, Mikko Perttunen wrote: [snip] >>> +

Re: [PATCH 4/4] drm/tegra: Use u64_to_user_ptr helper

2017-08-21 Thread Dmitry Osipenko
On 18.08.2017 19:15, Mikko Perttunen wrote: > Use the u64_to_user_ptr helper macro to cast IOCTL argument u64 values > to user pointers instead of writing out the cast manually. > > Signed-off-by: Mikko Perttunen > --- > drivers/gpu/drm/tegra/drm.c | 9 - > 1 file

Re: [PATCH 2/4] gpu: host1x: Enable gather filter

2017-08-21 Thread Dmitry Osipenko
On 20.08.2017 19:24, Dmitry Osipenko wrote: > On 18.08.2017 19:15, Mikko Perttunen wrote: >> The gather filter is a feature present on Tegra124 and newer where the >> hardware prevents GATHERed command buffers from executing commands >> normally reserved for the CDMA pushbuffer which is maintained

Re: [PATCH 2/4] gpu: host1x: Enable gather filter

2017-08-21 Thread Mikko Perttunen
On 08/21/2017 08:27 PM, Mikko Perttunen wrote: On 08/20/2017 07:59 PM, Dmitry Osipenko wrote: On 20.08.2017 19:44, Dmitry Osipenko wrote: On 20.08.2017 19:24, Dmitry Osipenko wrote: On 18.08.2017 19:15, Mikko Perttunen wrote: The gather filter is a feature present on Tegra124 and newer

Re: [PATCH 2/4] gpu: host1x: Enable gather filter

2017-08-21 Thread Dmitry Osipenko
On 18.08.2017 19:15, Mikko Perttunen wrote: > The gather filter is a feature present on Tegra124 and newer where the > hardware prevents GATHERed command buffers from executing commands > normally reserved for the CDMA pushbuffer which is maintained by the > kernel driver. > > This commit enables

Re: [PATCH 1/4] gpu: host1x: Enable Tegra186 syncpoint protection

2017-08-21 Thread Dmitry Osipenko
On 18.08.2017 19:15, Mikko Perttunen wrote: > Since Tegra186 the Host1x hardware allows syncpoints to be assigned to > specific channels, preventing any other channels from incrementing > them. > > Enable this feature where available and assign syncpoints to channels > when submitting a job.

Re: [PATCH 2/4] gpu: host1x: Enable gather filter

2017-08-21 Thread Mikko Perttunen
On 08/20/2017 07:59 PM, Dmitry Osipenko wrote: On 20.08.2017 19:44, Dmitry Osipenko wrote: On 20.08.2017 19:24, Dmitry Osipenko wrote: On 18.08.2017 19:15, Mikko Perttunen wrote: The gather filter is a feature present on Tegra124 and newer where the hardware prevents GATHERed command

Re: [PATCH 2/4] gpu: host1x: Enable gather filter

2017-08-21 Thread Mikko Perttunen
On 08/19/2017 01:42 PM, Dmitry Osipenko wrote: On 18.08.2017 19:15, Mikko Perttunen wrote: The gather filter is a feature present on Tegra124 and newer where the hardware prevents GATHERed command buffers from executing commands normally reserved for the CDMA pushbuffer which is maintained by

Re: [PATCH 2/4] gpu: host1x: Enable gather filter

2017-08-21 Thread Dmitry Osipenko
On 18.08.2017 19:15, Mikko Perttunen wrote: > The gather filter is a feature present on Tegra124 and newer where the > hardware prevents GATHERed command buffers from executing commands > normally reserved for the CDMA pushbuffer which is maintained by the > kernel driver. > > This commit enables

Re: [RFC PATCH v4 0/6] i2c: document DMA handling and add helpers for it

2017-08-21 Thread Jonathan Cameron
On Thu, 17 Aug 2017 16:14:43 +0200 Wolfram Sang wrote: > So, after revisiting old mail threads, taking part in a similar discussion on > the USB list, and implementing a not-convincing solution before, here is what > I > cooked up to document and ease DMA

[PATCH 2/3] drm: i2c: sil164: constify i2c_device_id

2017-08-21 Thread Arvind Yadav
i2c_device_id are not supposed to change at runtime. All functions working with i2c_device_id provided by work with const i2c_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/gpu/drm/i2c/sil164_drv.c | 2 +- 1 file changed, 1

[PATCH v4 1/4] drm/i915: Fix false-positive assert_rpm_wakelock_held in i915_pmic_bus_access_notifier

2017-08-21 Thread Hans de Goede
assert_rpm_wakelock_held is triggered from i915_pmic_bus_access_notifier even though it gets unregistered on (runtime) suspend, this is caused by a race happening under the following circumstances: intel_runtime_pm_put does: atomic_dec(_priv->pm.wakeref_count);

Re: [PATCH 1/4] gpu: host1x: Enable Tegra186 syncpoint protection

2017-08-21 Thread Mikko Perttunen
On 08/19/2017 01:09 PM, Dmitry Osipenko wrote: On 19.08.2017 11:10, Mikko Perttunen wrote: [snip] +host1x_hw_syncpt_set_protection(host, true); Is it really okay to force the protection? Maybe protection should be enabled with a respect to CONFIG_TEGRA_HOST1X_FIREWALL? In that case we

[PATCH 1/1] drm/mgag200: Expose version string

2017-08-21 Thread mathieu . larouche
From: Mathieu Larouche OEMs started distributing this module out of the box so adding the version in modinfo output for this module may be a good idea. Signed-off-by: Mathieu Larouche --- drivers/gpu/drm/mgag200/mgag200_drv.c | 3 +++

[PATCH v4 4/4] drm/i915: Acquire PUNIT->PMIC bus for intel_uncore_forcewake_reset()

2017-08-21 Thread Hans de Goede
intel_uncore_forcewake_reset() does forcewake puts and gets as such we need to make sure that no-one tries to access the PUNIT->PMIC bus (on systems where this bus is shared) while it runs, otherwise bad things happen. Normally this is taken care of by the i915_pmic_bus_access_notifier() which

Re: [PATCH v2 1/1] Split VGA default device handler out of VGA arbiter

2017-08-21 Thread Lorenzo Pieralisi
On Thu, Aug 17, 2017 at 09:30:28PM +1000, Daniel Axtens wrote: > A system without PCI legacy resources (e.g. ARM64) may find that no > default/boot VGA device has been marked, because the VGA arbiter > checks for legacy resource decoding before marking a card as default. I do not understand this

[PATCH v4 3/4] drm/i915: Call uncore_suspend before platform suspend handlers

2017-08-21 Thread Hans de Goede
Quoting Ville: "the forcewake timer might still be active until the uncore suspend, and having active forcewakes while we've already told the GT wake stuff to stop acting normally doesn't seem quite right to me." Reported-by: Ville Syrjälä Suggested-by: Imre Deak

Re: [PATCH 1/4] gpu: host1x: Enable Tegra186 syncpoint protection

2017-08-21 Thread Mikko Perttunen
On 08/19/2017 02:11 PM, Dmitry Osipenko wrote: On 19.08.2017 13:35, Mikko Perttunen wrote: On 08/19/2017 01:09 PM, Dmitry Osipenko wrote: On 19.08.2017 11:10, Mikko Perttunen wrote: [snip] +host1x_hw_syncpt_set_protection(host, true); Is it really okay to force the protection? Maybe

Re: [PATCH v2 1/1] Split VGA default device handler out of VGA arbiter

2017-08-21 Thread Bjorn Helgaas
On Thu, Aug 17, 2017 at 09:30:28PM +1000, Daniel Axtens wrote: > A system without PCI legacy resources (e.g. ARM64) Can you be a little more specific about what you mean by "a system without PCI legacy resources"? I'm not sure what the connection with ARM64 as an architecture is. My

[PATCH 0/3] constify drm i2c_device_id

2017-08-21 Thread Arvind Yadav
i2c_device_id are not supposed to change at runtime. All functions working with i2c_device_id provided by work with const i2c_device_id. So mark the non-const structs as const. Arvind Yadav (3): [PATCH 1/3] drm: i2c: ch7006: constify i2c_device_id [PATCH 2/3] drm: i2c: sil164: constify

Re: [PATCH 1/4] gpu: host1x: Enable Tegra186 syncpoint protection

2017-08-21 Thread Dmitry Osipenko
On 18.08.2017 19:15, Mikko Perttunen wrote: > Since Tegra186 the Host1x hardware allows syncpoints to be assigned to > specific channels, preventing any other channels from incrementing > them. > > Enable this feature where available and assign syncpoints to channels > when submitting a job.

Re: [PATCH 2/4] gpu: host1x: Enable gather filter

2017-08-21 Thread Dmitry Osipenko
On 20.08.2017 19:44, Dmitry Osipenko wrote: > On 20.08.2017 19:24, Dmitry Osipenko wrote: >> On 18.08.2017 19:15, Mikko Perttunen wrote: >>> The gather filter is a feature present on Tegra124 and newer where the >>> hardware prevents GATHERed command buffers from executing commands >>> normally

Re: [PATCH 1/4] gpu: host1x: Enable Tegra186 syncpoint protection

2017-08-21 Thread Dmitry Osipenko
On 18.08.2017 19:15, Mikko Perttunen wrote: > Since Tegra186 the Host1x hardware allows syncpoints to be assigned to > specific channels, preventing any other channels from incrementing > them. > > Enable this feature where available and assign syncpoints to channels > when submitting a job.

[PATCH v4 6/8] Documentation: Add device tree binding for Goldfish FB driver

2017-08-21 Thread Aleksandar Markovic
From: Aleksandar Markovic Add documentation for DT binding of Goldfish FB driver. The compatible string used by OS for binding the driver is "google,goldfish-fb". Signed-off-by: Miodrag Dinic Signed-off-by: Goran Ferenc

Re: [PATCH 1/4] gpu: host1x: Enable Tegra186 syncpoint protection

2017-08-21 Thread Dmitry Osipenko
On 19.08.2017 11:10, Mikko Perttunen wrote: [snip] >>> +host1x_hw_syncpt_set_protection(host, true); >> >> Is it really okay to force the protection? Maybe protection should be enabled >> with a respect to CONFIG_TEGRA_HOST1X_FIREWALL? In that case we would have to >> avoid software jobs

Re: [PATCH 4/4] drm/tegra: Use u64_to_user_ptr helper

2017-08-21 Thread Mikko Perttunen
On 08/19/2017 01:05 AM, Dmitry Osipenko wrote: On 18.08.2017 19:15, Mikko Perttunen wrote: Use the u64_to_user_ptr helper macro to cast IOCTL argument u64 values to user pointers instead of writing out the cast manually. Signed-off-by: Mikko Perttunen ---

Re: [PATCH] i915,drm/fourcc: Improve the CCS modifier documentation

2017-08-21 Thread Jason Ekstrand
On Mon, Aug 21, 2017 at 9:25 AM, Ben Widawsky wrote: > On 17-08-18 11:34:40, Jason Ekstrand wrote: > >> This updates the documentation on the intel CCS modifiers for a couple >> of reasons: >> >> 1) The old documentation required that the CCS modifier only be used >>with

[Bug 101594] Blender doesn't detect OpenCL with Clover

2017-08-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101594 Jan Vesely changed: What|Removed |Added Resolution|--- |NOTABUG

[Bug 99553] Tracker bug for runnning OpenCL applications on Clover

2017-08-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99553 Bug 99553 depends on bug 101594, which changed state. Bug 101594 Summary: Blender doesn't detect OpenCL with Clover https://bugs.freedesktop.org/show_bug.cgi?id=101594 What|Removed |Added

[Bug 99581] plasmashell segfault in nouveau_dri.so

2017-08-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99581 caguduz...@go2vpn.net changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #3 from

Re: [PATCH 0/9] drm/syncobj: Add full-featured wait support (v2)

2017-08-21 Thread Jason Ekstrand
On Wed, Aug 16, 2017 at 1:10 PM, Jason Ekstrand wrote: > On Wed, Aug 16, 2017 at 9:53 AM, Christian König > wrote: > >> [SNIP] >> >>> See a wait_queue is a callback mechanism anyway, so you are wrapping a callback mechanism inside another

Re: [PATCH 06/15] mtd: make device_type const

2017-08-21 Thread Boris Brezillon
Le Sat, 19 Aug 2017 13:52:17 +0530, Bhumika Goyal a écrit : > Make this const as it is only stored in the type field of a device > structure, which is const. > Done using Coccinelle. > Applied to l2-mtd/master. Thanks, Boris > Signed-off-by: Bhumika Goyal

Re: [PATCH v2 resend] drm/panel: Add driver for Seiko 43WVF1G panel

2017-08-21 Thread Rob Herring
On Thu, Jul 27, 2017 at 11:26 AM, Marco Frank wrote: > Thierry, > > 2017-07-20 13:12 GMT-03:00 Marco Franchi : >> >> Add driver for Seiko Instruments Inc. 4.3" WVGA (800 x RGB x 480) >> TFT with Touch-Panel. >> >> Datasheet available at: >>

Re: [PATCH 1/4 v2] drm/tve200: Add DT bindings

2017-08-21 Thread Rob Herring
On Sun, Aug 20, 2017 at 5:05 AM, Linus Walleij wrote: > This adds device tree bindings for the Faraday TVE200 IP block. > This IP block is present in the Gemini ARM SoC and also in some > Grain Media GM SoCs. > > Cc: devicet...@vger.kernel.org > Signed-off-by: Linus

[Bug 101961] Serious Sam Fusion hangs system completely

2017-08-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101961 Samuel Pitoiset changed: What|Removed |Added Status|REOPENED|RESOLVED

drm, fbdev emulation and drm_dev_unplug()

2017-08-21 Thread Noralf Trønnes
Hi, I'm looking into what happens if fbdev has open file handles when drm_dev_unplug() is called. udl is the only user of drm_dev_unplug(), but AFAICT it will keel over if unplugged with a /dev/fb handle open since fbdev is torn down during drm_driver->unload. My first attempt was to rely on

[Bug 101483] A10-8780P (Carrizo) + R7 M260/M265 does not boot without any "workaround" parameter.

2017-08-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101483 --- Comment #3 from Andrew --- Have you tried iommu=soft kernel parameter? you should provide the log of a faulty boot (i.e. dmesg), showing the different boot modes. That would help the devs to see what actually happens

[Bug 102342] mesa-17.1.7/src/gallium/auxiliary/pipebuffer/pb_cache.c:169]: (style) Suspicious condition

2017-08-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102342 Bug ID: 102342 Summary: mesa-17.1.7/src/gallium/auxiliary/pipebuffer/pb_cache. c:169]: (style) Suspicious condition Product: Mesa Version: 17.1 Hardware: Other

Re: [Intel-gfx] [PATCH] drm: Release driver tracking before making the object available again

2017-08-21 Thread Chris Wilson
Quoting Daniel Vetter (2017-08-21 17:16:24) > On Sat, Aug 19, 2017 at 01:05:58PM +0100, Chris Wilson wrote: > > This is the same bug as we fixed in commit f6cd7daecff5 ("drm: Release > > driver references to handle before making it available again"), but now > > the exposure is via the PRIME

Re: [PATCH libdrm 3/3] amdgpu: rework and remove amdgpu_get_auth()

2017-08-21 Thread Daniel Vetter
On Mon, Aug 21, 2017 at 01:31:28PM +0100, Emil Velikov wrote: > Hi all, > > Can anyone skim through this patch? > > Thanks > Emil > > On 22 January 2017 at 18:48, Emil Velikov wrote: > > All one needs is to establish if dev->fd is the flink (primary/card) > > node,

Re: DRM Format Modifiers in v4l2

2017-08-21 Thread Hans Verkuil
On 08/21/2017 06:01 PM, Daniel Vetter wrote: > On Mon, Aug 21, 2017 at 5:52 PM, Brian Starkey wrote: >> Hi all, >> >> I couldn't find this topic talked about elsewhere, but apologies if >> it's a duplicate - I'll be glad to be steered in the direction of a >> thread. >> >>

Re: [PATCH] drm: Squelch DEBUG_ATOMIC message for pointer manipulations

2017-08-21 Thread Daniel Vetter
On Mon, Aug 21, 2017 at 10:36:48AM +0200, Maarten Lankhorst wrote: > Op 21-08-17 om 10:31 schreef Chris Wilson: > > These messages flood the debug logs conveying very little information > > except that the same actions as performed on the last atomic modeset are > > being repeated on a different

Re: [PATCH 2/4 v2] drm/tve200: Add new driver for TVE200

2017-08-21 Thread Daniel Vetter
On Sun, Aug 20, 2017 at 12:05:55PM +0200, Linus Walleij wrote: > This adds a new DRM driver for the Faraday Technology TVE200 > block. This "TV Encoder" encodes a ITU-T BT.656 stream and can > be found in the StorLink SL3516 (later Cortina Systems CS3516) > as well as the Grain Media GM8180. > >

Re: [PATCH] i915,drm/fourcc: Improve the CCS modifier documentation

2017-08-21 Thread Ben Widawsky
On 17-08-18 11:34:40, Jason Ekstrand wrote: This updates the documentation on the intel CCS modifiers for a couple of reasons: 1) The old documentation required that the CCS modifier only be used with formats. While i915 currently only supports CCS scanout with formats (and

Re: [PATCH v3 01/22] drm: Add GEM backed framebuffer library

2017-08-21 Thread Daniel Vetter
On Sat, Aug 19, 2017 at 04:46:30PM +0200, Noralf Trønnes wrote: > > Den 16.08.2017 22.50, skrev Laurent Pinchart: > > Hi Noralf, > > > > One additional comment. > > > > On Wednesday 16 Aug 2017 23:37:54 Laurent Pinchart wrote: > > > On Sunday 13 Aug 2017 15:31:44 Noralf Trønnes wrote: > > > >

Re: [PATCH 2/2] drm/gem-fb-helper: Use debug message on gem lookup failure

2017-08-21 Thread Daniel Vetter
On Sat, Aug 19, 2017 at 04:34:45PM +0200, Noralf Trønnes wrote: > GEM lookup failure can easily be triggered by userspace so make > it a debug message, not an error message. > > Also remove unnecessary inner parentheses and fix alphabetical > struct declaration order. > > Cc: Laurent Pinchart

Re: [PATCH 1/2] drm/gem-fb-helper: Cleanup docs

2017-08-21 Thread Daniel Vetter
On Sat, Aug 19, 2017 at 04:34:44PM +0200, Noralf Trønnes wrote: > Make the docs read a little better. > > Cc: Laurent Pinchart > Signed-off-by: Noralf Trønnes A few nits on your nits, with those addressed: Reviewed-by: Daniel Vetter

Re: DRM Format Modifiers in v4l2

2017-08-21 Thread Brian Starkey
On Mon, Aug 21, 2017 at 06:01:24PM +0200, Daniel Vetter wrote: On Mon, Aug 21, 2017 at 5:52 PM, Brian Starkey wrote: Hi all, I couldn't find this topic talked about elsewhere, but apologies if it's a duplicate - I'll be glad to be steered in the direction of a thread.

Re: [Intel-gfx] [PATCH] drm: Release driver tracking before making the object available again

2017-08-21 Thread Daniel Vetter
On Sat, Aug 19, 2017 at 01:05:58PM +0100, Chris Wilson wrote: > This is the same bug as we fixed in commit f6cd7daecff5 ("drm: Release > driver references to handle before making it available again"), but now > the exposure is via the PRIME lookup tables. If we remove the > object/handle from the

Re: [PATCHv2 0/3] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

2017-08-21 Thread Daniel Vetter
On Sat, Aug 19, 2017 at 02:05:16PM +0200, Hans Verkuil wrote: > On 08/12/2017 11:01 AM, Hans Verkuil wrote: > > From: Hans Verkuil > > > > This patch series adds support for the DisplayPort CEC-Tunneling-over-AUX > > feature. This patch series is based on 4.13-rc4 which

Re: DRM Format Modifiers in v4l2

2017-08-21 Thread Daniel Vetter
On Mon, Aug 21, 2017 at 5:52 PM, Brian Starkey wrote: > Hi all, > > I couldn't find this topic talked about elsewhere, but apologies if > it's a duplicate - I'll be glad to be steered in the direction of a > thread. > > We'd like to support DRM format modifiers in v4l2 in

DRM Format Modifiers in v4l2

2017-08-21 Thread Brian Starkey
Hi all, I couldn't find this topic talked about elsewhere, but apologies if it's a duplicate - I'll be glad to be steered in the direction of a thread. We'd like to support DRM format modifiers in v4l2 in order to share the description of different (mostly proprietary) buffer formats between

[PULL] drm-intel-next

2017-08-21 Thread Daniel Vetter
Hi Dave, Ofc because my final pull I screwed it up. Somehow I didn't notice for over 2 weeks that the previous pull request never made it to you. Hence a bit bigger than usual for the final -rc pull. Not exactly sure how that happened :-/ drm-intel-next-2017-08-18: Final pile of features for

[Bug 102339] QXL driver hangs on virt guest login, kernel 4.12

2017-08-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102339 Bug ID: 102339 Summary: QXL driver hangs on virt guest login, kernel 4.12 Product: DRI Version: unspecified Hardware: Other OS: All Status: NEW

[Bug 102338] QXL driver causes oops on boot, kernel 4.12

2017-08-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102338 --- Comment #1 from Chuck Ebbert --- Note this is happening in a kvm guest. Removing "rhgb" from Fedora boot options (disables Plymouth boot graphics) lets the driver reach a gdm login screen. Then another bug hits

[Bug 102338] QXL driver causes oops on boot, kernel 4.12

2017-08-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102338 Bug ID: 102338 Summary: QXL driver causes oops on boot, kernel 4.12 Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: All Status: NEW

Re: [PATCH libdrm v2] etnaviv: prevent deadlock in error path

2017-08-21 Thread Eric Engestrom
On Monday, 2017-08-21 14:42:51 +0200, Philipp Zabel wrote: > If drmPrimeFDToHandle fails in etna_bo_from_dmabuf, the function must > not return with the table_lock mutex held. There is no reason to call > drmPrimeFDToHandle under that lock, so just take the lock after trying > to obtain the

Re: [PATCH libdrm v3 1/2] etnaviv: fix etna_bo_from_name

2017-08-21 Thread Eric Engestrom
On Monday, 2017-08-21 14:41:11 +0200, Philipp Zabel wrote: > Look up BOs from the name table using the name parameter instead of > req.handle (which at this point is always zero). > > Signed-off-by: Philipp Zabel > Reviewed-by: Eric Engestrom >

Re: [PATCH libdrm 3/3] amdgpu: rework and remove amdgpu_get_auth()

2017-08-21 Thread Christian König
Am 21.08.2017 um 14:31 schrieb Emil Velikov: Hi all, Can anyone skim through this patch? Thanks Emil On 22 January 2017 at 18:48, Emil Velikov wrote: All one needs is to establish if dev->fd is the flink (primary/card) node, rather than use DRM_IOCTL_GET_CLIENT to

[PATCH libdrm v2] etnaviv: prevent deadlock in error path

2017-08-21 Thread Philipp Zabel
If drmPrimeFDToHandle fails in etna_bo_from_dmabuf, the function must not return with the table_lock mutex held. There is no reason to call drmPrimeFDToHandle under that lock, so just take the lock after trying to obtain the handle. Based on ceb70a6b1015 ("freedreno: prevent deadlock in error

[PATCH libdrm v3 1/2] etnaviv: fix etna_bo_from_name

2017-08-21 Thread Philipp Zabel
Look up BOs from the name table using the name parameter instead of req.handle (which at this point is always zero). Signed-off-by: Philipp Zabel Reviewed-by: Eric Engestrom Reviewed-by: Christian Gmeiner Reviewed-by:

[PATCH libdrm v3 2/2] etnaviv: add etna_bo_from_handle

2017-08-21 Thread Philipp Zabel
Although etnaviv_drmif.h declared etna_bo_from_handle from the start, there was no implementation. Signed-off-by: Philipp Zabel Reviewed-by: Daniel Stone --- v3: drop unnecessary variable initialisation --- etnaviv/etnaviv_bo.c | 19

Re: [PATCH libdrm 3/3] amdgpu: rework and remove amdgpu_get_auth()

2017-08-21 Thread Emil Velikov
Hi all, Can anyone skim through this patch? Thanks Emil On 22 January 2017 at 18:48, Emil Velikov wrote: > All one needs is to establish if dev->fd is the flink (primary/card) > node, rather than use DRM_IOCTL_GET_CLIENT to query the auth status. > > The latter is

Re: [PATCH libdrm 1/2] etnaviv: prevent deadlock in error path

2017-08-21 Thread Philipp Zabel
On Mon, 2017-08-21 at 12:05 +0100, Emil Velikov wrote: > > On 21 August 2017 at 11:57, Philipp Zabel wrote: > > If drmPrimeFDToHandle fails in etna_bo_from_dmabuf, the function must > > not return with the table_lock mutex held. There is no reason to call > >

Re: [PATCH libdrm 1/1] drmsltest: Check expected neighbours

2017-08-21 Thread Emil Velikov
On 16 August 2017 at 02:51, Emil Velikov wrote: > Hi Jan, > > On 14 August 2017 at 03:44, Jan Vesely wrote: >> On Fri, 2017-07-28 at 10:23 -0400, Jan Vesely wrote: >>> Fixes: 7d8c9464081634f053e16e5eac9655a12fae1dc4 >>> Signed-off-by: Jan Vesely

Re: [PATCH libdrm v2 2/2] android: amdgpu: fix build break

2017-08-21 Thread Emil Velikov
On 17 August 2017 at 04:31, Chih-Wei Huang wrote: > Ping. Is there any other concern to merge the fix? > My earlier suggestion was to use the respective Android build system variable, instead of hardcoding the actual path. Merged v2 of the series, although I reserve my

Re: [PATCH libdrm v2 2/2] etnaviv: add etna_bo_from_handle

2017-08-21 Thread Daniel Stone
Hi Philipp, On 21 August 2017 at 11:56, Philipp Zabel wrote: > +struct etna_bo * > +etna_bo_from_handle(struct etna_device *dev, uint32_t handle, uint32_t size) > +{ > + struct etna_bo *bo = NULL; You can drop the NULL initialisation since it's always set by the

Re: [PATCH libdrm 1/2] etnaviv: prevent deadlock in error path

2017-08-21 Thread Emil Velikov
On 21 August 2017 at 11:57, Philipp Zabel wrote: > If drmPrimeFDToHandle fails in etna_bo_from_dmabuf, the function must > not return with the table_lock mutex held. There is no reason to call > drmPrimeFDToHandle under that lock, so just take the lock after trying > to

Re: [PATCH libdrm 1/2] etnaviv: prevent deadlock in error path

2017-08-21 Thread Christian Gmeiner
2017-08-21 12:57 GMT+02:00 Philipp Zabel : > If drmPrimeFDToHandle fails in etna_bo_from_dmabuf, the function must > not return with the table_lock mutex held. There is no reason to call > drmPrimeFDToHandle under that lock, so just take the lock after trying > to obtain

[PATCH libdrm 2/2] freedreno: simplify locking in fd_bo_from_dmabuf

2017-08-21 Thread Philipp Zabel
There should be no reason to call drmPrimeFDToHandle under the table_lock mutex. Instead of taking the lock early and releasing it in two places, just take it after trying to obtain the handle. Signed-off-by: Philipp Zabel --- freedreno/freedreno_bo.c | 4 ++-- 1 file

[PATCH libdrm 1/2] etnaviv: prevent deadlock in error path

2017-08-21 Thread Philipp Zabel
If drmPrimeFDToHandle fails in etna_bo_from_dmabuf, the function must not return with the table_lock mutex held. There is no reason to call drmPrimeFDToHandle under that lock, so just take the lock after trying to obtain the handle. Based on ceb70a6b1015 ("freedreno: prevent deadlock in error

[PATCH libdrm v2 2/2] etnaviv: add etna_bo_from_handle

2017-08-21 Thread Philipp Zabel
Although etnaviv_drmif.h declared etna_bo_from_handle from the start, there was no implementation. Signed-off-by: Philipp Zabel --- v2: no changes since v1 --- etnaviv/etnaviv_bo.c | 19 +++ 1 file changed, 19 insertions(+) diff --git

[PATCH libdrm v2 1/2] etnaviv: fix etna_bo_from_name

2017-08-21 Thread Philipp Zabel
Look up BOs from the name table using the name parameter instead of req.handle (which at this point is always zero). Signed-off-by: Philipp Zabel Reviewed-by: Eric Engestrom Reviewed-by: Christian Gmeiner Reviewed-by:

[PATCH] drm/bridge/sii8620: Fix memory corruption

2017-08-21 Thread Maciej Purski
Function sii8620_mt_read_devcap_reg_recv() used to read array index from a wrong msg register, which caused writing out of array bounds. It led to writing on other fields of struct sii8620. Signed-off-by: Maciej Purski Fixes: e9c6da270 ("drm/bridge/sii8620: add reading

[PATCH v3] drm/bridge/sii8620: add remote control support

2017-08-21 Thread Maciej Purski
MHL specification defines Remote Control Protocol(RCP) to send input events between MHL devices. The driver now recognizes RCP messages and reacts to them by reporting key events to input subsystem, allowing a user to control a device using TV remote control. Changes in v2: - use RC subsystem

Re: [PATCH] drm: Squelch DEBUG_ATOMIC message for pointer manipulations

2017-08-21 Thread Maarten Lankhorst
Op 21-08-17 om 10:31 schreef Chris Wilson: > These messages flood the debug logs conveying very little information > except that the same actions as performed on the last atomic modeset are > being repeated on a different pointer. That our identifier is a pointer > is an indicator that is not

[PATCH] drm: Squelch DEBUG_ATOMIC message for pointer manipulations

2017-08-21 Thread Chris Wilson
These messages flood the debug logs conveying very little information except that the same actions as performed on the last atomic modeset are being repeated on a different pointer. That our identifier is a pointer is an indicator that is not interesting enough to be tracked by a human ;) An

Re: [linux-sunxi] [PATCH 07/13] ARM: sun8i: h3: add display engine pipeline barebone

2017-08-21 Thread Maxime Ripard
On Wed, Aug 02, 2017 at 01:07:55PM +0800, icen...@aosc.io wrote: > 在 2017-08-02 12:47,Jernej Škrabec 写道: > > Hi Icenowy, > > > > Dne torek, 01. avgust 2017 ob 15:12:58 CEST je Icenowy Zheng napisal(a): > > > As we have already the support for the DE2 on Allwinner H3, add the > > > display engine

Re: [maintainer-tools PATCH] dim: Add drm-misc-commit-flow.svg to clean target

2017-08-21 Thread Jani Nikula
On Fri, 18 Aug 2017, Sean Paul wrote: > Clean up drm-misc-commit-flow.svg when running make clean. You're late to the party! ;) 84127e33aa71 ("build: add drm-misc-commit-flow.svg to clean target") Thanks, Jani. > > Signed-off-by: Sean Paul > ---

Re: [PATCH] drm/imx: parallel-display: use correct connector enum

2017-08-21 Thread Philipp Zabel
On Fri, 2017-08-18 at 18:34 +0200, Lucas Stach wrote: > The imx parrallel display exposes a, well, display parallel interface. > Use the correct enum, instead of disguising the thing as a VGA connector. > > Signed-off-by: Lucas Stach > --- >  

Re: [PATCH v3 16/22] drm/sti: Use drm_gem_fb_create()

2017-08-21 Thread Vincent ABRIOU
Hi Noralf, On 08/13/2017 03:31 PM, Noralf Trønnes wrote: > drm_fb_cma_create() is just a wrapper around drm_gem_fb_create() now, > so use the function directly. > > Cc: Benjamin Gaignard > Cc: Vincent Abriou > Signed-off-by: Noralf Trønnes