Re: [BUG] drm: vc4: refcount_t: increment on 0; use-after-free.

2017-11-22 Thread Daniel Vetter
17:43:35 +0100 (CET) > > > Stefan Wahren wrote: > > > > > >> Hi Boris, > > >> if i boot Raspberry Pi 3 (ARM64, defconfig, linux-next-20171122) with > > >> sufficient CMA memory (32 MB), i'll get this warning during boot: > > >> &g

Re: [PATCH 1/6] drm/i915: export the stolen region as a resource

2017-11-22 Thread Joonas Lahtinen
+ Dave as a heads-up On Thu, 2017-11-23 at 07:17 +0100, Ingo Molnar wrote: > * Matthew Auld wrote: > > > We duplicate the stolen discovery code in early-quirks and in i915, > > however if we just export the region as a resource from early-quirks we > > can nuke the duplication. > > > > Suggeste

Re: [PATCH 3/8] drm/mediatek: mt2701: switch to mfd probing.

2017-11-22 Thread CK Hu
Hi, Matthias: On Tue, 2017-11-14 at 22:41 +0100, Matthias Brugger wrote: > With the mtk-mmsys MFD device in place, we switch the probing for > mt2701 from device-tree to mfd. > > Signed-off-by: Matthias Brugger > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 32 +---

Re: [PATCH 1/8] drm/mediatek: Use regmap for register access

2017-11-22 Thread CK Hu
Hi, Matthias: On Tue, 2017-11-14 at 22:41 +0100, Matthias Brugger wrote: > The mmsys memory space is shared between the drm and the > clk driver. Use regmap to access it. > > Signed-off-by: Matthias Brugger Acked-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 4 ++-- > drivers/

Re: [PATCH v2] drm/exynos: gem: Drop NONCONTIG flag for buffers allocated without IOMMU

2017-11-22 Thread Inki Dae
2017년 11월 22일 22:14에 Marek Szyprowski 이(가) 쓴 글: > When no IOMMU is available, all GEM buffers allocated by Exynos DRM driver > are contiguous, because of the underlying dma_alloc_attrs() function > provides only such buffers. In such case it makes no sense to keep > BO_NONCONTIG flag for the allo

[git pull] drm for v4.15 (fixes/cleanups/one small feature)

2017-11-22 Thread Dave Airlie
Hi Linus, This is just some bits and pieces for the second half of the merge window, 1. Remove the MSM dt-bindings file Rob managed to push in the previous pull. 2. Add a property/edid quirk to denote HMD devices, I had these hanging around for a few weeks and Keith had done some work on them, th

[PATCH] drm/ttm: don't attempt to use hugepages if dma32 requested (v2)

2017-11-22 Thread Dave Airlie
From: Dave Airlie The commit below introduced thp support for ttm allocations, however it didn't take into account the case where dma32 was requested. Some drivers always request dma32, and the bochs driver is one of those. This fixes an oops: [ 30.108507] [ cut here ]---

[PATCH] drm/ttm: don't attempt to use hugepages if dma32 requested

2017-11-22 Thread Dave Airlie
From: Dave Airlie The commit below introduced thp support for ttm allocations, however it didn't take into account the case where dma32 was requested. Some drivers always request dma32, and the bochs driver is one of those. This fixes an oops: [ 30.108507] [ cut here ]---

Re: Regression in TTM driver w/Linus' master

2017-11-22 Thread Dave Airlie
On 23 November 2017 at 11:17, Laura Abbott wrote: > Hi, > > Fedora QA testing reported a panic when booting up VMs > using qmeu vga drivers > (https://paste.fedoraproject.org/paste/498yRWTCJv2LKIrmj4EliQ) > > [ 30.108507] [ cut here ] > [ 30.108920] kernel BUG at ./incl

Re: Regression in TTM driver w/Linus' master

2017-11-22 Thread Adam Williamson
On Wed, 2017-11-22 at 17:17 -0800, Laura Abbott wrote: > Hi, > > Fedora QA testing reported a panic when booting up VMs > using qmeu vga drivers > (https://paste.fedoraproject.org/paste/498yRWTCJv2LKIrmj4EliQ) > > [ 30.108507] [ cut here ] > [ 30.108920] kernel BUG at

Regression in TTM driver w/Linus' master

2017-11-22 Thread Laura Abbott
Hi, Fedora QA testing reported a panic when booting up VMs using qmeu vga drivers (https://paste.fedoraproject.org/paste/498yRWTCJv2LKIrmj4EliQ) [ 30.108507] [ cut here ] [ 30.108920] kernel BUG at ./include/linux/gfp.h:408! [ 30.109356] invalid opcode: [#1] S

Re: [PATCHv3] drm: adv7511/33: Fix adv7511_cec_init() failure handling

2017-11-22 Thread John Stultz
On Tue, Nov 21, 2017 at 12:17 AM, Hans Verkuil wrote: > If the device tree for a board did not specify a cec clock, then > adv7511_cec_init would return an error, which would cause adv7511_probe() > to fail and thus there is no HDMI output. > > There is no need to have adv7511_probe() fail if the

Re: [PATCH] drm/vc4: Fix false positive WARN() backtrace on refcount_inc() usage

2017-11-22 Thread Eric Anholt
Boris Brezillon writes: > On Wed, 22 Nov 2017 13:16:08 -0800 > Eric Anholt wrote: > >> Boris Brezillon writes: >> >> > With CONFIG_REFCOUNT_FULL enabled, refcount_inc() complains when it's >> > passed a refcount object that has its counter set to 0. In this driver, >> > this is a valid use cas

Re: [PATCH] drm/vc4: Fix false positive WARN() backtrace on refcount_inc() usage

2017-11-22 Thread Boris Brezillon
On Wed, 22 Nov 2017 13:16:08 -0800 Eric Anholt wrote: > Boris Brezillon writes: > > > With CONFIG_REFCOUNT_FULL enabled, refcount_inc() complains when it's > > passed a refcount object that has its counter set to 0. In this driver, > > this is a valid use case since we want to increment ->usecn

[PATCH 1/6] drm/i915: export the stolen region as a resource

2017-11-22 Thread Matthew Auld
We duplicate the stolen discovery code in early-quirks and in i915, however if we just export the region as a resource from early-quirks we can nuke the duplication. Suggested-by: Joonas Lahtinen Suggested-by: Chris Wilson Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Chris Wilson Cc: P

Re: [PATCH] drm/vc4: Fix false positive WARN() backtrace on refcount_inc() usage

2017-11-22 Thread Eric Anholt
Boris Brezillon writes: > With CONFIG_REFCOUNT_FULL enabled, refcount_inc() complains when it's > passed a refcount object that has its counter set to 0. In this driver, > this is a valid use case since we want to increment ->usecnt only when > the BO object starts to be used by real HW component

[Bug 103100] Performance regression with various games in drm-next-amd-staging Kernel

2017-11-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103100 --- Comment #9 from Gregor Münch --- Created attachment 135674 --> https://bugs.freedesktop.org/attachment.cgi?id=135674&action=edit Shadow of Mordor benchmark current amd-staging kernel shader cache This is the situation after the shader cac

[Bug 103100] Performance regression with various games in drm-next-amd-staging Kernel

2017-11-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103100 --- Comment #8 from Gregor Münch --- Created attachment 135673 --> https://bugs.freedesktop.org/attachment.cgi?id=135673&action=edit Shadow of Mordor benchmark older amd-staging kernel -- You are receiving this mail because: You are the assi

[Bug 103100] Performance regression with various games in drm-next-amd-staging Kernel

2017-11-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103100 --- Comment #7 from Gregor Münch --- Created attachment 135672 --> https://bugs.freedesktop.org/attachment.cgi?id=135672&action=edit Shadow of Mordor benchmark current amd-staging kernel This is current situation... I dont know if this helps.

[PATCH] drm/vc4: Fix false positive WARN() backtrace on refcount_inc() usage

2017-11-22 Thread Boris Brezillon
With CONFIG_REFCOUNT_FULL enabled, refcount_inc() complains when it's passed a refcount object that has its counter set to 0. In this driver, this is a valid use case since we want to increment ->usecnt only when the BO object starts to be used by real HW components and this is definitely not the c

[Bug 103850] "Quern" game crashes on start-up

2017-11-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103850 --- Comment #1 from yunt...@gmail.com --- Created attachment 135671 --> https://bugs.freedesktop.org/attachment.cgi?id=135671&action=edit Unturned crash - bt full -- You are receiving this mail because: You are the assignee for the bug.__

[Bug 103850] "Quern" game crashes on start-up

2017-11-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103850 Bug ID: 103850 Summary: "Quern" game crashes on start-up Product: Mesa Version: 17.3 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: norma

[Bug 103814] incorrect dust rendering in hl2ep1 without some R600_DEBUG options

2017-11-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103814 Hleb Valoshka <375...@gmail.com> changed: What|Removed |Added Summary|incorrect dust rendering in |incorrect dust renderi

[Bug 100745] amdgpu fails to wake up DisplayPort DELL monitors with 'clock recovery failed'

2017-11-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100745 --- Comment #8 from Benjamin Bellec --- I hit the same problem today after enabling amdgpu.dc=1 The screen doesn't light up at all if I boot the kernel with amdgpu.dc=1 Config is: Fedora 27 + kernel 4.15.0-0.rc0.git7.1.fc28.x86_64 Radeon R9 380

[Bug 100745] amdgpu fails to wake up DisplayPort DELL monitors with 'clock recovery failed'

2017-11-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100745 Benjamin Bellec changed: What|Removed |Added CC||b.bel...@gmail.com --- Comment #7 fro

Re: [PATCH 02/10] drm/edid: Allow HDMI infoframe without VIC or S3D

2017-11-22 Thread Ville Syrjälä
On Fri, Nov 17, 2017 at 08:40:02AM +0530, Sharma, Shashank wrote: > Regards > > Shashank > > > On 11/16/2017 9:51 PM, Ville Syrjälä wrote: > > On Thu, Nov 16, 2017 at 08:10:55PM +0530, Sharma, Shashank wrote: > >> Regards > >> > >> Shashank > >> > >> > >> On 11/13/2017 10:34 PM, Ville Syrjala wr

Re: [BUG] drm: vc4: refcount_t: increment on 0; use-after-free.

2017-11-22 Thread Boris Brezillon
On Wed, 22 Nov 2017 19:13:09 +0100 Daniel Vetter wrote: > On Wed, Nov 22, 2017 at 6:51 PM, Boris Brezillon > wrote: > > Hi Stefan, > > > > On Wed, 22 Nov 2017 17:43:35 +0100 (CET) > > Stefan Wahren wrote: > > > >> Hi Boris, > >> if i boot

Re: [BUG] drm: vc4: refcount_t: increment on 0; use-after-free.

2017-11-22 Thread Daniel Vetter
On Wed, Nov 22, 2017 at 6:51 PM, Boris Brezillon wrote: > Hi Stefan, > > On Wed, 22 Nov 2017 17:43:35 +0100 (CET) > Stefan Wahren wrote: > >> Hi Boris, >> if i boot Raspberry Pi 3 (ARM64, defconfig, linux-next-20171122) with >> sufficient CMA memory (32 MB),

Re: [BUG] drm: vc4: refcount_t: increment on 0; use-after-free.

2017-11-22 Thread Boris Brezillon
Hi Stefan, On Wed, 22 Nov 2017 17:43:35 +0100 (CET) Stefan Wahren wrote: > Hi Boris, > if i boot Raspberry Pi 3 (ARM64, defconfig, linux-next-20171122) with > sufficient CMA memory (32 MB), i'll get this warning during boot: > > [7.623510] vc4-drm soc:gpu: boun

Re: [PATCH] drm/amd/display: fix memory leaks on error exit return

2017-11-22 Thread Harry Wentland
On 2017-11-22 11:47 AM, Colin King wrote: > From: Colin Ian King > > Currently in the case where some of the allocations fail for dce110_tgv, > dce110_xfmv, dce110_miv or dce110_oppv then the exit return path ends > up leaking allocated objects. Fix this by kfree'ing them before returning. > Also

Re: [PATCH v2] drm/exynos: gem: Drop NONCONTIG flag for buffers allocated without IOMMU

2017-11-22 Thread Tobias Jakobi
Marek Szyprowski wrote: > When no IOMMU is available, all GEM buffers allocated by Exynos DRM driver > are contiguous, because of the underlying dma_alloc_attrs() function > provides only such buffers. In such case it makes no sense to keep > BO_NONCONTIG flag for the allocated GEM buffers. This al

[Bug 103788] [DC] Screen goes blank after screen sleep and will not come back on

2017-11-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103788 Michel Dänzer changed: What|Removed |Added Summary|Screen goes blank after |[DC] Screen goes blank

[Bug 103788] Screen goes blank after screen sleep and will not come back on

2017-11-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103788 Michel Dänzer changed: What|Removed |Added Attachment #135572|text/x-log |text/plain mime type|

[Bug 103788] Screen goes blank after screen sleep and will not come back on

2017-11-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103788 Michel Dänzer changed: What|Removed |Added Attachment #135571|text/x-log |text/plain mime type|

Re: [PATCH v9 4/5] x86/PCI: Enable a 64bit BAR on AMD Family 15h (Models 30h-3fh) Processors v5

2017-11-22 Thread Christian König
Am 22.11.2017 um 17:24 schrieb Boris Ostrovsky: On 11/22/2017 05:09 AM, Christian König wrote: Am 21.11.2017 um 23:26 schrieb Boris Ostrovsky: On 11/21/2017 08:34 AM, Christian König wrote: Hi Boris, attached are two patches. The first one is a trivial fix for the infinite loop issue, it now

[PATCH] drm/amd/display: fix memory leaks on error exit return

2017-11-22 Thread Colin King
From: Colin Ian King Currently in the case where some of the allocations fail for dce110_tgv, dce110_xfmv, dce110_miv or dce110_oppv then the exit return path ends up leaking allocated objects. Fix this by kfree'ing them before returning. Also re-work the comparison of the null pointers to use th

Hardware 3D acceleration doesn't work anymore with the latest git kernel

2017-11-22 Thread Christian Zigotzky
On 22 November 2017 at 2:45PM, Ilia Mirkin wrote: I thought I covered that... "I'd recommend doing a proper bisect (search for "git bisect", there are tons of guides). That will identify the commit that's actually responsible." -ilia ___ dri-devel

Re: [PATCH v2 4/4] drm/tinydrm: add driver for ILI9225 panels

2017-11-22 Thread Noralf Trønnes
Den 19.11.2017 21.12, skrev David Lechner: This adds a new driver for display panels based on the Ilitek ILI9225 controller. This was developed for a no-name panel with a red PCB that is commonly marketed for Arduino. See . Signed-off-by: David Lechner

Re: [PATCH v2 3/4] drm/tinydrm: export mipi_dbi_buf_copy and mipi_dbi_spi_cmd_max_speed

2017-11-22 Thread Noralf Trønnes
Den 19.11.2017 21.12, skrev David Lechner: This exports the mipi_dbi_buf_copy() and mipi_dbi_spi_cmd_max_speed() functions so that they can be shared with other drivers. Signed-off-by: David Lechner --- Reviewed-by: Noralf Trønnes v2 changes: * new patch in v2 drivers/gpu/drm/tinydrm/m

Re: Hardware 3D acceleration doesn't work anymore with the latest git kernel

2017-11-22 Thread Ilia Mirkin
On Wed, Nov 22, 2017 at 8:40 AM, Christian Zigotzky wrote: > On 22 November 2017 at 2:27PM, Ilia Mirkin wrote: >> >> On Wed, Nov 22, 2017 at 8:20 AM, Christian Zigotzky >> wrote: >>> >>> Hi Alex, >>> >>> I reverted the following files in the first bad commit (first DRM >>> updates) >> >> Is the m

Hardware 3D acceleration doesn't work anymore with the latest git kernel

2017-11-22 Thread Christian Zigotzky
On 22 November 2017 at 2:27PM, Ilia Mirkin wrote: On Wed, Nov 22, 2017 at 8:20 AM, Christian Zigotzky wrote: Hi Alex, I reverted the following files in the first bad commit (first DRM updates) Is the merge commit really the first bad commit? i.e. both parents of the merge are good, but the me

Re: Hardware 3D acceleration doesn't work anymore with the latest git kernel

2017-11-22 Thread Ilia Mirkin
On Wed, Nov 22, 2017 at 8:20 AM, Christian Zigotzky wrote: > Hi Alex, > > I reverted the following files in the first bad commit (first DRM updates) Is the merge commit really the first bad commit? i.e. both parents of the merge are good, but the merge commit itself is bad? Or did you do this man

Hardware 3D acceleration doesn't work anymore with the latest git kernel

2017-11-22 Thread Christian Zigotzky
Hi Alex, I reverted the following files in the first bad commit (first DRM updates) [1]. -rw-r--r--    drivers/gpu/drm/radeon/Makefile    5 -rw-r--r--    drivers/gpu/drm/radeon/atombios_dp.c    46 -rw-r--r--    drivers/gpu/drm/radeon/ci_dpm.c    22 -rw-r--r--    drivers/gpu/drm/radeon/ci_dpm.h

[PATCH v2] drm/exynos: gem: Drop NONCONTIG flag for buffers allocated without IOMMU

2017-11-22 Thread Marek Szyprowski
When no IOMMU is available, all GEM buffers allocated by Exynos DRM driver are contiguous, because of the underlying dma_alloc_attrs() function provides only such buffers. In such case it makes no sense to keep BO_NONCONTIG flag for the allocated GEM buffers. This allows to avoid failures for buffe

[GIT PULL] drm/tegra: Fixes for v4.15-rc1

2017-11-22 Thread Thierry Reding
Hi Dave, The following changes since commit fb83be8873909ba7c089d1c5cb72873cc2cce7d1: drm/tegra: hdmi: Add cec-notifier support (2017-10-20 14:19:54 +0200) are available in the Git repository at: git://anongit.freedesktop.org/tegra/linux tags/drm/tegra/for-4.15-rc1-fixes for you to fetch c

Re: [PATCH] gpu: ipu-v3: prg: switch to runtime PM

2017-11-22 Thread Philipp Zabel
On Fri, 2017-11-10 at 17:06 +0100, Lucas Stach wrote: > Instead of open-coding the clk enable/disable in all of the callers > move this to the RPM suspend/resume functions. > > Signed-off-by: Lucas Stach > Signed-off-by: Philipp Zabel Applied to imx-drm/next, thanks. regards Philipp __

Re: [PATCH v2 4/4] drm/imx: advertise supported plane format modifiers

2017-11-22 Thread Philipp Zabel
On Fri, 2017-11-10 at 17:10 +0100, Lucas Stach wrote: > Let userspace know about the supported modifiers, to make automatic > selection of a proper modifier possible. > > Signed-off-by: Lucas Stach Applied all four to imx-drm/next, thanks! regards Philipp ___

[Bug 103100] Performance regression with various games in drm-next-amd-staging Kernel

2017-11-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103100 --- Comment #6 from Christian König --- (In reply to Michel Dänzer from comment #4) > Christian, might it be possible to e.g. maintain a list of per-VM BOs which > were evicted from VRAM, and try to move them back to VRAM as part of the > existi

Re: [GIT PULL] imx-drm: various cleanups

2017-11-22 Thread Philipp Zabel
Hi Dave, On Wed, 2017-10-18 at 19:17 +0200, Philipp Zabel wrote: > Hi Dave, > > please consider merging these small cleanups for the imx-drm driver, > including a switch from drm_property_unreference_blob to > drm_property_blob_put, a change of the parallel-display connector enum > from VGA to DP

Re: [PATCH 1/3] drm/ttm: add set_pages_wb for handling page order more than zero

2017-11-22 Thread Christian König
Am 22.11.2017 um 12:50 schrieb Chris Wilson: Quoting Roger He (2017-11-22 11:44:27) Change-Id: Idf5ccb579d264b343199d8b8344bddeec2c0019f Signed-off-by: Roger He --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/ttm/ttm_p

Re: [PATCH 3/3] drm/ttm: roundup the shrink request to prevent skip huge pool

2017-11-22 Thread Chris Wilson
Quoting Roger He (2017-11-22 11:44:29) > e.g. shrink reqeust is less than 512, the logic will skip huge pool You should also tell the shrinker that you skipped objects so that it knows to accumulate the request for the next pass. See shrinkctl->nr_scanned. -Chris __

Re: [PATCH 1/3] drm/ttm: add set_pages_wb for handling page order more than zero

2017-11-22 Thread Christian König
Am 22.11.2017 um 12:44 schrieb Roger He: Change-Id: Idf5ccb579d264b343199d8b8344bddeec2c0019f Signed-off-by: Roger He Reviewed-by: Christian König for the whole series. --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu

Re: [PATCH 1/3] drm/ttm: add set_pages_wb for handling page order more than zero

2017-11-22 Thread Chris Wilson
Quoting Roger He (2017-11-22 11:44:27) > Change-Id: Idf5ccb579d264b343199d8b8344bddeec2c0019f > Signed-off-by: Roger He > --- > drivers/gpu/drm/ttm/ttm_page_alloc.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c > b/drivers/gpu/drm/ttm

[PATCH 1/3] drm/ttm: add set_pages_wb for handling page order more than zero

2017-11-22 Thread Roger He
Change-Id: Idf5ccb579d264b343199d8b8344bddeec2c0019f Signed-off-by: Roger He --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c index a8b2bfa..cdbb731 100644 --- a/d

[PATCH 2/3] drm/ttm: add page order support in ttm_pages_put

2017-11-22 Thread Roger He
Change-Id: Ia55b206d95812c5afcfd6cec29f580758d1f50f0 Signed-off-by: Roger He --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c index

[PATCH 3/3] drm/ttm: roundup the shrink request to prevent skip huge pool

2017-11-22 Thread Roger He
e.g. shrink reqeust is less than 512, the logic will skip huge pool Change-Id: Id8bd4d1ecff9f3ab14355e2dbd1c59b9fe824e01 Signed-off-by: Roger He --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_page_

[Bug 103175] R9285 Unreal tournament perf regression with agd5f 4.15-wip kernels possibly CPU related

2017-11-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103175 Andy Furniss changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 103100] Performance regression with various games in drm-next-amd-staging Kernel

2017-11-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103100 Andy Furniss changed: What|Removed |Added CC||adf.li...@gmail.com --- Comment #5 from

[PATCH v3] drm/printer: Add drm_vprintf()

2017-11-22 Thread Chris Wilson
Simple va_args equivalent to the existing drm_printf() for use with the drm_printer. v2: Fixup kerneldoc to match final parameter names. v3: Turn it into a kerneldoc comment Signed-off-by: Chris Wilson Cc: Rob Clark Reviewed-by: Daniel Vetter Cc: Dave Airlie --- Dave, could you ack this fo

RE: [PATCH 3/5] drm/ttm: add page order support in ttm_pages_put

2017-11-22 Thread He, Roger
Hi Christian: Maybe we can get back the logic for page order 0 in ttm_pages_put. I mean: handle order 0 with set_pages_array_wb and handle order 9 with set_pages_wb. If that, no performance concern. How about that? Thanks Roger(Hongbo.He) -Original Message- From: Christian König [mailto

[Bug 103100] Performance regression with various games in drm-next-amd-staging Kernel

2017-11-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103100 Michel Dänzer changed: What|Removed |Added CC||ckoenig.leichtzumerken@gmai

[Bug 103838] Random segfaults in applications from radeonsi_dri.so

2017-11-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103838 Michel Dänzer changed: What|Removed |Added Attachment #135653|text/x-log |text/plain mime type|

[Bug 103838] Random segfaults in applications from radeonsi_dri.so

2017-11-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103838 Michel Dänzer changed: What|Removed |Added Attachment #135654|text/x-log |text/plain mime type|

Re: [PATCH v9 4/5] x86/PCI: Enable a 64bit BAR on AMD Family 15h (Models 30h-3fh) Processors v5

2017-11-22 Thread Christian König
Am 21.11.2017 um 23:26 schrieb Boris Ostrovsky: On 11/21/2017 08:34 AM, Christian König wrote: Hi Boris, attached are two patches. The first one is a trivial fix for the infinite loop issue, it now correctly aborts the fixup when it can't find address space for the root window. The second is

[PATCH] lib/rbtree,drm/mm: Add rbtree_replace_node_cached()

2017-11-22 Thread Chris Wilson
Add a variant of rbtree_replace_node() that maintains the leftmost cache of struct rbtree_root_cached when replacing nodes within the rbtree. As drm_mm is the only rb_replace_node() being used on an interval tree, the mistake looks fairly self-contained. Furthermore the only user of drm_mm_replace

[Bug 100591] [AMD APU A9-9410] Kernel hang when using graphics acceleration

2017-11-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100591 --- Comment #8 from Hin-Tak Leung --- is this patch in the release kernel yet? -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.free

[Bug 103788] Screen goes blank after screen sleep and will not come back on

2017-11-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103788 --- Comment #4 from Hin-Tak Leung --- I seem to have a similar problem. Laptop working fine under fedora 26; since ungraded to fedora 27 a few days ago; when the screen sleeps, it won't wake. For other reasons I am still using the fedora 26 ker

Re: [PATCH 3/5] drm/ttm: add page order support in ttm_pages_put

2017-11-22 Thread Christian König
That completely negates the advantage of setting write back on multiple pages at once. In other words this way we wouldn't need the array any more at all and could remove the whole complicated handling. I'm pretty close to saying just go ahead with that and even clean up the whole stuff with

[PATCH 3/5] drm/ttm: add page order support in ttm_pages_put

2017-11-22 Thread Roger He
Change-Id: Ia55b206d95812c5afcfd6cec29f580758d1f50f0 Signed-off-by: Roger He --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c index 9b48b93

RE: [PATCH 2/4] drm/ttm: add page order support in ttm_pages_put

2017-11-22 Thread He, Roger
Hi Christian: This is old patch, I already send new patches. And it is clean and simple. Please check that. Thanks Roger(Hongbo.He) -Original Message- From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: Wednesday, November 22, 2017 5:29 PM To: He, Roger ; amd-...@lis

Re: [PATCH 1/5] drm/ttm: add page order in page pool

2017-11-22 Thread Chunming Zhou
the patch set looks ok to me, Reviewed-by: Chunming Zhou On 2017年11月22日 17:17, Roger He wrote: to indicate page order for each element in the pool Change-Id: Ic609925ca5d2a5d4ad49d6becf505388ce3624cf Signed-off-by: Roger He --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 38 +++

Re: [PATCH 1/5] drm/ttm: add page order in page pool

2017-11-22 Thread Christian König
Am 22.11.2017 um 10:17 schrieb Roger He: to indicate page order for each element in the pool Change-Id: Ic609925ca5d2a5d4ad49d6becf505388ce3624cf Signed-off-by: Roger He Reviewed-by: Christian König for this one. Feel free to commit it preliminary, but I think we still need to work on the

Re: [PATCH 2/4] drm/ttm: add page order support in ttm_pages_put

2017-11-22 Thread Christian König
I would rather completely nuke ttm_pages_put() instead of coming up with more workarounds here. Going to provide a cleanup patch to show what I mean, just give me a minute. Regards, Christian. Am 22.11.2017 um 06:36 schrieb Roger He: Change-Id: Ia55b206d95812c5afcfd6cec29f580758d1f50f0 Signed

[PATCH 5/5] drm/ttm: delete set_pages_array_wb since no one use it anymore

2017-11-22 Thread Roger He
Change-Id: I9fa45af447c3c78d0b7b2b8958081e584c560120 Signed-off-by: Roger He --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c index a710d9e..388c5b1 100644 --- a/dr

[PATCH 4/5] drm/ttm: roundup the shrink request to prevent skip huge pool

2017-11-22 Thread Roger He
e.g. shrink reqeust is less than 512, the logic will skip huge pool Change-Id: Id8bd4d1ecff9f3ab14355e2dbd1c59b9fe824e01 Signed-off-by: Roger He --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_page_

[PATCH 2/5] drm/ttm: add set_pages_wb for handling page order more than zero

2017-11-22 Thread Roger He
Change-Id: Idf5ccb579d264b343199d8b8344bddeec2c0019f Signed-off-by: Roger He --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c index a02bd65..9b48b93 100644 --- a/d

[PATCH 1/5] drm/ttm: add page order in page pool

2017-11-22 Thread Roger He
to indicate page order for each element in the pool Change-Id: Ic609925ca5d2a5d4ad49d6becf505388ce3624cf Signed-off-by: Roger He --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 38 +--- 1 file changed, 27 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/ttm

[PATCH] drm/bridge/sii8620: fix potential buffer overflow

2017-11-22 Thread Maciej Purski
Buffer overflow error should not occur, as mode_fixup() callback filters pixel clock value and it should never exceed 60. However, current implementation is not obviously safe and relies on implementation of mode_fixup(). Make 'i' variable never reach unsafe value in order to avoid buffer over

[Bug 103370] `vblank_mode=0 DRI_PRIME=1 glxgears` will introduce GPU lock up on Intel Graphics [8086:5917] + AMD Graphics [1002:6665] (rev c3)

2017-11-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103370 --- Comment #40 from Shih-Yuan Lee --- Created attachment 135662 --> https://bugs.freedesktop.org/attachment.cgi?id=135662&action=edit dmesg (In reply to Alex Deucher from comment #38) > Created attachment 135647 [details] [review] > workarou

[PATCH 10/30] drm/nouveau: deprecate pci_get_bus_and_slot()

2017-11-22 Thread Sinan Kaya
pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as where a PCI device is present. This restricts the device drivers to be reused for other domain numbers. Use pci_get_domain_bus_and_slot() with a domain number of 0 where we can't extract the domain number. Other places, use the

[PATCH 09/30] drm/i915: deprecate pci_get_bus_and_slot()

2017-11-22 Thread Sinan Kaya
pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as where a PCI device is present. This restricts the device drivers to be reused for other domain numbers. Use pci_get_domain_bus_and_slot() with a domain number of 0 where we can't extract the domain number. Other places, use the

Re: Autoselect patches for stable (Was: Re: [PATCH AUTOSEL for 4.9 36/56] drm/i915: Fix the level 0 max_wm hack on VLV/CHV)

2017-11-22 Thread Josh Boyer
On Tue, Nov 21, 2017 at 10:07 AM, wrote: > On Mon, Nov 20, 2017 at 11:21:52AM +, Emil Velikov wrote: >> - Document the autoselect process >>Information about about What, Why, and [ideally] How - analogous to >>the normal stable nominations. >>Insert reference to the process in the patch notif

Re: [PATCH v2 03/22] drm/arc: Use drm_fb_cma_fbdev_init/fini()

2017-11-22 Thread Alexey Brodkin
Hi Noralf, On Wed, 2017-11-15 at 15:19 +0100, Noralf Trønnes wrote: > Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on > the fact that drm_device holds a pointer to the drm_fb_helper structure. > This means that the driver doesn't have to keep track of that. > Also use the d

Re: [PATCH v9 4/5] x86/PCI: Enable a 64bit BAR on AMD Family 15h (Models 30h-3fh) Processors v5

2017-11-22 Thread Boris Ostrovsky
On 11/21/2017 08:34 AM, Christian König wrote: > Hi Boris, > > attached are two patches. > > The first one is a trivial fix for the infinite loop issue, it now > correctly aborts the fixup when it can't find address space for the > root window. > > The second is a workaround for your board. It simp

Re: [PATCH v2 00/22] drm/cma-helper: Remove drm_fbdev_cma* functions

2017-11-22 Thread Alexey Brodkin
Hi Noralf, On Tue, 2017-11-21 at 00:52 +0100, Noralf Trønnes wrote: > Den 17.11.2017 10.10, skrev Alexey Brodkin: > > > > Hi Noralf, > > > > On Thu, 2017-11-16 at 21:11 +0100, Noralf Trønnes wrote: > > > > > > Den 16.11.2017 09.14, skrev Shawn Guo: > > > > > > > > On Wed, Nov 15, 2017 at 03:19

Re: Autoselect patches for stable (Was: Re: [PATCH AUTOSEL for 4.9 36/56] drm/i915: Fix the level 0 max_wm hack on VLV/CHV)

2017-11-22 Thread alexander . levin
On Tue, Nov 21, 2017 at 12:09:33PM -0500, Josh Boyer wrote: >The root of the concern seems to be around how the stable process >currently works and how auto-selection plays into that. When Greg >sends out the RC, the default model of "if nobody objects, this patch >will get included in the next st

[PATCH] drm/mediatek: Use ERR_CAST instead of ERR_PTR(PTR_ERR())

2017-11-22 Thread Vasyl Gomonovych
Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...)). drivers/gpu/drm/mediatek/mtk_drm_gem.c:223:9-16: WARNING: ERR_CAST can be used with mtk_gem Generated by: scripts/coccinelle/api/err_cast.cocci Signed-off-by: Vasyl Gomonovych --- drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 +- 1 f

RE: [PATCH 1/4] drm/ttm: add page order in page pool

2017-11-22 Thread He, Roger
-Original Message- From: Koenig, Christian Sent: Wednesday, November 22, 2017 3:48 PM To: He, Roger ; amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Subject: Re: [PATCH 1/4] drm/ttm: add page order in page pool Am 22.11.2017 um 06:36 schrieb Roger He: > to indicate page

[PATCH 5/5] drm/ttm: delete set_pages_array_wb since no one use it anymore

2017-11-22 Thread Roger He
Change-Id: I9fa45af447c3c78d0b7b2b8958081e584c560120 Signed-off-by: Roger He --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c index 82d40c6..53fd8e9 100644 --- a/dr

[PATCH 4/5] drm/ttm: free one in huge pool even shrink request less than one element

2017-11-22 Thread Roger He
Change-Id: Id8bd4d1ecff9f3ab14355e2dbd1c59b9fe824e01 Signed-off-by: Roger He --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c index 343db0b..82d40c6 10064

[PATCH 2/5] drm/ttm: add set_pages_wb for handling page order more than zero

2017-11-22 Thread Roger He
Change-Id: Idf5ccb579d264b343199d8b8344bddeec2c0019f Signed-off-by: Roger He --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c index 2db551f..fabb082 100644 --- a/d

[PATCH 3/5] drm/ttm: add page order support in ttm_pages_put

2017-11-22 Thread Roger He
Change-Id: Ia55b206d95812c5afcfd6cec29f580758d1f50f0 Signed-off-by: Roger He --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c index fabb082

[PATCH 1/5] drm/ttm: add page order in page pool

2017-11-22 Thread Roger He
to indicate page order for each element in the pool Change-Id: Ic609925ca5d2a5d4ad49d6becf505388ce3624cf Signed-off-by: Roger He --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 42 ++-- 1 file changed, 31 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/ttm

Re: [PATCH 1/4] drm/ttm: add page order in page pool

2017-11-22 Thread Christian König
Am 22.11.2017 um 06:36 schrieb Roger He: to indicate page order for each element in the pool Change-Id: Ic609925ca5d2a5d4ad49d6becf505388ce3624cf Signed-off-by: Roger He --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 42 ++-- 1 file changed, 31 insertions(+), 11 d