RE: [PATCH] drm/ttm: add updated_glob_count in dma_page

2018-01-16 Thread He, Roger
-Original Message- From: Koenig, Christian Sent: Wednesday, January 17, 2018 3:37 PM To: He, Roger ; dri-devel@lists.freedesktop.org Cc: Grodzovsky, Andrey Subject: Re: [PATCH] drm/ttm: add updated_glob_count in dma_page Am 17.01.2018 um 06:54 schrieb Roger He: > add this for correctly

Re: [PATCH] drm/ttm: add updated_glob_count in dma_page

2018-01-16 Thread Christian König
Am 17.01.2018 um 06:54 schrieb Roger He: add this for correctly updating global mem count in ttm_mem_zone. before that when ttm_mem_global_alloc_page fails, we would update all dma_page's global mem count in ttm_dma->pages_list. but actually here we should not update for the last dma_page. Signe

drm: fix vmwgfx boot warning WAS Re: [PATCH] [RESEND] vmwgfx: use monotonic event timestamps

2018-01-16 Thread Thomas Hellstrom
Hi, Woody, On 01/16/2018 10:39 PM, Woody Suwalski wrote: Thomas, the same way my DRM patch has disappeared: Date Tue, 19 Dec 2017 11:50:57 -0800 From Sinclair Yeh <> Subject Re: [PATCH v.2] 4.15 vmgfx boot warning This looks okay to me. Since this is a core DRM patch I think S

[PATCH 0/4] drm/msm/dsi: Add DSI 10nm PLL/PHY drivers

2018-01-16 Thread Archit Taneja
Add the 10nm DSI PHY/PLL drivers. This will be used on the SDM845 SoC. Most of the code is based on the corresponding downstream PLL [1] and PHY [2] drivers. The PHY driver has a few TODOs which would be resolved in future patches. [1] https://source.codeaurora.org/quic/la/kernel/msm-4.9/tree/dr

[PATCH 3/4] drm/msm/dsi: Populate PLL 10nm clock ops

2018-01-16 Thread Archit Taneja
Populate PLL clock ops from downstream. This contains the VCO PLL ops and the registration of standard clk_divider and clk_mux clocks. Unlike 14nm PLL, the postdividers/mux of the slave PLL doesn't need to be set to the same values of the postdivs/mux of the master PLL. Hence, we don't need special

[PATCH 4/4] drm/msm/dsi: Populate the 10nm PHY funcs

2018-01-16 Thread Archit Taneja
Populate the PHY ops with the downstream driver as reference. There are a couple of TODOs which need to be resolved: - The PHY timings are all hardcoded for now. This needs to be replaced with automatic calculations once we get/understand them. - There are some lane configuration registers which

[PATCH 2/4] drm/msm/dsi: Add skeleton 10nm PHY/PLL code

2018-01-16 Thread Archit Taneja
Add new 10nm DSI PLL/PHY files that will be used on SDM845. Just populate empty pll/phy funcs for now. These will be filled up later. Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/Kconfig| 7 ++ drivers/gpu/drm/msm/Makefile | 2 + drivers/gpu/drm/msm/dsi

[PATCH 1/4] drm/msm/dsi: Update generated headers for 10nm PLL/PHY

2018-01-16 Thread Archit Taneja
Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/dsi/dsi.xml.h | 187 +++--- 1 file changed, 174 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi.xml.h b/drivers/gpu/drm/msm/dsi/dsi.xml.h index 479086ccf180..f6a9471b70c8 100644 --- a/dr

[PATCH] rnndb: dsi: Add DSI 10nm PLL/PHY registers

2018-01-16 Thread Archit Taneja
Signed-off-by: Archit Taneja --- rnndb/dsi/dsi.xml | 95 +++ 1 file changed, 95 insertions(+) diff --git a/rnndb/dsi/dsi.xml b/rnndb/dsi/dsi.xml index c7052378..fdcc2d3e 100644 --- a/rnndb/dsi/dsi.xml +++ b/rnndb/dsi/dsi.xml @@ -814,4 +814,99 @

[PATCH] drm/ttm: add updated_glob_count in dma_page

2018-01-16 Thread Roger He
add this for correctly updating global mem count in ttm_mem_zone. before that when ttm_mem_global_alloc_page fails, we would update all dma_page's global mem count in ttm_dma->pages_list. but actually here we should not update for the last dma_page. Signed-off-by: Roger He --- drivers/gpu/drm/tt

[Bug 104597] [bisected] Compton weird colors

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104597 --- Comment #9 from Fredrik Höglund --- The broken window preview is actually a bug in plasma. The thumbnail code doesn't look at the sizes of the color channels; it only checks that the GLX_BUFFER_SIZE matches the depth of the window. -- You

Re: [PATCHv<8> 3/3] ARM:drm ivip Intel FPGA Video and Image Processing Suite

2018-01-16 Thread kbuild test robot
Hi Ong, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on v4.15-rc8 next-20180116] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

[Bug 104597] [bisected] Compton weird colors

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104597 --- Comment #8 from Mario Kleiner --- compton didn't cause problems for me under default 24 bit color-depth on X-Server 1.19.3. But Christoph's setup is running the new server 1.19.6, and the glxinfo shows various new 32 bit visuals, not only r

Re: [PATCH] drm: Make PANEL_ORIENTATION_QUIRKS depend on DRM

2018-01-16 Thread kbuild test robot
Hi Chris, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on next-20180116] [cannot apply to v4.15-rc8] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

[Bug 104540] Corrupted colors in OBS-Studio window capture

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104540 --- Comment #2 from Mario Kleiner --- Just to add a bit to this: Testing this also on Kubuntu 16.04.3 LTS in X default color depth 24 bit and running apitrace on obs showed nothing suspicious to me wrt. selection of fbconfigs and visuals, creati

[radeon-alex:amd-staging-drm-next 1493/1561] sound/soc/amd/raven/acp3x-pcm-dma.c:246:10: error: implicit declaration of function 'page_to_phys'; did you mean 'page_to_pfn'?

2018-01-16 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next head: 39bfc5b3764e987ae64388e7169bc63589c93a79 commit: 4ab7d004f9ff2e877caa267887360e1804b4edcf [1493/1561] ASoC: AMD: enable ACP3x drivers build config: tile-allmodconfig (attached as .config) compiler: tilegx-linux-gcc

RE: [PATCH v2 1/2] drm/ttm: Allow page allocations w/o triggering OOM..

2018-01-16 Thread He, Roger
Reviewed-by: Roger He Thanks Roger(Hongbo.He) -Original Message- From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of Andrey Grodzovsky Sent: Tuesday, January 16, 2018 11:18 PM To: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; Koenig, Christia

[radeon-alex:amd-staging-drm-next 1493/1561] sound/soc/amd/raven/pci-acp3x.c:58:8: error: implicit declaration of function 'pci_enable_msi'

2018-01-16 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next head: 39bfc5b3764e987ae64388e7169bc63589c93a79 commit: 4ab7d004f9ff2e877caa267887360e1804b4edcf [1493/1561] ASoC: AMD: enable ACP3x drivers build config: openrisc-allmodconfig (attached as .config) compiler: or1k-linux-gc

RE: [PATCH 2/2] drm/amdgpu: Use new TTM flag to avoid OOM triggering.

2018-01-16 Thread He, Roger
-Original Message- From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: Tuesday, January 16, 2018 8:46 PM To: Grodzovsky, Andrey ; Koenig, Christian ; He, Roger ; dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org Subject: Re: [PATCH 2/2] drm/amdgpu: Use ne

[PATCH 4/4] drm/vgem: flush page during page fault

2018-01-16 Thread Gurchetan Singh
This is required to use buffers allocated by vgem on AMD and ARM devices. We're experiencing a case where eviction of the cache races with userspace writes. To fix this, flush the cache after retrieving a page. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/vgem/vgem_drv.c | 1 + 1 file chan

[PATCH 1/4] drm: rename {drm_clflush_sg, drm_clflush_pages}

2018-01-16 Thread Gurchetan Singh
Since clfush is an x86-only instruction, these function names won't make much sense if we start adding cases for other architectures. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/drm_cache.c | 12 ++-- drivers/gpu/drm/i915/i915_gem.c | 2 +- drivers/gpu

[PATCH 3/4] drm: add ARM flush implementations

2018-01-16 Thread Gurchetan Singh
The DMA API can be used to flush scatter gather tables and physical pages on ARM devices. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/drm_cache.c | 17 + drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 7 ++- drivers/gpu/drm/tegra/gem.c |

[PATCH 2/4] drm: add additional parameter in drm_flush_pages() and drm_flush_sg()

2018-01-16 Thread Gurchetan Singh
We've found the DMA API is effective for flushing the cache on ARM devices, and it requires a struct device *. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/drm_cache.c | 5 +++-- drivers/gpu/drm/i915/i915_gem.c | 2 +- drivers/gpu/drm/i915/i915_gem_clflush.c | 2 +- dri

Re: [PATCH] drm/fb-helper: Fix of-by-one in setcmap_pseudo_palette

2018-01-16 Thread Sean Paul
On Tue, Jan 16, 2018 at 11:27:28PM +0100, Daniel Vetter wrote: > On Tue, Jan 16, 2018 at 11:00 PM, Sean Paul wrote: > > On Fri, Jan 12, 2018 at 10:08:49PM +0100, Daniel Vetter wrote: > >> On Fri, Jan 12, 2018 at 3:08 PM, Sean Paul wrote: > >> > On Fri, Jan 12, 2018 at 4:48 AM, Daniel Vetter > >

Re: [PATCH] drm/fb-helper: Fix of-by-one in setcmap_pseudo_palette

2018-01-16 Thread Daniel Vetter
On Tue, Jan 16, 2018 at 11:00 PM, Sean Paul wrote: > On Fri, Jan 12, 2018 at 10:08:49PM +0100, Daniel Vetter wrote: >> On Fri, Jan 12, 2018 at 3:08 PM, Sean Paul wrote: >> > On Fri, Jan 12, 2018 at 4:48 AM, Daniel Vetter >> > wrote: >> >> [Fair warning: This is pure conjecture right now.] >> >>

Re: [PATCH] drm/dsi: Fix improper use of mipi_dsi_device_transfer() return value

2018-01-16 Thread Sean Paul
On Mon, Jan 15, 2018 at 10:12:24AM +0100, Andrzej Hajda wrote: > On 12.01.2018 15:48, Philippe Cornu wrote: > > The function mipi_dsi_device_transfer() returns the number of transmitted > > or received bytes on success or a negative error code on failure. > > > > The functions mipi_dsi_shutdown_per

[PATCH] drm/panel: panasonic-vvx10f034n00: Fix wuxga_nt_panel_disable() return value

2018-01-16 Thread Sean Paul
Return value for mipi_dsi_shutdown_peripheral() is unchecked. Check it and return any errors if they come up. Even if mipi_dsi_shutdown_peripheral() fails, continue attempting to disable. Cc: Philippe Cornu Signed-off-by: Sean Paul --- drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c | 5 ++

Re: [PATCH v2 2/2] drm: rcar-du: lvds: Fix LVDS startup on R-Car gen2

2018-01-16 Thread Laurent Pinchart
Hi Sergei, On Tuesday, 16 January 2018 22:17:31 EET Sergei Shtylyov wrote: > On 01/16/2018 06:46 PM, Laurent Pinchart wrote: > >>> From: Sergei Shtylyov > >>> > >>> According to the latest revision 2.00 of the R-Car gen2 manual, the LVDS > >>> must be enabled and the bias crcuit enabled after th

[Bug 104508] Unable to set "Content Type" bit for HDMI and DisplayPort

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104508 --- Comment #3 from N. W. --- Any update on this one? -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists

Re: [PATCH] drm/fb-helper: Fix of-by-one in setcmap_pseudo_palette

2018-01-16 Thread Sean Paul
On Fri, Jan 12, 2018 at 10:08:49PM +0100, Daniel Vetter wrote: > On Fri, Jan 12, 2018 at 3:08 PM, Sean Paul wrote: > > On Fri, Jan 12, 2018 at 4:48 AM, Daniel Vetter > > wrote: > >> [Fair warning: This is pure conjecture right now.] > >> > >> In > >> > >> commit b8e2b0199cc377617dc238f5106352c06

[Bug 104507] Unable to set "Content Type" bit for HDMI and DisplayPort

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104507 --- Comment #3 from N. W. --- Any update on this one? -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists

[Bug 104611] [fiji] BUG: unable to handle kernel NULL pointer dereference when waking up displays with amdgpu.dc=1

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104611 --- Comment #2 from roman...@amd.com --- I cannot reproduce it on v4.15-rc7 (git#1545dec46db3) Vedran, can you provide more info on your setup: - display and connector types - window manager - dmesg with amdgpu.dc_log=1 -- You are receiving th

Re: [PATCH] [RESEND] vmwgfx: use monotonic event timestamps

2018-01-16 Thread Arnd Bergmann
On Tue, Jan 16, 2018 at 6:28 PM, Thomas Hellstrom wrote: > Hi, Arnd, > > Sinclair's on paternal leave and I thought this patch was already in > drm-next. My bad. No worries. > Dave, is it too late to pull this in for the next merge window? The patch isn't urgent, it's fine to wait until after t

Re: [PATCH v16 00/10] Add backlight helper functions

2018-01-16 Thread Sean Paul
On Tue, Jan 16, 2018 at 10:31:07AM +, Meghana Madhyastha wrote: > Move drm helper functions from tinydrm-helpers to linux/backlight for > ease of use by callers in other drivers. > > Changes in v16: > -Add a comment about setting brightness = max_brightness in of_find_backlight > -Add dri-deve

[PATCH v2 2/3] drm/msm/dsi: correct DSI id bounds check during registration

2018-01-16 Thread Lloyd Atkinson
Check DSI instance id argument against the proper boundary size to protect against invalid configuration of the DSI id. Signed-off-by: Lloyd Atkinson --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.

Re: [Intel-gfx] [PATCH 1/5] drm/vblank: Fix return type for drm_vblank_count()

2018-01-16 Thread Pandiyan, Dhinakaran
On Mon, 2018-01-15 at 10:38 +0100, Daniel Vetter wrote: > On Fri, Jan 12, 2018 at 01:57:03PM -0800, Dhinakaran Pandiyan wrote: > > drm_vblank_count() has a u32 type returning what is a 64-bit vblank count. > > The effect of this is when drm_wait_vblank_ioctl() tries to widen the user > > space requ

[PATCH v2 1/3] drm/msm/dsi: check for failure on retrieving pll in dsi manager

2018-01-16 Thread Lloyd Atkinson
Make msm_dsi_pll_init consistently return an error code instead of NULL when pll initialization fails so that later pll retrieval can check against an error code. Add checks for these failures after retrieval of src_pll to avoid invalid pointer dereferences later in msm_dsi_pll_get_clk_provider. S

[PATCH v2 3/3] drm/msm/dsi: check msm_dsi and dsi pointers before use

2018-01-16 Thread Lloyd Atkinson
Move null checks of pointer arguments to the beginning of the modeset init function since they are referenced immediately instead of after they have already been used. Signed-off-by: Lloyd Atkinson --- drivers/gpu/drm/msm/dsi/dsi.c | 22 ++ 1 file changed, 10 insertions(+), 1

[PATCH v2 0/3] drm/msm/dsi: improve pointer validation checks

2018-01-16 Thread Lloyd Atkinson
This series improves a few pointer validation checks around the drm/msm/dsi driver. v2 incoporates feedback on patch 1/3 and patch 3/3. Lloyd Atkinson (3): drm/msm/dsi: check for failure on retrieving pll in dsi manager drm/msm/dsi: correct DSI id bounds check during registration drm/msm/ds

[Bug 104608] [r600, RV635] Removing radeon module results in BUG: unable to handle kernel NULL pointer dereference at 0000000000000258

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104608 --- Comment #5 from Vedran Miletić --- 4.15-rc8 on Kaveri after modprobe -r: [ 215.855452] [drm] radeon: finishing device. [ 215.895091] [TTM] Finalizing pool allocator [ 215.895254] [TTM] Finalizing DMA pool allocator [ 215.895302] [TTM] Z

Re: [PATCH v2 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-01-16 Thread Laurent Pinchart
Hi Rob, On Tuesday, 16 January 2018 18:54:00 EET Rob Herring wrote: > On Tue, Jan 16, 2018 at 10:32 AM, Laurent Pinchart wrote: > > On Tuesday, 16 January 2018 16:35:26 EET Rob Herring wrote: > >> On Mon, Jan 15, 2018 at 5:46 PM, Frank Rowand wrote: > >>> On 01/15/18 12:29, Laurent Pinchart wrote:

Re: [PATCH 01/19] drm/fourcc: Add a function to tell if the format embeds alpha

2018-01-16 Thread Maxime Ripard
Hi Ayan, On Mon, Jan 15, 2018 at 03:47:44PM +, Ayan Halder wrote: > On Tue, Jan 09, 2018 at 02:28:33PM +0100, Maxime Ripard wrote: > > On Tue, Jan 09, 2018 at 02:29:58PM +0200, Laurent Pinchart wrote: > > > On Tuesday, 9 January 2018 12:56:20 EET Maxime Ripard wrote: > > > > There's a bunch of

Re: [PATCH v2 2/2] drm: rcar-du: lvds: Fix LVDS startup on R-Car gen2

2018-01-16 Thread Sergei Shtylyov
On 01/16/2018 06:46 PM, Laurent Pinchart wrote: From: Sergei Shtylyov According to the latest revision 2.00 of the R-Car gen2 manual, the LVDS must be enabled and the bias crcuit enabled after the LVDS I/O pins are Oops, this needs fixing (note the typo!). Could you please change this pa

[PATCH v3] drm/amdgpu: Use new TTM flag to avoid OOM triggering.

2018-01-16 Thread Andrey Grodzovsky
Avoid OOM on syatem pages allocations. v2: Remove modeprobe parameter, make this behaviour the only option. v3: Move setting no_retry flag into amdgpu_ttm_init. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 1 file changed, 4 insertions(+) diff --git a/

[Bug 104660] DC R9 285 dual link DVI modes not shown.

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104660 --- Comment #5 from Andy Furniss --- Thanks, stupid monitor rather than some rounding then :-) -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-

[Bug 104660] DC R9 285 dual link DVI modes not shown.

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104660 --- Comment #4 from Alex Deucher --- (In reply to Andy Furniss from comment #3) > Thanks, that works. > > This is the same with non dc, but is there a reason they are a bit low? > > 1920x1080 (0x5b) 285.500MHz +HSync -VSync > h: widt

[Bug 104660] DC R9 285 dual link DVI modes not shown.

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104660 --- Comment #3 from Andy Furniss --- Thanks, that works. This is the same with non dc, but is there a reason they are a bit low? 1920x1080 (0x5b) 285.500MHz +HSync -VSync h: width 1920 start 1968 end 2000 total 2080 skew0 clock

Re: [PATCH v2 1/2] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet()

2018-01-16 Thread Brian Norris
Hi all, I believe Philippe's comments about return values have been addressed separately, and this patch was applied to drm-misc-next. But I have one additional thought below. On Tue, Jan 09, 2018 at 12:32:47PM -0800, Brian Norris wrote: > This takes care of 2 TODOs in this driver, by using the c

Re: [PATCH v2 2/2] drm/bridge/synopsys: dsi: handle endianness correctly in dw_mipi_dsi_write()

2018-01-16 Thread Brian Norris
On Tue, Jan 16, 2018 at 12:22:52PM +0530, Archit Taneja wrote: > On 01/10/2018 08:03 PM, Andrzej Hajda wrote: > >On 09.01.2018 21:32, Brian Norris wrote: > >>@@ -386,9 +386,9 @@ static int dw_mipi_dsi_write(struct dw_mipi_dsi *dsi, > >>} > >>} > >>- remainder = 0; > >>- memcpy(&

[Bug 104660] DC R9 285 dual link DVI modes not shown.

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104660 --- Comment #2 from Harry Wentland --- Created attachment 136782 --> https://bugs.freedesktop.org/attachment.cgi?id=136782&action=edit Fix for dual-link DVI modes The error is unrelated. This patch should fix your dual-link DVI modes. It's hi

[Bug 104660] DC R9 285 dual link DVI modes not shown.

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104660 --- Comment #1 from Andy Furniss --- Created attachment 136780 --> https://bugs.freedesktop.org/attachment.cgi?id=136780&action=edit xrandr with missing > 60Hz modes -- You are receiving this mail because: You are the assignee for the bug.__

[Bug 104660] DC R9 285 dual link DVI modes not shown.

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104660 Bug ID: 104660 Summary: DC R9 285 dual link DVI modes not shown. Product: DRI Version: DRI git Hardware: Other OS: All Status: NEW Severity: normal

Re: [PATCH] [RESEND] vmwgfx: use monotonic event timestamps

2018-01-16 Thread Thomas Hellstrom
Hi, Arnd, Sinclair's on paternal leave and I thought this patch was already in drm-next. My bad. Dave, is it too late to pull this in for the next merge window? /Thomas On 01/16/2018 06:18 PM, Arnd Bergmann wrote: DRM_VMW_EVENT_FENCE_SIGNALED (struct drm_vmw_event_fence) and DRM_EVENT_VBLAN

[PATCH] [RESEND] vmwgfx: use monotonic event timestamps

2018-01-16 Thread Arnd Bergmann
DRM_VMW_EVENT_FENCE_SIGNALED (struct drm_vmw_event_fence) and DRM_EVENT_VBLANK (struct drm_event_vblank) pass timestamps in 32-bit seconds/microseconds format. As of commit c61eef726a78 ("drm: add support for monotonic vblank timestamps"), other DRM drivers use monotonic times for drm_event_vblank

Re: [PATCH v16 07/10] drm/panel: Use backlight_enable/disable helpers

2018-01-16 Thread Noralf Trønnes
Den 16.01.2018 11.35, skrev Meghana Madhyastha: Use backlight_enable/disable helpers instead of changing the property and calling backlight_update_status for cleaner and simpler code and also to avoid repetitions. Signed-off-by: Meghana Madhyastha --- drivers/gpu/drm/panel/panel-innolux-p079

Re: [PATCH v16 09/10] drm/panel: Use of_find_backlight helper

2018-01-16 Thread Noralf Trønnes
Den 16.01.2018 11.36, skrev Meghana Madhyastha: Replace of_find_backlight_by_node and of the code around it with of_find_backlight helper to avoid repetition of code. Signed-off-by: Meghana Madhyastha --- drivers/gpu/drm/panel/panel-innolux-p079zca.c | 10 +++--- drivers/gpu/drm/panel

Re: [PATCH v16 06/10] drm/tinydrm: Call devres version of of_find_backlight

2018-01-16 Thread Noralf Trønnes
Den 16.01.2018 11.34, skrev Meghana Madhyastha: Call devm_of_find_backlight (the devres version) instead of of_find_backlight. Signed-off-by: Meghana Madhyastha --- drivers/gpu/drm/tinydrm/mi0283qt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tinydrm

Re: [PATCH v16 05/10] video: backlight: Add devres versions of of_find_backlight

2018-01-16 Thread Noralf Trønnes
Den 16.01.2018 11.34, skrev Meghana Madhyastha: Add devm_of_find_backlight and the corresponding release function because some drivers use devres versions of functions for acquiring device resources. Signed-off-by: Meghana Madhyastha checkpatch complains: -:26: WARNING: Block comments should

Re: [PATCH v16 04/10] drm/tinydrm: Replace tinydrm_of_find_backlight with of_find_backlight

2018-01-16 Thread Noralf Trønnes
Den 16.01.2018 11.34, skrev Meghana Madhyastha: Remove tinydrm_of_find_backlight from tinydrm-helpers.c. We now have a generic of_find_backlight defined in backlight.c. Let the callers of tinydrm_of_find_backlight call of_find_backlight. Signed-off-by: Meghana Madhyastha This patch needs reb

Re: [PATCH v16 03/10] video: backlight: Add of_find_backlight helper in backlight.c

2018-01-16 Thread Noralf Trønnes
Den 16.01.2018 11.33, skrev Meghana Madhyastha: Add of_find_backlight, a helper function which is a generic version of tinydrm_of_find_backlight that can be used by other drivers to avoid repetition of code and simplify things. Signed-off-by: Meghana Madhyastha --- Changes in v16: -Add comment

Re: [PATCH v2 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-01-16 Thread Rob Herring
On Tue, Jan 16, 2018 at 10:32 AM, Laurent Pinchart wrote: > Hi Rob, > > On Tuesday, 16 January 2018 16:35:26 EET Rob Herring wrote: >> On Mon, Jan 15, 2018 at 5:46 PM, Frank Rowand wrote: >> > On 01/15/18 12:29, Laurent Pinchart wrote: >> >> On Monday, 15 January 2018 22:12:33 EET Frank Rowand wro

[Bug 198123] Console is the wrong color at boot with radeon 6670

2018-01-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=198123 --- Comment #18 from Bill Fraser (bill.fra...@gmail.com) --- Assuming that patch is meant to be applied directly to b8e2b019 without any other patches, yep, that works for me. I tried rebasing onto 4.15-rc8, and it did so without any merge confli

Re: [PATCH v16 02/10] drm/tinydrm: Convert tinydrm_enable/disable_backlight to backlight_enable/disable

2018-01-16 Thread Noralf Trønnes
Den 16.01.2018 11.32, skrev Meghana Madhyastha: Remove tinydrm_enable/disable_backlight and let the callers call the more generic backlight_enable/disable helpers Signed-off-by: Meghana Madhyastha This patch needs to be rebased on some recent changes to mipi-dbi. Reviewed-by: Noralf Trønnes

Re: [PATCH v16 01/10] video: backlight: Add helpers to enable and disable backlight

2018-01-16 Thread Noralf Trønnes
Den 16.01.2018 11.31, skrev Meghana Madhyastha: Add helper functions backlight_enable and backlight_disable to enable/disable a backlight device. These helper functions can then be used by different drm and tinydrm drivers to avoid repetition of code and also to enforce a uniform and consistent

Re: [PATCH] [v2] drm/i915: use static const array for PICK macro

2018-01-16 Thread Arnd Bergmann
On Mon, Dec 11, 2017 at 7:40 PM, Chris Wilson wrote: > Quoting Chris Wilson (2017-12-11 12:51:42) >> Quoting Arnd Bergmann (2017-12-11 12:46:22) >> > v2: rebased after a1986f4174a4 ("drm/i915: Remove unnecessary PORT3 >> > definition.") >> > --- >> > drivers/gpu/drm/i915/i915_reg.h | 18

[Bug 104608] [r600, RV635] Removing radeon module results in BUG: unable to handle kernel NULL pointer dereference at 0000000000000258

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104608 --- Comment #4 from Vedran Miletić --- Actually, this seems to affect the Kaveri system from bug 99353 as well. I'll test 4.15-rc ASAP. -- You are receiving this mail because: You are the assignee for the bug.__

Re: [PATCH v2 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-01-16 Thread Laurent Pinchart
Hi Rob, On Tuesday, 16 January 2018 16:35:26 EET Rob Herring wrote: > On Mon, Jan 15, 2018 at 5:46 PM, Frank Rowand wrote: > > On 01/15/18 12:29, Laurent Pinchart wrote: > >> On Monday, 15 January 2018 22:12:33 EET Frank Rowand wrote: > >>> On 01/15/18 11:22, Laurent Pinchart wrote: > On Mond

Re: [PATCH v2 2/2] drm: rcar-du: lvds: Fix LVDS startup on R-Car gen2

2018-01-16 Thread Laurent Pinchart
Hi Sergei, On Saturday, 13 January 2018 11:33:55 EET Sergei Shtylyov wrote: > On 1/13/2018 2:10 AM, Laurent Pinchart wrote: > > From: Sergei Shtylyov > > > > According to the latest revision 2.00 of the R-Car gen2 manual, the LVDS > > must be enabled and the bias crcuit enabled after the LVDS I/

Re: [PATCH 1/2] drm: rcar-du: lvds: fix LVDS startup on R-Car gen3

2018-01-16 Thread Laurent Pinchart
Hi Sergei, On Saturday, 13 January 2018 11:25:31 EET Sergei Shtylyov wrote: > On 1/13/2018 1:15 AM, Laurent Pinchart wrote: > >>> According to the latest revisions of the R-Car gen3 manual, the LVDS > >>> mode must be set before the LVDS I/O pins are enabled, not after -- fix > >>> the gen3 LVDS

Re: [PATCH v2 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-01-16 Thread Geert Uytterhoeven
Hi Rob, On Tue, Jan 16, 2018 at 4:08 PM, Rob Herring wrote: > On Tue, Jan 16, 2018 at 2:56 AM, Geert Uytterhoeven > wrote: >> On Mon, Jan 15, 2018 at 7:01 PM, Laurent Pinchart >> wrote: >>> On Monday, 15 January 2018 19:09:53 EET Rob Herring wrote: On Fri, Jan 12, 2018 at 5:14 PM, Laurent

Re: [PATCH v2 1/2] drm/ttm: Allow page allocations w/o triggering OOM..

2018-01-16 Thread Christian König
Am 16.01.2018 um 16:18 schrieb Andrey Grodzovsky: This to allow drivers to choose to avoid OOM invocation and handle page allocation failures instead. v2: Remove extra new lines. Signed-off-by: Andrey Grodzovsky Reviewed-by: Christian König for the series. --- drivers/gpu/drm/ttm/ttm_bo

[PATCH v2 1/2] drm/ttm: Allow page allocations w/o triggering OOM..

2018-01-16 Thread Andrey Grodzovsky
This to allow drivers to choose to avoid OOM invocation and handle page allocation failures instead. v2: Remove extra new lines. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/ttm/ttm_bo.c | 3 +++ drivers/gpu/drm/ttm/ttm_page_alloc.c | 6 ++ drivers/gpu/drm/ttm/ttm_

[PATCH v2 2/2] drm/amdgpu: Use new TTM flag to avoid OOM triggering.

2018-01-16 Thread Andrey Grodzovsky
Avoid OOM on syatem pages allocations. v2: Remove modeprobe parameter, making this behaviour the only option. Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/dri

[Bug 99353] Kaveri 7400K shows random colored noise instead of GUI in X or Wayland

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99353 --- Comment #18 from Bong Cosca --- The only saving grace with all this display corruption is that there's a mouse cursor when I use amdgpu with 2D acceleration disabled. -- You are receiving this mail because: You are the assignee for the bug.

Re: [PATCH v2 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-01-16 Thread Rob Herring
On Tue, Jan 16, 2018 at 2:56 AM, Geert Uytterhoeven wrote: > Hi Laurent, > > On Mon, Jan 15, 2018 at 7:01 PM, Laurent Pinchart > wrote: >> On Monday, 15 January 2018 19:09:53 EET Rob Herring wrote: >>> On Fri, Jan 12, 2018 at 5:14 PM, Laurent Pinchart wrote: >>> > The internal LVDS encoders now h

Re: [PATCH] [RESEND] gpu: ipu-v3: prg: avoid possible array underflow

2018-01-16 Thread Philipp Zabel
Hi Arnd, On Tue, 2018-01-16 at 15:31 +0100, Arnd Bergmann wrote: > gcc-8 reports that we access an array with a negative index > in an error case: > > drivers/gpu/ipu-v3/ipu-prg.c: In function 'ipu_prg_channel_disable': > drivers/gpu/ipu-v3/ipu-prg.c:252:43: error: array subscript -22 is below >

[PATCH] [RESEND] drm/gma500: initialize gma_clock_t structures

2018-01-16 Thread Arnd Bergmann
The two functions pass a partially initialized structure back to the caller after a memset() on the destination. This is not entirely well-defined, most compilers are sensible enough to either keep the zero-initialization for the uninitialized members, but gcc-4.4 does not, and it warns about this

Re: [PATCH] drm: amd: dc: don't use FP math when Kcov is enabled

2018-01-16 Thread Arnd Bergmann
On Tue, Dec 5, 2017 at 6:01 PM, Harry Wentland wrote: >> > > Thanks, Arnd. This is what I was missing. I'll take another look. > > It would still work without KCOV, although I agree that's not ideal by any > means. Any update on this? I see building DCN1.0 with KCOV using gcc-8 is still broken.

Re: [PATCH v2 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-01-16 Thread Rob Herring
On Mon, Jan 15, 2018 at 5:46 PM, Frank Rowand wrote: > On 01/15/18 12:29, Laurent Pinchart wrote: >> Hi Frank, >> >> On Monday, 15 January 2018 22:12:33 EET Frank Rowand wrote: >>> On 01/15/18 11:22, Laurent Pinchart wrote: On Monday, 15 January 2018 21:12:44 EET Frank Rowand wrote: > On

[PATCH] [RESEND] gpu: ipu-v3: prg: avoid possible array underflow

2018-01-16 Thread Arnd Bergmann
gcc-8 reports that we access an array with a negative index in an error case: drivers/gpu/ipu-v3/ipu-prg.c: In function 'ipu_prg_channel_disable': drivers/gpu/ipu-v3/ipu-prg.c:252:43: error: array subscript -22 is below array bounds of 'struct ipu_prg_channel[3]' [-Werror=array-bounds] This move

Re: [PATCH 05/10] ARM: dts: porter: Fix HDMI output routing

2018-01-16 Thread Simon Horman
On Mon, Jan 15, 2018 at 10:25:34AM +0200, Laurent Pinchart wrote: > Hi Simon, > > On Monday, 15 January 2018 09:56:03 EET Simon Horman wrote: > > On Fri, Jan 12, 2018 at 02:58:53AM +0200, Laurent Pinchart wrote: > > > The HDMI encoder is connected to the RGB output of the DU, which is > > > port@0

Re: [PATCH 2/5] drm/ttm: Export the ttm_k[un]map_atomic_prot API.

2018-01-16 Thread Christian König
Am 16.01.2018 um 14:56 schrieb Thomas Hellstrom: It will be used by vmwgfx cpu blit. Cc: Christian König Signed-off-by: Thomas Hellstrom Reviewed-by: Brian Paul Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_util.c | 31 ++- include/drm/ttm/ttm

Re: [PATCH 1/5] drm/ttm: Clean up kmap_atomic_prot selection code

2018-01-16 Thread Christian König
Am 16.01.2018 um 14:56 schrieb Thomas Hellstrom: Use helpers to perform the kmap_atomic_prot() functionality to a) Avoid in-function ifdefs that violate the kernel coding policy, b) Facilitate exporting the functionality. This commit should not change any functionality. Cc: Christian König Sig

Re: [PATCH libdrm] drm: fix return value

2018-01-16 Thread Zhou, David(ChunMing)
Can your guys help me push it and last vamgr patches to upstream? My new count request for libdrm still is under pending. Thanks, David Zhou 发自坚果 Pro Christian K鰊ig 于 2018年1月16日 下午4:56写道: Apart from that a good catch and Reviewed-by: Christian König . Regards, Christian. Am 16.01.2018 um 09

[PATCH 0/5] drm/ttm, drm/vmwgfx: Use kmap_atomic() for cpu blit

2018-01-16 Thread Thomas Hellstrom
The purpose of this series is to remove the often full-screen vmwgfx sequence vmap() blit() vunmap() and replace it with kmap_atomic() style per-page maps. Although somewhat rare nowadays, 32-bit VMs restrict the vmap space so that huge vmaps may sometimes fail. Also, large vmaps lead to frequent

[PATCH 4/5] drm/vmwgfx: Add a cpu blit utility that can be used for page-backed bos

2018-01-16 Thread Thomas Hellstrom
The utility uses kmap_atomic() instead of vmapping the whole buffer object. As a result there will be more book-keeping but on some architectures this will help avoid exhausting vmalloc space and also avoid expensive TLB flushes. The blit utility also adds a provision to compute a bounding box of

[PATCH 3/5] drm/vmwgfx: Don't cache framebuffer maps

2018-01-16 Thread Thomas Hellstrom
Buffer objects need to be either pinned or reserved while a map is active, that's not the case here, so avoid caching the framebuffer map. This will cause increasing mapping activity mainly when we don't do page flipping. This fixes occasional garbage filled screens when the framebuffer has been e

[PATCH 5/5] drm/vmwgfx: Use the cpu blit utility for framebuffer to screen target blits

2018-01-16 Thread Thomas Hellstrom
This blit was previously performed using two large vmaps, one of which was teared down and remapped on each blit. Use the more resource- conserving TTM cpu blit instead. The blit is used in boundary-box computing mode which makes it possible to minimize the bounding box used in host operations. S

[PATCH 2/5] drm/ttm: Export the ttm_k[un]map_atomic_prot API.

2018-01-16 Thread Thomas Hellstrom
It will be used by vmwgfx cpu blit. Cc: Christian König Signed-off-by: Thomas Hellstrom Reviewed-by: Brian Paul --- drivers/gpu/drm/ttm/ttm_bo_util.c | 31 ++- include/drm/ttm/ttm_bo_api.h | 4 2 files changed, 30 insertions(+), 5 deletions(-) diff --git

[PATCH 1/5] drm/ttm: Clean up kmap_atomic_prot selection code

2018-01-16 Thread Thomas Hellstrom
Use helpers to perform the kmap_atomic_prot() functionality to a) Avoid in-function ifdefs that violate the kernel coding policy, b) Facilitate exporting the functionality. This commit should not change any functionality. Cc: Christian König Signed-off-by: Thomas Hellstrom --- drivers/gpu/drm/

[PATCH] [RESEND v2] drm/nouveau/clk: fix gcc-7 -Wint-in-bool-context warning

2018-01-16 Thread Arnd Bergmann
gcc thinks that interpreting a multiplication result as a bool is confusing: drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c: In function 'read_pll': drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c:133:8: error: '*' in boolean context, suggest '&&' instead [-Werror=int-in-bool-context] Adding a

[Bug 104608] [r600, RV635] Removing radeon module results in BUG: unable to handle kernel NULL pointer dereference at 0000000000000258

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104608 --- Comment #3 from Vedran Miletić --- (In reply to Michel Dänzer from comment #2) > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/ > ?id=e97f12f359775de4fabfb507f836ebffa20f4986 should help for this. Thanks. imirkin

[PATCH 4/7] drm/vmwgfx: Move screen object page flip to atomic function

2018-01-16 Thread Thomas Hellstrom
From: Deepak Rawat The dmabuf_dirty/surface_dirty in case of screen object is moved to plane atomic update, so that page flip in atomic ioctl also works. vmwgfx does not support DRM_MODE_PAGE_FLIP_ASYNC, so this flag is never expected. Signed-off-by: Deepak Rawat Signed-off-by: Thomas Hellstro

[PATCH 6/7] drm/vmwgfx: Send the correct nonblock option for atomic_commit

2018-01-16 Thread Thomas Hellstrom
From: Deepak Rawat Page flip can be slow for vmwgfx in some cases, like need to do surface copy to different surface or waiting for IN_FENCE_FD. Enabling nonblocking commits for vmwgfx in case userspace request it. Signed-off-by: Deepak Rawat Reviewed-by: Sinclair Yeh Signed-off-by: Thomas Hel

[PATCH 1/7] drm/vmwgfx: Avoid iterating over display unit if crtc is available

2018-01-16 Thread Thomas Hellstrom
From: Deepak Rawat In case of page flip there is no need to iterate over all display unit in the function "vmw_kms_helper_dirty". If crtc is available then dirty commands is performed on that crtc only. Signed-off-by: Deepak Rawat Reviewed-by: Sinclair Yeh Reviewed-by: Thomas Hellstrom --- d

[PATCH 7/7] drm/vmwgfx: Cursor update fixes

2018-01-16 Thread Thomas Hellstrom
Use drm_plane_helper_check_update also for the cursor plane. Avoid uploading a new cursor image on each cursor move and only upload cursor images on cursor fb changes, assuming that we're in effect page-flipping the cursor, which is exactly what the legacy helper does. Cursor front-buffer like rend

[PATCH 5/7] drm/vmwgfx: Move the stdu vblank event to atomic function

2018-01-16 Thread Thomas Hellstrom
From: Deepak Rawat Atomic ioctl can also send the same page flip flags as legacy ioctl. In those cases also need to send the vblank event to userspace. vmwgfx does not support flag DRM_MODE_PAGE_FLIP_ASYNC, so this flag is never expected. Signed-off-by: Deepak Rawat Signed-off-by: Thomas Hells

[PATCH 3/7] drm/vmwgfx: Remove drm_crtc_arm_vblank_event from atomic flush

2018-01-16 Thread Thomas Hellstrom
From: Deepak Rawat The function drm_crtc_arm_vblank_event should be used for the driver which have vblank interrupt support. In case of vmwgfx we do not have vblank interrupt. Signed-off-by: Deepak Rawat Reviewed-by: Thomas Hellstrom Reviewed-by: Sinclair Yeh --- drivers/gpu/drm/vmwgfx/vmwgf

[PATCH 2/7] drm/vmwgfx: Move surface copy cmd to atomic function

2018-01-16 Thread Thomas Hellstrom
From: Deepak Rawat When display surface is different than the framebuffer surface, atomic path do not copy the surface data. This commit moved the code to copy surface from legacy to atomic path. Signed-off-by: Deepak Rawat Reviewed-by: Sinclair Yeh Reviewed-by: Thomas Hellstrom --- drivers/

[PATCH 0/7] drm/vmwgfx: Various atomic modesetting fixes

2018-01-16 Thread Thomas Hellstrom
Part of the pageflip functionality that was intended to be performed using atomic commit was only present in the legacy pageflip ioctl. That problem is fixed in this series. We also better support nonblocking commits as some time-consuming operations previously were performed in the calling proces

  1   2   >