iommu_intel or i915 regression in 4.18, 4.19.12 and drm-tip

2018-12-27 Thread Eric Wong
I just got a used Thinkpad X201 (Core i5 M 520, Intel QM57 chipset) and hit some kernel panics while trying to view image/animation-intensive stuff in Firefox (X11) unless I use "iommu_intel=igfx_off". With Debian stable backport kernels, "linux-image-4.17.0-0.bpo.3-amd64" (4.17.17-1~bpo9+1) has n

Re: [RFC PATCH 1/2] drm/fb-helper: Bring back workaround for bugs of SDL 1.2

2018-12-27 Thread Ivan Mironov
On Thu, 2018-12-27 at 13:00 +0100, Daniel Vetter wrote: > > + /* > > +* Workaround for SDL 1.2, which is known to be setting all pixel format > > +* fields values to zero in some cases. We treat this situation as a > > +* kind of "use some reasonable autodetected values". > > +*/

Re: [PATCH v3 7/9] drm/komeda: Attach komeda_dev to DRM-KMS

2018-12-27 Thread Liviu Dudau
On Thu, Dec 27, 2018 at 07:09:07AM +, james qian wang (Arm Technology China) wrote: > On Mon, Dec 24, 2018 at 08:32:14PM +0800, Liviu Dudau wrote: > > On Fri, Dec 21, 2018 at 10:00:33AM +, james qian wang (Arm Technology > > China) wrote: > > > Add komeda_kms abstracton to attach komeda_d

Re: [PATCH 2/3] dt-bindings: gpu: samsung-rotator: Document s5pv210 support

2018-12-27 Thread Paweł Chmiel
Dnia środa, 19 grudnia 2018 17:22:51 CET Krzysztof Kozlowski pisze: > On Wed, 19 Dec 2018 at 17:04, Paweł Chmiel > wrote: > > > > This commit documents new compatible for s5pv210 soc, > > which will be also supported by this driver. > > > > Signed-off-by: Paweł Chmiel > > --- > > Documentation/d

[PATCH v1 1/2] drm/fb-helper: Bring back workaround for bugs of SDL 1.2

2018-12-27 Thread Ivan Mironov
SDL 1.2 sets all fields related to the pixel format to zero in some cases[1]. Prior to commit db05c48197759 ("drm: fb-helper: Reject all pixel format changing requests"), there was an unintentional workaround for this that existed for more than a decade. First in device-specific DRM drivers, then h

[PATCH v1 2/2] drm/fb-helper: Ignore the value of fb_var_screeninfo.pixclock

2018-12-27 Thread Ivan Mironov
Strict requirement of pixclock to be zero breaks support of SDL 1.2 which contains hardcoded table of supported video modes with non-zero pixclock values[1]. To better understand which pixclock values are considered valid and how driver should handle these values, I briefly examined few existing f

Re: [PATCH v2 1/3] dt-bindings: display: bridge: fork out ti, ds90c185 from lvds-transmitter

2018-12-27 Thread Peter Rosin
On 2018-12-27 22:27, Rob Herring wrote: > On Wed, Dec 19, 2018 at 02:04:47PM +0100, Peter Rosin wrote: >> From: Peter Rosin >> >> DS90C185 has a shutdown pin which does not fit in the lvds-transmitter >> binding, which is meant to be generic. >> >> The sister chip DS90C187 is similar to DS90C185,

Re: [PATCH] drm/intel_dsi_vbt: Remove duplicate header

2018-12-27 Thread Jani Nikula
On Tue, 25 Dec 2018, Brajeswar Ghosh wrote: > Remove video/mipi_display.h which is included more than once > > Signed-off-by: Brajeswar Ghosh Pushed to drm-intel-next-queued, thanks for the patch. BR, Jani. > --- > drivers/gpu/drm/i915/intel_dsi_vbt.c | 1 - > 1 file changed, 1 deletion(-) >

Re: [PATCH v3 7/9] drm/komeda: Attach komeda_dev to DRM-KMS

2018-12-27 Thread james qian wang (Arm Technology China)
On Thu, Dec 27, 2018 at 10:31:52PM +0800, Liviu Dudau wrote: > On Thu, Dec 27, 2018 at 07:09:07AM +, james qian wang (Arm Technology > China) wrote: > > On Mon, Dec 24, 2018 at 08:32:14PM +0800, Liviu Dudau wrote: > > > On Fri, Dec 21, 2018 at 10:00:33AM +, james qian wang (Arm Technology

[Bug 200695] Blank screen on RX 580 with amdgpu.dc=1 enabled (no displays detected)

2018-12-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=200695 anode@gmail.com changed: What|Removed |Added CC||anode@gmail.com --- Comment #22

Re: [Intel-gfx] [PATCH v3 2/3] drm: Add CRTC background color property (v3)

2018-12-27 Thread Eric Anholt
Brian Starkey writes: > Hi Matt, > > On Thu, Nov 15, 2018 at 02:13:45PM -0800, Matt Roper wrote: >>Some display controllers can be programmed to present non-black colors >>for pixels not covered by any plane (or pixels covered by the >>transparent regions of higher planes). Compositors that want

Re: [Intel-gfx] [PATCH v3 0/3] CRTC background color

2018-12-27 Thread Stéphane Marchesin
On Thu, Dec 27, 2018 at 4:45 PM Matt Roper wrote: > > On Thu, Dec 27, 2018 at 04:22:28PM -0800, Stéphane Marchesin wrote: > > On Thu, Dec 27, 2018 at 3:49 PM Li, Wei C wrote: > > > > > > Matt, > > > > > > Is that possible for you to get some time to review > > > https://chromium-review.googlesou

Re: [Intel-gfx] [PATCH v3 0/3] CRTC background color

2018-12-27 Thread Matt Roper
On Thu, Dec 27, 2018 at 04:22:28PM -0800, Stéphane Marchesin wrote: > On Thu, Dec 27, 2018 at 3:49 PM Li, Wei C wrote: > > > > Matt, > > > > Is that possible for you to get some time to review > > https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1387366 > > and confirm

Re: [Intel-gfx] [PATCH v3 0/3] CRTC background color

2018-12-27 Thread Stéphane Marchesin
On Thu, Dec 27, 2018 at 3:49 PM Li, Wei C wrote: > > Matt, > > Is that possible for you to get some time to review > https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1387366 > and confirm the FROMLIST change if it looks good to you so we could move > forward? > To be

RE: [Intel-gfx] [PATCH v3 0/3] CRTC background color

2018-12-27 Thread Li, Wei C
Matt, Is that possible for you to get some time to review https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1387366 and confirm the FROMLIST change if it looks good to you so we could move forward? BTW, I've backported your kernel patch into Chrome OS and verified it u

Re: [PATCH] drm/vc4: Allow fb modifiers early enough to fill IN_FORMATS property

2018-12-27 Thread Eric Anholt
Paul Kocialkowski writes: > The KMS mode_config elements are currently configured in vc4_kms_load, > that is called after all components are binded (component_bind_all). > However, the CRTC component (for the Pixel Valve) needs to access the > allow_fb_modifiers element at bind time, when initial

Re: [Intel-gfx] [PATCH v3 0/3] CRTC background color

2018-12-27 Thread Stéphane Marchesin
Hey, Is there anything missing on the Chrome side to move forward with this series? Stéphane On Thu, Nov 15, 2018 at 2:14 PM Matt Roper wrote: > > Third version of the series previously posted here: > https://lists.freedesktop.org/archives/intel-gfx/2018-November/181777.html > > This version

Re: [PATCH v1 7/7] drm: remove include of drmP.h from drm_gem_cma_helper.h

2018-12-27 Thread Sam Ravnborg
Hi David. Thanks for your comments. On Thu, Dec 27, 2018 at 10:28:07AM -0600, David Lechner wrote: > On 12/26/18 3:03 PM, Sam Ravnborg wrote: > >Fix fallout in various files/drivers. > > > > What fallout is being fixed? The removal of drmP.h from drm_gem_cma_helper.h resulted in some build erro

Re: [PATCH v1 2/7] drm: move DRM_SWITCH_POWER defines to drm_device.h

2018-12-27 Thread Sam Ravnborg
Hi Daniel. > > +/* Used by drm_device.switch_power_state */ > > +#define DRM_SWITCH_POWER_ON 0 > > +#define DRM_SWITCH_POWER_OFF 1 > > +#define DRM_SWITCH_POWER_CHANGING 2 > > +#define DRM_SWITCH_POWER_DYNAMIC_OFF 3 > > Since this isn't uapi it'd be nice to change it to an enum, which we can > th

Re: [PATCH v6 1/2] drm/sched: Refactor ring mirror list handling.

2018-12-27 Thread kbuild test robot
Hi Andrey, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on next-20181224] [cannot apply to v4.20] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://gith

Re: [PATCH v2 2/3] dt-bindings: display: bridge: lvds-transmitter: cleanup example

2018-12-27 Thread Rob Herring
On Wed, 19 Dec 2018 14:04:48 +0100, Peter Rosin wrote: > From: Peter Rosin > > Drop #address-cells and #size-cells from the root node in the > example, they are unused. > > Signed-off-by: Peter Rosin > --- > Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt | 2 -- > 1 file

Re: [PATCH v2 1/3] dt-bindings: display: bridge: fork out ti,ds90c185 from lvds-transmitter

2018-12-27 Thread Rob Herring
On Wed, Dec 19, 2018 at 02:04:47PM +0100, Peter Rosin wrote: > From: Peter Rosin > > DS90C185 has a shutdown pin which does not fit in the lvds-transmitter > binding, which is meant to be generic. > > The sister chip DS90C187 is similar to DS90C185, describe it here as well. > > Signed-off-by:

[PATCH v6 1/2] drm/sched: Refactor ring mirror list handling.

2018-12-27 Thread Andrey Grodzovsky
Decauple sched threads stop and start and ring mirror list handling from the policy of what to do about the guilty jobs. When stoppping the sched thread and detaching sched fences from non signaled HW fenes wait for all signaled HW fences to complete before rerunning the jobs. v2: Fix resubmission

[PATCH v6 2/2] drm/sched: Rework HW fence processing.

2018-12-27 Thread Andrey Grodzovsky
Expedite job deletion from ring mirror list to the HW fence signal callback instead from finish_work, together with waiting for all such fences to signal in drm_sched_stop we garantee that already signaled job will not be processed twice. Remove the sched finish fence callback and just submit finis

[v6 0/2] Add Colorspace connector property interface

2018-12-27 Thread Uma Shankar
This patch series creates a new connector property to program colorspace to sink devices. Modern sink devices support more than 1 type of colorspace like 601, 709, BT2020 etc. This helps to switch based on content type which is to be displayed. The decision lies with compositors as to in which scen

[v6 1/2] drm: Add colorspace connector property

2018-12-27 Thread Uma Shankar
This patch adds a colorspace connector property, enabling userspace to switch to various supported colorspaces. This will help enable BT2020 along with other colorspaces. v2: Addressed Maarten and Ville's review comments. Enhanced the colorspace enum to incorporate both HDMI and DP supported color

[v6 2/2] drm/i915: Attach colorspace property and enable modeset

2018-12-27 Thread Uma Shankar
This patch attaches the colorspace connector property to the hdmi connector. Based on colorspace change, modeset will be triggered to switch to new colorspace. Based on colorspace property value create an infoframe with appropriate colorspace. This can be used to send an infoframe packet with prop

[Bug 109162] Bugs Bunny: Lost in Time

2018-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109162 --- Comment #7 from smoki --- But replaying of trace show it fine, so it isn't LLVM :D -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@

[Bug 109162] Bugs Bunny: Lost in Time

2018-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109162 --- Comment #6 from smoki --- Ah OK, that Mesa for Windows uses LLVM 6, while Debian Mesa uses LLVM 7... so could be an LLVM regression. -- You are receiving this mail because: You are the assignee for the bug.___

[Bug 109162] Bugs Bunny: Lost in Time

2018-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109162 --- Comment #5 from smoki --- And BTW forgot to mention... on AMD proprietary OpenGL driver this is fine. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mail

[Bug 109162] Bugs Bunny: Lost in Time

2018-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109162 --- Comment #4 from smoki --- I tried various MESA version overrides and R600_DEBUG variables like no2d, notiling and such to no avail, even tried to disable DRI3 with LIBGL_DRI3_DISABLE and nope - mess is still there. -- You are receiving t

[Bug 109162] Bugs Bunny: Lost in Time

2018-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109162 --- Comment #3 from smoki --- So, software Mesa for Windows shows it correctly, while same version of software Mesa for Linux via LIBGL_ALWAYS_SOFTWARE=true show this garbage ;) -- You are receiving this mail because: You are the assignee fo

Re: [PATCH v1 7/7] drm: remove include of drmP.h from drm_gem_cma_helper.h

2018-12-27 Thread David Lechner
On 12/26/18 3:03 PM, Sam Ravnborg wrote: Fix fallout in various files/drivers. What fallout is being fixed? It would be helpful if we received the full patch series for context. It would also be nice to have a more detailed description in this commit message. _

[Bug 109162] Bugs Bunny: Lost in Time

2018-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109162 --- Comment #2 from smoki --- Link to the trace: https://www.dropbox.com/s/tk2i1j6ownzh4px/bugs-trace.7z Anyway, this replays fine here too. It is just when i run a game actually this mess came by. I tried to run game on a CPU by using s

Re: [PATCH 6/6] drm/i915: drop all drmP.h includes

2018-12-27 Thread Jani Nikula
On Thu, 27 Dec 2018, Daniel Vetter wrote: > I guess next up would be to split up i915_drv.h and intel_drv.h and see > how much our driver is a spaghetti mess where everything needs everything > else :-) In general this got me wondering how self-contained the header files really need to be. Turns

[Bug 109162] Bugs Bunny: Lost in Time

2018-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109162 --- Comment #1 from smoki --- Created attachment 142904 --> https://bugs.freedesktop.org/attachment.cgi?id=142904&action=edit mess on the screen This is how it looks like. Broken presentation image i would say, as trace shows it OK. -- Yo

[RFC] drm: add DRM_DEBUG_CORE() and friends and use them

2018-12-27 Thread Jani Nikula
DRM_DEBUG() was intended to be used by the drm core code only, but we weren't careful. Today, the driver usage of DRM_DEBUG() trumps drm core usage about 10:1. It's easier to swith the core over to a new DRM_DEBUG_CORE() macro than the drivers over to DRM_DEBUG_DRIVER(). Do the same for DRM_DEV_DE

[Bug 109162] Bugs Bunny: Lost in Time

2018-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109162 Bug ID: 109162 Summary: Bugs Bunny: Lost in Time Product: Mesa Version: 18.2 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal

[Bug 109150] "failed to set DRM interface version 1.4: Permission denied" after resume for lock screen.

2018-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109150 Michel Dänzer changed: What|Removed |Added Attachment #142890|text/x-log |text/plain mime type|

[Bug 109150] "failed to set DRM interface version 1.4: Permission denied" after resume for lock screen.

2018-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109150 Michel Dänzer changed: What|Removed |Added Attachment #142891|text/x-log |text/plain mime type|

[Bug 109135] R9 390 hangs at boot with DPM/DC enabled for kernels 4.19.x and above, says KMS not supported

2018-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109135 --- Comment #4 from Michel Dänzer --- Looks VCE related: Dec 24 21:12:11.223675 tom-comp kernel: [drm:amdgpu_vce_ring_test_ring [amdgpu]] *ERROR* amdgpu: ring 12 test failed Dec 24 21:12:11.223708 tom-comp kernel: [drm:amdgpu_device_init.cold.1

Re: [PATCH 6/6] drm/i915: drop all drmP.h includes

2018-12-27 Thread Daniel Vetter
On Thu, Dec 27, 2018 at 02:56:41PM +0200, Jani Nikula wrote: > Needs just a few additional includes here and there. > > Cc: Sam Ravnborg > Cc: Daniel Vetter > Cc: Laurent Pinchart > Signed-off-by: Jani Nikula lgtm, but didn't try to second-guess gcc :-) Acked-by: Daniel Vetter I guess next

[Bug 109135] R9 390 hangs at boot with DPM/DC enabled for kernels 4.19.x and above, says KMS not supported

2018-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109135 Michel Dänzer changed: What|Removed |Added Attachment #142880|text/x-log |text/plain mime type|

[Bug 109135] R9 390 hangs at boot with DPM/DC enabled for kernels 4.19.x and above, says KMS not supported

2018-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109135 Michel Dänzer changed: What|Removed |Added Attachment #142874|text/x-log |text/plain mime type|

[Bug 109135] R9 390 hangs at boot with DPM/DC enabled for kernels 4.19.x and above, says KMS not supported

2018-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109135 Michel Dänzer changed: What|Removed |Added Attachment #142875|text/x-log |text/plain mime type|

Re: [PATCH 1/6] drm: include drm_device.h from drm_legacy.h

2018-12-27 Thread Daniel Vetter
On Thu, Dec 27, 2018 at 05:04:20PM +0100, Daniel Vetter wrote: > On Thu, Dec 27, 2018 at 02:56:36PM +0200, Jani Nikula wrote: > > Make it easier to drop drmP.h includes. > > > > Cc: Sam Ravnborg > > Cc: Daniel Vetter > > Cc: Laurent Pinchart > > Signed-off-by: Jani Nikula > > --- > > include/

Re: [PATCH 5/6] drm: include drm_file.h from drm_syncobj.h

2018-12-27 Thread Daniel Vetter
On Thu, Dec 27, 2018 at 02:56:40PM +0200, Jani Nikula wrote: > Make it easier to drop drmP.h includes. Switch from "" to <> includes > while at it. > > Cc: Sam Ravnborg > Cc: Daniel Vetter > Cc: Laurent Pinchart > Signed-off-by: Jani Nikula > --- > include/drm/drm_syncobj.h | 4 +++- > 1 file

Re: [PATCH 4/6] drm: include types.h from drm_hdcp.h

2018-12-27 Thread Daniel Vetter
On Thu, Dec 27, 2018 at 02:56:39PM +0200, Jani Nikula wrote: > Make it easier to drop drmP.h includes. > > Cc: Sam Ravnborg > Cc: Daniel Vetter > Cc: Laurent Pinchart > Signed-off-by: Jani Nikula Reviewed-by: Daniel Vetter > --- > include/drm/drm_hdcp.h | 2 ++ > 1 file changed, 2 insertion

Re: [PATCH 3/6] drm: include idr.h from drm_file.h

2018-12-27 Thread Daniel Vetter
On Thu, Dec 27, 2018 at 02:56:38PM +0200, Jani Nikula wrote: > Make it easier to drop drmP.h includes. > > Cc: Sam Ravnborg > Cc: Daniel Vetter > Cc: Laurent Pinchart > Signed-off-by: Jani Nikula > --- > include/drm/drm_file.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/

Re: [PATCH 2/6] drm: include kernel.h and agp_backend.h from intel-gtt.h

2018-12-27 Thread Daniel Vetter
On Thu, Dec 27, 2018 at 02:56:37PM +0200, Jani Nikula wrote: > Make it easier to drop drmP.h includes. > > Cc: Sam Ravnborg > Cc: Daniel Vetter > Cc: Laurent Pinchart > Signed-off-by: Jani Nikula Makes sense. Reviewed-by: Daniel Vetter > --- > include/drm/intel-gtt.h | 3 +++ > 1 file cha

Re: [PATCH 1/6] drm: include drm_device.h from drm_legacy.h

2018-12-27 Thread Daniel Vetter
On Thu, Dec 27, 2018 at 02:56:36PM +0200, Jani Nikula wrote: > Make it easier to drop drmP.h includes. > > Cc: Sam Ravnborg > Cc: Daniel Vetter > Cc: Laurent Pinchart > Signed-off-by: Jani Nikula > --- > include/drm/drm_legacy.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/includ

Re: [PATCH 0/6] drm/i915: drmP.h include removal w/ drm prep work

2018-12-27 Thread Daniel Vetter
On Thu, Dec 27, 2018 at 02:56:35PM +0200, Jani Nikula wrote: > First make some drm headers self-contained, removing the implicit > dependency on a previous drmP.h include. Then remove all drmP.h includes > from drm/i915. > > Inspired by Sam's series [1]. Theres a one line trivial conflict between

[Bug 109161] Kernel crash shortly after gnome-shell login - refcount_t: increment on 0; use-after-free

2018-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109161 --- Comment #2 from Yanko Kaneti --- I can confirm the fix. After applying 77acd1cd912987ffd62dad6a09275a1fb406f0c2 on top of linus tip shell is stable, so far. Thanks -- You are receiving this mail because: You are the assignee for the bug

[Bug 109140] [KBL-G][GL] KHR-GL43.compute_shader.max test failed

2018-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109140 Michel Dänzer changed: What|Removed |Added Version|XOrg git|18.3 QA Contact|

[Bug 109159] [KBL-G][vulkan] dEQP-VK.api.version_check.entry_points test failed.

2018-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109159 Michel Dänzer changed: What|Removed |Added Component|DRM/AMDgpu |Drivers/Vulkan/radeon Assigne

[Bug 109161] Kernel crash shortly after gnome-shell login - refcount_t: increment on 0; use-after-free

2018-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109161 --- Comment #1 from Michel Dänzer --- Probably introduced by https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=674e78acae0dfb4beb56132e41cbae5b60f7d662 , fixed by https://cgit.freedesktop.org/~agd5f/linux/commit/?h=dr

RE: [v5 2/2] drm/i915: Attach colorspace property and enable modeset

2018-12-27 Thread Shankar, Uma
>-Original Message- >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of >Sharma, Shashank >Sent: Thursday, December 20, 2018 11:02 PM >To: Shankar, Uma ; intel-...@lists.freedesktop.org; >dri-devel@lists.freedesktop.org >Cc: hansv...@cisco.com; Syrjala, Ville ;

Re: [PATCH v3 7/9] drm/komeda: Attach komeda_dev to DRM-KMS

2018-12-27 Thread Liviu Dudau
On Thu, Dec 27, 2018 at 07:09:07AM +, james qian wang (Arm Technology China) wrote: > On Mon, Dec 24, 2018 at 08:32:14PM +0800, Liviu Dudau wrote: > > On Fri, Dec 21, 2018 at 10:00:33AM +, james qian wang (Arm Technology > > China) wrote: > > > Add komeda_kms abstracton to attach komeda_d

[PATCH 2/6] drm: include kernel.h and agp_backend.h from intel-gtt.h

2018-12-27 Thread Jani Nikula
Make it easier to drop drmP.h includes. Cc: Sam Ravnborg Cc: Daniel Vetter Cc: Laurent Pinchart Signed-off-by: Jani Nikula --- include/drm/intel-gtt.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/drm/intel-gtt.h b/include/drm/intel-gtt.h index 2324c84a25c0..71d81923e6b0 1006

[PATCH 0/6] drm/i915: drmP.h include removal w/ drm prep work

2018-12-27 Thread Jani Nikula
First make some drm headers self-contained, removing the implicit dependency on a previous drmP.h include. Then remove all drmP.h includes from drm/i915. Inspired by Sam's series [1]. Theres a one line trivial conflict between that one and this series in drm_file.h (patch 3), but I'm keeping this

[PATCH 6/6] drm/i915: drop all drmP.h includes

2018-12-27 Thread Jani Nikula
Needs just a few additional includes here and there. Cc: Sam Ravnborg Cc: Daniel Vetter Cc: Laurent Pinchart Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/dvo.h | 1 - drivers/gpu/drm/i915/i915_drv.c| 1 - drivers/gpu/drm/i915/i915_drv.h| 2 +- dr

[PATCH 3/6] drm: include idr.h from drm_file.h

2018-12-27 Thread Jani Nikula
Make it easier to drop drmP.h includes. Cc: Sam Ravnborg Cc: Daniel Vetter Cc: Laurent Pinchart Signed-off-by: Jani Nikula --- include/drm/drm_file.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h index 84ac79219e4c..6710b612e2f6 100644 ---

[PATCH 5/6] drm: include drm_file.h from drm_syncobj.h

2018-12-27 Thread Jani Nikula
Make it easier to drop drmP.h includes. Switch from "" to <> includes while at it. Cc: Sam Ravnborg Cc: Daniel Vetter Cc: Laurent Pinchart Signed-off-by: Jani Nikula --- include/drm/drm_syncobj.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/drm/drm_syncobj.h

[PATCH 4/6] drm: include types.h from drm_hdcp.h

2018-12-27 Thread Jani Nikula
Make it easier to drop drmP.h includes. Cc: Sam Ravnborg Cc: Daniel Vetter Cc: Laurent Pinchart Signed-off-by: Jani Nikula --- include/drm/drm_hdcp.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h index a6de09c5e47f..d6dfef8cff6a 100644 -

[PATCH 1/6] drm: include drm_device.h from drm_legacy.h

2018-12-27 Thread Jani Nikula
Make it easier to drop drmP.h includes. Cc: Sam Ravnborg Cc: Daniel Vetter Cc: Laurent Pinchart Signed-off-by: Jani Nikula --- include/drm/drm_legacy.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/drm_legacy.h b/include/drm/drm_legacy.h index 8fad66f88e4f..743d7e70c896 1006

Re: [PATCH 0/6] drm/i915: drmP.h include removal w/ drm prep work

2018-12-27 Thread Jani Nikula
On Thu, 27 Dec 2018, Jani Nikula wrote: > First make some drm headers self-contained, removing the implicit > dependency on a previous drmP.h include. Then remove all drmP.h includes > from drm/i915. > > Inspired by Sam's series [1]. Theres a one line trivial conflict between > that one and this s

Re: [PATCH] drm/i915_request.h: Remove duplicate header

2018-12-27 Thread Chris Wilson
Quoting Brajeswar Ghosh (2018-12-25 13:23:40) > Remove i915_scheduler.h which is included more than once > > Signed-off-by: Brajeswar Ghosh Thanks for the patch, pushed to dinq. -Chris ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://

[Bug 109161] Kernel crash shortly after gnome-shell login - refcount_t: increment on 0; use-after-free

2018-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109161 Bug ID: 109161 Summary: Kernel crash shortly after gnome-shell login - refcount_t: increment on 0; use-after-free Product: DRI Version: unspecified Hardware: Other

Re: [PATCH] drm: rcar-du: Remove inclusion of drmP.h

2018-12-27 Thread Daniel Vetter
On Thu, Dec 27, 2018 at 12:12:06PM +0200, Laurent Pinchart wrote: > The DRM kernel API used to be defined in a handful of headers, pulled in > through drmP.h. It has since been split in multiple headers for the > different DRM components, and drmP.h turned into a legacy header that > just pulls in

Re: [PATCH v1 3/7] drm: move drm_can_sleep() to drm_util.h

2018-12-27 Thread Daniel Vetter
On Wed, Dec 26, 2018 at 10:03:49PM +0100, Sam Ravnborg wrote: > Move drm_can_sleep() out of drmP.h to allow users > to get rid of the drmP.h include. > > There was no header file that was a good match for this helper function. > So add this to drm_util with the relevant includes. > > Add include

Re: [PATCH v1 2/7] drm: move DRM_SWITCH_POWER defines to drm_device.h

2018-12-27 Thread Daniel Vetter
On Wed, Dec 26, 2018 at 10:03:48PM +0100, Sam Ravnborg wrote: > Move DRM_SWITCH_POWER out of drmP.h to allow users > to get rid of the drmP include. > > DRM_SWITCH_POWER defines are used in combination > with drm_device.switch_power_state. > > Move the DRM_SWITCH_POWER defines to the file where >

Re: [PATCH v1 1/7] drm: move DRM_IF_VERSION to drm_internal.h

2018-12-27 Thread Daniel Vetter
On Wed, Dec 26, 2018 at 10:03:47PM +0100, Sam Ravnborg wrote: > Move DRM_IF_VERSION out of drmP.h to allow users > to get rid of the drmP include. > > Signed-off-by: Sam Ravnborg > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter Applied to dr

[Bug 109122] blank screen on rx580 starting with kernel 4.19.9

2018-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109122 --- Comment #3 from Matej Lach --- I can confirm this bug is indeed present. Worth noting that the screen is only blank on the laptop built-in display, (after KMS), external monitors work fine. Adding `amdgpu.dc=0` to the kernel parameters re

Re: [RFC PATCH 1/2] drm/fb-helper: Bring back workaround for bugs of SDL 1.2

2018-12-27 Thread Daniel Vetter
On Wed, Dec 26, 2018 at 05:11:23PM +0500, Ivan Mironov wrote: > SDL 1.2 sets all fields related to the pixel format to zero in some > cases[1]. Prior to commit db05c48197759 ("drm: fb-helper: Reject all > pixel format changing requests"), there was an unintentional workaround > for this that existe

Re: [PATCH] drm: Put damage blob when destroy plane state

2018-12-27 Thread Daniel Vetter
On Wed, Dec 26, 2018 at 09:50:44AM -0800, Deepak Singh Rawat wrote: > On Tue, 2018-12-25 at 07:01 -0800, Thomas Hellstrom wrote: > > On Mon, 2018-12-24 at 11:49 +0100, Daniel Vetter wrote: > > > On Fri, Dec 21, 2018 at 8:56 PM Thomas Hellstrom < > > > thellst...@vmware.com> wrote: > > > > Reviewed-

Re: [PATCH 2/3] drm/amd: validate user pitch alignment

2018-12-27 Thread Michel Dänzer
On 2018-12-23 10:44 p.m., Yu Zhao wrote: > On Fri, Dec 21, 2018 at 10:07:26AM +0100, Michel Dänzer wrote: >> On 2018-12-21 4:10 a.m., Yu Zhao wrote: >>> Userspace may request pitch alignment that is not supported by GPU. >>> Some requests 32, but GPU ignores it and uses default 64 when cpp is >>> 4

Re: [PATCH] drm/drm_drv.c: Remove duplicate header

2018-12-27 Thread Daniel Vetter
On Mon, Dec 24, 2018 at 08:06:36PM +0530, Brajeswar Ghosh wrote: > Remove drm_crtc_internal.h which is included more than once > > Signed-off-by: Brajeswar Ghosh Applied, thanks for your patch. -Daniel > --- > drivers/gpu/drm/drm_drv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/d

[PATCH] drm: rcar-du: Remove inclusion of drmP.h

2018-12-27 Thread Laurent Pinchart
The DRM kernel API used to be defined in a handful of headers, pulled in through drmP.h. It has since been split in multiple headers for the different DRM components, and drmP.h turned into a legacy header that just pulls in most of the DRM kernel API (and a large number of other miscellaneous kern

Re: [PATCH v1 6/7] drm: remove include of drmP.h from drm_modeset_helper.h

2018-12-27 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Wednesday, 26 December 2018 23:03:52 EET Sam Ravnborg wrote: > Fix fallout in various files/drivers by adding missing include files. > > Signed-off-by: Sam Ravnborg > Cc: Alexey Brodkin > Cc: David Airlie > Cc: Daniel Vetter > Cc: Archit Taneja > Cc: Andr

Re: [PATCH v1 4/7] drm: remove include of drmP.h from bridge/dw_hdmi.h

2018-12-27 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Wednesday, 26 December 2018 23:03:50 EET Sam Ravnborg wrote: > Add missing includes in dw_hdmi.h and > fix fallout in drivers. > > Signed-off-by: Sam Ravnborg > Cc: Archit Taneja > Cc: Andrzej Hajda > Cc: Laurent Pinchart > Cc: David Airlie > Cc: Daniel V

Re: [PATCH] backlight: (adp8870) fix a missing check for adp8870_write

2018-12-27 Thread Sam Ravnborg
Hi Kangjie > adp8870_write() may fail. This fix checks if adp8870_write fails, and if > so, returns its error code. > > Signed-off-by: Kangjie Lu > --- > drivers/video/backlight/adp8870_bl.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/drivers/video/back

答复: [PATCH] gpu: drm: fix an improper check of amdgpu_bo_create_kernel

2018-12-27 Thread Qu, Jim
Comments in line. Thanks JimQu 发件人: amd-gfx 代表 Kangjie Lu 发送时间: 2018年12月26日 14:23 收件人: k...@umn.edu 抄送: Zhou, David(ChunMing); David Airlie; Xu, Feifei; Francis, David; linux-ker...@vger.kernel.org; amd-...@lists.freedesktop.org; Huang, Ray; dri-devel

[Bug 107978] [amdgpu] Switching to tty fails with DisplayPort 1.2 monitor going to sleep (REG_WAIT timeout / dce110_stream_encoder_dp_blank)

2018-12-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107978 --- Comment #38 from Shmerl --- (In reply to Jerry Zuo from comment #30) > Please try the patch, and see if you can see reg_wait timeout > dce110_stream_encoder_dp_blank() Do you plan to backport at least this patch to 4.20.x? -- You are rece

Re: [PATCH 15/18] drm/mediatek: add RDMA1 fifo size into RDMA private data

2018-12-27 Thread CK Hu
Hi, Yongqiang: On Mon, 2018-12-24 at 16:08 +0800, Yongqiang Niu wrote: > This patch add RDMA1 fifo size into RDMA private data > > Signed-off-by: Yongqiang Niu > --- > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 16 +++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --g