[Bug 202537] amdgpu/DC failed to reserve new abo buffer before flip

2019-02-13 Thread bugzilla-daemon--- via dri-devel
https://bugzilla.kernel.org/show_bug.cgi?id=202537 --- Comment #10 from Bernd Steinhauser (li...@bernd-steinhauser.de) --- Unfortunately this turns out to be much harder than expected, because about 1/3 of the revs to test just won't boot at all (like instant kernel panic and not responding).

[PATCH] drm/msm: fix an error code in the ioctl

2019-02-13 Thread Dan Carpenter via dri-devel
The copy_to/from_user() functions return the number of bytes remaining to be copied but we should return -EFAULT to the user. Fixes: f05c83e77460 ("drm/msm: add uapi to get/set debug name") Signed-off-by: Dan Carpenter --- If I were reviewing this patch, I would be suspicous that we don't return

Re: [PATCH 1/3] drm/mediatek: move mipi_dsi_host_register to probe

2019-02-13 Thread Nicolas Boichat via dri-devel
Just some comments on the error path, I'm not sure about the change itself. On Thu, Feb 14, 2019 at 12:42 PM Jitao Shi wrote: > > DSI panel driver need attach function which is inculde in > mipi_dsi_host_ops. > > If mipi_dsi_host_register is not in probe, dsi panel will > probe fail or more

Re: [PATCH 3/3] drm/mediatek: add mt8183 dsi driver support

2019-02-13 Thread Nicolas Boichat via dri-devel
On Thu, Feb 14, 2019 at 12:43 PM Jitao Shi wrote: > > MT8183 dsi has two changes with mt8173. > 1. Add the register double buffer control, but we no need it, So make >it default off. Can you describe a little bit more what this is about? That's shadow registers, right? > 2. Add picture size

Re: [PATCH 2/3] drm/mediatek: CMDQ reg address of mt8173 is different with mt2701

2019-02-13 Thread Nicolas Boichat via dri-devel
On Thu, Feb 14, 2019 at 12:42 PM Jitao Shi wrote: > > Config the different CMDQ reg address in driver data. > > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 39 -- > 1 file changed, 31 insertions(+), 8 deletions(-) > > diff --git

RE: [PATCH] drm/amdgpu: Error handling issues about CHECKED_RETURN

2019-02-13 Thread Zhou, David(ChunMing)
> -Original Message- > From: Bo YU > Sent: Thursday, February 14, 2019 12:46 PM > To: Deucher, Alexander ; Koenig, Christian > ; Zhou, David(ChunMing) > ; airl...@linux.ie; dan...@ffwll.ch; Zhu, Rex > ; Grodzovsky, Andrey > ; dri-devel@lists.freedesktop.org; linux- >

[PATCH 1/3] drm/mediatek: move mipi_dsi_host_register to probe

2019-02-13 Thread Jitao Shi
DSI panel driver need attach function which is inculde in mipi_dsi_host_ops. If mipi_dsi_host_register is not in probe, dsi panel will probe fail or more delay. So move the mipi_dsi_host_register to probe from bind. Signed-off-by: Jitao Shi --- drivers/gpu/drm/mediatek/mtk_dsi.c | 49

[PATCH 2/3] drm/mediatek: CMDQ reg address of mt8173 is different with mt2701

2019-02-13 Thread Jitao Shi
Config the different CMDQ reg address in driver data. Signed-off-by: Jitao Shi --- drivers/gpu/drm/mediatek/mtk_dsi.c | 39 -- 1 file changed, 31 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c

[PATCH 3/3] drm/mediatek: add mt8183 dsi driver support

2019-02-13 Thread Jitao Shi
MT8183 dsi has two changes with mt8173. 1. Add the register double buffer control, but we no need it, So make it default off. 2. Add picture size control. Signed-off-by: Jitao Shi --- drivers/gpu/drm/mediatek/mtk_dsi.c | 20 +++- 1 file changed, 19 insertions(+), 1

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Move dsc rate params compute into drm

2019-02-13 Thread kbuild test robot via dri-devel
Hi David, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.0-rc4 next-20190213] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: [PATCH 2/2] drm/lima: driver for ARM Mali4xx GPUs

2019-02-13 Thread Alex Deucher via dri-devel
I typed this up yesterday, but it looks like I never hit send. On Tue, Feb 12, 2019 at 3:05 PM Rob Herring wrote: > > On Tue, Feb 12, 2019 at 10:24 AM Alex Deucher wrote: > > > > On Tue, Feb 12, 2019 at 10:53 AM Rob Herring via dri-devel > > wrote: > > > > > > On Wed, Feb 6, 2019 at 7:16 AM

[PATCH v2 4/4] drm/msm/dpu: remove mode_set_complete

2019-02-13 Thread Jeykumar Sankaran
This flag was introduced as a fix to notify modeset complete when hw reservations were happening in both atomic_check and atomic_commit paths. Now that we are reserving only in atomic_check, we can get rid of this flag. changes in v2: - none Signed-off-by: Jeykumar Sankaran Reviewed-by:

[PATCH v2 2/4] drm/msm/dpu: track HW resources using private object state

2019-02-13 Thread Jeykumar Sankaran
DPU maintained reservation lists to cache assigned HW blocks for the display and a retrieval mechanism for the individual DRM components to query their respective HW blocks. This patch uses the sub-classed private object state to store and track HW blocks assigned for different components of the

[PATCH v2 3/4] drm/msm/dpu: remove reserve in encoder mode_set

2019-02-13 Thread Jeykumar Sankaran
Now that we have dpu private state tracking the reserved HW resources, we have access to them after atomic swap. So avoid reserving the resources in mode_set. changes in v2: - removal applied on private object based reservation Signed-off-by: Jeykumar Sankaran Reviewed-by: Sean Paul

[PATCH v2 0/4] reserve RM resources in private obj state

2019-02-13 Thread Jeykumar Sankaran
v2 patches for [1]. changes in v2: - Reserve and track hw resources allocated per display in subclassed drm private object states. - Private objects are created per CRTC. [1] https://patchwork.freedesktop.org/series/50722/ Follow up series will be submitted to clean

[PATCH v2 1/4] drm/msm/dpu: add atomic private object to dpu crtc

2019-02-13 Thread Jeykumar Sankaran
Subclass drm private object state for DPU for handling driver specific data. Adds atomic private object to dpu crtc to track hw resources per display. Provide helper function to retrieve DPU private data from current atomic state before atomic swap. changes in v2: - private objects are

Re: [PATCH v2 0/7] move dpu resource parsing to encoder modeset

2019-02-13 Thread Jeykumar Sankaran
On 2019-02-13 17:19, Jeykumar Sankaran wrote: Fixing some of the low hanging fruits by moving the hw resource parsing and assignment to encoder modeset. This series prepares DPU resource management to switch to state based resource tracking which is implemented in the next incoming changes.

[PATCH v2 6/7] drm/msm/dpu: assign intf to encoder in mode_set

2019-02-13 Thread Jeykumar Sankaran
Iterate and assign HW intf block to physical encoders in encoder modeset. Moving all the HW block assignments to encoder modeset to allow easy switching to state based resource management. Signed-off-by: Jeykumar Sankaran --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c| 22

[PATCH v2 5/7] drm/msm/dpu: map mixer/ctl hw blocks in encoder modeset

2019-02-13 Thread Jeykumar Sankaran
After resource allocation, iterate and populate mixer/ctl hw blocks in encoder modeset thereby centralizing all the resource mapping to the CRTC. This change is made for easy switching to state based allocation using private objects later in this series. Signed-off-by: Jeykumar Sankaran ---

[PATCH v2 2/7] drm/msm/dpu: remove phys_vid subclass

2019-02-13 Thread Jeykumar Sankaran
Not holding any video encoder specific data. Get rid of it. Signed-off-by: Jeykumar Sankaran --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 11 --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 18 -- 2 files changed, 4 insertions(+), 25 deletions(-)

[PATCH v2 0/7] move dpu resource parsing to encoder modeset

2019-02-13 Thread Jeykumar Sankaran
Fixing some of the low hanging fruits by moving the hw resource parsing and assignment to encoder modeset. This series prepares DPU resource management to switch to state based resource tracking which is implemented in the next incoming changes. Thanks. Jeykumar Sankaran (7): drm/msm/dpu:

[PATCH v2 4/7] drm/msm/dpu: dont use encoder->crtc in atomic path

2019-02-13 Thread Jeykumar Sankaran
encoder->crtc is not really meaningful for atomic path. Use crtc->encoder_mask to identify the crtc attached with an encoder. Signed-off-by: Jeykumar Sankaran --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[PATCH v2 1/7] drm/msm/dpu: move hw_inf encoder baseclass

2019-02-13 Thread Jeykumar Sankaran
Both video and command physical encoders will have a hw interface assigned to it. So there is really no need to track the hw block in specific encoder subclass. Signed-off-by: Jeykumar Sankaran --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 4 +-

[PATCH v2 7/7] drm/msm/dpu: check split role for single flush

2019-02-13 Thread Jeykumar Sankaran
Removing unwanted access of crtc_state for finding this information. Use split role information to know whether we have slave ctl. Signed-off-by: Jeykumar Sankaran --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff

[PATCH v2 3/7] drm/msm/dpu: release resources on modeset failure

2019-02-13 Thread Jeykumar Sankaran
release resources allocated in mode_set if any of the hw check fails. Most of these checks are not necessary and they will be removed in the follow up patches with state based resource allocations. Signed-off-by: Jeykumar Sankaran --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 7 +-- 1

RE: [PATCH v5 0/3] Support 64 bpp half float formats

2019-02-13 Thread Strasser, Kevin via dri-devel
Maarten Lankhorst wrote: > Op 13-02-2019 om 16:53 schreef Ville Syrjälä: > > On Fri, Feb 08, 2019 at 01:49:40PM -0800, Kevin Strasser wrote: > >> This series defines new formats and adds implementation to the i915 driver. > >> Since posting v1 I have removed the pixel normalize property, as it's

[PATCH 0/1] staging: android: ion: add the GPL exception note to header

2019-02-13 Thread Hyun Kwon
Hi, I wonder if the exception, "WITH Linux-syscall-note", can be added to the ion header license, to allow user source code with different license to include it without being derivative of GPL. More specifically, we want to use this ion header in a BSD license module [1], without enforcing the

[PATCH 1/1] staging: android: ion: Add the GPL exception for syscalls

2019-02-13 Thread Hyun Kwon
Add "WITH Linux-syscall-note" to the license to not put GPL restrictions on user space programs using this header. Signed-off-by: Hyun Kwon --- drivers/staging/android/uapi/ion.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/uapi/ion.h

Re: [PATCH V2 3/7] mm/gup: Change GUP fast to use flags rather than a write 'bool'

2019-02-13 Thread Ira Weiny via dri-devel
On Wed, Feb 13, 2019 at 04:11:10PM -0700, Jason Gunthorpe wrote: > On Wed, Feb 13, 2019 at 03:04:51PM -0800, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > To facilitate additional options to get_user_pages_fast() change the > > singular write parameter to be gup_flags. > > So now we

Re: [PATCH v2] drm: Block fb changes for async plane updates

2019-02-13 Thread Helen Koike via dri-devel
On 2/13/19 7:21 PM, Helen Koike wrote: > > > On 2/13/19 5:18 PM, Nicholas Kazlauskas wrote: >> The prepare_fb call always happens on new_plane_state. >> >> The drm_atomic_helper_cleanup_planes checks to see if >> plane state pointer has changed when deciding to call cleanup_fb on >> either the

[PATCH V2 0/7] Add FOLL_LONGTERM to GUP fast and use it

2019-02-13 Thread ira.weiny--- via dri-devel
From: Ira Weiny NOTE: This series depends on my clean up patch to remove the write parameter from gup_fast_permitted()[1] HFI1, qib, and mthca, use get_user_pages_fast() due to it performance advantages. These pages can be held for a significant time. But get_user_pages_fast() does not

[PATCH V2 7/7] IB/mthca: Use the new FOLL_LONGTERM flag to get_user_pages_fast()

2019-02-13 Thread ira.weiny--- via dri-devel
From: Ira Weiny Use the new FOLL_LONGTERM to get_user_pages_fast() to protect against FS DAX pages being mapped. Signed-off-by: Ira Weiny --- drivers/infiniband/hw/mthca/mthca_memfree.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH V2 6/7] IB/qib: Use the new FOLL_LONGTERM flag to get_user_pages_fast()

2019-02-13 Thread ira.weiny--- via dri-devel
From: Ira Weiny Use the new FOLL_LONGTERM to get_user_pages_fast() to protect against FS DAX pages being mapped. Signed-off-by: Ira Weiny --- drivers/infiniband/hw/qib/qib_user_sdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/qib/qib_user_sdma.c

[PATCH V2 3/7] mm/gup: Change GUP fast to use flags rather than a write 'bool'

2019-02-13 Thread ira.weiny--- via dri-devel
From: Ira Weiny To facilitate additional options to get_user_pages_fast() change the singular write parameter to be gup_flags. This patch does not change any functionality. New functionality will follow in subsequent patches. Some of the get_user_pages_fast() call sites were unchanged because

[PATCH V2 1/7] mm/gup: Replace get_user_pages_longterm() with FOLL_LONGTERM

2019-02-13 Thread ira.weiny--- via dri-devel
From: Ira Weiny Rather than have a separate get_user_pages_longterm() call, introduce FOLL_LONGTERM and change the longterm callers to use it. This patch does not change any functionality. FOLL_LONGTERM can only be supported with get_user_pages() as it requires vmas to determine if DAX is in

[PATCH V2 4/7] mm/gup: Add FOLL_LONGTERM capability to GUP fast

2019-02-13 Thread ira.weiny--- via dri-devel
From: Ira Weiny DAX pages were previously unprotected from longterm pins when users called get_user_pages_fast(). Use the new FOLL_LONGTERM flag to check for DEVMAP pages and fall back to regular GUP processing if a DEVMAP page is encountered. Signed-off-by: Ira Weiny --- mm/gup.c | 24

[PATCH V2 5/7] IB/hfi1: Use the new FOLL_LONGTERM flag to get_user_pages_fast()

2019-02-13 Thread ira.weiny--- via dri-devel
From: Ira Weiny Use the new FOLL_LONGTERM to get_user_pages_fast() to protect against FS DAX pages being mapped. Signed-off-by: Ira Weiny --- drivers/infiniband/hw/hfi1/user_pages.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH V2 2/7] mm/gup: Change write parameter to flags in fast walk

2019-02-13 Thread ira.weiny--- via dri-devel
From: Ira Weiny In order to support more options in the GUP fast walk, change the write parameter to flags throughout the call stack. This patch does not change functionality and passes FOLL_WRITE where write was previously used. Signed-off-by: Ira Weiny --- mm/gup.c | 52

Re: [PATCH 2/2] staging/vboxvideo: Add TODO

2019-02-13 Thread Hans de Goede via dri-devel
Hi, On 13-02-19 19:46, Sam Ravnborg wrote: Hi Hans Which bring me back to a question asked a week ago or so. What is missing before we can move vboxvideo out of staging/ I think it boils down to someone needs to submit it and we'll take a look. Right, I have this on my TODO, but I did

Re: [RFC v3 14/19] Documentation: kunit: add documentation for KUnit

2019-02-13 Thread Kieran Bingham
Hi Brendan, On 12/02/2019 22:10, Brendan Higgins wrote: > On Mon, Feb 11, 2019 at 4:16 AM Kieran Bingham > wrote: >> >> Hi Brendan, >> >> On 09/02/2019 00:56, Brendan Higgins wrote: >>> On Thu, Dec 6, 2018 at 4:16 AM Kieran Bingham >>> wrote: Hi Brendan, On 03/12/2018 23:53,

Re: [PATCH v2] drm: Block fb changes for async plane updates

2019-02-13 Thread Helen Koike via dri-devel
On 2/13/19 5:18 PM, Nicholas Kazlauskas wrote: > The prepare_fb call always happens on new_plane_state. > > The drm_atomic_helper_cleanup_planes checks to see if > plane state pointer has changed when deciding to call cleanup_fb on > either the new_plane_state or the old_plane_state. > > For a

Re: [PATCH 3/3] drm/dsc: Change infoframe_pack to payload_pack

2019-02-13 Thread Manasi Navare via dri-devel
On Wed, Feb 13, 2019 at 09:45:36AM -0500, David Francis wrote: > The function drm_dsc_pps_infoframe_pack only > packed the payload portion of the infoframe. > Change the input struct to the PPS payload > to clarify the function's purpose and allow > for drivers with their own handling of sdp. >

Re: [PATCH v2 1/4] drm/sched: Fix entities with 0 rqs.

2019-02-13 Thread Alex Deucher via dri-devel
On Wed, Jan 30, 2019 at 5:43 AM Christian König wrote: > > Am 30.01.19 um 02:53 schrieb Bas Nieuwenhuizen: > > Some blocks in amdgpu can have 0 rqs. > > > > Job creation already fails with -ENOENT when entity->rq is NULL, > > so jobs cannot be pushed. Without a rq there is no scheduler to > > pop

Re: [PATCH 2/3] drm: Add basic helper to allow precise pageflip timestamps in vrr.

2019-02-13 Thread Daniel Vetter
On Wed, Feb 13, 2019 at 07:10:00PM +0100, Mario Kleiner wrote: > On Wed, Feb 13, 2019 at 5:03 PM Daniel Vetter wrote: > > > > On Wed, Feb 13, 2019 at 4:46 PM Kazlauskas, Nicholas > > wrote: > > > > > > On 2/13/19 10:14 AM, Daniel Vetter wrote: > > > > On Wed, Feb 13, 2019 at 3:33 PM Kazlauskas,

Re: [PATCH] drm/amd/display: Fix reference counting for struct dc_sink.

2019-02-13 Thread Alex Deucher via dri-devel
Add amd-gfx and some DC people. Alex On Sun, Feb 10, 2019 at 5:13 AM wrote: > > From: Mathias Fröhlich > > Reference counting in amdgpu_dm_connector for amdgpu_dm_connector::dc_sink > and amdgpu_dm_connector::dc_em_sink as well as in dc_link::local_sink seems > to be out of shape. Thus make

[Bug 109048] [amdgpu] [apitrace] Penumbra Overture crash in radeonsi_dri.so on RX580

2019-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109048 --- Comment #11 from Henri Valta --- The bisection did not help much. The earliest commits I could test were somewhere between 18.1.9 and 18.2.0-rc1 and they also had the same issue. Earlier commits had problems with LLVM compiling shaders and

[pull] amdgpu, sched drm-fixes-5.0

2019-02-13 Thread Alex Deucher via dri-devel
Hi Dave, Daniel, A few small fixes for 5.0. amdgpu: - Vega20 psp fix - Add vrr range to debugfs for freesync debugging sched: - Scheduler race fix The following changes since commit 78eb1ca47589f0cd9db2ceb28b60434e8d512131: Merge branch 'vmwgfx-fixes-5.0-2' of

[Bug 109048] [amdgpu] [apitrace] Penumbra Overture crash in radeonsi_dri.so on RX580

2019-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109048 --- Comment #10 from Henri Valta --- Looking to start the bisect run now. It took a bit of time to reproduce the crash with plain git build. It seems that the crash only happens when mesa is built with CFLAGS="-O2" If I omit the O2, then the

Re: [PATCH 2/3] drm/dsc: Add native 420 and 422 support to compute_rc_params

2019-02-13 Thread Manasi Navare via dri-devel
On Wed, Feb 13, 2019 at 09:45:35AM -0500, David Francis wrote: > Native 420 and 422 transfer modes are new in DSC1.2 > > In these modes, each two pixels of a slice are treated as one > pixel, so the slice width is half as large (round down) for > the purposes of calucating the groups per line and

Re: [PATCH 2/2] staging/vboxvideo: Add TODO

2019-02-13 Thread Sam Ravnborg
Hi Hans > > > >>Which bring me back to a question asked a week ago or so. > >>What is missing before we can move vboxvideo out of staging/ > > > >I think it boils down to someone needs to submit it and we'll take a look. > > Right, I have this on my TODO, but I did not manage to find time for

Re: [PATCH 1/3] drm/i915: Move dsc rate params compute into drm

2019-02-13 Thread Manasi Navare via dri-devel
On Wed, Feb 13, 2019 at 09:45:34AM -0500, David Francis wrote: > The function intel_compute_rc_parameters is part of the dsc spec > and is not driver-specific. Other drm drivers might like to use > it. The function is not changed; just moved and renamed. > Yes this sounds fair since its DSC spec

Re: [PATCH 2/3] drm: Add basic helper to allow precise pageflip timestamps in vrr.

2019-02-13 Thread Kazlauskas, Nicholas
On 2/13/19 1:10 PM, Mario Kleiner wrote: > On Wed, Feb 13, 2019 at 5:03 PM Daniel Vetter wrote: >> >> On Wed, Feb 13, 2019 at 4:46 PM Kazlauskas, Nicholas >> wrote: >>> >>> On 2/13/19 10:14 AM, Daniel Vetter wrote: On Wed, Feb 13, 2019 at 3:33 PM Kazlauskas, Nicholas wrote: >

Re: [PATCH] staging: android: ion: Use low_order_gfp_flags for smaller allocations

2019-02-13 Thread Laura Abbott via dri-devel
On 2/11/19 11:09 PM, Jing Xia wrote: gfp_flags is always set high_order_gfp_flags even if allocations of order 0 are made.But for smaller allocations, the system should be able to reclaim some memory. Signed-off-by: Jing Xia Reviewed-by: Yuming Han Reviewed-by: Zhaoyang Huang Reviewed-by:

Re: [PATCH 2/3] drm: Add basic helper to allow precise pageflip timestamps in vrr.

2019-02-13 Thread Mario Kleiner via dri-devel
On Wed, Feb 13, 2019 at 5:03 PM Daniel Vetter wrote: > > On Wed, Feb 13, 2019 at 4:46 PM Kazlauskas, Nicholas > wrote: > > > > On 2/13/19 10:14 AM, Daniel Vetter wrote: > > > On Wed, Feb 13, 2019 at 3:33 PM Kazlauskas, Nicholas > > > wrote: > > >> > > >> On 2/13/19 4:50 AM, Daniel Vetter wrote:

Re: [PATCH] drm: imx: Use of_node_name_eq for node name comparisons

2019-02-13 Thread Rob Herring via dri-devel
On Wed, Dec 5, 2018 at 1:50 PM Rob Herring wrote: > > Convert string compares of DT node names to use of_node_name_eq helper > instead. This removes direct access to the node name pointer. > > For instances using of_node_cmp, this has the side effect of now using > case sensitive comparisons.

Re: [PATCH v3 5/7] drm/sun4i: Rely on dma interconnect for our RAM offset

2019-02-13 Thread Robin Murphy
On 13/02/2019 15:41, Maxime Ripard wrote: Hi Robin, Thanks for your feedback! On Tue, Feb 12, 2019 at 06:46:40PM +, Robin Murphy wrote: On 11/02/2019 15:02, Maxime Ripard wrote: Now that we can express our DMA topology, rely on those property instead of hardcoding an offset from the

Re: [PATCH v2] drm: Merge __drm_atomic_helper_disable_all() into drm_atomic_helper_disable_all()

2019-02-13 Thread Sean Paul
On Wed, Feb 13, 2019 at 05:35:05PM +0200, Ville Syrjälä wrote: > On Tue, Feb 12, 2019 at 12:32:41PM -0500, Sean Paul wrote: > > From: Sean Paul > > > > The only difference between the functions is the clean_old_fbs argument, > > whose > > use was removed in the patch referenced below. So remove

Re: [PATCH] MAINTAINERS: update entry for drm/msm

2019-02-13 Thread Sean Paul
On Wed, Feb 13, 2019 at 05:04:59PM +0100, Daniel Vetter wrote: > On Wed, Feb 13, 2019 at 4:43 PM Rob Clark via dri-devel > wrote: > > > > On Wed, Feb 13, 2019 at 10:28 AM Daniel Vetter wrote: > > > > > > On Wed, Feb 13, 2019 at 10:10:44AM -0500, Rob Clark via dri-devel wrote: > > > > We've moved

Re: [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol

2019-02-13 Thread Bartlomiej Zolnierkiewicz via dri-devel
On 02/13/2019 04:19 PM, Daniel Vetter wrote: > On Wed, Feb 13, 2019 at 4:04 PM Bartlomiej Zolnierkiewicz via > dri-devel wrote: >> >> >> On 02/12/2019 09:42 AM, Lee Jones wrote: >>> On Fri, 08 Feb 2019, Bartlomiej Zolnierkiewicz wrote: >>> On 01/17/2019 05:19 PM, Daniel Thompson wrote:

[GIT PULL] drm/imx: pending update handling, plane zpos property

2019-02-13 Thread Philipp Zabel
Hi Dave, Daniel, please consider merging these imx-drm updates for v5.1. The branch sits on top of yesterday's drm/imx fixes and adds support for pending update handling, plane zpos property, builds under COMPILE_TEST on all platforms. regards Philipp The following changes since commit

Re: [PATCH] MAINTAINERS: update entry for drm/msm

2019-02-13 Thread Daniel Vetter
On Wed, Feb 13, 2019 at 4:43 PM Rob Clark via dri-devel wrote: > > On Wed, Feb 13, 2019 at 10:28 AM Daniel Vetter wrote: > > > > On Wed, Feb 13, 2019 at 10:10:44AM -0500, Rob Clark via dri-devel wrote: > > > We've moved the tree to a shared gitlab tree, so that Sean can help out > > > with

Re: [PATCH 2/3] drm: Add basic helper to allow precise pageflip timestamps in vrr.

2019-02-13 Thread Daniel Vetter
On Wed, Feb 13, 2019 at 4:46 PM Kazlauskas, Nicholas wrote: > > On 2/13/19 10:14 AM, Daniel Vetter wrote: > > On Wed, Feb 13, 2019 at 3:33 PM Kazlauskas, Nicholas > > wrote: > >> > >> On 2/13/19 4:50 AM, Daniel Vetter wrote: > >>> On Tue, Feb 12, 2019 at 10:32:31PM +0100, Mario Kleiner wrote: >

Re: [PATCH v5 0/3] Support 64 bpp half float formats

2019-02-13 Thread Maarten Lankhorst via dri-devel
Op 13-02-2019 om 16:53 schreef Ville Syrjälä: > On Fri, Feb 08, 2019 at 01:49:40PM -0800, Kevin Strasser wrote: >> This series defines new formats and adds implementation to the i915 driver. >> Since posting v1 I have removed the pixel normalize property, as it's not >> needed >> for basic

Re: [PATCH v5 0/3] Support 64 bpp half float formats

2019-02-13 Thread Ville Syrjälä via dri-devel
On Fri, Feb 08, 2019 at 01:49:40PM -0800, Kevin Strasser wrote: > This series defines new formats and adds implementation to the i915 driver. > Since posting v1 I have removed the pixel normalize property, as it's not > needed > for basic functionality. Also, I have been working on adding support

Re: [PATCH] MAINTAINERS: update entry for drm/msm

2019-02-13 Thread Rob Clark via dri-devel
On Wed, Feb 13, 2019 at 10:28 AM Daniel Vetter wrote: > > On Wed, Feb 13, 2019 at 10:10:44AM -0500, Rob Clark via dri-devel wrote: > > We've moved the tree to a shared gitlab tree, so that Sean can help out > > with maintainer duties. > > > > Cc: Sean Paul > > Signed-off-by: Rob Clark > > --- >

Re: [PATCH v3 5/7] drm/sun4i: Rely on dma interconnect for our RAM offset

2019-02-13 Thread Maxime Ripard
Hi Robin, Thanks for your feedback! On Tue, Feb 12, 2019 at 06:46:40PM +, Robin Murphy wrote: > On 11/02/2019 15:02, Maxime Ripard wrote: > > Now that we can express our DMA topology, rely on those property instead of > > hardcoding an offset from the dma_addr_t which wasn't really great. >

Re: [PATCH 2/3] drm: Add basic helper to allow precise pageflip timestamps in vrr.

2019-02-13 Thread Kazlauskas, Nicholas
On 2/13/19 10:14 AM, Daniel Vetter wrote: > On Wed, Feb 13, 2019 at 3:33 PM Kazlauskas, Nicholas > wrote: >> >> On 2/13/19 4:50 AM, Daniel Vetter wrote: >>> On Tue, Feb 12, 2019 at 10:32:31PM +0100, Mario Kleiner wrote: On Mon, Feb 11, 2019 at 6:04 PM Daniel Vetter wrote: > > On

Re: [PATCH 3/3] drm/dsc: Change infoframe_pack to payload_pack

2019-02-13 Thread Wentland, Harry
On 2019-02-13 9:45 a.m., David Francis wrote: > The function drm_dsc_pps_infoframe_pack only > packed the payload portion of the infoframe. > Change the input struct to the PPS payload > to clarify the function's purpose and allow > for drivers with their own handling of sdp. > (e.g. drivers with

Re: [PATCH v2] drm: Merge __drm_atomic_helper_disable_all() into drm_atomic_helper_disable_all()

2019-02-13 Thread Ville Syrjälä via dri-devel
On Tue, Feb 12, 2019 at 12:32:41PM -0500, Sean Paul wrote: > From: Sean Paul > > The only difference between the functions is the clean_old_fbs argument, whose > use was removed in the patch referenced below. So remove the internal > copy and drop the guts back into

Re: [PATCH] MAINTAINERS: update entry for drm/msm

2019-02-13 Thread Sean Paul
On Wed, Feb 13, 2019 at 10:10:44AM -0500, Rob Clark via dri-devel wrote: > We've moved the tree to a shared gitlab tree, so that Sean can help out > with maintainer duties. > > Cc: Sean Paul Acked-by: Sean Paul > Signed-off-by: Rob Clark > --- > I can include this patch in msm-next for v5.1,

Re: [PATCH] MAINTAINERS: update entry for drm/msm

2019-02-13 Thread Daniel Vetter
On Wed, Feb 13, 2019 at 10:10:44AM -0500, Rob Clark via dri-devel wrote: > We've moved the tree to a shared gitlab tree, so that Sean can help out > with maintainer duties. > > Cc: Sean Paul > Signed-off-by: Rob Clark > --- > I can include this patch in msm-next for v5.1, but wanted to get it >

Re: [PATCH 2/3] drm/dsc: Add native 420 and 422 support to compute_rc_params

2019-02-13 Thread Wentland, Harry
On 2019-02-13 9:45 a.m., David Francis wrote: > Native 420 and 422 transfer modes are new in DSC1.2 > > In these modes, each two pixels of a slice are treated as one > pixel, so the slice width is half as large (round down) for > the purposes of calucating the groups per line and chunk size > in

Re: [PATCH 1/3] drm/i915: Move dsc rate params compute into drm

2019-02-13 Thread Wentland, Harry
On 2019-02-13 9:45 a.m., David Francis wrote: > The function intel_compute_rc_parameters is part of the dsc spec > and is not driver-specific. Other drm drivers might like to use > it. The function is not changed; just moved and renamed. > > Signed-off-by: David Francis Reviewed-by: Harry

[Bug 109526] [CARRIZO] amdgpu fails to resume from S3, atombios stuck executing C554 (len 629, WS 0, PS 0)

2019-02-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109526 --- Comment #1 from Johannes Hirte --- Still an issue with linux-5.0.0-rc6 -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list

Re: [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol

2019-02-13 Thread Daniel Vetter
On Wed, Feb 13, 2019 at 4:04 PM Bartlomiej Zolnierkiewicz via dri-devel wrote: > > > On 02/12/2019 09:42 AM, Lee Jones wrote: > > On Fri, 08 Feb 2019, Bartlomiej Zolnierkiewicz wrote: > > > >> > >> On 01/17/2019 05:19 PM, Daniel Thompson wrote: > >>> On Thu, Jan 17, 2019 at 04:33:35PM +0300,

Re: [PATCH 2/3] drm: Add basic helper to allow precise pageflip timestamps in vrr.

2019-02-13 Thread Daniel Vetter
On Wed, Feb 13, 2019 at 3:33 PM Kazlauskas, Nicholas wrote: > > On 2/13/19 4:50 AM, Daniel Vetter wrote: > > On Tue, Feb 12, 2019 at 10:32:31PM +0100, Mario Kleiner wrote: > >> On Mon, Feb 11, 2019 at 6:04 PM Daniel Vetter wrote: > >>> > >>> On Mon, Feb 11, 2019 at 4:01 PM Kazlauskas, Nicholas >

[PATCH] MAINTAINERS: update entry for drm/msm

2019-02-13 Thread Rob Clark via dri-devel
We've moved the tree to a shared gitlab tree, so that Sean can help out with maintainer duties. Cc: Sean Paul Signed-off-by: Rob Clark --- I can include this patch in msm-next for v5.1, but wanted to get it ack'd on list MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol

2019-02-13 Thread Bartlomiej Zolnierkiewicz via dri-devel
On 02/12/2019 09:42 AM, Lee Jones wrote: > On Fri, 08 Feb 2019, Bartlomiej Zolnierkiewicz wrote: > >> >> On 01/17/2019 05:19 PM, Daniel Thompson wrote: >>> On Thu, Jan 17, 2019 at 04:33:35PM +0300, Alexander Shiyan wrote: We have two *_CLASS_DEVICE kernel config options (LCD_CLASS_DEVICE

[PATCH 3/3] drm/dsc: Change infoframe_pack to payload_pack

2019-02-13 Thread David Francis
The function drm_dsc_pps_infoframe_pack only packed the payload portion of the infoframe. Change the input struct to the PPS payload to clarify the function's purpose and allow for drivers with their own handling of sdp. (e.g. drivers with their own struct for all SDP transactions) Signed-off-by:

[PATCH 2/3] drm/dsc: Add native 420 and 422 support to compute_rc_params

2019-02-13 Thread David Francis
Native 420 and 422 transfer modes are new in DSC1.2 In these modes, each two pixels of a slice are treated as one pixel, so the slice width is half as large (round down) for the purposes of calucating the groups per line and chunk size in bytes In native 422 mode, each pixel has four components,

[PATCH 1/3] drm/i915: Move dsc rate params compute into drm

2019-02-13 Thread David Francis
The function intel_compute_rc_parameters is part of the dsc spec and is not driver-specific. Other drm drivers might like to use it. The function is not changed; just moved and renamed. Signed-off-by: David Francis --- drivers/gpu/drm/drm_dsc.c | 133 ++

[PATCH 0/3] Make DRM DSC helpers more generally usable

2019-02-13 Thread David Francis
drm_dsc could use some work so that drm drivers other than i915 can make use of it their own DSC implementations Move rc compute, a function that forms part of the DSC spec, into drm. Update it to DSC 1.2. Also change the packing function to operate only on the packing struct, to allow for

Re: [PATCH v3 6/8] drm/sun4i: dsi: Rework a bit the hblk calculation

2019-02-13 Thread Paul Kocialkowski
Hi, On Mon, 2019-02-11 at 15:41 +0100, Maxime Ripard wrote: > It turns out that the hblk calculation actually follows a similar pattern > than the other packets. Rework a bit the calculation and add a comment. This looks consistent with what the BSP is doing for video mode. Reviewed-by: Paul

Re: [PATCH v3 7/8] drm/sun4i: dsi: Add burst support

2019-02-13 Thread Paul Kocialkowski
Hi, On Mon, 2019-02-11 at 15:41 +0100, Maxime Ripard wrote: > From: Konstantin Sudakov > > The current driver doesn't support the DSI burst operation mode. > > Let's add the needed quirks to make it work. > > Signed-off-by: Konstantin Sudakov > Signed-off-by: Maxime Ripard > --- >

Re: [PATCH v3 5/8] drm/sun4i: dsi: Fix DRQ calculation

2019-02-13 Thread Paul Kocialkowski
Hi, On Mon, 2019-02-11 at 15:41 +0100, Maxime Ripard wrote: > The DRQ calculation code in the Allwinner BSP uses the vertical front > porch value as the condition, but we're using the video back porch. > > Since I always confuse the two, and I'm the original author of that code, I > guess I

Re: [PATCH 2/3] drm: Add basic helper to allow precise pageflip timestamps in vrr.

2019-02-13 Thread Kazlauskas, Nicholas
On 2/13/19 4:50 AM, Daniel Vetter wrote: > On Tue, Feb 12, 2019 at 10:32:31PM +0100, Mario Kleiner wrote: >> On Mon, Feb 11, 2019 at 6:04 PM Daniel Vetter wrote: >>> >>> On Mon, Feb 11, 2019 at 4:01 PM Kazlauskas, Nicholas >>> wrote: On 2/11/19 3:35 AM, Daniel Vetter wrote: > On

Re: [PATCH v2 3/5] drm: msm: Switch to use drm_gem_object reservation_object

2019-02-13 Thread Rob Clark via dri-devel
On Sat, Feb 2, 2019 at 10:42 AM Rob Herring wrote: > > Now that the base struct drm_gem_object has a reservation_object, use it > and remove the private BO one. > > We can't use the drm_gem_reservation_object_wait() helper for MSM > because (in theory) msm_gem_cpu_prep() will also do some cache >

Re: [PATCH v3 8/8] drm/panel: Add Ronbo RB070D30 panel

2019-02-13 Thread Paul Kocialkowski
Hi, On Mon, 2019-02-11 at 15:41 +0100, Maxime Ripard wrote: > From: Konstantin Sudakov > > The Ronbo RB070D30 panel is a MIPI-DSI panel based on a Fitipower EK79007 > controller and a 1024x600 panel. > > Reviewed-by: Sam Ravnborg > Signed-off-by: Konstantin Sudakov > Signed-off-by: Maxime

Re: drm bridge control from another driver

2019-02-13 Thread Andrzej Hajda via dri-devel
On 13.02.2019 14:40, Vinay Simha B N wrote: > Andrzej/Daniel, > > please suggest any input on the scenario for temperature control and > dsi bridge enable/disable. > > On Mon, Feb 11, 2019 at 2:41 PM Vinay Simha B N > wrote: > > dsi2hdmi(adv7511) chip operating

[PATCH 6/6] drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal planes

2019-02-13 Thread Swati Sharma via dri-devel
Signed-off-by: Swati Sharma Signed-off-by: Vidya Srinivas Reviewed-by: Juha-Pekka Heikkila Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 30 ++ drivers/gpu/drm/i915/intel_sprite.c | 60 +++- 2 files changed, 89

[PATCH 4/6] drm: Add Y2xx and Y4xx (xx:10/12/16) format definitions and fourcc

2019-02-13 Thread Swati Sharma via dri-devel
The following pixel formats are packed format that follows 4:2:2 chroma sampling. For memory represenation each component is allocated 16 bits each. Thus each pixel occupies 32bit. Y210: For each component, valid data occupies MSB 10 bits. LSB 6 bits are filled with zeroes. Y212: For

[PATCH 5/6] drm/i915/icl: Add Y2xx and Y4xx (xx:10/12/16) plane control definitions

2019-02-13 Thread Swati Sharma via dri-devel
Added needed plane control flag definitions for Y2xx and Y4xx (10, 12 and 16 bits) Signed-off-by: Swati Sharma Signed-off-by: Vidya Srinivas Reviewed-by: Juha-Pekka Heikkila Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/i915_reg.h | 6 ++ 1 file changed, 6 insertions(+) diff

[PATCH 2/6] drm/i915: Preparations for enabling P010, P012, P016 formats

2019-02-13 Thread Swati Sharma via dri-devel
From: Juha-Pekka Heikkila Preparations for enabling P010, P012 and P016 formats. These formats will extend NV12 for larger bit depths. Signed-off-by: Juha-Pekka Heikkila Signed-off-by: Swati Sharma Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_atomic_plane.c | 2 +-

[PATCH 3/6] drm/i915: Enable P010, P012, P016 formats for primary and sprite planes

2019-02-13 Thread Swati Sharma via dri-devel
From: Juha-Pekka Heikkila Enabling of P010, P012 and P016 formats. These formats will extend NV12 for larger bit depths. Signed-off-by: Juha-Pekka Heikkila Signed-off-by: Swati Sharma Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_sprite.c | 28 ++-- 1

[PATCH 0/6] Enable P0xx (planar), Y2xx/Y4xx (packed) pixel formats

2019-02-13 Thread Swati Sharma via dri-devel
This patch series is for enabling P0xx, Y2xx and Y4xx pixel formats for intel's i915 driver. In this patch series, Juha Pekka's patch series Gen10+ P0xx formats https://patchwork.freedesktop.org/series/56053/ is combined with Swati's https://patchwork.freedesktop.org/series/55035/ for Gen11+

[PATCH 1/6] drm/i915: Add P010, P012, P016 plane control definitions

2019-02-13 Thread Swati Sharma via dri-devel
From: Juha-Pekka Heikkila Add needed plane control flag definitions for P010, P012 and P016 formats. Signed-off-by: Juha-Pekka Heikkila Signed-off-by: Swati Sharma Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/i915_reg.h | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH v3 3/3] phy: Add driver for mixel dphy found on imx8

2019-02-13 Thread kbuild test robot via dri-devel
Hi Guido, Thank you for the patch! Yet something to improve: [auto build test ERROR on phy/next] [also build test ERROR on next-20190212] [cannot apply to v5.0-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH i-g-t] i915/gem_exec_big: Add a single shot test

2019-02-13 Thread Chris Wilson
CI complains that the exhaustive test of trying every size up to the limit is too slow, so add a simple test that tries to submit one extreme batch buffer and check all the relocations land. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=10 Signed-off-by: Chris Wilson --- Continue

Re: [PATCH] drm/amd/display: Use vrr friendly pageflip throttling in DC.

2019-02-13 Thread Daniel Vetter
On Wed, Feb 13, 2019 at 11:54 AM Michel Dänzer wrote: > > On 2019-02-13 10:53 a.m., Daniel Vetter wrote: > > On Mon, Feb 11, 2019 at 04:01:12PM +0100, Michel Dänzer wrote: > >> On 2019-02-09 7:52 a.m., Mario Kleiner wrote: > >>> In VRR mode, keep track of the vblank count of the last > >>>

Re: [PATCH 2/3] drm: Add basic helper to allow precise pageflip timestamps in vrr.

2019-02-13 Thread Daniel Vetter
On Wed, Feb 13, 2019 at 12:05 PM Mario Kleiner wrote: > > On Wed, Feb 13, 2019 at 10:56 AM Chris Wilson > wrote: > > > > Quoting Daniel Vetter (2019-02-13 09:50:55) > > > On Tue, Feb 12, 2019 at 10:32:31PM +0100, Mario Kleiner wrote: > > > > I think all kms drivers try to call

  1   2   >