[Bug 110514] [CI][BAT] igt@* - skip - Test requirement: is_i915_device(fd) && has_known_intel_chipset(fd), Skip

2019-04-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110514 --- Comment #6 from Mika Kahola --- It seems that we are missing device info for CML. Hence, we are failing on these is_i915_device() and has_known_intel_chipset() tests. -- You are receiving this mail because: You are the assignee for the bug

[Bug 110514] [CI][BAT] igt@* - skip - Test requirement: is_i915_device(fd) && has_known_intel_chipset(fd), Skip

2019-04-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110514 --- Comment #5 from CI Bug Log --- The CI Bug Log issue associated to this bug has been updated. ### New filters associated * CML: all tests - skip - Test requirement: intel_gen(intel_get_drm_devid(fd)) >= 5, SKIP - https://intel-gfx-ci.01.o

[Bug 110521] Make skips easily parseable by machines

2019-04-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110521 Bug ID: 110521 Summary: Make skips easily parseable by machines Product: DRI Version: XOrg git Hardware: Other OS: All Status: NEW Severity: normal

[Bug 110514] [CI][BAT] igt@* - skip - Test requirement: is_i915_device(fd) && has_known_intel_chipset(fd), Skip

2019-04-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110514 --- Comment #4 from CI Bug Log --- A CI Bug Log filter associated to this bug has been updated: {- CML: igt@* - skip - Test requirement: is_i915_device(fd) && has_known_intel_chipset(fd), Skip -} {+ CML: igt@* - skip - Test requirement: is_i915

[PATCH] Revert "drm/qxl: drop prime import/export callbacks"

2019-04-25 Thread Gerd Hoffmann
This reverts commit f4c34b1e2a37d5676180901fa6ff188bcb6371f8. Simliar to commit a0cecc23cfcb Revert "drm/virtio: drop prime import/export callbacks". We have to do the same with qxl, for the same reasons (it breaks DRI3). Drop the WARN_ON_ONCE(). Fixes: f4c34b1e2a37d5676180901fa6ff188bcb6371f8

Re: [Intel-gfx] [PATCH v2] drm: prefix header search paths with $(srctree)/

2019-04-25 Thread Dave Airlie
Daniel, drm-misc-next-fixes? Dave. On Fri, 26 Apr 2019 at 12:25, wrote: > > Hi Dave, > > > -Original Message- > > From: Dave Airlie [mailto:airl...@gmail.com] > > Sent: Friday, April 26, 2019 11:19 AM > > To: Yamada, Masahiro/山田 真弘 > > Cc: David Airlie ; Daniel Vetter ; > > dri-devel ;

Re: [Intel-gfx] [PATCH v2] drm: prefix header search paths with $(srctree)/

2019-04-25 Thread Dave Airlie
On Fri, 26 Apr 2019 at 11:46, Masahiro Yamada wrote: > > Hi. > > > On Fri, Mar 29, 2019 at 8:37 PM Masahiro Yamada > wrote: > > > > Currently, the Kbuild core manipulates header search paths in a crazy > > way [1]. > > > > To fix this mess, I want all Makefiles to add explicit $(srctree)/ to > >

linux-next: build failure after merge of the drm tree

2019-04-25 Thread Stephen Rothwell
Hi all, After merging the drm tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/gpu/drm/virtio/virtgpu_prime.c:43:18: error: redefinition of 'virtgpu_gem_prime_get_sg_table' struct sg_table *virtgpu_gem_prime_get_sg_table(struct drm_gem_object *obj)

[Bug 105819] Window system hang due to GPU Fault

2019-04-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105819 --- Comment #11 from xom --- Still happening on 5.1.0-0.rc5, system hangs and only solution is a reboot. Happens somewhat randomly, gpu can be underload or just browsing with firefox. Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz 01:00.0 VGA compati

[git pull] drm fixes for 5.1-rc7

2019-04-25 Thread Dave Airlie
Hi Linus, Regular drm fixes pull, nothing too outstanding, I'm guessing Easter was slowing people down. i915: - FEC enable fix - BXT display lanes fix ttm: - fix reinit for reloading drivers regression imx: - DP CSC fix sun4i: - module unload/load fix vc4: - memory leak fix - compile fix dw-

Re: [PATCH] drm/msm: check for equals 0 only

2019-04-25 Thread Rob Clark
On Thu, Apr 25, 2019 at 7:09 AM Nicholas Mc Guire wrote: > > wait_for_completion_timeout() returns 0 on timeout and aleast 1 otherwise > so checking for < makes no sense here. > > Signed-off-by: Nicholas Mc Guire > --- > > Problem located with an experimental coccinelle script > > While this chec

[Bug 110517] Running any OpenGL related command with DRI_PRIME=1 crashes the system

2019-04-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110517 --- Comment #1 from Alex Deucher --- Closed source OpenGL does not support PRIME. For hybrid laptops, please use mesa. -- You are receiving this mail because: You are the assignee for the bug.___ dr

[Bug 110517] Running any OpenGL related command with DRI_PRIME=1 crashes the system

2019-04-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110517 Alex Deucher changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW

[Bug 109206] Kernel 4.20 amdgpu fails to load firmware on Ryzen 2500U

2019-04-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109206 --- Comment #39 from Alex Deucher --- (In reply to Adrian Garay from comment #38) > (In reply to Alex Deucher from comment #33) > > (In reply to Talha Khan from comment #31) > > > I moved the raven_dcmu.bin file to another directory, but unfortu

Re: [Freedreno] [PATCH] drm/msm: check for equals 0 only

2019-04-25 Thread Abhinav Kumar
On 2019-04-25 07:03, Nicholas Mc Guire wrote: wait_for_completion_timeout() returns 0 on timeout and aleast 1 otherwise so checking for < makes no sense here. Signed-off-by: Nicholas Mc Guire Reviewed-by: Abhinav Kumar --- Problem located with an experimental coccinelle script While this

Re: [PATCH v3 12/26] compat_ioctl: move more drivers to compat_ptr_ioctl

2019-04-25 Thread Johannes Berg
On Thu, 2019-04-25 at 17:55 +0200, Arnd Bergmann wrote: > On Thu, Apr 25, 2019 at 5:35 PM Al Viro wrote: > > > > On Thu, Apr 25, 2019 at 12:21:53PM -0300, Mauro Carvalho Chehab wrote: > > > > > If I understand your patch description well, using compat_ptr_ioctl > > > only works if the driver is

Re: [PATCH v1 11/17] kunit: test: add test managed resource tests

2019-04-25 Thread Brendan Higgins
On Wed, Apr 24, 2019 at 12:00 PM Masayoshi Mizuma wrote: > > On Thu, Apr 04, 2019 at 03:06:46PM -0700, Brendan Higgins wrote: > > From: Avinash Kondareddy > > > > Tests how tests interact with test managed resources in their lifetime. > > > > Signed-off-by: Avinash Kondareddy > > Signed-off-by:

Re: [PATCH v1 14/17] Documentation: kunit: add documentation for KUnit

2019-04-25 Thread Brendan Higgins
On Wed, Apr 24, 2019 at 11:58 AM Masayoshi Mizuma wrote: > > Hi Brendan, > > KUNIT_ASSERT_NOT_ERR_OR_NULL() should be replaced to > KUNIT_EXPECT_NOT_ERR_OR_NULL(), right? Generally speaking, no. There may be places that I have used it improperly, but I think it is generally okay to use. If you

[git pull] vmwgfx-fixes-5.1

2019-04-25 Thread Thomas Hellstrom
Dave, Daniel A single fix for a layer violation requested by Cristoph. The following changes since commit c2d311553855395764e2e5bf401d987ba65c2056: drm/vmwgfx: Don't double-free the mode stored in par->set_mode (2019-03-20 07:57:01 +0100) are available in the Git repository at: git://peop

[Bug 109955] amdgpu [RX Vega 64] system freeze while gaming

2019-04-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109955 --- Comment #15 from Jaap Buurman --- That's bad to hear :( Worth a try though. How often do you experience freezes by the way? And is this for all games, or are some games completely stable? For me, I am getting crashes in Kerbal Space Program,

[Bug 109206] Kernel 4.20 amdgpu fails to load firmware on Ryzen 2500U

2019-04-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109206 --- Comment #38 from Adrian Garay --- (In reply to Alex Deucher from comment #33) > (In reply to Talha Khan from comment #31) > > I moved the raven_dcmu.bin file to another directory, but unfortunately I am > > still unable to boot any kernel ne

[Bug 110517] Running any OpenGL related command with DRI_PRIME=1 crashes the system

2019-04-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110517 Bug ID: 110517 Summary: Running any OpenGL related command with DRI_PRIME=1 crashes the system Product: DRI Version: DRI git Hardware: x86-64 (AMD64) OS: L

Re: [PATCH v2 9/9] platform/chrome: chromeos_laptop: use helper pci_dev_id

2019-04-25 Thread Benson Leung
Hi Heiner, On Wed, Apr 24, 2019 at 09:17:19PM +0200, Heiner Kallweit wrote: > Use new helper pci_dev_id() to simplify the code. > > Signed-off-by: Heiner Kallweit Acked-By: Benson Leung > --- > drivers/platform/chrome/chromeos_laptop.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v2 25/79] docs: convert docs to ReST and rename to *.rst

2019-04-25 Thread Mark Brown
On Mon, Apr 22, 2019 at 10:27:14AM -0300, Mauro Carvalho Chehab wrote: > Convert the PM documents to ReST, in order to allow them to > build with Sphinx. This is massively CCed covering a large range of subsystems and is patch 25 of a 79 patch series so I've no context for what's going on here or

Re: [PATCH] drm/bridge/synopsys: dsi: Don't blindly call post_disable

2019-04-25 Thread Laurent Pinchart
On Thu, Apr 25, 2019 at 08:59:15PM +0300, Laurent Pinchart wrote: > On Thu, Apr 25, 2019 at 12:39:27PM +, Matt Redfearn wrote: > > On 25/04/2019 13:13, Andrzej Hajda wrote: > >> On 24.04.2019 16:22, Matt Redfearn wrote: > >>> The DRM documentation states that post_disable is an optional callbac

Re: [PATCH] drm/bridge/synopsys: dsi: Don't blindly call post_disable

2019-04-25 Thread Laurent Pinchart
Hi Matt, On Thu, Apr 25, 2019 at 12:39:27PM +, Matt Redfearn wrote: > On 25/04/2019 13:13, Andrzej Hajda wrote: > > On 24.04.2019 16:22, Matt Redfearn wrote: > >> The DRM documentation states that post_disable is an optional callback. > >> As such an implementing device may not populate it. To

Re: [PATCH v7 4/4] drm/vc4: Allocate binner bo when starting to use the V3D

2019-04-25 Thread Eric Anholt
Paul Kocialkowski writes: > The binner BO is not required until the V3D is in use, so avoid > allocating it at probe and do it on the first non-dumb BO allocation. > > Keep track of which clients are using the V3D and liberate the buffer > when there is none left, using a kref. Protect the logic

Re: [PATCH 2/2] drm/prime: split drm_gem_prime_handle_to_fd()

2019-04-25 Thread Sam Ravnborg
Hi Emil. Thans, again a nice simplification. But the export_handle_to_buf now have to mutex_unlock. Please use proper goto error handlign with a single unlock in the end of the fuction. This makes it simple to check that we always do the unlock. Likewise in next function. Avoid two mutex_unlock, w

Re: [PATCH 1/2] drm/prime: split drm_gem_prime_fd_to_handle()

2019-04-25 Thread Sam Ravnborg
Hi Emil. Thanks for the patch - it looks like a good simplification. The changes introduced in import_buf_to_handle() changes the logic a little to avoid goto - this hurts readability. It would be better to keep the current structure and use goto label to hanlde the error situations. Then error h

Re: [PATCH] dma-buf: call kfree() w/o mutex held in dma_buf_attach()

2019-04-25 Thread Daniel Vetter
On Thu, Apr 25, 2019 at 04:48:50PM +0100, Emil Velikov wrote: > From: Emil Velikov > > In dma_buf_attach() we allocate memory w/o a mutex being held, thus in > the error path we should kfree() it after the mutex_unlock. > > The inverse function dma_buf_deattach() gets this right. > > Cc: Sumit

[Bug 109206] Kernel 4.20 amdgpu fails to load firmware on Ryzen 2500U

2019-04-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109206 --- Comment #37 from Talha Khan --- The issue occurs (and workaround works) on kernels 5.0.8 and 5.0.9. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing

Re: [PATCH v3 12/26] compat_ioctl: move more drivers to compat_ptr_ioctl

2019-04-25 Thread Arnd Bergmann
On Thu, Apr 25, 2019 at 5:35 PM Al Viro wrote: > > On Thu, Apr 25, 2019 at 12:21:53PM -0300, Mauro Carvalho Chehab wrote: > > > If I understand your patch description well, using compat_ptr_ioctl > > only works if the driver is not for s390, right? > > No; s390 is where "oh, just set ->compat_ioct

Re: [PATCH v3 12/26] compat_ioctl: move more drivers to compat_ptr_ioctl

2019-04-25 Thread Mauro Carvalho Chehab
Em Thu, 25 Apr 2019 16:35:34 +0100 Al Viro escreveu: > On Thu, Apr 25, 2019 at 12:21:53PM -0300, Mauro Carvalho Chehab wrote: > > > If I understand your patch description well, using compat_ptr_ioctl > > only works if the driver is not for s390, right? > > No; s390 is where "oh, just set ->co

[PATCH 2/2] drm/prime: split drm_gem_prime_handle_to_fd()

2019-04-25 Thread Emil Velikov
From: Emil Velikov Currently drm_gem_prime_handle_to_fd() consists of illegible amount of goto labels, for no obvious reason. Split it in two (as below) making the code far simpler and obvious. drm_gem_prime_handle_to_fd() - prime mtx handling - drm_gem_object lookup and refcounting - creati

[PATCH 1/2] drm/prime: split drm_gem_prime_fd_to_handle()

2019-04-25 Thread Emil Velikov
From: Emil Velikov Currently drm_gem_prime_fd_to_handle() consists of illegible amount of goto labels, for no obvious reason. Split it in two (as below) making the code far simpler and obvious. drm_gem_prime_fd_to_handle() - prime mtx handling - fd/dmabuf refcounting - hash table lookup import

[Bug 110355] radeonsi: GTK elements become invisible in some applications (GIMP, LibreOffice)

2019-04-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110355 Marek Olšák changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[PATCH] dma-buf: call kfree() w/o mutex held in dma_buf_attach()

2019-04-25 Thread Emil Velikov
From: Emil Velikov In dma_buf_attach() we allocate memory w/o a mutex being held, thus in the error path we should kfree() it after the mutex_unlock. The inverse function dma_buf_deattach() gets this right. Cc: Sumit Semwal Signed-off-by: Emil Velikov --- drivers/dma-buf/dma-buf.c | 2 +- 1

Re: [PATCH v3 12/26] compat_ioctl: move more drivers to compat_ptr_ioctl

2019-04-25 Thread Arnd Bergmann
On Thu, Apr 25, 2019 at 5:22 PM Mauro Carvalho Chehab wrote: > Em Tue, 16 Apr 2019 22:25:33 +0200 Arnd Bergmann escreveu: > > If I understand your patch description well, using compat_ptr_ioctl > only works if the driver is not for s390, right? No, the purpose of compat_ptr_ioctl() is to make su

Re: [PATCH v3 12/26] compat_ioctl: move more drivers to compat_ptr_ioctl

2019-04-25 Thread Mauro Carvalho Chehab
Em Tue, 16 Apr 2019 22:25:33 +0200 Arnd Bergmann escreveu: > The .ioctl and .compat_ioctl file operations have the same prototype so > they can both point to the same function, which works great almost all > the time when all the commands are compatible. > > One exception is the s390 architectur

Re: Support for 2D engines/blitters in V4L2 and DRM

2019-04-25 Thread Michel Dänzer
On 2019-04-24 7:43 p.m., Nicolas Dufresne wrote: > Le mercredi 24 avril 2019 à 18:54 +0200, Michel Dänzer a écrit : >> On 2019-04-24 5:44 p.m., Nicolas Dufresne wrote: >>> Le mercredi 24 avril 2019 à 17:06 +0200, Daniel Vetter a écrit : On Wed, Apr 24, 2019 at 4:41 PM Paul Kocialkowski w

Re: [PATCH] drm/gem: Fix sphinx warnings

2019-04-25 Thread Sean Paul
On Wed, Apr 24, 2019 at 02:59:00PM -0700, Eric Anholt wrote: > Sean Paul writes: > > > From: Sean Paul > > > > Sphinx really wants colons after arguments :/ > > > > Fixes the following warnings: > > drm_gem.c:1384: warning: Function parameter or member 'fence_array' not > > described in 'drm_ge

[PATCH] drm/msm: check for equals 0 only

2019-04-25 Thread Nicholas Mc Guire
wait_for_completion_timeout() returns 0 on timeout and aleast 1 otherwise so checking for < makes no sense here. Signed-off-by: Nicholas Mc Guire --- Problem located with an experimental coccinelle script While this check does no harm in this form - it should be fixed anyway to comply with the

[Bug 110510] Radeon VII HDMI issues: Flicking/system crashing

2019-04-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110510 --- Comment #4 from Tom B --- Unfortunately this workaround does not work. As soon as I launch a game on either monitor the whole system freezes despite the performance setting. Nothing appeared in journalctl this time but it seems like the sa

Re: [patch V3 18/29] lockdep: Remove save argument from check_prev_add()

2019-04-25 Thread Peter Zijlstra
On Thu, Apr 25, 2019 at 11:45:11AM +0200, Thomas Gleixner wrote: > There is only one caller which hands in save_trace as function pointer. > > Signed-off-by: Thomas Gleixner Acked-by: Peter Zijlstra (Intel) ___ dri-devel mailing list dri-devel@lists.f

Re: [patch V3 00/29] stacktrace: Consolidate stack trace usage

2019-04-25 Thread Josh Poimboeuf
On Thu, Apr 25, 2019 at 11:44:53AM +0200, Thomas Gleixner wrote: > This is an update to V2 which can be found here: > > https://lkml.kernel.org/r/20190418084119.056416...@linutronix.de > > Changes vs. V2: > > - Fixed the kernel-doc issue pointed out by Mike > > - Removed the '-1' oddity f

Re: [patch V3 24/29] tracing: Remove the last struct stack_trace usage

2019-04-25 Thread Josh Poimboeuf
On Thu, Apr 25, 2019 at 11:45:17AM +0200, Thomas Gleixner wrote: > Simplify the stack retrieval code by using the storage array based > interface. > > Signed-off-by: Thomas Gleixner > Reviewed-by: Steven Rostedt (VMware) > --- > kernel/trace/trace_stack.c | 37

Re: [patch V3 21/29] tracing: Use percpu stack trace buffer more intelligently

2019-04-25 Thread Josh Poimboeuf
On Thu, Apr 25, 2019 at 11:45:14AM +0200, Thomas Gleixner wrote: > @@ -2788,29 +2798,32 @@ static void __ftrace_trace_stack(struct >*/ > preempt_disable_notrace(); > > - use_stack = __this_cpu_inc_return(ftrace_stack_reserve); > + stackidx = __this_cpu_inc_return(ftrace_stac

[PULL] drm-misc-fixes

2019-04-25 Thread Maxime Ripard
Hi Daniel, Dave, Here is a new drm-misc-fixes PR. Thanks! Maxime drm-misc-fixes-2019-04-25: - sun4i: Fix module loading / unloading - vc4: Fix a compilation error and memory leak - dw-hdmi: Fix an overflow on Rockchip and SCDC configuration The following changes since commit 1a07a94b47b1f528f39c

[Bug 110514] [CI][BAT] igt@* - skip - Test requirement: is_i915_device(fd) && has_known_intel_chipset(fd), Skip

2019-04-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110514 --- Comment #3 from CI Bug Log --- The CI Bug Log issue associated to this bug has been updated. ### New filters associated * CML: igt@kms_addfb_basic@* - skip - Test requirement: gen >= 9, SKIP - https://intel-gfx-ci.01.org/tree/drm-tip/Pat

Re: [PATCH] pci/quirks: Add quirk to reset nvgpu at boot for the Lenovo ThinkPad P50

2019-04-25 Thread Bjorn Helgaas
On Tue, Feb 12, 2019 at 05:02:30PM -0500, Lyude Paul wrote: > On a very specific subset of ThinkPad P50 SKUs, particularly ones that > come with a Quadro M1000M chip instead of the M2000M variant, the BIOS > seems to have a very nasty habit of not always resetting the secondary > Nvidia GPU between

Re: [PATCH] drm/bridge/synopsys: dsi: Don't blindly call post_disable

2019-04-25 Thread Matt Redfearn
Hi Andrzej, On 25/04/2019 13:13, Andrzej Hajda wrote: > On 24.04.2019 16:22, Matt Redfearn wrote: >> The DRM documentation states that post_disable is an optional callback. >> As such an implementing device may not populate it. To avoid panicing >> the kernel by calling a NULL function pointer, we

Re: [PATCH] drm/bridge/synopsys: dsi: Allow VPG to be enabled via debugfs

2019-04-25 Thread Matt Redfearn
Hi Laurent, Thanks for the review! On 25/04/2019 10:31, Laurent Pinchart wrote: > On Wed, Apr 24, 2019 at 02:22:18PM +, Matt Redfearn wrote: >> The Synopsys MIPI DSI IP contains a video test pattern generator which >> is helpful in debugging video timing with connected displays. >> Add a deb

[Bug 110514] [CI][BAT] igt@* - skip - Test requirement: is_i915_device(fd) && has_known_intel_chipset(fd), Skip

2019-04-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110514 --- Comment #2 from CI Bug Log --- The CI Bug Log issue associated to this bug has been updated. ### New filters associated * CML: igt@* - skip - Test requirement: is_i915_device(fd) && has_known_intel_chipset(fd), Skip (No new failures asso

[Bug 110514] [CI][BAT] igt@* - skip - Test requirement: is_i915_device(fd) && has_known_intel_chipset(fd), Skip

2019-04-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110514 Martin Peres changed: What|Removed |Added Component|DRM/Intel |IGT Priority|medium

[PATCH v7 4/4] drm/vc4: Allocate binner bo when starting to use the V3D

2019-04-25 Thread Paul Kocialkowski
The binner BO is not required until the V3D is in use, so avoid allocating it at probe and do it on the first non-dumb BO allocation. Keep track of which clients are using the V3D and liberate the buffer when there is none left, using a kref. Protect the logic with a mutex to avoid race conditions

[PATCH v7 2/4] drm/vc4: Check for V3D before binner bo alloc

2019-04-25 Thread Paul Kocialkowski
Check that we have a V3D device registered before attempting to allocate a binner buffer object. Signed-off-by: Paul Kocialkowski --- drivers/gpu/drm/vc4/vc4_v3d.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_v3d.c b/drivers/gpu/drm/vc4/vc4_v3d.c index 7c490106e

[PATCH v7 1/4] drm/vc4: Reformat and the binner bo allocation helper

2019-04-25 Thread Paul Kocialkowski
In preparation for wrapping the binner bo allocation helper with put/get helpers, pass the vc4 dev directly and drop the vc4 prefix. Signed-off-by: Paul Kocialkowski --- drivers/gpu/drm/vc4/vc4_v3d.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/

[PATCH v7 0/4] drm/vc4: Binner BO management improvements

2019-04-25 Thread Paul Kocialkowski
Changes since v6: * Removed vc4_v3d_bin_bo_put from error paths; * Added WARN_ON_ONCE when no bin BO at refcount release. Changes since v5: * Fix more locking mistakes; * Introduce get/put helpers; * Grabbed a reference when submitting an exec job with a binner slot. * Addressed misc comments. Ch

[PATCH v7 3/4] drm/vc4: Check for the binner bo before handling OOM interrupt

2019-04-25 Thread Paul Kocialkowski
Since the OOM interrupt directly deals with the binner bo, it doesn't make sense to try and handle it without a binner buffer registered. Signed-off-by: Paul Kocialkowski --- drivers/gpu/drm/vc4/vc4_irq.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_irq.c b/driv

Re: [PATCH] drm/bridge/synopsys: dsi: Don't blindly call post_disable

2019-04-25 Thread Andrzej Hajda
On 24.04.2019 16:22, Matt Redfearn wrote: > The DRM documentation states that post_disable is an optional callback. > As such an implementing device may not populate it. To avoid panicing > the kernel by calling a NULL function pointer, we should NULL check it > before blindy calling it. > > Signed

Re: [Intel-gfx] [PATCH v4 0/1] drm/fb-helper: Move modesetting code to drm_client

2019-04-25 Thread Noralf Trønnes
Den 25.04.2019 11.25, skrev Daniel Vetter: > On Thu, Apr 25, 2019 at 10:31 AM Noralf Trønnes wrote: >> >> The Intel CI [1] was not happy with the previous version and I don't >> know which part it didn't like. So I'll split up the series and feed it >> piece by piece until I know where the probl

[Bug 109607] [CI][DRMTIP] Time is passing at a different rate between IGT machines and the controller

2019-04-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109607 --- Comment #12 from Arek Hiler --- This is an infrastructure deficiency coming from technical limitations. It is especially bad as it requires us to create a catch-all bug for incompletes, that may obscure some serious problems. To mitigate th

Re: [PATCH v6 1/3] drm: Add CRTC background color property (v5)

2019-04-25 Thread Maarten Lankhorst
Op 26-02-2019 om 17:17 schreef Matt Roper: > On Tue, Feb 26, 2019 at 08:26:36AM +0100, Maarten Lankhorst wrote: >> Hey, >> >> Op 21-02-2019 om 01:28 schreef Matt Roper: >>> Some display controllers can be programmed to present non-black colors >>> for pixels not covered by any plane (or pixels cove

Re: [PATCH 0/6 v2] libdrm: Patches from AOSP

2019-04-25 Thread Emil Velikov
On Wed, 24 Apr 2019 at 18:08, John Stultz wrote: > > Recently I've been trying to sync the AOSP libdrm tree with > the upstream freedesktop branch. > > Thanks to input from Sean, Alistair and Marissa, we've managed > to drop a bunch of stale patches AOSP was carrying, and get > the AOSP libdrm upd

Re: [PATCH libdrm] tests/libkms-test-plane: fix possbile memory leak

2019-04-25 Thread Emil Velikov
On Thu, 25 Apr 2019 at 10:49, Seung-Woo Kim wrote: > > The pointer p aquired with drmModeGetPlane() is not free in error > path. Fix possible memory leak by calling drmModeFreePlane() in > the error path. > > Signed-off-by: Seung-Woo Kim Reviewed-by: Emil Velikov and pushed to master. Thanks

Re: [patch V3 00/29] stacktrace: Consolidate stack trace usage

2019-04-25 Thread Ingo Molnar
* Thomas Gleixner wrote: > - if (unlikely(!ret)) > + if (unlikely(!ret)) { > + if (!trace->nr_entries) { > + /* > + * If save_trace fails here, the printing might > + * trigger a WARN but because of the !nr_entries

[PATCH libdrm] tests/libkms-test-plane: fix possbile memory leak

2019-04-25 Thread Seung-Woo Kim
The pointer p aquired with drmModeGetPlane() is not free in error path. Fix possible memory leak by calling drmModeFreePlane() in the error path. Signed-off-by: Seung-Woo Kim --- tests/kms/libkms-test-plane.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/tests/kms/l

Re: [PATCH] drm/etnaviv: initialize idle mask before querying the HW db

2019-04-25 Thread Philipp Zabel
On Wed, 2019-04-17 at 14:21 +0200, Lucas Stach wrote: > If there is a match in the HW DB, the function is left early, before > inititalizing the idle mask. Fix this by doing the init earlier, as > only old GPUs, not present in the HW DB need a different idle mask. > > Signed-off-by: Lucas Stach

Re: [PATCH 16/17] drm/vkms: Convert to using __drm_atomic_helper_crtc_reset() for reset.

2019-04-25 Thread Maarten Lankhorst
Op 06-03-2019 om 23:43 schreef Rodrigo Siqueira: > On 03/01, Maarten Lankhorst wrote: >> Convert vkms to using __drm_atomic_helper_crtc_reset(), instead of >> writing its own version. Instead of open coding destroy_state(), >> call it directly for freeing the old state. >> >> Signed-off-by: Maarten

Re: [PATCH v2 6/8] drm/etnaviv: provide MMU context to etnaviv_gem_mapping_get

2019-04-25 Thread Philipp Zabel
On Wed, 2019-04-17 at 15:50 +0200, Lucas Stach wrote: > In preparation to having a context per process, etnaviv_gem_mapping_get > should not use the current GPU context, but needs to be told which > context to use. > > Signed-off-by: Lucas Stach Reviewed-by: Philipp Zabel regards Philipp _

Re: [PATCH] drm/bridge/synopsys: dsi: Allow VPG to be enabled via debugfs

2019-04-25 Thread Laurent Pinchart
On Wed, Apr 24, 2019 at 02:22:18PM +, Matt Redfearn wrote: > The Synopsys MIPI DSI IP contains a video test pattern generator which > is helpful in debugging video timing with connected displays. > Add a debugfs directory containing files which allow the VPG to be > enabled and disabled, and it

Re: [PATCH v2 5/8] drm/etnaviv: split out starting of FE idle loop

2019-04-25 Thread Philipp Zabel
On Wed, 2019-04-17 at 15:50 +0200, Lucas Stach wrote: > Move buffer setup and starting of the FE loop in the kernel ringbuffer > into a separate function. This is a preparation to start the FE later > in the submit process. > > Signed-off-by: Lucas Stach Reviewed-by: Philipp Zabel regards Phil

Re: [Intel-gfx] [PATCH v4 0/1] drm/fb-helper: Move modesetting code to drm_client

2019-04-25 Thread Daniel Vetter
On Thu, Apr 25, 2019 at 10:31 AM Noralf Trønnes wrote: > > The Intel CI [1] was not happy with the previous version and I don't > know which part it didn't like. So I'll split up the series and feed it > piece by piece until I know where the problem is. You can also send stuff to intel-gfx-try...

Re: [PATCH] drm/bridge/synopsys: dsi: Don't blindly call post_disable

2019-04-25 Thread Laurent Pinchart
Hi Matt, Thank you for the patch. On Wed, Apr 24, 2019 at 02:22:00PM +, Matt Redfearn wrote: > The DRM documentation states that post_disable is an optional callback. > As such an implementing device may not populate it. To avoid panicing > the kernel by calling a NULL function pointer, we sh

Re: [PATCH] drm/bridge/synopsys: dsi: Wait for all active lanes to reach stop

2019-04-25 Thread Laurent Pinchart
Hi Matt, Thank you for the patch. On Wed, Apr 24, 2019 at 02:21:40PM +, Matt Redfearn wrote: > The Synopsys manual states that software should wait for all active > lanes to reach stop state (User manual section 3.1.5). Currently the > driver only waits for / checks that the clock lane is in

Re: [PATCH 4/9] drm/ttm: Allow the driver to provide the ttm struct vm_operations_struct

2019-04-25 Thread Koenig, Christian
Am 25.04.2019 10:35 schrieb Thomas Hellstrom : Hi, Christian, On Wed, 2019-04-24 at 16:20 +0200, Thomas Hellström wrote: > On Wed, 2019-04-24 at 14:10 +, Koenig, Christian wrote: > > Am 24.04.19 um 14:00 schrieb Thomas Hellstrom: > > > Add a pointer to the struct vm_operations_struct in the

[GIT PULL] drm/imx: fix DP CSC handling

2019-04-25 Thread Philipp Zabel
Hi Dave, Daniel, please consider merging these imx-drm fixes for v5.1. regards Philipp The following changes since commit dc4060a5dc2557e6b5aa813bf5b73677299d62d2: Linux 5.1-rc5 (2019-04-14 15:17:41 -0700) are available in the Git repository at: git://git.pengutronix.de/pza/linux tags/imx

Re: [PATCH] drm/bridge: dw-hdmi: fix SCDC configuration for ddc-i2c-bus

2019-04-25 Thread Andrzej Hajda
On 21.04.2019 10:25, Jonas Karlman wrote: > When ddc-i2c-bus property is used, a NULL pointer dereference is reported: > > [ 31.041669] Unable to handle kernel NULL pointer dereference at virtual > address 0008 > [ 31.041671] pgd = 4d3c16f6 > [ 31.041673] [0008] *pgd= > [ 3

Re: [PATCH 4/9] drm/ttm: Allow the driver to provide the ttm struct vm_operations_struct

2019-04-25 Thread Thomas Hellstrom
Hi, Christian, On Wed, 2019-04-24 at 16:20 +0200, Thomas Hellström wrote: > On Wed, 2019-04-24 at 14:10 +, Koenig, Christian wrote: > > Am 24.04.19 um 14:00 schrieb Thomas Hellstrom: > > > Add a pointer to the struct vm_operations_struct in the > > > bo_device, > > > and > > > assign that poin

[PATCH v4 1/1] drm/fb-helper: Avoid race with DRM userspace

2019-04-25 Thread Noralf Trønnes
drm_fb_helper_is_bound() is used to check if DRM userspace is in control. This is done by looking at the fb on the primary plane. By the time fb-helper gets around to committing, it's possible that the facts have changed. Avoid this race by holding the drm_device->master_mutex lock while committin

[PATCH v4 0/1] drm/fb-helper: Move modesetting code to drm_client

2019-04-25 Thread Noralf Trønnes
The Intel CI [1] was not happy with the previous version and I don't know which part it didn't like. So I'll split up the series and feed it piece by piece until I know where the problem is. Noralf. [1] https://patchwork.freedesktop.org/series/58597/ Noralf Trønnes (1): drm/fb-helper: Avoid ra

Re: [PATCH v2 5/7] pwm: atmel-hlcdc: add compatible for SAM9X60 HLCDC's PWM

2019-04-25 Thread Lee Jones
On Tue, 05 Mar 2019, claudiu.bez...@microchip.com wrote: > From: Claudiu Beznea > > Add compatible string for SAM9X60 HLCDC's PWM. > > Signed-off-by: Claudiu Beznea > Acked-by: Thierry Reding > --- > drivers/pwm/pwm-atmel-hlcdc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/d

[Bug 102646] Screen flickering under amdgpu-experimental [buggy auto power profile]

2019-04-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102646 --- Comment #83 from Tom B --- I have a similar problem with my Radeon VII. My testing/experiments are outlined here: https://bugs.freedesktop.org/show_bug.cgi?id=110510 sorry for the long post! However my bug seems slightly different albeit re

[Bug 110313] [CI][SHARDS] igt@kms_lease@lease-uevent - fail - Failed assertion: igt_lease_change_detected(uevent_monitor, 1)

2019-04-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110313 --- Comment #4 from Daniel Vetter --- (In reply to Arek Hiler from comment #3) > This seems like a test deficiency. We are polling on udev monitor FD in > anticipation of an events. According the the log linked in the previous > comments we get

[git pull] vmwgfx-fixes-5.1

2019-04-25 Thread Thomas Hellstrom
Dave, Daniel A single fix for a layer violation requested by Cristoph. The following changes since commit c2d311553855395764e2e5bf401d987ba65c2056: drm/vmwgfx: Don't double-free the mode stored in par->set_mode (2019-03-20 07:57:01 +0100) are available in the Git repository at: git://peop

Re: [PATCH] gpu/docs: Clarify what userspace means for gl

2019-04-25 Thread Daniel Vetter
On Thu, Apr 25, 2019 at 11:28:40AM +0800, zhoucm1 wrote: > > > On 2019年04月25日 03:22, Eric Anholt wrote: > > "Zhou, David(ChunMing)" writes: > > > > > Will linux be only mesa-linux? I thought linux is an open linux. > > > Which will impact our opengl/amdvlk(MIT open source), not sure Rocm: > >

[PATCH] drm/komeda: Use memset to initialize config_id

2019-04-25 Thread Nathan Chancellor
Clang warns: drivers/gpu/drm/arm/display/komeda/komeda_dev.c:76:38: warning: suggest braces around initialization of subobject [-Wmissing-braces] union komeda_config_id config_id = {0,}; ^ {} 1 warning

[PATCH v2 5/9] drm/amdkfd: use helper pci_dev_id

2019-04-25 Thread Heiner Kallweit
Use new helper pci_dev_id() to simplify the code. Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c index 2cb09e

Re: [PATCH v2 56/79] docs: Documentation/*.txt: rename all ReST files to *.rst

2019-04-25 Thread Borislav Petkov
On Tue, Apr 23, 2019 at 04:06:40PM -0600, Jonathan Corbet wrote: > Remember that most of our docs are 99% RST even though they were written > by people who had never even heard of RST. I really don't think it's a > big deal - a far smaller cognitive load than trying to keep up with any > given sub

[PATCH v2 3/9] r8169: use new helper pci_dev_id

2019-04-25 Thread Heiner Kallweit
Use new helper pci_dev_id() to simplify the code. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index efaea1a0a..ae476fe8d

Re: Support for 2D engines/blitters in V4L2 and DRM

2019-04-25 Thread Nicolas Dufresne
Le mercredi 24 avril 2019 à 18:54 +0200, Michel Dänzer a écrit : > On 2019-04-24 5:44 p.m., Nicolas Dufresne wrote: > > Le mercredi 24 avril 2019 à 17:06 +0200, Daniel Vetter a écrit : > > > On Wed, Apr 24, 2019 at 4:41 PM Paul Kocialkowski > > > wrote: > > > > On Wed, 2019-04-24 at 16:39 +0200, M

Re: Support for 2D engines/blitters in V4L2 and DRM

2019-04-25 Thread Nicolas Dufresne
Le mercredi 24 avril 2019 à 10:31 +0200, Michel Dänzer a écrit : > On 2019-04-19 10:38 a.m., Paul Kocialkowski wrote: > > On Thu, 2019-04-18 at 20:30 -0400, Nicolas Dufresne wrote: > > > Le jeudi 18 avril 2019 à 10:18 +0200, Daniel Vetter a écrit : > > > > > It would be cool if both could be used c

Re: [PATCH v2 56/79] docs: Documentation/*.txt: rename all ReST files to *.rst

2019-04-25 Thread Mauro Carvalho Chehab
Em Wed, 24 Apr 2019 16:54:10 +0200 Borislav Petkov escreveu: > On Wed, Apr 24, 2019 at 07:40:07AM -0300, Mauro Carvalho Chehab wrote: > > Personally, I don't care much with monospaced fonts on this table. After > > all, if I want to see it monospaced, I can simply click at the > > "View page sour

Re: [PATCH] [v8,1/2] dt-bindings: panel: Add Boe Himax8279d is 1200x1920, 4-lane MIPI-DSI LCD panel

2019-04-25 Thread Jerry Han
Hi Thierry Reding: *Could you please help to check whether there is any problem with the sign-off identity**?* *Thanks* Jerry Han 于2019年4月25日周四 上午11:18写道: > The Boe Himax8279d is a 8.0" panel with a 1200x1920 resolution and > connected to DSI using four lanes. > > V8: > - Modify communication

[PATCH v2 6/9] iommu/amd: use helper pci_dev_id

2019-04-25 Thread Heiner Kallweit
Use new helper pci_dev_id() to simplify the code. Signed-off-by: Heiner Kallweit --- drivers/iommu/amd_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c index f467cc4b4..5cb201422 100644 --- a/drivers/iommu/amd_iommu

Re: [PATCH v1 11/17] kunit: test: add test managed resource tests

2019-04-25 Thread Masayoshi Mizuma
On Thu, Apr 04, 2019 at 03:06:46PM -0700, Brendan Higgins wrote: > From: Avinash Kondareddy > > Tests how tests interact with test managed resources in their lifetime. > > Signed-off-by: Avinash Kondareddy > Signed-off-by: Brendan Higgins > --- > kunit/test-test.c | 122 ++

Re: [PATCH v2 56/79] docs: Documentation/*.txt: rename all ReST files to *.rst

2019-04-25 Thread Mauro Carvalho Chehab
Em Tue, 23 Apr 2019 23:38:16 +0200 Borislav Petkov escreveu: > On Tue, Apr 23, 2019 at 05:05:02PM -0300, Mauro Carvalho Chehab wrote: > > That's my view about how that specific file would be after > > converted to ReST: > > > > > > https://git.linuxtv.org/mchehab/experimental.git/tree/Docum

[PATCH v2 9/9] platform/chrome: chromeos_laptop: use helper pci_dev_id

2019-04-25 Thread Heiner Kallweit
Use new helper pci_dev_id() to simplify the code. Signed-off-by: Heiner Kallweit --- drivers/platform/chrome/chromeos_laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/chrome/chromeos_laptop.c b/drivers/platform/chrome/chromeos_laptop.c index 24326eec

[PATCH v2 2/9] PCI: use helper pci_dev_id

2019-04-25 Thread Heiner Kallweit
Use new helper pci_dev_id() to simplify the code. Signed-off-by: Heiner Kallweit --- drivers/pci/msi.c| 6 +++--- drivers/pci/search.c | 10 +++--- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index 73986825d..e039b740f 100644 ---

[PATCH] [v8, 1/2] dt-bindings: panel: Add Boe Himax8279d is 1200x1920, 4-lane MIPI-DSI LCD panel

2019-04-25 Thread Jerry Han
The Boe Himax8279d is a 8.0" panel with a 1200x1920 resolution and connected to DSI using four lanes. V8: - Modify communication address V7: - Add the information of the reviewer V6: - Add the information of the reviewer V5: - Added changelog V4: - None V3: - None V2: - Add compatible device

  1   2   >