Re: [PATCH v2 0/8] drm/omap: OMAP_BO flags

2019-08-02 Thread Jean-Jacques Hiblot
On 01/08/2019 11:02, Tomi Valkeinen wrote: Hi JJ, On 08/07/2019 13:45, Jean-Jacques Hiblot wrote: A first version of this work had been sent by Tomi Valkeinen in may 2017 (https://www.spinics.net/lists/dri-devel/msg140663.html). This series adds a few new OMAP_BO flags to help the userspace

Re: [PATCH 2/2] i915: do not leak module ref counter

2019-08-02 Thread Sergey Senozhatsky
On (08/02/19 14:10), Chris Wilson wrote: > > > drivers/gpu/drm/i915/gem/i915_gemfs.c | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/i915/gem/i915_gemfs.c > > > b/drivers/gpu/drm/i915/gem/i915_gemfs.c > > > index cf05ba72df9d..d437188d1736

[PATCH v7 05/18] drm/virtio: drop no_wait argument from virtio_gpu_object_reserve

2019-08-02 Thread Gerd Hoffmann
All callers pass no_wait = false. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_drv.h | 5 ++--- drivers/gpu/drm/virtio/virtgpu_gem.c | 4 ++-- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 4 ++-- 3 files changed, 6 insertions(+), 7 deletions(-)

[PATCH v7 18/18] drm/virtio: add fence sanity check

2019-08-02 Thread Gerd Hoffmann
Make sure we don't leak half-initialized fences outside the driver. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_fence.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/virtio/virtgpu_fence.c b/drivers/gpu/drm/virtio/virtgpu_fence.c index

[PATCH v7 03/18] drm/virtio: simplify cursor updates

2019-08-02 Thread Gerd Hoffmann
No need to do the reservation dance, we can just wait on the fence directly. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_plane.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git

[PATCH v7 12/18] drm/virtio: rework virtio_gpu_cmd_context_{attach, detach}_resource

2019-08-02 Thread Gerd Hoffmann
Switch to the virtio_gpu_array_* helper workflow. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_drv.h | 4 ++-- drivers/gpu/drm/virtio/virtgpu_gem.c | 24 +++- drivers/gpu/drm/virtio/virtgpu_vq.c | 12 3 files changed, 21 insertions(+), 19

[PATCH v7 08/18] drm/virtio: rework virtio_gpu_execbuffer_ioctl fencing

2019-08-02 Thread Gerd Hoffmann
Rework fencing workflow, starting with virtio_gpu_execbuffer_ioctl. Stop using ttm helpers, use the virtio_gpu_array_* helpers (which work on the reservation objects directly) instead. Also store the object array in struct virtio_gpu_vbuffer, so we explicitly keep a reference of all buffers used

[PATCH v7 06/18] drm/virtio: remove ttm calls from in virtio_gpu_object_{reserve, unreserve}

2019-08-02 Thread Gerd Hoffmann
Call reservation_object_* directly instead of using ttm_bo_{reserve,unreserve}. v4: check for EINTR only. v3: check for EINTR too. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_drv.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH v7 17/18] drm/virtio: drop virtio_gpu_object_{reserve, unreserve}

2019-08-02 Thread Gerd Hoffmann
No users left. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_drv.h | 21 - 1 file changed, 21 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h b/drivers/gpu/drm/virtio/virtgpu_drv.h index 59f71dc94017..fb35831ed351 100644 ---

[PATCH v7 00/18] drm/virtio: switch from ttm to gem shmem helpers.

2019-08-02 Thread Gerd Hoffmann
ttm increasingly gets into the way while hacking on virtio-gpu memory management. It also overkill for what virtio-gpu needs. Lets get rid of it. v7: - rebase to latest drm-misc-next - reorder patches: switch all virtio commands to object array helpers first. then drop ttm, to make sure we

[PATCH v7 15/18] drm/virtio: remove virtio_gpu_alloc_object

2019-08-02 Thread Gerd Hoffmann
Thin wrapper around virtio_gpu_object_create(), but calling that directly works equally well. Signed-off-by: Gerd Hoffmann Acked-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_drv.h | 4 drivers/gpu/drm/virtio/virtgpu_gem.c | 23 ---

[PATCH v7 04/18] drm/virtio: remove virtio_gpu_object_wait

2019-08-02 Thread Gerd Hoffmann
No users left. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_drv.h| 1 - drivers/gpu/drm/virtio/virtgpu_object.c | 13 - 2 files changed, 14 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h

[PATCH v7 09/18] drm/virtio: rework virtio_gpu_object_create fencing

2019-08-02 Thread Gerd Hoffmann
Rework fencing workflow. Stop using ttm helpers, use the virtio_gpu_array_* helpers instead. Due to using the gem reservation object it is initialized and ready for use before calling ttm_bo_init. So we can simply use the standard fencing workflow and drop the tricky logic which checks whenever

[PATCH v7 02/18] drm/virtio: switch virtio_gpu_wait_ioctl() to gem helper.

2019-08-02 Thread Gerd Hoffmann
Use drm_gem_reservation_object_wait() in virtio_gpu_wait_ioctl(). This also makes the ioctl run lockless. v5: handle lookup failure. v2: use reservation_object_test_signaled_rcu for VIRTGPU_WAIT_NOWAIT. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter ---

[PATCH v7 11/18] drm/virtio: rework virtio_gpu_transfer_to_host_ioctl fencing

2019-08-02 Thread Gerd Hoffmann
Switch to the virtio_gpu_array_* helper workflow. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_drv.h | 4 +-- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 50 +++--- drivers/gpu/drm/virtio/virtgpu_plane.c | 21 ---

[PATCH v7 14/18] drm/virtio: switch from ttm to gem shmem helpers

2019-08-02 Thread Gerd Hoffmann
virtio-gpu basically needs a sg_table for the bo, to tell the host where the backing pages for the object are. So the gem shmem helpers are a perfect fit. Some drm_gem_object_funcs need thin wrappers to update the host state, but otherwise the helpers handle everything just fine. Once the

[PATCH v7 10/18] drm/virtio: rework virtio_gpu_transfer_from_host_ioctl fencing

2019-08-02 Thread Gerd Hoffmann
Switch to the virtio_gpu_array_* helper workflow. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_drv.h | 3 +- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 40 ++ drivers/gpu/drm/virtio/virtgpu_vq.c| 8 -- 3 files changed, 23 insertions(+), 28

[PATCH v7 07/18] drm/virtio: add virtio_gpu_object_array & helpers

2019-08-02 Thread Gerd Hoffmann
Some helper functions to manage an array of gem objects. v6: - add ticket to struct virtio_gpu_object_array. - add virtio_gpu_array_{lock,unlock}_resv helpers. - add virtio_gpu_array_add_fence helper. v5: some small optimizations (Chia-I Wu). v4: make them virtio-private instead of generic

[PATCH v7 16/18] drm/virtio: drop virtio_gpu_object_{ref,unref}

2019-08-02 Thread Gerd Hoffmann
No users left. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_drv.h | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h b/drivers/gpu/drm/virtio/virtgpu_drv.h index d4d82679d83a..59f71dc94017 100644 ---

[PATCH v7 13/18] drm/virtio: drop virtio_gpu_object_list_validate/virtio_gpu_unref_list

2019-08-02 Thread Gerd Hoffmann
No users left. Signed-off-by: Gerd Hoffmann Acked-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_drv.h | 3 -- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 39 -- 2 files changed, 42 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h

[PATCH v7 01/18] drm/virtio: pass gem reservation object to ttm init

2019-08-02 Thread Gerd Hoffmann
With this gem and ttm will use the same reservation object, so mixing and matching ttm / gem reservation helpers should work fine. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_object.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

Re: [PATCH 2/2] i915: do not leak module ref counter

2019-08-02 Thread Chris Wilson
Quoting Chris Wilson (2019-08-02 13:58:36) > Quoting Sergey Senozhatsky (2019-08-02 13:39:56) > > put_filesystem() before i915_gemfs_init() deals with > > kern_mount() error. > > > > Signed-off-by: Sergey Senozhatsky > > --- > > drivers/gpu/drm/i915/gem/i915_gemfs.c | 4 +++- > > 1 file

Re: [PATCH 1/2] i915: convert to new mount API

2019-08-02 Thread Sergey Senozhatsky
On (08/02/19 13:54), Chris Wilson wrote: [..] > > int i915_gemfs_init(struct drm_i915_private *i915) > > { > > + struct fs_context *fc = NULL; > > struct file_system_type *type; > > struct vfsmount *gemfs; > > + bool ok = true; > > Start with ok = false, we only need

Re: [PATCH 2/2] i915: do not leak module ref counter

2019-08-02 Thread Chris Wilson
Quoting Sergey Senozhatsky (2019-08-02 13:39:56) > put_filesystem() before i915_gemfs_init() deals with > kern_mount() error. > > Signed-off-by: Sergey Senozhatsky > --- > drivers/gpu/drm/i915/gem/i915_gemfs.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git

[PATCH v2] drm/tilcdc: Remove obsolete crtc_mode_valid() hack

2019-08-02 Thread Jyri Sarha
Earlier there were no mode_valid() helper for crtc and tilcdc had a hack to over come this limitation. But now the mode_valid() helper is there (has been since v4.13), so it is about time to get rid of that hack. Signed-off-by: Jyri Sarha Reviewed-by: Laurent Pinchart --- This is just a rebased

Re: [PATCH 1/2] i915: convert to new mount API

2019-08-02 Thread Chris Wilson
Quoting Sergey Senozhatsky (2019-08-02 13:39:55) > tmpfs does not set ->remount_fs() anymore and its users need > to be converted to new mount API. > > BUG: kernel NULL pointer dereference, address: > PF: supervisor instruction fetch in kernel mode > PF: error_code(0x0010) -

[Bug 107020] Dolphin freezes only with OpenGL

2019-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107020 Andre Klapper changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW

Re: [PATCH 00/34] put_user_pages(): miscellaneous call sites

2019-08-02 Thread Jan Kara
On Fri 02-08-19 11:12:44, Michal Hocko wrote: > On Thu 01-08-19 19:19:31, john.hubb...@gmail.com wrote: > [...] > > 2) Convert all of the call sites for get_user_pages*(), to > > invoke put_user_page*(), instead of put_page(). This involves dozens of > > call sites, and will take some time. > >

[PATCH 1/2] i915: convert to new mount API

2019-08-02 Thread Sergey Senozhatsky
tmpfs does not set ->remount_fs() anymore and its users need to be converted to new mount API. BUG: kernel NULL pointer dereference, address: PF: supervisor instruction fetch in kernel mode PF: error_code(0x0010) - not-present page RIP: 0010:0x0 Code: Bad RIP value. Call

[PATCH 2/2] i915: do not leak module ref counter

2019-08-02 Thread Sergey Senozhatsky
put_filesystem() before i915_gemfs_init() deals with kern_mount() error. Signed-off-by: Sergey Senozhatsky --- drivers/gpu/drm/i915/gem/i915_gemfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gemfs.c

[Bug 111284] Sadmin,privileged admin Privileged examiner can edit questions in the purchased packages.Subjects can also be edited

2019-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111284 dhrisya changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail

[Bug 111284] Sadmin,privileged admin Privileged examiner can edit questions in the purchased packages.Subjects can also be edited

2019-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111284 Bug ID: 111284 Summary: Sadmin,privileged admin Privileged examiner can edit questions in the purchased packages.Subjects can also be edited Product: DRI

Re: Threaded submission & semaphore sharing

2019-08-02 Thread Lionel Landwerlin
Went through the spec VUs again and there is a bit that says that binary semaphores must have all of the their dependencies submitted for execution. So essentially it means in our implementation of QueueSubmit() we should be able to do a short wait_for_available on all of those which does

Re: [PATCH] drm/imx: Drop unused imx-ipuv3-crtc.o build

2019-08-02 Thread Philipp Zabel
Hi Guido, Fabio, On Fri, 2019-08-02 at 08:03 -0300, Fabio Estevam wrote: > Hi Guido, > > Good catch! > > On Fri, Aug 2, 2019 at 7:55 AM Guido Günther wrote: > > > > Since > > > > commit 3d1df96ad468 ("drm/imx: merge imx-drm-core and ipuv3-crtc in one > > module") > > > > imx-ipuv3-crtc.o

Re: [PATCH] etnaviv: fix whitespace errors

2019-08-02 Thread Christian Gmeiner
Hi Philipp Am Do., 1. Aug. 2019 um 11:22 Uhr schrieb Philipp Zabel : > > Hi Christian, > > On Wed, 2019-07-31 at 23:29 +0200, Christian Gmeiner wrote: > > Signed-off-by: Christian Gmeiner > > --- > > drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2

[PATCH v2] etnaviv: fix whitespace errors

2019-08-02 Thread Christian Gmeiner
Changes in V2: - use indentation as suggested by Philipp Zabel. Signed-off-by: Christian Gmeiner --- drivers/gpu/drm/etnaviv/etnaviv_perfmon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_perfmon.c

Re: [PATCH] drm/imx: Drop unused imx-ipuv3-crtc.o build

2019-08-02 Thread Fabio Estevam
Hi Guido, Good catch! On Fri, Aug 2, 2019 at 7:55 AM Guido Günther wrote: > > Since > > commit 3d1df96ad468 ("drm/imx: merge imx-drm-core and ipuv3-crtc in one > module") > > imx-ipuv3-crtc.o is built via imxdrm-objs. So there's no need to keep an Actually, it is ipuv3-crtc.o that is built

[Bug 111244] amdgpu kernel 5.2 blank display after resume from suspend

2019-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111244 Samuele Decarli changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #7 from Samuele

[PATCH] drm/imx: Drop unused imx-ipuv3-crtc.o build

2019-08-02 Thread Guido Günther
Since commit 3d1df96ad468 ("drm/imx: merge imx-drm-core and ipuv3-crtc in one module") imx-ipuv3-crtc.o is built via imxdrm-objs. So there's no need to keep an extra entry with a non existing config value (CONFIG_DRM_IMX_IPUV3). Signed-off-by: Guido Günther --- drivers/gpu/drm/imx/Makefile |

Re: [PATCH v2 00/10] drivers, provide a way to add sysfs groups easily

2019-08-02 Thread Greg Kroah-Hartman
On Wed, Jul 31, 2019 at 06:10:45AM -0700, Dmitry Torokhov wrote: > On Wed, Jul 31, 2019 at 02:43:39PM +0200, Greg Kroah-Hartman wrote: > > This patch originally started out just as a way for platform drivers to > > easily add a sysfs group in a race-free way, but thanks to Dmitry's > > patch, this

Re: [PATCH] drm/komeda: Adds error event print functionality

2019-08-02 Thread james qian wang (Arm Technology China)
On Fri, Aug 02, 2019 at 06:05:08PM +0800, Mihail Atanassov wrote: > On Friday, 2 August 2019 10:43:10 BST Lowry Li (Arm Technology China) wrote: > > From: "Lowry Li (Arm Technology China)" > > > > Adds to print the event message when error happens and the same event > > will not be printed until

Re: drm/komeda: Add support for generation of CRC data per frame.

2019-08-02 Thread Brian Starkey
Hi Daniel, On Fri, Aug 02, 2019 at 11:52:11AM +0200, Daniel Vetter wrote: > On Fri, Aug 2, 2019 at 11:39 AM Brian Starkey wrote: > > > > Hi Liviu, > > > > On Thu, Aug 01, 2019 at 11:42:31AM +0100, Liviu Dudau wrote: > > > Komeda has support to generate per-frame CRC values in the DOU > > >

Re: [PATCH v1 2/2] drm: Clear the fence pointer when writeback job signaled

2019-08-02 Thread james qian wang (Arm Technology China)
On Fri, Aug 02, 2019 at 05:29:20PM +0800, Brian Starkey wrote: > Hi Lowry, > > On Thu, Aug 01, 2019 at 06:34:08AM +, Lowry Li (Arm Technology China) > wrote: > > Hi Brian, > > > > On Wed, Jul 31, 2019 at 09:20:04PM +0800, Brian Starkey wrote: > > > Hi Lowry, > > > > > > Thanks for this

Re: [PATCH v1 2/2] drm: Clear the fence pointer when writeback job signaled

2019-08-02 Thread Brian Starkey
Hi Daniel, On Fri, Aug 02, 2019 at 11:45:13AM +0200, Daniel Vetter wrote: > On Fri, Aug 2, 2019 at 11:43 AM Daniel Vetter wrote: > > > > On Fri, Aug 2, 2019 at 11:29 AM Brian Starkey wrote: > > > > > > Hi Lowry, > > > > > > On Thu, Aug 01, 2019 at 06:34:08AM +, Lowry Li (Arm Technology

Re: [PATCH] drm/komeda: Adds error event print functionality

2019-08-02 Thread Mihail Atanassov
On Friday, 2 August 2019 10:43:10 BST Lowry Li (Arm Technology China) wrote: > From: "Lowry Li (Arm Technology China)" > > Adds to print the event message when error happens and the same event > will not be printed until next vsync. > > Changes since v2: > 1. Refine komeda_sprintf(); > 2. Not

Re: [PATCH v1 22/33] drm/tilcdc: drop use of drmP.h

2019-08-02 Thread Jyri Sarha
On 30/06/2019 09:19, Sam Ravnborg wrote: > Dropped drmP.h and all other header files not used by tilcdc_drv.h. > Added the minimal includes and forwards to make the header file > self-contained. > > Then dropped the remaining uses of drmP.h and fixed all fall-out. > > Signed-off-by: Sam Ravnborg

Re: Threaded submission & semaphore sharing

2019-08-02 Thread zhoucm1
On 2019年08月02日 17:41, Lionel Landwerlin wrote: Hey David, On 02/08/2019 12:11, zhoucm1 wrote: Hi Lionel, For binary semaphore, I guess every one will think application will guarantee wait is behind the signal, whenever the semaphore is shared or used in internal-process. I think below

Re: [PATCH] drm/tilcdc: Check priv->crtc validity in cpufreq_transition()

2019-08-02 Thread Peter Ujfalusi
On 02/08/2019 12.35, Jyri Sarha wrote: > On 02/08/2019 11:39, Peter Ujfalusi wrote: >> The notifier can be called before we have crtc. With the check we can avoid >> NULL pointer dereference within tilcdc_crtc_update_clk(). >> >> Signed-off-by: Peter Ujfalusi > > Peter, do you have

Re: drm/komeda: Add support for generation of CRC data per frame.

2019-08-02 Thread Daniel Vetter
On Fri, Aug 2, 2019 at 11:39 AM Brian Starkey wrote: > > Hi Liviu, > > On Thu, Aug 01, 2019 at 11:42:31AM +0100, Liviu Dudau wrote: > > Komeda has support to generate per-frame CRC values in the DOU > > backend subsystem. Implement necessary hooks to expose the CRC > > "control" and "data" file

Re: [PATCH v1 2/2] drm: Clear the fence pointer when writeback job signaled

2019-08-02 Thread Daniel Vetter
On Fri, Aug 2, 2019 at 11:43 AM Daniel Vetter wrote: > > On Fri, Aug 2, 2019 at 11:29 AM Brian Starkey wrote: > > > > Hi Lowry, > > > > On Thu, Aug 01, 2019 at 06:34:08AM +, Lowry Li (Arm Technology China) > > wrote: > > > Hi Brian, > > > > > > On Wed, Jul 31, 2019 at 09:20:04PM +0800,

Re: [PATCH v1 2/2] drm: Clear the fence pointer when writeback job signaled

2019-08-02 Thread Daniel Vetter
On Fri, Aug 2, 2019 at 11:29 AM Brian Starkey wrote: > > Hi Lowry, > > On Thu, Aug 01, 2019 at 06:34:08AM +, Lowry Li (Arm Technology China) > wrote: > > Hi Brian, > > > > On Wed, Jul 31, 2019 at 09:20:04PM +0800, Brian Starkey wrote: > > > Hi Lowry, > > > > > > Thanks for this cleanup. > >

[PATCH] drm/komeda: Adds error event print functionality

2019-08-02 Thread Lowry Li (Arm Technology China)
From: "Lowry Li (Arm Technology China)" Adds to print the event message when error happens and the same event will not be printed until next vsync. Changes since v2: 1. Refine komeda_sprintf(); 2. Not using STR_SZ macro for the string size in komeda_print_events(). Changes since v1: 1.

Re: Threaded submission & semaphore sharing

2019-08-02 Thread Lionel Landwerlin
Hey David, On 02/08/2019 12:11, zhoucm1 wrote: Hi Lionel, For binary semaphore, I guess every one will think application will guarantee wait is behind the signal, whenever the semaphore is shared or used in internal-process. I think below two options can fix your problem: a. Can we

Re: drm/komeda: Add support for generation of CRC data per frame.

2019-08-02 Thread Brian Starkey
Hi Liviu, On Thu, Aug 01, 2019 at 11:42:31AM +0100, Liviu Dudau wrote: > Komeda has support to generate per-frame CRC values in the DOU > backend subsystem. Implement necessary hooks to expose the CRC > "control" and "data" file over debugfs and program the DOUx_BS > accordingly. > > This patch

Re: [PATCH] drm/tilcdc: Check priv->crtc validity in cpufreq_transition()

2019-08-02 Thread Jyri Sarha
On 02/08/2019 11:39, Peter Ujfalusi wrote: > The notifier can be called before we have crtc. With the check we can avoid > NULL pointer dereference within tilcdc_crtc_update_clk(). > > Signed-off-by: Peter Ujfalusi Peter, do you have "drm/tilcdc: Register cpufreq notifier after we have

Re: [PATCH] drm/komeda: Adds error event print functionality

2019-08-02 Thread Lowry Li (Arm Technology China)
Hi Mihail, On Thu, Aug 01, 2019 at 10:48:45PM +0800, Mihail Atanassov wrote: > Hi Lowry, > > On Thursday, 1 August 2019 12:37:15 BST Lowry Li (Arm Technology China) wrote: > > From: "Lowry Li (Arm Technology China)" > > > > Adds to print the event message when error happens and the same event >

Re: [PATCH v1 2/2] drm: Clear the fence pointer when writeback job signaled

2019-08-02 Thread Brian Starkey
Hi Lowry, On Thu, Aug 01, 2019 at 06:34:08AM +, Lowry Li (Arm Technology China) wrote: > Hi Brian, > > On Wed, Jul 31, 2019 at 09:20:04PM +0800, Brian Starkey wrote: > > Hi Lowry, > > > > Thanks for this cleanup. > > > > On Wed, Jul 31, 2019 at 11:04:45AM +, Lowry Li (Arm Technology

Re: [drm/mgag200] 90f479ae51: vm-scalability.median -18.8% regression

2019-08-02 Thread Thomas Zimmermann
Hi Am 02.08.19 um 11:11 schrieb Daniel Vetter: > On Wed, Jul 31, 2019 at 12:10:54PM +0200, Thomas Zimmermann wrote: >> Hi >> >> Am 31.07.19 um 10:13 schrieb Daniel Vetter: >>> On Tue, Jul 30, 2019 at 10:27 PM Dave Airlie wrote: On Wed, 31 Jul 2019 at 05:00, Daniel Vetter wrote: >

[PULL] drm-intel-fixes

2019-08-02 Thread Jani Nikula
Hi Dave and Daniel - First off, we failed to explicitly agree who's going to cover me handling the v5.3 fixes during my time off. So it ended up not happening, and I was faced with quite the backlog. On top of that, testing uncovered lockdep issues that needed to be addressed before sending the

Re: [PATCH] Revert "drm/vgem: fix cache synchronization on arm/arm64"

2019-08-02 Thread Daniel Vetter
On Thu, Aug 01, 2019 at 01:44:58PM +0100, Chris Wilson wrote: > commit 7e9e5ead55be ("drm/vgem: fix cache synchronization on arm/arm64") > broke all of the !llc i915-vgem coherency tests in CI, and left the HW > very, very unhappy (which is even more scary). > > Fixes: 7e9e5ead55be ("drm/vgem:

Re: [LKP] [drm/mgag200] 90f479ae51: vm-scalability.median -18.8% regression

2019-08-02 Thread Thomas Zimmermann
Hi Am 02.08.19 um 09:11 schrieb Rong Chen: > Hi, > > On 8/1/19 7:58 PM, Thomas Zimmermann wrote: >> Hi >> >> Am 01.08.19 um 13:25 schrieb Feng Tang: >>> Hi Thomas, >>> >>> On Thu, Aug 01, 2019 at 11:59:28AM +0200, Thomas Zimmermann wrote: Hi Am 01.08.19 um 10:37 schrieb Feng Tang:

Re: [PATCH 06/34] drm/i915: convert put_page() to put_user_page*()

2019-08-02 Thread Joonas Lahtinen
Quoting john.hubb...@gmail.com (2019-08-02 05:19:37) > From: John Hubbard > > For pages that were retained via get_user_pages*(), release those pages > via the new put_user_page*() routines, instead of via put_page() or > release_pages(). > > This is part a tree-wide conversion, as described in

Re: [PATCH 00/34] put_user_pages(): miscellaneous call sites

2019-08-02 Thread Michal Hocko
On Thu 01-08-19 19:19:31, john.hubb...@gmail.com wrote: [...] > 2) Convert all of the call sites for get_user_pages*(), to > invoke put_user_page*(), instead of put_page(). This involves dozens of > call sites, and will take some time. How do we make sure this is the case and it will remain the

Re: [drm/mgag200] 90f479ae51: vm-scalability.median -18.8% regression

2019-08-02 Thread Daniel Vetter
On Wed, Jul 31, 2019 at 12:10:54PM +0200, Thomas Zimmermann wrote: > Hi > > Am 31.07.19 um 10:13 schrieb Daniel Vetter: > > On Tue, Jul 30, 2019 at 10:27 PM Dave Airlie wrote: > >> > >> On Wed, 31 Jul 2019 at 05:00, Daniel Vetter wrote: > >>> > >>> On Tue, Jul 30, 2019 at 8:50 PM Thomas

Re: Threaded submission & semaphore sharing

2019-08-02 Thread zhoucm1
Hi Lionel, For binary semaphore, I guess every one will think application will guarantee wait is behind the signal, whenever the semaphore is shared or used in internal-process. I think below two options can fix your problem: a. Can we extend vkWaitForFence so that it can be able to wait on

[Bug 111272] [DRI_PRIME] Error on multi GPU with only one enabled

2019-08-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111272 Michel Dänzer changed: What|Removed |Added Assignee|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.

Re: [PATCH v2 5/5] ARM: dts: stm32: remove phy-dsi-supply property on stm32mp157c-dk2 board

2019-08-02 Thread Yannick FERTRE
Hi Alexandre, this patch can be abandoned. BR -- Yannick Fertré | TINA: 166 7152 | Tel: +33 244027152 | Mobile: +33 620600270 Microcontrollers and Digital ICs Group | Microcontrolleurs Division On 5/10/19 4:20 PM, Yannick Fertré wrote: > This property is already defined into stm32mp157c.dtsi

Re: [PATCH v2 4/5] ARM: dts: stm32: move fixe regulators reg11 & reg18

2019-08-02 Thread Yannick FERTRE
Hi Alexandre, this patch can be abandoned. BR -- Yannick Fertré | TINA: 166 7152 | Tel: +33 244027152 | Mobile: +33 620600270 Microcontrollers and Digital ICs Group | Microcontrolleurs Division On 5/10/19 4:20 PM, Yannick Fertré wrote: > Move regulators reg11 & reg18 from device-tree files

Re: [PATCH v2 3/5] ARM: dts: stm32: add phy-dsi-supply property on stm32mp157c

2019-08-02 Thread Yannick FERTRE
Hi Alexandre, this patch can be abandoned. BR -- Yannick Fertré | TINA: 166 7152 | Tel: +33 244027152 | Mobile: +33 620600270 Microcontrollers and Digital ICs Group | Microcontrolleurs Division On 5/10/19 4:20 PM, Yannick Fertré wrote: > The dsi physical layer is powered by the 1v8 power

Re: [PATCH/RFC 05/12] drm: rcar-du: lvds: Add data swap support

2019-08-02 Thread Geert Uytterhoeven
Hi Laurent, On Fri, Aug 2, 2019 at 10:06 AM Laurent Pinchart wrote: > On Fri, Aug 02, 2019 at 08:34:02AM +0100, Fabrizio Castro wrote: > > When in vertical stripe mode of operation, there is the option > > of swapping even data and odd data on the two LVDS interfaces > > used to drive the video

[GIT PULL] exynos-drm-fixes

2019-08-02 Thread Inki Dae
Hi Dave, Just two fixups which fixes undefined reference error with NOMMU configuration and potential infinite issue of scaler module, and two trivial cleanups. Please kindly let me know if there is any problem. Thanks, Inki Dae The following changes since commit

Re: [PATCH v6 11/22] clk: sunxi-ng: a64: Add minimum rate for PLL_MIPI

2019-08-02 Thread Michael Nazzareno Trimarchi
Hi Maxime On Mon, Jul 29, 2019 at 8:59 AM Michael Nazzareno Trimarchi wrote: > > Hi > > On Wed, Jul 24, 2019 at 11:05 AM Maxime Ripard > wrote: > > > > On Mon, Jul 22, 2019 at 03:51:04PM +0530, Jagan Teki wrote: > > > Hi Maxime, > > > > > > On Sat, Jul 20, 2019 at 3:02 PM Maxime Ripard > > >

[PATCH] drm/tilcdc: Check priv->crtc validity in cpufreq_transition()

2019-08-02 Thread Peter Ujfalusi
The notifier can be called before we have crtc. With the check we can avoid NULL pointer dereference within tilcdc_crtc_update_clk(). Signed-off-by: Peter Ujfalusi --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH/RFC 09/12] drm: rcar-du: lvds: Fix companion's mode

2019-08-02 Thread Laurent Pinchart
Hi Fabrizio, Thank you for the patch. On Fri, Aug 02, 2019 at 08:34:06AM +0100, Fabrizio Castro wrote: > The companion encoder needs to be told to use the same > mode as the primary encoder. > > Fixes: e9e8798ab7b8 ("drm: rcar-du: lvds: Add support for dual-link mode") > Signed-off-by: Fabrizio

Re: [LKP] [drm/mgag200] 90f479ae51: vm-scalability.median -18.8% regression

2019-08-02 Thread Thomas Zimmermann
Hi Am 02.08.19 um 09:11 schrieb Rong Chen: > Hi, > > On 8/1/19 7:58 PM, Thomas Zimmermann wrote: >> Hi >> >> Am 01.08.19 um 13:25 schrieb Feng Tang: >>> Hi Thomas, >>> >>> On Thu, Aug 01, 2019 at 11:59:28AM +0200, Thomas Zimmermann wrote: Hi Am 01.08.19 um 10:37 schrieb Feng Tang:

[PATCH 34/34] fs/binfmt_elf: convert put_page() to put_user_page*()

2019-08-02 Thread john . hubbard
From: Ira Weiny For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder

Re: [PATCH 20/34] xen: convert put_page() to put_user_page*()

2019-08-02 Thread Juergen Gross
On 02.08.19 07:48, John Hubbard wrote: On 8/1/19 9:36 PM, Juergen Gross wrote: On 02.08.19 04:19, john.hubb...@gmail.com wrote: From: John Hubbard ... diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c index 2f5ce7230a43..29e461dbee2d 100644 --- a/drivers/xen/privcmd.c +++

Re: [PATCH 5/9] nouveau: simplify nouveau_dmem_migrate_to_ram

2019-08-02 Thread Bharata B Rao
On Mon, Jul 29, 2019 at 05:28:39PM +0300, Christoph Hellwig wrote: > Factor the main copy page to ram routine out into a helper that acts on > a single page and which doesn't require the nouveau_dmem_fault > structure for argument passing. Also remove the loop over multiple > pages as we only

Re: [PATCH/RFC 08/12] drm: rcar-du: lvds: Fix bridge_to_rcar_lvds

2019-08-02 Thread Laurent Pinchart
Hi Fabrizio, Thank you for the patch. On Fri, Aug 02, 2019 at 08:34:05AM +0100, Fabrizio Castro wrote: > Using name "bridge" for macro bridge_to_rcar_lvds argument doesn't > work when the pointer name used by the caller is not "bridge". > Rename the argument to "bridge_ptr" to allow for any

Re: [PATCH 2/2] drm/etnaviv: remove unused function etnaviv_gem_mapping_reference

2019-08-02 Thread Guido Günther
Hi, On Fri, Jul 05, 2019 at 07:15:36PM +0200, Lucas Stach wrote: > Hasn't been used for quite a while. There is no point in keeping > unused code around. > > Signed-off-by: Lucas Stach > --- > drivers/gpu/drm/etnaviv/etnaviv_gem.c | 12 > drivers/gpu/drm/etnaviv/etnaviv_gem.h | 1

[PATCH 33/34] kernel/events/core.c: convert put_page() to put_user_page*()

2019-08-02 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder

[PATCH 03/34] net/ceph: convert put_page() to put_user_page*()

2019-08-02 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder

[PATCH 24/34] futex: convert put_page() to put_user_page*()

2019-08-02 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder

[PATCH 26/34] mm/gup_benchmark.c: convert put_page() to put_user_page*()

2019-08-02 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder

[PATCH 02/34] net/rds: convert put_page() to put_user_page*()

2019-08-02 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder

[PATCH 14/34] oradax: convert put_page() to put_user_page*()

2019-08-02 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder

Re: [PATCH 16/34] drivers/tee: convert put_page() to put_user_page*()

2019-08-02 Thread Jens Wiklander
On Fri, Aug 2, 2019 at 4:20 AM wrote: > > From: John Hubbard > > For pages that were retained via get_user_pages*(), release those pages > via the new put_user_page*() routines, instead of via put_page() or > release_pages(). > > This is part a tree-wide conversion, as described in commit

Re: [RFC PATCH 01/11] devfreq: exynos-bus: Extract exynos_bus_profile_init()

2019-08-02 Thread Artur Świgoń
Hi, On Wed, 2019-07-24 at 21:07 +0200, Krzysztof Kozlowski wrote: > On Tue, Jul 23, 2019 at 02:20:06PM +0200, Artur Świgoń wrote: > > This patch adds a new static function, exynos_bus_profile_init(), extracted > > from exynos_bus_probe(). > > > > Signed-off-by: Artur Świgoń > > --- > >

[PATCH 01/34] mm/gup: add make_dirty arg to put_user_pages_dirty_lock()

2019-08-02 Thread john . hubbard
From: John Hubbard Provide more capable variation of put_user_pages_dirty_lock(), and delete put_user_pages_dirty(). This is based on the following: 1. Lots of call sites become simpler if a bool is passed into put_user_page*(), instead of making the call site choose which put_user_page*()

Re: [PATCH 20/34] xen: convert put_page() to put_user_page*()

2019-08-02 Thread John Hubbard
On 8/1/19 9:36 PM, Juergen Gross wrote: On 02.08.19 04:19, john.hubb...@gmail.com wrote: From: John Hubbard ... diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c index 2f5ce7230a43..29e461dbee2d 100644 --- a/drivers/xen/privcmd.c +++ b/drivers/xen/privcmd.c @@ -611,15 +611,10 @@

[PATCH 12/34] vmci: convert put_page() to put_user_page*()

2019-08-02 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder

[PATCH 07/34] drm/radeon: convert put_page() to put_user_page*()

2019-08-02 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder

Re: [PATCH v19 00/15] arm64: untag user pointers passed to the kernel

2019-08-02 Thread Kevin Brodsky
On 31/07/2019 17:50, Dave Hansen wrote: On 7/23/19 10:58 AM, Andrey Konovalov wrote: The mmap and mremap (only new_addr) syscalls do not currently accept tagged addresses. Architectures may interpret the tag as a background colour for the corresponding vma. What the heck is a "background

Re: [PATCH v2 6/7] drm/panfrost: Add support for GPU heap allocations

2019-08-02 Thread Steven Price
On 30/07/2019 21:03, Rob Herring wrote: > On Thu, Jul 25, 2019 at 9:35 AM Steven Price wrote: >> >> On 25/07/2019 15:59, Steven Price wrote: >> [...] >>> It would appear that in the following call sgt==NULL: ret = sg_alloc_table_from_pages(sgt, pages + page_offset,

Re: [PATCH libdrm v2 4/4] meson.build: Fix meson script on FreeBSD

2019-08-02 Thread Niclas Zeising
On 2019-06-17 15:44, Eric Engestrom wrote: On Monday, 2019-06-17 11:20:43 +0200, Niclas Zeising wrote: On 2019-06-17 11:14, Eric Engestrom wrote: On Sunday, 2019-06-16 14:23:43 +0100, Emil Velikov wrote: From: Niclas Zeising FreeBSD requires sys/types.h for sys/sysctl.h, add it as part of

[PATCH 13/34] rapidio: convert put_page() to put_user_page*()

2019-08-02 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder

[PATCH 11/34] scif: convert put_page() to put_user_page*()

2019-08-02 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder

Re: [PATCH v19 02/15] arm64: Introduce prctl() options to control the tagged user addresses ABI

2019-08-02 Thread Kevin Brodsky
On 31/07/2019 18:05, Dave Hansen wrote: On 7/23/19 10:58 AM, Andrey Konovalov wrote: +long set_tagged_addr_ctrl(unsigned long arg) +{ + if (!tagged_addr_prctl_allowed) + return -EINVAL; + if (is_compat_task()) + return -EINVAL; + if (arg &

Re: [PATCH 20/34] xen: convert put_page() to put_user_page*()

2019-08-02 Thread Juergen Gross
On 02.08.19 04:19, john.hubb...@gmail.com wrote: From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit

Re: [PATCH 1/2] drm/etnaviv: fix etnaviv_cmdbuf_suballoc_new return value

2019-08-02 Thread Guido Günther
Hi, On Fri, Jul 05, 2019 at 07:15:35PM +0200, Lucas Stach wrote: > The call site expects to get either a valid suballoc or an error > pointer, so a NULL return will not be treated as an error. Make > sure to always return a proper error pointer in case something goes > wrong. > > Signed-off-by:

<    1   2   3   >