Re: [PATCH 13/60] drm/bridge: tfp410: Don't include drmP.h

2019-08-26 Thread Tomi Valkeinen
On 07/07/2019 21:18, Laurent Pinchart wrote: The drmP.h header is deprecated, replace it with the headers specifically needed by the tfp410 driver. While at it, replace the DRM print macros with dev_info() and dev_err() instead of including drm_print.h Signed-off-by: Laurent Pinchart --- driv

Re: [PATCH 11/60] drm/bridge: Add driver for the TI TPD12S015 HDMI level shifter

2019-08-26 Thread Tomi Valkeinen
On 07/07/2019 21:18, Laurent Pinchart wrote: The TI TPD12S015 is an HDMI level shifter and ESD protector controlled through GPIOs. Add a DRM bridge driver for the device. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/bridge/Kconfig| 8 + drivers/gpu/drm/bridge/Makefile

Re: [PATCH 07/60] drm/bridge: simple-bridge: Add support for the TI OP362

2019-08-26 Thread Tomi Valkeinen
On 07/07/2019 21:18, Laurent Pinchart wrote: The TI OP362 is an analog video amplifier controlled through a GPIO. Add support for it to the simple-bridge driver. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/bridge/simple-bridge.c | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [PATCH] drm/bridge: tc358767: Expose test mode functionality via debugfs

2019-08-26 Thread Tomi Valkeinen
Hi, On 26/08/2019 21:25, Andrey Smirnov wrote: Presently, the driver code artificially limits test pattern mode to a single pattern with fixed color selection. It being a kernel module parameter makes switching "test patter" <-> "proper output" modes on-the-fly clunky and outright impossible if

Re: [PATCH] drm/meson: vclk: use the correct G12A frac max value

2019-08-26 Thread Martin Blumenstingl
On Mon, Aug 26, 2019 at 4:47 PM Neil Armstrong wrote: > > When calculating the HDMI PLL settings for a DMT mode PHY frequency, > use the correct max fractional PLL value for G12A VPU. > > With this fix, we can finally setup the 1024x76-60 mode. nit-pick: is this really 1024x76 or 1024x768?

Re: [PATCH v9 5/6] drm/i915/hdcp: update current transcoder into intel_hdcp

2019-08-26 Thread Sharma, Shashank
Regards Shashank On 8/27/2019 10:57 AM, Ramalingam C wrote: On 2019-08-27 at 10:49:25 +0530, Sharma, Shashank wrote: Regards Shashank On 8/22/2019 8:49 PM, Ramalingam C wrote: On gen12+ platforms, HDCP HW is associated to the transcoder. Hence on every modeset update associated transcoder i

Re: [PATCH v9 5/6] drm/i915/hdcp: update current transcoder into intel_hdcp

2019-08-26 Thread Ramalingam C
On 2019-08-27 at 10:49:25 +0530, Sharma, Shashank wrote: > Regards > > Shashank > > On 8/22/2019 8:49 PM, Ramalingam C wrote: > > On gen12+ platforms, HDCP HW is associated to the transcoder. > > Hence on every modeset update associated transcoder into the > > intel_hdcp of the port. > > > > v2:

Re: [PATCH v2] drm/virtio: add plane check

2019-08-26 Thread Gerd Hoffmann
On Mon, Aug 26, 2019 at 03:34:56PM -0700, Chia-I Wu wrote: > On Thu, Aug 22, 2019 at 2:47 AM Gerd Hoffmann wrote: > > > > Use drm_atomic_helper_check_plane_state() > > to sanity check the plane state. > > > > Signed-off-by: Gerd Hoffmann > > --- > > drivers/gpu/drm/virtio/virtgpu_plane.c | 17 ++

Re: [PATCH v9 3/6] drm: Extend I915 mei interface for transcoder info

2019-08-26 Thread Ramalingam C
On 2019-08-27 at 10:36:11 +0530, Sharma, Shashank wrote: > > On 8/22/2019 8:49 PM, Ramalingam C wrote: > > I915 needs to send the index of the transcoder as per ME FW. > > To support this, define enum mei_fw_ddi and add as a member into > > the struct hdcp_port_data. > > > > Signed-off-by: Ramali

Re: [PATCH v9 4/6] misc/mei/hdcp: Fill transcoder index in port info

2019-08-26 Thread Sharma, Shashank
On 8/27/2019 10:47 AM, Ramalingam C wrote: On 2019-08-27 at 10:42:33 +0530, Sharma, Shashank wrote: Regards Shashank On 8/22/2019 8:49 PM, Ramalingam C wrote: For gen12+ platform we need to pass the transcoder info as part of the port info into ME FW. This change fills the payload for ME FW

Re: [PATCH v9 3/6] drm: Extend I915 mei interface for transcoder info

2019-08-26 Thread Ramalingam C
On 2019-08-27 at 10:18:07 +0530, Sharma, Shashank wrote: > > On 8/22/2019 8:49 PM, Ramalingam C wrote: > > I915 needs to send the index of the transcoder as per ME FW. > > To support this, define enum mei_fw_ddi and add as a member into > > the struct hdcp_port_data. > > The commit message says y

Re: [PATCH v9 5/6] drm/i915/hdcp: update current transcoder into intel_hdcp

2019-08-26 Thread Sharma, Shashank
Regards Shashank On 8/22/2019 8:49 PM, Ramalingam C wrote: On gen12+ platforms, HDCP HW is associated to the transcoder. Hence on every modeset update associated transcoder into the intel_hdcp of the port. v2: s/trans/cpu_transcoder [Jani] Signed-off-by: Ramalingam C Acked-by: Jani Nikula

Re: [PATCH v9 4/6] misc/mei/hdcp: Fill transcoder index in port info

2019-08-26 Thread Ramalingam C
On 2019-08-27 at 10:42:33 +0530, Sharma, Shashank wrote: > Regards > > Shashank > > On 8/22/2019 8:49 PM, Ramalingam C wrote: > > For gen12+ platform we need to pass the transcoder info > > as part of the port info into ME FW. > > > > This change fills the payload for ME FW from hdcp_port_data.

Re: [PATCH v4 00/17] drm: add gem ttm helpers, rework mmap workflow.

2019-08-26 Thread Gerd Hoffmann
Hi, > Also this patch series also adjust vram helpers, and I think it has a > slightly different goal: Just aligning mmap paths a bit more between > ttm and not-ttm based drivers. Not just ttm/not-ttm. gem_driver->fops->mmap is the only fops callback where we can't use a generic gem callback t

Re: [PATCH v9 4/6] misc/mei/hdcp: Fill transcoder index in port info

2019-08-26 Thread Sharma, Shashank
Regards Shashank On 8/22/2019 8:49 PM, Ramalingam C wrote: For gen12+ platform we need to pass the transcoder info as part of the port info into ME FW. This change fills the payload for ME FW from hdcp_port_data. Signed-off-by: Ramalingam C Acked-by: Jani Nikula --- drivers/misc/mei/hdcp/

Re: [PATCH v9 3/6] drm: Extend I915 mei interface for transcoder info

2019-08-26 Thread Sharma, Shashank
On 8/22/2019 8:49 PM, Ramalingam C wrote: I915 needs to send the index of the transcoder as per ME FW. To support this, define enum mei_fw_ddi and add as a member into the struct hdcp_port_data. Signed-off-by: Ramalingam C Acked-by: Jani Nikula --- include/drm/i915_mei_hdcp_interface.h | 13

Re: [PATCH v4 00/17] drm: add gem ttm helpers, rework mmap workflow.

2019-08-26 Thread Gerd Hoffmann
On Mon, Aug 26, 2019 at 10:47:07AM +0200, Thomas Zimmermann wrote: > Hi, > > I would have liked to get some context on the purpose of GEM TTM > helpers. Is is just share-able code? Yes. Shareable code for drivers which use both ttm and gem (all except vmgfx). > From my understanding VRAM helper

Re: [PATCH] drm/ingenic: Hardcode panel type to DPI

2019-08-26 Thread Sam Ravnborg
On Fri, Aug 23, 2019 at 11:30:09PM +0200, Paul Cercueil wrote: > Hi Laurent, > > > Le ven. 23 août 2019 à 23:23, Laurent Pinchart > a écrit : > > The ingenic driver supports DPI panels only at the moment, so hardcode > > their type to DPI instead of Unknown. > > > > Signed-off-by: Laurent Pinch

[Bug 111494] Raven Ridge (2400G): Firefox menu items become invisible

2019-08-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111494 --- Comment #1 from Diego Viola --- My system specs: - Arch Linux (x86_64). - Linux 5.2.9-arch1-1-ARCH - mesa 19.1.5-1 - i3-wm 4.17-1 - Firefox 68.0.2-1 -- You are receiving this mail because: You are the assignee for the bug.

Re: [PATCH v9 3/6] drm: Extend I915 mei interface for transcoder info

2019-08-26 Thread Sharma, Shashank
On 8/22/2019 8:49 PM, Ramalingam C wrote: I915 needs to send the index of the transcoder as per ME FW. To support this, define enum mei_fw_ddi and add as a member into the struct hdcp_port_data. The commit message says you are defining enum mei_fw_ddi, but you are actually defining enum mei_f

[Bug 111482] Sapphire Pulse RX 5700 XT power consumption

2019-08-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111482 --- Comment #2 from Andrew Sheldon --- I have the same problem, but with the MSI Evoke 5700 XT. If you read /sys/class/drm/card0/device/pp_dpm_mclk you should find that it's forced to the highest state (3: 875Mhz) and that although it lets you s

Re: [PATCH v9 1/6] drm/i915: mei_hdcp: I915 sends ddi index as per ME FW

2019-08-26 Thread Sharma, Shashank
Regards Shashank On 8/27/2019 10:03 AM, Ramalingam C wrote: On 2019-08-27 at 09:54:18 +0530, Sharma, Shashank wrote: Hello Ram, On 8/22/2019 8:48 PM, Ramalingam C wrote: I915 converts it's port value into ddi index defiend by ME FW and pass it as a member of hdcp_port_data structure. Hence

Re: [PATCH v9 2/6] drm: Move port definition back to i915 header

2019-08-26 Thread Sharma, Shashank
On 8/22/2019 8:49 PM, Ramalingam C wrote: Handled the need for exposing enum port to mei_hdcp driver, by converting the port into ddi index as per ME FW and sending to mei_hdcp. Hence move enum port definition into I915 driver itself. This is a nitpick, but if we can re-arrange this commit me

Re: [PATCH v9 1/6] drm/i915: mei_hdcp: I915 sends ddi index as per ME FW

2019-08-26 Thread Ramalingam C
On 2019-08-27 at 09:54:18 +0530, Sharma, Shashank wrote: > Hello Ram, > > On 8/22/2019 8:48 PM, Ramalingam C wrote: > > I915 converts it's port value into ddi index defiend by ME FW > > and pass it as a member of hdcp_port_data structure. > > > > Hence expose the enum mei_fw_ddi to I915 through >

Re: [PATCH] drm/bridge: tc358767: Expose test mode functionality via debugfs

2019-08-26 Thread Andrey Smirnov
On Mon, Aug 26, 2019 at 3:08 PM Laurent Pinchart wrote: > > Hi Andrey, > > Thank you for the patch. > > On Mon, Aug 26, 2019 at 11:25:24AM -0700, Andrey Smirnov wrote: > > Presently, the driver code artificially limits test pattern mode to a > > single pattern with fixed color selection. It being

Re: [PATCH v9 1/6] drm/i915: mei_hdcp: I915 sends ddi index as per ME FW

2019-08-26 Thread Sharma, Shashank
Hello Ram, On 8/22/2019 8:48 PM, Ramalingam C wrote: I915 converts it's port value into ddi index defiend by ME FW and pass it as a member of hdcp_port_data structure. Hence expose the enum mei_fw_ddi to I915 through i915_mei_interface.h. Signed-off-by: Ramalingam C Acked-by: Jani Nikula ---

[Bug 111494] Raven Ridge (2400G): Firefox menu items become invisible

2019-08-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111494 Bug ID: 111494 Summary: Raven Ridge (2400G): Firefox menu items become invisible Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All)

Re: [PATCH v3 08/14] drm: rcar-du: Add support for CMM

2019-08-26 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Sun, Aug 25, 2019 at 03:51:48PM +0200, Jacopo Mondi wrote: > Add a driver for the R-Car Display Unit Color Correction Module. > > In most of Gen3 SoCs, each DU output channel is provided with a CMM unit > to perform image enhancement and color correction. >

Re: [PATCH v3 13/14] drm: rcar-du: kms: Update CMM in atomic commit tail

2019-08-26 Thread Laurent Pinchart
On Tue, Aug 27, 2019 at 03:00:17AM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Sun, Aug 25, 2019 at 03:51:53PM +0200, Jacopo Mondi wrote: > > Update CMM settings at in the atomic commit tail helper method. > > > > The CMM is updated with new gamma values provi

Re: [PATCH v3 14/14] drm: rcar-du: Force CMM enablement when resuming

2019-08-26 Thread Laurent Pinchart
Hi Jacopo, (Question for Daniel below) Thank you for the patch. On Sun, Aug 25, 2019 at 03:51:54PM +0200, Jacopo Mondi wrote: > When resuming from system suspend, the DU driver is responsible for > reprogramming and enabling the CMM unit if it was in use at the time > the system entered the susp

Re: [PATCH v3 13/14] drm: rcar-du: kms: Update CMM in atomic commit tail

2019-08-26 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Sun, Aug 25, 2019 at 03:51:53PM +0200, Jacopo Mondi wrote: > Update CMM settings at in the atomic commit tail helper method. > > The CMM is updated with new gamma values provided to the driver > in the GAMMA_LUT blob property. > > Reviewed-by: Ulrich Hecht

Re: [PATCH v3 10/14] drm: rcar-du: kms: Collect CMM instances

2019-08-26 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Sun, Aug 25, 2019 at 03:51:50PM +0200, Jacopo Mondi wrote: > Implement device tree parsing to collect the available CMM instances > described by the 'cmms' property. Associate CMMs with CRTCs and store a > mask of active CMMs in the DU group for later enable

[Bug 204611] amdgpu error scheduling IBs when waking from sleep

2019-08-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204611 --- Comment #2 from tones...@hotmail.com --- The problem is after v5.1, and before v5.2. It's very reproducible on v5.2 but might be less frequent as the bisect progresses. Attempts have driven me into the weeds, but I'm still trying. It looks

[Bug 204227] Visual artefacts and crash from suspend on amdgpu

2019-08-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204227 tones...@hotmail.com changed: What|Removed |Added CC||tones...@hotmail.com --- Comment #

[Bug 111482] Sapphire Pulse RX 5700 XT power consumption

2019-08-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111482 --- Comment #1 from Robert --- Not sure if it's of any use but I figured out today that after starting KDE Plasma, launching "Konsole" and typing "sensors" the output is basically garbage: """ amdgpu-pci-0c00 Adapter: PCI adapter vddgfx:

Re: [PATCH v3 07/14] arm64: dts: renesas: r8a77995: Add CMM units

2019-08-26 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Sun, Aug 25, 2019 at 03:51:47PM +0200, Jacopo Mondi wrote: > Add CMM units to Renesas R-Car D3 device tree and reference them from > the Display Unit they are connected to. > > While at it, re-sort the du device node properties to match the ordering > found

Re: [PATCH v3 06/14] arm64: dts: renesas: r8a77990: Add CMM units

2019-08-26 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Sun, Aug 25, 2019 at 03:51:46PM +0200, Jacopo Mondi wrote: > Add CMM units to Renesas R-Car E3 device tree and reference them from > the Display Unit they are connected to. > > While at it, re-sort the du device node properties to match the ordering > found

Re: [PATCH v3 05/14] arm64: dts: renesas: r8a77965: Add CMM units

2019-08-26 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Sun, Aug 25, 2019 at 03:51:45PM +0200, Jacopo Mondi wrote: > Add CMM units to Renesas R-Car M3-N device tree and reference them from > the Display Unit they are connected to. > > Signed-off-by: Jacopo Mondi Apart from the issue with compatible string as p

[Bug 110865] Rx480 consumes 20w more power in idle than under Windows

2019-08-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110865 --- Comment #24 from Martin --- I am so sorry to hear that Dieter, this is really terrible. But I can assure you your English is fine. I also think your problem is somewhere else. You mentioned it yourself. and I think Alex Deucher did as well

Re: [PATCH v3 04/14] arm64: dts: renesas: r8a7795: Add CMM units

2019-08-26 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Sun, Aug 25, 2019 at 03:51:44PM +0200, Jacopo Mondi wrote: > Add CMM units to Renesas R-Car H3 device tree and reference them from > the Display Unit they are connected to. > > While at it, re-sort the du device node properties to match the ordering > found

Re: [PATCH v3 03/14] arm64: dts: renesas: r8a7796: Add CMM units

2019-08-26 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. Should you squash this with the patches that add CMM units to the other SoCs ? On Sun, Aug 25, 2019 at 03:51:43PM +0200, Jacopo Mondi wrote: > Add CMM units to Renesas R-Car M3-W device tree and reference them from > the Display Unit they are connected to. >

Re: [PATCH v2] drm/virtio: add plane check

2019-08-26 Thread Chia-I Wu
On Thu, Aug 22, 2019 at 2:47 AM Gerd Hoffmann wrote: > > Use drm_atomic_helper_check_plane_state() > to sanity check the plane state. > > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/virtio/virtgpu_plane.c | 17 - > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff

[PATCH v3 5/8] drm/panfrost: Split mmu_hw_do_operation into locked and unlocked version

2019-08-26 Thread Rob Herring
In preparation to call mmu_hw_do_operation with the as_lock already held, Add a mmu_hw_do_operation_locked function. Fixes: 7282f7645d06 ("drm/panfrost: Implement per FD address spaces") Cc: Tomeu Vizoso Cc: Steven Price Cc: Alyssa Rosenzweig Cc: David Airlie Cc: Daniel Vetter Signed-off-by:

[PATCH v3 1/8] drm/panfrost: Rework runtime PM initialization

2019-08-26 Thread Rob Herring
There's a few issues with the runtime PM initialization. The documentation states pm_runtime_set_active() should be called before pm_runtime_enable(). The pm_runtime_put_autosuspend() could suspend the GPU before panfrost_perfcnt_init() is called which touches the h/w. The autosuspend delay keeps

[PATCH v3 6/8] drm/panfrost: Add cache/TLB flush before switching address space

2019-08-26 Thread Rob Herring
It's not entirely clear if this is required, but add a flush of GPU caches and TLBs before we change an address space to new page tables. Fixes: 7282f7645d06 ("drm/panfrost: Implement per FD address spaces") Cc: Tomeu Vizoso Cc: Steven Price Cc: Alyssa Rosenzweig Cc: David Airlie Cc: Daniel Ve

[PATCH v3 7/8] drm/panfrost: Flush and disable address space when freeing page tables

2019-08-26 Thread Rob Herring
Currently, page tables are freed without disabling the address space first. This probably is fine as we'll switch to new page tables when the address space is allocated again and runtime PM suspend will reset the GPU clearing the registers. However, it's better to clean up after ourselves. There is

[PATCH v3 2/8] drm/panfrost: Hold runtime PM reference until jobs complete

2019-08-26 Thread Rob Herring
Doing a pm_runtime_put as soon as a job is submitted is wrong as it should not happen until the job completes. It works currently because we are relying on the autosuspend timeout to keep the h/w enabled. Fixes: f3ba91228e8e ("drm/panfrost: Add initial panfrost driver") Cc: Tomeu Vizoso Cc: Steve

[PATCH v3 8/8] drm/panfrost: Remove unnecessary hwaccess_lock spin_lock

2019-08-26 Thread Rob Herring
With the introduction of the as_lock to serialize address space registers, the hwaccess_lock is only used within the job code and is not protecting anything. panfrost_job_hw_submit() only accesses registers for 1 job slot and it's already serialized by drm_sched. Fixes: 7282f7645d06 ("drm/panfrost

[PATCH v3 3/8] drm/panfrost: Remove unnecessary mmu->lock mutex

2019-08-26 Thread Rob Herring
There's no need to serialize io-pgtable calls and the as_lock is sufficient to serialize flush operations, so we can remove the per page table lock. Fixes: 7282f7645d06 ("drm/panfrost: Implement per FD address spaces") Suggested-by: Robin Murphy Cc: Tomeu Vizoso Cc: Steven Price Cc: Alyssa Rose

[PATCH v3 4/8] drm/panfrost: Rework page table flushing and runtime PM interaction

2019-08-26 Thread Rob Herring
There is no point in resuming the h/w just to do flush operations and doing so takes several locks which cause lockdep issues with the shrinker. Rework the flush operations to only happen when the h/w is already awake. This avoids taking any locks associated with resuming which trigger lockdep warn

[PATCH v3 0/8] panfrost: Locking and runtime PM fixes

2019-08-26 Thread Rob Herring
With further testing of recent changes with lockdep identified some locking issues. Avoiding lockdep issues means we need to avoid some locks in panfrost_mmu_unmap which in turn means avoiding runtime PM resume. In the process of re-working runtime PM several runtime PM and locking clean-ups have b

Re: [PATCH RESEND 05/14] drm: rockchip: Provide ddc symlink in rk3066_hdmi sysfs directory

2019-08-26 Thread Heiko Stuebner
Am Montag, 26. August 2019, 21:25:47 CEST schrieb Andrzej Pietrasiewicz: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz > Acked-by: Sam Ravnborg > Reviewed-by: Emil Velikov Acked-by: Heiko Stuebner

Re: [PATCH RESEND 06/14] drm: rockchip: Provide ddc symlink in inno_hdmi sysfs directory

2019-08-26 Thread Heiko Stuebner
Am Montag, 26. August 2019, 21:25:48 CEST schrieb Andrzej Pietrasiewicz: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz > Acked-by: Sam Ravnborg > Reviewed-by: Emil Velikov Acked-by: Heiko Stuebner

Re: [PATCH] drm/bridge: tc358767: Expose test mode functionality via debugfs

2019-08-26 Thread Laurent Pinchart
Hi Andrey, Thank you for the patch. On Mon, Aug 26, 2019 at 11:25:24AM -0700, Andrey Smirnov wrote: > Presently, the driver code artificially limits test pattern mode to a > single pattern with fixed color selection. It being a kernel module > parameter makes switching "test patter" <-> "proper o

[Bug 110865] Rx480 consumes 20w more power in idle than under Windows

2019-08-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110865 --- Comment #23 from Dieter Nützel --- Oh, BTW Martin which type are your 2 identical displays? HDMI (like mine) or DisplayPort? I use sound over HDMI, too. And only one display present it. -- You are receiving this mail because: You are the

Re: [PATCH 02/26] drm/dp_mst: Destroy mstbs from destroy_connector_work

2019-08-26 Thread Lyude Paul
On Tue, 2019-08-13 at 15:00 +0200, Daniel Vetter wrote: > On Wed, Jul 17, 2019 at 09:42:25PM -0400, Lyude Paul wrote: > > Currently we remove MST branch devices from the in-memory topology > > immediately when their topology refcount reaches 0. This works just fine > > at the moment, but since we'r

Re: [PATCH v2] drm/virtio: make resource id workaround runtime switchable.

2019-08-26 Thread Chia-I Wu
On Thu, Aug 22, 2019 at 3:26 AM Gerd Hoffmann wrote: > > Also update the comment with a reference to the virglrenderer fix. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Chia-I Wu > --- > drivers/gpu/drm/virtio/virtgpu_object.c | 44 ++--- > 1 file changed, 24 insertions(+),

Re: [PATCH 01/26] drm/dp_mst: Move link address dumping into a function

2019-08-26 Thread Lyude Paul
*sigh* finally have some time to go through these reviews jfyi: I realized after looking over this patch that it's not actually needed - I had been planning on using drm_dp_dump_link_address() for other things, but ended up deciding to make the final plan to use something that dumps into a format

[Bug 110865] Rx480 consumes 20w more power in idle than under Windows

2019-08-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110865 --- Comment #22 from Dieter Nützel --- Hello Alex and Martin, I've tried both on my Polaris 20, RX580 8 GB Sapphire Technology Limited Nitro+ Radeon RX 580 - v2 patched into amd-staging-drm-next (before inclusion of v3) - v3 with amd-staging-

Re: [PATCH v4 0/5] MST DSC support in drm-mst

2019-08-26 Thread Harry Wentland
On 2019-08-26 3:50 p.m., Dave Airlie wrote: > On Sat, 24 Aug 2019 at 06:24, Francis, David wrote: >> >> Adding DSC functionality to drm_dp_mst_atomic_check() is a good idea. >> However, until amdgpu switches over to that system, I wouldn't be able >> to test those changes. Making that switch is on

Re: [PATCH v8 5/6] drm/dp_mst: Add new quirk for Synaptics MST hubs

2019-08-26 Thread Harry Wentland
On 2019-08-26 3:14 p.m., Francis, David wrote: > On 2019-08-26 2:05 p.m., David Francis wrote: >>> Synaptics DP1.4 hubs (BRANCH_ID 0x90CC24) do not >>> support virtual DPCD registers, but do support DSC. >>> The DSC caps can be read from the physical aux, >>> like in SST DSC. These hubs have many d

Re: [PATCH v8 6/6] drm/dp_mst: Add helpers for MST DSC and virtual DPCD aux

2019-08-26 Thread Harry Wentland
On 2019-08-26 2:05 p.m., David Francis wrote: > Add drm_dp_mst_dsc_aux_for_port. To enable DSC, the DSC_ENABLED > register might have to be written on the leaf port's DPCD, > its parent's DPCD, or the MST manager's DPCD. This function > finds the correct aux for the job. > > As part of this, add d

[Bug 111492] HDMI audio is unavailable with amdgpu on R9 270

2019-08-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111492 --- Comment #1 from Marti Raudsepp --- Oh and I'm using HDMI output for video, which works fine. Unplugging and re-plugging the HDMI cable does not help. -- You are receiving this mail because: You are the assignee for the bug.

Re: [PATCH v8 6/6] drm/dp_mst: Add helpers for MST DSC and virtual DPCD aux

2019-08-26 Thread Lyude Paul
Please fix the indenting on this. I've mentioned this already in my previous reviews. On Mon, 2019-08-26 at 19:16 +, Francis, David wrote: > Received offline review from AMD MST DSC (Non-Linux) expert Wenjing Liu, > giving me permission to mark this patch > Reviewed-by: Wenjing Liu > >

[PATCH 0/5] mmu notifer debug annotations

2019-08-26 Thread Daniel Vetter
Hi all, Next round. Changes: - I kept the two lockdep annotations patches since when I rebased this before retesting linux-next didn't yet have them. Otherwise unchanged except for a trivial conflict. - Ack from Peter Z. on the kernel.h patch. - Added annotations for non_block to invalidate

[PATCH 5/5] mm, notifier: annotate with might_sleep()

2019-08-26 Thread Daniel Vetter
Since mmu notifiers don't exist for more processes, but could block in interesting places, add some annotations. This should help make sure core mm keeps up its end of the mmu notifier contract. The checks here are outside of all notifier checks because of that. They compile away without CONFIG_DE

[PATCH 2/5] mm, notifier: Prime lockdep

2019-08-26 Thread Daniel Vetter
We want to teach lockdep that mmu notifiers can be called from direct reclaim paths, since on many CI systems load might never reach that level (e.g. when just running fuzzer or small functional tests). Motivated by a discussion with Jason. I've put the annotation into mmu_notifier_register since

[PATCH 4/5] mm, notifier: Catch sleeping/blocking for !blockable

2019-08-26 Thread Daniel Vetter
We need to make sure implementations don't cheat and don't have a possible schedule/blocking point deeply burried where review can't catch it. I'm not sure whether this is the best way to make sure all the might_sleep() callsites trigger, and it's a bit ugly in the code flow. But it gets the job d

[PATCH 3/5] kernel.h: Add non_block_start/end()

2019-08-26 Thread Daniel Vetter
In some special cases we must not block, but there's not a spinlock, preempt-off, irqs-off or similar critical section already that arms the might_sleep() debug checks. Add a non_block_start/end() pair to annotate these. This will be used in the oom paths of mmu-notifiers, where blocking is not al

[PATCH 1/5] mm, notifier: Add a lockdep map for invalidate_range_start/end

2019-08-26 Thread Daniel Vetter
This is a similar idea to the fs_reclaim fake lockdep lock. It's fairly easy to provoke a specific notifier to be run on a specific range: Just prep it, and then munmap() it. A bit harder, but still doable, is to provoke the mmu notifiers for all the various callchains that might lead to them. But

Re: [PATCH v2 3/4] drm/vmwgfx: Update the backdoor call with support for new instructions

2019-08-26 Thread Dave Airlie
Acked-by: Dave Airlie (for merging via x86 trees). Dave. On Fri, 23 Aug 2019 at 18:13, Thomas Hellström (VMware) wrote: > > From: Thomas Hellstrom > > Use the definition provided by include/asm/vmware.h > > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: "H. Peter Anvin"

[Bug 107835] DisplayPort audio stopped working in a kernel upgrade

2019-08-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107835 --- Comment #3 from Marti Raudsepp --- Thanks Alex, reported new bug 111492. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freede

Re: [PATCH] drm/mcde: Fix an error handling path in 'mcde_probe()'

2019-08-26 Thread Linus Walleij
On Thu, Aug 22, 2019 at 11:15 PM Christophe JAILLET wrote: > If we don't find any matching components, we should go through the error > handling path, in order to free some resources. > > Fixes: ca5be902a87d ("drm/mcde: Fix uninitialized variable") > Signed-off-by: Christophe JAILLET Patch appl

[Bug 111492] HDMI audio is unavailable with amdgpu on R9 270

2019-08-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111492 Bug ID: 111492 Summary: HDMI audio is unavailable with amdgpu on R9 270 Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

[PATCH v2 0/3] Add possibility to specify the number of displayed logos

2019-08-26 Thread Peter Rosin
Hi! The first patch fixes the fact that there are two items numbered "4" in the list of fbcon options. This bug is a teenager... The second patch extends that list with a new option that allows the user to display any number of logos (that fits on the screen). I need it to limit the display to on

[PATCH v2 3/3] fbdev: fbmem: avoid exporting fb_center_logo

2019-08-26 Thread Peter Rosin
The variable is only ever used from fbcon.c which is linked into the same module. Therefore, the export is not needed. Signed-off-by: Peter Rosin --- drivers/video/fbdev/core/fbmem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fb

[PATCH v2 2/3] fbdev: fbmem: allow overriding the number of bootup logos

2019-08-26 Thread Peter Rosin
Probably most useful if you only want one logo regardless of how many CPU cores you have. Signed-off-by: Peter Rosin --- Documentation/fb/fbcon.rst | 5 + drivers/video/fbdev/core/fbcon.c | 7 +++ drivers/video/fbdev/core/fbmem.c | 4 +++- include/linux/fb.h | 1 + 4

[PATCH v2 1/3] fbdev: fix numbering of fbcon options

2019-08-26 Thread Peter Rosin
Three shall be the number thou shalt count, and the number of the counting shall be three. Four shalt thou not count... One! Two! Five! Fixes: efb985f6b265 ("[PATCH] fbcon: Console Rotation - Add framebuffer console documentation") Signed-off-by: Peter Rosin --- Documentation/fb/fbcon.rst | 8

[Bug 111491] missing 32 bits multiarch in the openSUSE Leap 15.1 AMDGpu-pro 19.30

2019-08-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111491 alexandr changed: What|Removed |Added Summary|missing 32 bits multiarch |missing 32 bits multiarch

[Bug 111491] missing 32 bits multiarch in the openSUSE Leap 15.1 AMDGpu 19.30

2019-08-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111491 Bug ID: 111491 Summary: missing 32 bits multiarch in the openSUSE Leap 15.1 AMDGpu 19.30 Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: Lin

Re: [PATCH v4 0/5] MST DSC support in drm-mst

2019-08-26 Thread Dave Airlie
On Sat, 24 Aug 2019 at 06:24, Francis, David wrote: > > Adding DSC functionality to drm_dp_mst_atomic_check() is a good idea. > However, until amdgpu switches over to that system, I wouldn't be able > to test those changes. Making that switch is on our TODO list, and it would > fix a number of pro

RE: [PATCH v2 6/6] drm/i915/dp: Attach HDR metadata property to DP connector

2019-08-26 Thread Shankar, Uma
>-Original Message- >From: Mun, Gwan-gyeong >Sent: Friday, August 23, 2019 3:23 PM >To: intel-...@lists.freedesktop.org >Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; >Sharma, Shashank >Subject: [PATCH v2 6/6] drm/i915/dp: Attach HDR metadata property to DP >connector > >It attach

RE: [PATCH v2 5/6] drm/i915/dp: Program an Infoframe SDP Header and DB for HDR Static Metadata

2019-08-26 Thread Shankar, Uma
>-Original Message- >From: Mun, Gwan-gyeong >Sent: Friday, August 23, 2019 3:23 PM >To: intel-...@lists.freedesktop.org >Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; >Sharma, Shashank >Subject: [PATCH v2 5/6] drm/i915/dp: Program an Infoframe SDP Header and DB for >HDR Static Meta

[PATCH RESEND 13/14] drm/tilcdc: Provide ddc symlink in connector sysfs directory

2019-08-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz Acked-by: Sam Ravnborg Reviewed-by: Emil Velikov --- drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410

[PATCH RESEND 12/14] drm: zte: Provide ddc symlink in vga connector sysfs directory

2019-08-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz Acked-by: Sam Ravnborg Reviewed-by: Emil Velikov --- drivers/gpu/drm/zte/zx_vga.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/zte/zx_vga.c b/drivers/gpu/drm

[PATCH RESEND 14/14] drm/i915: Provide ddc symlink in hdmi connector sysfs directory

2019-08-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz Acked-by: Sam Ravnborg Reviewed-by: Emil Velikov --- drivers/gpu/drm/i915/display/intel_hdmi.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/displ

[PATCH RESEND 09/14] drm/tegra: Provide ddc symlink in output connector sysfs directory

2019-08-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz Acked-by: Sam Ravnborg Reviewed-by: Emil Velikov --- drivers/gpu/drm/tegra/hdmi.c | 7 --- drivers/gpu/drm/tegra/sor.c | 7 --- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/dr

[PATCH RESEND 11/14] drm: zte: Provide ddc symlink in hdmi connector sysfs directory

2019-08-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz Acked-by: Sam Ravnborg Reviewed-by: Emil Velikov --- drivers/gpu/drm/zte/zx_hdmi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/zte/zx_hdmi.c b/drivers/gpu/d

[PATCH RESEND 10/14] drm/vc4: Provide ddc symlink in connector sysfs directory

2019-08-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz Acked-by: Sam Ravnborg Reviewed-by: Emil Velikov --- drivers/gpu/drm/vc4/vc4_hdmi.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/driv

[PATCH RESEND 07/14] drm/msm/hdmi: Provide ddc symlink in hdmi connector sysfs directory

2019-08-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz Acked-by: Sam Ravnborg Reviewed-by: Emil Velikov --- drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_con

[PATCH RESEND 08/14] drm/mediatek: Provide ddc symlink in hdmi connector sysfs directory

2019-08-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz Acked-by: Sam Ravnborg Reviewed-by: Emil Velikov --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b

[PATCH RESEND 05/14] drm: rockchip: Provide ddc symlink in rk3066_hdmi sysfs directory

2019-08-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz Acked-by: Sam Ravnborg Reviewed-by: Emil Velikov --- drivers/gpu/drm/rockchip/rk3066_hdmi.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rk3066_hdm

[PATCH RESEND 06/14] drm: rockchip: Provide ddc symlink in inno_hdmi sysfs directory

2019-08-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz Acked-by: Sam Ravnborg Reviewed-by: Emil Velikov --- drivers/gpu/drm/rockchip/inno_hdmi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c

[PATCH RESEND 03/14] drm/amdgpu: Provide ddc symlink in dm connector's sysfs directory

2019-08-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/disp

[PATCH RESEND 04/14] drm/exynos: Provide ddc symlink in connector's sysfs

2019-08-26 Thread Andrzej Pietrasiewicz
Switch to using the ddc provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz Acked-by: Sam Ravnborg Reviewed-by: Emil Velikov --- drivers/gpu/drm/exynos/exynos_hdmi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi

[PATCH RESEND 02/14] drm/radeon: Provide ddc symlink in connector sysfs directory

2019-08-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/radeon/radeon_connectors.c | 143 +++-- 1 file changed, 107 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/r

[PATCH RESEND 01/14] drm/bridge: ti-tfp410: Update drm_connector_init_with_ddc() error message

2019-08-26 Thread Andrzej Pietrasiewicz
From: Geert Uytterhoeven The code was changed to call drm_connector_init_with_ddc() instead of drm_connector_init(), but the corresponding error message was not updated. Fixes: cfb444552926989f ("drm/bridge: ti-tfp410: Provide ddc symlink in connector sysfs directory") Signed-off-by: Geert Uytt

[PATCH RESEND 00/14] Next round of associating ddc adapters with connectors

2019-08-26 Thread Andrzej Pietrasiewicz
I'm resending the patches which have somehow got lost: one patch from Geert and 13 patches from me. Geert's patch updates the error message to reflect the actually called function's name. Most of patches from me have their Acked-by and Reviewed-by tags and deal with providing a ddc symlink in con

Re: [PATCH v3 00/15] Improvements and fixes for mxsfb DRM driver

2019-08-26 Thread Leonard Crestez
On 26.08.2019 17:35, Stefan Agner wrote: > On 2019-08-26 14:05, Guido Günther wrote: >> Hi, >> On Wed, Aug 21, 2019 at 01:15:40PM +0300, Robert Chiras wrote: >>> This patch-set improves the use of eLCDIF block on iMX 8 SoCs (like 8MQ, 8MM >>> and 8QXP). Following, are the new features added and fix

RE: [PATCH v2 4/6] drm/i915/dp: Attach colorspace property

2019-08-26 Thread Shankar, Uma
>-Original Message- >From: Mun, Gwan-gyeong >Sent: Friday, August 23, 2019 3:23 PM >To: intel-...@lists.freedesktop.org >Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; >Sharma, Shashank >Subject: [PATCH v2 4/6] drm/i915/dp: Attach colorspace property > >It attaches the colorspace co

  1   2   3   >